| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:688eb8a4-403d-f6f7-085c-748d0a217dd0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8DDC:25A6BD:21D29C:2A2CEB:69913858 |
| html-safe-nonce | 9517840911e0ef6c3c8c42d37c0cfc884a9e2be9d9bee1de6b5ed7468c522cc6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RERDOjI1QTZCRDoyMUQyOUM6MkEyQ0VCOjY5OTEzODU4IiwidmlzaXRvcl9pZCI6IjYxMzMzMjUzMjkxNDYzMjc5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e99d00c3b3dfb4b2c4784e23a91abbcc1fb0e58e45efb812fabff58ff75474ab |
| hovercard-subject-tag | pull_request:238703959 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25041/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2054627c058a7f4543b23e9da623209acc949f3a7e06322fa1dd0da1e7212479/nodejs/node/pull/25041 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2054627c058a7f4543b23e9da623209acc949f3a7e06322fa1dd0da1e7212479/nodejs/node/pull/25041 |
| og:image:alt | Original commit message:
[cpu-profiler] Fix a leak caused by re-logging existing functions.
Don't re-log all existing functions during StartProcessorIfNotStarted().
They will already be in the... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | psmarshall |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25041#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25041 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25041 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25041 |
| Reload | https://github.com/nodejs/node/pull/25041 |
| Reload | https://github.com/nodejs/node/pull/25041 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
710
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| psmarshall | https://github.com/psmarshall |
| nodejs:v8.x-staging | https://github.com/nodejs/node/tree/v8.x-staging |
| psmarshall:backport-8-memleak | https://github.com/psmarshall/node/tree/backport-8-memleak |
| Conversation | https://github.com/nodejs/node/pull/25041 |
| Commits1 (1) | https://github.com/nodejs/node/pull/25041/commits |
| Checks | https://github.com/nodejs/node/pull/25041/checks |
| Files changed | https://github.com/nodejs/node/pull/25041/files |
| [v8.x] deps: V8: cherry-pick 525b396 | https://github.com/nodejs/node/pull/25041#top |
| psmarshall | https://github.com/psmarshall |
| nodejs:v8.x-staging | https://github.com/nodejs/node/tree/v8.x-staging |
| psmarshall:backport-8-memleak | https://github.com/psmarshall/node/tree/backport-8-memleak |
|
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25041#issue-391088885 |
| v8/v8@525b396 | https://github.com/v8/v8/commit/525b39619548b4e7fbf48934acb18d3f209321db |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
|
| https://github.com/psmarshall |
| deps: V8: cherry-pick | https://github.com/nodejs/node/pull/25041/commits/bdd5f404b49215f1f8025fc3b44a3bb032955f76 |
| 525b396 | https://github.com/psmarshall/node/commit/525b396427d82f52b8b19483e8a4e9f8548c02b7 |
| bdd5f40 | https://github.com/nodejs/node/pull/25041/commits/bdd5f404b49215f1f8025fc3b44a3bb032955f76 |
| https://chromium-review.googlesource.com/1256763 | https://chromium-review.googlesource.com/1256763 |
| nodejs#56336 | https://github.com/nodejs/node/pull/56336 |
| v8/v8@525b396 | https://github.com/v8/v8/commit/525b39619548b4e7fbf48934acb18d3f209321db |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25041#issuecomment-447308518 |
| @psmarshall | https://github.com/psmarshall |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1946/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1946/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
|
v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25041#event-2026697249 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
|
Dec 14, 2018
| https://github.com/nodejs/node/pull/25041#ref-issue-363333877 |
|
Memory Leak in V8 CpuProfiler
#23070
| https://github.com/nodejs/node/issues/23070 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25041#issuecomment-447310103 |
| https://ci.nodejs.org/job/node-test-pull-request/19517/ | https://ci.nodejs.org/job/node-test-pull-request/19517/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1937/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1937/ |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| MylesBorins | https://github.com/MylesBorins |
| hashseed | https://github.com/hashseed |
| December 14, 2018 12:27 | https://github.com/nodejs/node/pull/25041#event-2026714938 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25041#event-2026721089 |
| https://github.com/psmarshall |
| psmarshall | https://github.com/psmarshall |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25041#event-2026726773 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25041#issuecomment-447343305 |
| https://ci.nodejs.org/job/node-test-pull-request/19522/ | https://ci.nodejs.org/job/node-test-pull-request/19522/ |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
| https://github.com/hashseed |
| hashseed | https://github.com/hashseed |
|
Dec 14, 2018
| https://github.com/nodejs/node/pull/25041#pullrequestreview-185184283 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25041/files/bdd5f404b49215f1f8025fc3b44a3bb032955f76 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25041#issuecomment-447396069 |
| https://ci.nodejs.org/job/node-test-pull-request/19531/ | https://ci.nodejs.org/job/node-test-pull-request/19531/ |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25041#issuecomment-447440703 |
| https://ci.nodejs.org/job/node-test-pull-request/19538/ | https://ci.nodejs.org/job/node-test-pull-request/19538/ |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25041#issuecomment-447486526 |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
| https://ci.nodejs.org/job/node-test-pull-request/19543/ | https://ci.nodejs.org/job/node-test-pull-request/19543/ |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25041#issuecomment-447491995 |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Dec 15, 2018 | https://github.com/nodejs/node/pull/25041#issuecomment-447555693 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Dec 18, 2018
| https://github.com/nodejs/node/pull/25041#pullrequestreview-185890011 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25041/files/bdd5f404b49215f1f8025fc3b44a3bb032955f76 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/25041#issuecomment-448079356 |
| c1611c1 | https://github.com/nodejs/node/commit/c1611c1096dab18a8c83fa5b5a742b21d05dd92d |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/25041#event-2031909494 |
| rvagg | https://github.com/rvagg |
|
Dec 18, 2018
| https://github.com/nodejs/node/pull/25041#ref-commit-c1611c1 |
|
| https://github.com/psmarshall |
|
| https://github.com/rvagg |
| deps: cherry-pick | https://github.com/nodejs/node/commit/c1611c1096dab18a8c83fa5b5a742b21d05dd92d |
| 525b396 | https://github.com/nodejs/node/commit/525b396427d82f52b8b19483e8a4e9f8548c02b7 |
| from V8 upstream | https://github.com/nodejs/node/commit/c1611c1096dab18a8c83fa5b5a742b21d05dd92d |
| c1611c1 | https://github.com/nodejs/node/commit/c1611c1096dab18a8c83fa5b5a742b21d05dd92d |
| v8:8253 | https://bugs.chromium.org/p/v8/issues/detail?id=8253 |
| https://chromium-review.googlesource.com/1256763 | https://chromium-review.googlesource.com/1256763 |
| #56336 | https://github.com/nodejs/node/pull/56336 |
| v8/v8@525b396 | https://github.com/v8/v8/commit/525b39619548b4e7fbf48934acb18d3f209321db |
| #25041 | https://github.com/nodejs/node/pull/25041 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 18, 2018
| https://github.com/nodejs/node/pull/25041#ref-commit-ae24aaf |
|
| https://github.com/psmarshall |
|
| https://github.com/MylesBorins |
| deps: cherry-pick | https://github.com/nodejs/node/commit/ae24aafd40cc4cd44f325e1d0fd03abd8ea50d30 |
| 525b396 | https://github.com/nodejs/node/commit/525b396427d82f52b8b19483e8a4e9f8548c02b7 |
| from V8 upstream | https://github.com/nodejs/node/commit/ae24aafd40cc4cd44f325e1d0fd03abd8ea50d30 |
| ae24aaf | https://github.com/nodejs/node/commit/ae24aafd40cc4cd44f325e1d0fd03abd8ea50d30 |
| v8:8253 | https://bugs.chromium.org/p/v8/issues/detail?id=8253 |
| https://chromium-review.googlesource.com/1256763 | https://chromium-review.googlesource.com/1256763 |
| #56336 | https://github.com/nodejs/node/pull/56336 |
| v8/v8@525b396 | https://github.com/v8/v8/commit/525b39619548b4e7fbf48934acb18d3f209321db |
| #25041 | https://github.com/nodejs/node/pull/25041 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 26, 2018
| https://github.com/nodejs/node/pull/25041#ref-commit-8810051 |
|
| https://github.com/psmarshall |
|
| https://github.com/MylesBorins |
| deps: cherry-pick | https://github.com/nodejs/node/commit/881005110f13c711da03e2a7c4d60a400608842d |
| 525b396 | https://github.com/nodejs/node/commit/525b396427d82f52b8b19483e8a4e9f8548c02b7 |
| from V8 upstream | https://github.com/nodejs/node/commit/881005110f13c711da03e2a7c4d60a400608842d |
| 8810051 | https://github.com/nodejs/node/commit/881005110f13c711da03e2a7c4d60a400608842d |
| v8:8253 | https://bugs.chromium.org/p/v8/issues/detail?id=8253 |
| https://chromium-review.googlesource.com/1256763 | https://chromium-review.googlesource.com/1256763 |
| #56336 | https://github.com/nodejs/node/pull/56336 |
| v8/v8@525b396 | https://github.com/v8/v8/commit/525b39619548b4e7fbf48934acb18d3f209321db |
| #25041 | https://github.com/nodejs/node/pull/25041 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25041#ref-commit-a1aff28 |
|
| https://github.com/psmarshall |
|
| https://github.com/rvagg |
| deps: cherry-pick | https://github.com/nodejs/node/commit/a1aff28fba251e2104c97c6d3a23e2452dc05304 |
| 525b396 | https://github.com/nodejs/node/commit/525b396427d82f52b8b19483e8a4e9f8548c02b7 |
| from V8 upstream | https://github.com/nodejs/node/commit/a1aff28fba251e2104c97c6d3a23e2452dc05304 |
| a1aff28 | https://github.com/nodejs/node/commit/a1aff28fba251e2104c97c6d3a23e2452dc05304 |
| v8:8253 | https://bugs.chromium.org/p/v8/issues/detail?id=8253 |
| https://chromium-review.googlesource.com/1256763 | https://chromium-review.googlesource.com/1256763 |
| #56336 | https://github.com/nodejs/node/pull/56336 |
| v8/v8@525b396 | https://github.com/v8/v8/commit/525b39619548b4e7fbf48934acb18d3f209321db |
| #25041 | https://github.com/nodejs/node/pull/25041 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 26, 2019
| https://github.com/nodejs/node/pull/25041#ref-pullrequest-425612104 |
|
v8.16.0 proposal
#26933
| https://github.com/nodejs/node/pull/26933 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25041 |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
| https://github.com/rvagg |
|
rvagg
| https://github.com/rvagg |
|
| https://github.com/nodejs/node/pull/25041/files/bdd5f404b49215f1f8025fc3b44a3bb032955f76 |
|
| https://github.com/hashseed |
|
hashseed
| https://github.com/hashseed |
|
| https://github.com/nodejs/node/pull/25041/files/bdd5f404b49215f1f8025fc3b44a3bb032955f76 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/25041 |
|
| https://github.com/psmarshall |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/targos |
|
| https://github.com/rvagg |
|
| https://github.com/hashseed |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |