René's URL Explorer Experiment


Title: [8.x] http: fix regression of binary upgrade response body by mcollina · Pull Request #25037 · nodejs/node · GitHub

Open Graph Title: [8.x] http: fix regression of binary upgrade response body by mcollina · Pull Request #25037 · nodejs/node

X Title: [8.x] http: fix regression of binary upgrade response body by mcollina · Pull Request #25037 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: See: #24958 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: See: #24958 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/25037

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:810ddea1-925b-3d12-ae96-8edd57c454bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8128:418ED:534648C:73D501E:6A4F7CB7
html-safe-nonce92c3a546a1318bb7f4ef7f650273f09dd3a30b8caa2ddc98e85e344bd7600d38
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTI4OjQxOEVEOjUzNDY0OEM6NzNENTAxRTo2QTRGN0NCNyIsInZpc2l0b3JfaWQiOiIyNzc3NTcxNjI1NzM3ODc4NzExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdb330b731500c4d3bad35c54132cc54c2e13d6a6e3136241ff864456f955dd12
hovercard-subject-tagpull_request:238694893
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25037/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b1f96d5b3f7d3b48ae22bc0afc4637e800bdcf1388fc43d979d5768508efdd0f/nodejs/node/pull/25037
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b1f96d5b3f7d3b48ae22bc0afc4637e800bdcf1388fc43d979d5768508efdd0f/nodejs/node/pull/25037
og:image:altSee: #24958 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcollina
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25037#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25037
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25037
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25037
Reloadhttps://github.com/nodejs/node/pull/25037
Reloadhttps://github.com/nodejs/node/pull/25037
Please reload this pagehttps://github.com/nodejs/node/pull/25037
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25037
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mcollinahttps://github.com/mcollina
nodejs:v8.xhttps://github.com/nodejs/node/tree/v8.x
mcollina:8-remove-spurious-http-fixhttps://github.com/mcollina/node/tree/8-remove-spurious-http-fix
Conversationhttps://github.com/nodejs/node/pull/25037
Commits1 (1)https://github.com/nodejs/node/pull/25037/commits
Checkshttps://github.com/nodejs/node/pull/25037/checks
Files changedhttps://github.com/nodejs/node/pull/25037/files
[8.x] http: fix regression of binary upgrade response bodyhttps://github.com/nodejs/node/pull/25037#top
mcollinahttps://github.com/mcollina
nodejs:v8.xhttps://github.com/nodejs/node/tree/v8.x
mcollina:8-remove-spurious-http-fixhttps://github.com/mcollina/node/tree/8-remove-spurious-http-fix
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 14, 2018https://github.com/nodejs/node/pull/25037#issue-391077488
#24958https://github.com/nodejs/node/issues/24958
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25037
https://github.com/mcollina
http: fix regression of binary upgrade response bodyhttps://github.com/nodejs/node/pull/25037/commits/faff7e15a94e0093f32bd2b413fead0c006af814
faff7e1https://github.com/nodejs/node/pull/25037/commits/faff7e15a94e0093f32bd2b413fead0c006af814
nodejs#24958https://github.com/nodejs/node/issues/24958
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 14, 2018https://github.com/nodejs/node/pull/25037#issuecomment-447300601
@mcollinahttps://github.com/mcollina
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1944/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1944/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25037
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http_parser https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp_parser
v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x
Dec 14, 2018https://github.com/nodejs/node/pull/25037#event-2026633109
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 14, 2018https://github.com/nodejs/node/pull/25037#issuecomment-447300646
@MylesBorinshttps://github.com/MylesBorins
Please reload this pagehttps://github.com/nodejs/node/pull/25037
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 14, 2018https://github.com/nodejs/node/pull/25037#issuecomment-447300733
https://ci.nodejs.org/job/node-test-pull-request/19515/https://ci.nodejs.org/job/node-test-pull-request/19515/
Please reload this pagehttps://github.com/nodejs/node/pull/25037
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 14, 2018https://github.com/nodejs/node/pull/25037#event-2026635522
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 14, 2018 https://github.com/nodejs/node/pull/25037#ref-pullrequest-391075170
[v6.x] http: fix regression of binary upgrade response body #25036 https://github.com/nodejs/node/pull/25036
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/25037#issuecomment-447342311
https://ci.nodejs.org/job/node-test-pull-request/19521/https://ci.nodejs.org/job/node-test-pull-request/19521/
Please reload this pagehttps://github.com/nodejs/node/pull/25037
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/25037#issuecomment-447352584
Please reload this pagehttps://github.com/nodejs/node/pull/25037
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/25037#issuecomment-447352747
Please reload this pagehttps://github.com/nodejs/node/pull/25037
https://ci.nodejs.org/job/node-test-pull-request/19525/https://ci.nodejs.org/job/node-test-pull-request/19525/
Please reload this pagehttps://github.com/nodejs/node/pull/25037
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 14, 2018https://github.com/nodejs/node/pull/25037#issuecomment-447353108
Please reload this pagehttps://github.com/nodejs/node/pull/25037
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018 https://github.com/nodejs/node/pull/25037#pullrequestreview-187457461
View reviewed changes https://github.com/nodejs/node/pull/25037/files/faff7e15a94e0093f32bd2b413fead0c006af814
MylesBorinshttps://github.com/MylesBorins
https://github.com/nodejs/node/pull/25037#pullrequestreview-187457461
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25037
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018 https://github.com/nodejs/node/pull/25037#ref-commit-a947b75
https://github.com/mcollina
https://github.com/MylesBorins
http: fix regression of binary upgrade response bodyhttps://github.com/nodejs/node/commit/a947b75448ce7c91945691a244e810c556b3b393
a947b75https://github.com/nodejs/node/commit/a947b75448ce7c91945691a244e810c556b3b393
#24958https://github.com/nodejs/node/issues/24958
#25037https://github.com/nodejs/node/pull/25037
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018https://github.com/nodejs/node/pull/25037#issuecomment-449433910
a947b75https://github.com/nodejs/node/commit/a947b75448ce7c91945691a244e810c556b3b393
Please reload this pagehttps://github.com/nodejs/node/pull/25037
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018https://github.com/nodejs/node/pull/25037#event-2041186909
https://github.com/mcollina
mcollinahttps://github.com/mcollina
December 21, 2018 16:29https://github.com/nodejs/node/pull/25037#event-2041189475
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018 https://github.com/nodejs/node/pull/25037#ref-commit-f31dc1b
https://github.com/mcollina
https://github.com/MylesBorins
http: fix regression of binary upgrade response bodyhttps://github.com/nodejs/node/commit/f31dc1ba080f86f9df7fabfa3e2d226e2baf95f8
f31dc1bhttps://github.com/nodejs/node/commit/f31dc1ba080f86f9df7fabfa3e2d226e2baf95f8
#24958https://github.com/nodejs/node/issues/24958
#25037https://github.com/nodejs/node/pull/25037
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018 https://github.com/nodejs/node/pull/25037#ref-pullrequest-393620696
v8.15.0 proposal #25177 https://github.com/nodejs/node/pull/25177
MylesBorinshttps://github.com/MylesBorins
Dec 22, 2018 https://github.com/nodejs/node/pull/25037#ref-commit-215ecfe
https://github.com/mcollina
https://github.com/MylesBorins
http: fix regression of binary upgrade response bodyhttps://github.com/nodejs/node/commit/215ecfe4de0bcab2c2ed0d23923a0c7c87abd733
215ecfehttps://github.com/nodejs/node/commit/215ecfe4de0bcab2c2ed0d23923a0c7c87abd733
#24958https://github.com/nodejs/node/issues/24958
#25037https://github.com/nodejs/node/pull/25037
2018-12-26 Version 8.15.0 'Carbon' (LTS) @MylesBorins beevelop/docker-nodejs#253 https://github.com/beevelop/docker-nodejs/issues/253
2018-12-26 Version 8.15.0 'Carbon' (LTS) @MylesBorins beevelop/docker-android-nodejs#275 https://github.com/beevelop/docker-android-nodejs/issues/275
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25037
https://github.com/MylesBorins
MylesBorins https://github.com/MylesBorins
https://github.com/nodejs/node/pull/25037/files/faff7e15a94e0093f32bd2b413fead0c006af814
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http_parser https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp_parser
Please reload this pagehttps://github.com/nodejs/node/pull/25037
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.