René's URL Explorer Experiment


Title: [v6.x] http: fix regression of binary upgrade response body by mcollina · Pull Request #25036 · nodejs/node · GitHub

Open Graph Title: [v6.x] http: fix regression of binary upgrade response body by mcollina · Pull Request #25036 · nodejs/node

X Title: [v6.x] http: fix regression of binary upgrade response body by mcollina · Pull Request #25036 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: See: #24958 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: See: #24958 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/25036

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a7aa8812-30c0-d753-1db1-5b08d8953193
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC94A:6F3CF:1156CBD:17898F0:6A4EEDC5
html-safe-nonce4557dc4e1bd929b3d2bc85add3270b68cd5e2a9d0b0bb38a7d5ab119eaeff9b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTRBOjZGM0NGOjExNTZDQkQ6MTc4OThGMDo2QTRFRURDNSIsInZpc2l0b3JfaWQiOiI4NDgwMDY2MTY0OTYwOTgwNDIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2d9b777fecbd285fd5952e8ebe809827ce2b8a5a0dfbe1b2def60b7df89b5398
hovercard-subject-tagpull_request:238693040
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25036/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/084935d41fa501e06957feb0f98e99d801a431fa0368bbace84819b7d5ac5183/nodejs/node/pull/25036
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/084935d41fa501e06957feb0f98e99d801a431fa0368bbace84819b7d5ac5183/nodejs/node/pull/25036
og:image:altSee: #24958 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcollina
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release00d04d6b867d2f16ab50bebae8ccc56e07c8988b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25036#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25036
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25036
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25036
Reloadhttps://github.com/nodejs/node/pull/25036
Reloadhttps://github.com/nodejs/node/pull/25036
Please reload this pagehttps://github.com/nodejs/node/pull/25036
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25036
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mcollinahttps://github.com/mcollina
nodejs:v6.xhttps://github.com/nodejs/node/tree/v6.x
mcollina:6-remove-spurious-http-fixhttps://github.com/mcollina/node/tree/6-remove-spurious-http-fix
Conversationhttps://github.com/nodejs/node/pull/25036
Commits1 (1)https://github.com/nodejs/node/pull/25036/commits
Checkshttps://github.com/nodejs/node/pull/25036/checks
Files changedhttps://github.com/nodejs/node/pull/25036/files
[v6.x] http: fix regression of binary upgrade response bodyhttps://github.com/nodejs/node/pull/25036#top
mcollinahttps://github.com/mcollina
nodejs:v6.xhttps://github.com/nodejs/node/tree/v6.x
mcollina:6-remove-spurious-http-fixhttps://github.com/mcollina/node/tree/6-remove-spurious-http-fix
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 14, 2018https://github.com/nodejs/node/pull/25036#issue-391075170
#24958https://github.com/nodejs/node/issues/24958
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25036
https://github.com/mcollina
http: fix regression of binary upgrade response bodyhttps://github.com/nodejs/node/pull/25036/commits/d48a021068a7fdfbb38f70a777e37ae655994224
d48a021https://github.com/nodejs/node/pull/25036/commits/d48a021068a7fdfbb38f70a777e37ae655994224
nodejs#24958https://github.com/nodejs/node/issues/24958
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 14, 2018https://github.com/nodejs/node/pull/25036#issuecomment-447298988
@mcollinahttps://github.com/mcollina
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1943/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1943/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25036
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http_parser https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp_parser
v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x
Dec 14, 2018https://github.com/nodejs/node/pull/25036#event-2026619321
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 14, 2018https://github.com/nodejs/node/pull/25036#issuecomment-447299043
@MylesBorinshttps://github.com/MylesBorins
Please reload this pagehttps://github.com/nodejs/node/pull/25036
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 14, 2018https://github.com/nodejs/node/pull/25036#issuecomment-447299150
Please reload this pagehttps://github.com/nodejs/node/pull/25036
https://ci.nodejs.org/job/node-test-pull-request/19514/https://ci.nodejs.org/job/node-test-pull-request/19514/
Please reload this pagehttps://github.com/nodejs/node/pull/25036
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 14, 2018https://github.com/nodejs/node/pull/25036#event-2026621346
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 14, 2018https://github.com/nodejs/node/pull/25036#issuecomment-447302874
#25037https://github.com/nodejs/node/pull/25037
#25039https://github.com/nodejs/node/pull/25039
Please reload this pagehttps://github.com/nodejs/node/pull/25036
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 14, 2018https://github.com/nodejs/node/pull/25036#issuecomment-447303737
#24958 (comment)https://github.com/nodejs/node/issues/24958#issuecomment-446704683
Please reload this pagehttps://github.com/nodejs/node/pull/25036
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018 https://github.com/nodejs/node/pull/25036#ref-issue-390716131
Re-evaluate waiting on green CI #25016 https://github.com/nodejs/node/issues/25016
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018 https://github.com/nodejs/node/pull/25036#pullrequestreview-187456117
View reviewed changes https://github.com/nodejs/node/pull/25036/files/d48a021068a7fdfbb38f70a777e37ae655994224
MylesBorinshttps://github.com/MylesBorins
https://github.com/nodejs/node/pull/25036#pullrequestreview-187456117
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25036
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018 https://github.com/nodejs/node/pull/25036#ref-commit-8af2553
https://github.com/mcollina
https://github.com/MylesBorins
http: fix regression of binary upgrade response bodyhttps://github.com/nodejs/node/commit/8af25532ce1619ed25421521763565b705690440
8af2553https://github.com/nodejs/node/commit/8af25532ce1619ed25421521763565b705690440
#24958https://github.com/nodejs/node/issues/24958
#25036https://github.com/nodejs/node/pull/25036
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018https://github.com/nodejs/node/pull/25036#issuecomment-449433001
8af2553https://github.com/nodejs/node/commit/8af25532ce1619ed25421521763565b705690440
Please reload this pagehttps://github.com/nodejs/node/pull/25036
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018https://github.com/nodejs/node/pull/25036#event-2041180130
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018 https://github.com/nodejs/node/pull/25036#ref-commit-8a3e0c0
https://github.com/mcollina
https://github.com/MylesBorins
http: fix regression of binary upgrade response bodyhttps://github.com/nodejs/node/commit/8a3e0c069747cb6a7e1889de92304856224fee72
8a3e0c0https://github.com/nodejs/node/commit/8a3e0c069747cb6a7e1889de92304856224fee72
#24958https://github.com/nodejs/node/issues/24958
#25036https://github.com/nodejs/node/pull/25036
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 21, 2018 https://github.com/nodejs/node/pull/25036#ref-pullrequest-393620875
v6.16.0 proposal #25178 https://github.com/nodejs/node/pull/25178
2018-12-26 Version 6.16.0 'Boron' (LTS) @MylesBorins beevelop/docker-nodejs#252 https://github.com/beevelop/docker-nodejs/issues/252
2018-12-26 Version 6.16.0 'Boron' (LTS) @MylesBorins beevelop/docker-android-nodejs#274 https://github.com/beevelop/docker-android-nodejs/issues/274
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25036
https://github.com/MylesBorins
MylesBorins https://github.com/MylesBorins
https://github.com/nodejs/node/pull/25036/files/d48a021068a7fdfbb38f70a777e37ae655994224
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http_parser https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp_parser
Please reload this pagehttps://github.com/nodejs/node/pull/25036
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.