| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fa294242-b806-efcb-8e56-e0062af2b832 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 92F2:CD446:2554D50:3365E31:6A4EEE4C |
| html-safe-nonce | 9dd42cfdac50cf98504b63d8aa0a828ef1b0129dee5027f9b397792ff8ac82a7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkYyOkNENDQ2OjI1NTRENTA6MzM2NUUzMTo2QTRFRUU0QyIsInZpc2l0b3JfaWQiOiIxMjYxMTg3MDUzNDE4MTE0NjM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 70945dec009493e50e81e51f2dea8a0c913560d656e4440913859b43768b71b3 |
| hovercard-subject-tag | pull_request:238542197 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25025/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/206f32924400b5a35b6f356e880cbaa5c97555d257e31fb42d6ab9f2a90d3cf3/nodejs/node/pull/25025 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/206f32924400b5a35b6f356e880cbaa5c97555d257e31fb42d6ab9f2a90d3cf3/nodejs/node/pull/25025 |
| og:image:alt | Test didn't require child process creation. While this test has not been
unstable, child process creation is slower and can be flaky in ci, so
test directly for the segfault regression.
@addale... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sam-github |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 00d04d6b867d2f16ab50bebae8ccc56e07c8988b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25025#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25025 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25025 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25025 |
| Reload | https://github.com/nodejs/node/pull/25025 |
| Reload | https://github.com/nodejs/node/pull/25025 |
| Please reload this page | https://github.com/nodejs/node/pull/25025 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25025 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| sam-github | https://github.com/sam-github |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sam-github:merge-segv-hash-test | https://github.com/sam-github/node/tree/merge-segv-hash-test |
| Conversation | https://github.com/nodejs/node/pull/25025 |
| Commits3 (3) | https://github.com/nodejs/node/pull/25025/commits |
| Checks | https://github.com/nodejs/node/pull/25025/checks |
| Files changed | https://github.com/nodejs/node/pull/25025/files |
| test: merge test with unnecessary child process | https://github.com/nodejs/node/pull/25025#top |
| sam-github | https://github.com/sam-github |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sam-github:merge-segv-hash-test | https://github.com/sam-github/node/tree/merge-segv-hash-test |
|
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25025#issue-390872550 |
| @addaleax | https://github.com/addaleax |
| @Trott | https://github.com/Trott |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25025 |
|
| https://github.com/sam-github |
| test: merge test with unnecessary child process | https://github.com/nodejs/node/pull/25025/commits/0073954f33bbbb2e7f279db561b0335beba4715c |
| 0073954 | https://github.com/nodejs/node/pull/25025/commits/0073954f33bbbb2e7f279db561b0335beba4715c |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Trott | https://github.com/Trott |
| addaleax | https://github.com/addaleax |
| December 13, 2018 21:44 | https://github.com/nodejs/node/pull/25025#event-2025411870 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25025#issuecomment-447131675 |
| @sam-github | https://github.com/sam-github |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1937/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1937/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25025 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25025#event-2025411987 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25025#issuecomment-447161360 |
| @tniessen | https://github.com/tniessen |
| 88351a22eda | https://github.com/nodejs/node/commit/88351a22eda |
| Please reload this page | https://github.com/nodejs/node/pull/25025 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 13, 2018
| https://github.com/nodejs/node/pull/25025#pullrequestreview-184919169 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25025/files/0073954f33bbbb2e7f279db561b0335beba4715c |
| test/parallel/test-crypto-hmac.js | https://github.com/nodejs/node/pull/25025/files/0073954f33bbbb2e7f279db561b0335beba4715c#diff-328da3aa2382f05a8281956c0ecdb1d6d345d40718eccea1aef607351f4b75bb |
| Trott | https://github.com/Trott |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25025#discussion_r241602191 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25025 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 13, 2018
| https://github.com/nodejs/node/pull/25025#pullrequestreview-184920867 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25025/files/0073954f33bbbb2e7f279db561b0335beba4715c |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Dec 14, 2018
| https://github.com/nodejs/node/pull/25025#pullrequestreview-185094801 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25025/files/0073954f33bbbb2e7f279db561b0335beba4715c |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/25025#pullrequestreview-185094801 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25025 |
|
| https://github.com/sam-github |
| fixup! test: merge test with unnecessary child process | https://github.com/nodejs/node/pull/25025/commits/081381bdfd9969dc519569619763e5435a647920 |
| 081381b | https://github.com/nodejs/node/pull/25025/commits/081381bdfd9969dc519569619763e5435a647920 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Dec 14, 2018
| https://github.com/nodejs/node/pull/25025#pullrequestreview-185204212 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25025/files/081381bdfd9969dc519569619763e5435a647920 |
|
| https://github.com/sam-github |
| fixup! fixup! test: merge test with unnecessary child process | https://github.com/nodejs/node/pull/25025/commits/421539012fe7ab02a97ba003b6e98a7eb904c78a |
| 4215390 | https://github.com/nodejs/node/pull/25025/commits/421539012fe7ab02a97ba003b6e98a7eb904c78a |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25025#issuecomment-447492683 |
| Please reload this page | https://github.com/nodejs/node/pull/25025 |
| https://ci.nodejs.org/job/node-test-pull-request/19535/ | https://ci.nodejs.org/job/node-test-pull-request/19535/ |
| https://ci.nodejs.org/job/node-test-pull-request/19545/ | https://ci.nodejs.org/job/node-test-pull-request/19545/ |
| Please reload this page | https://github.com/nodejs/node/pull/25025 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 15, 2018 | https://github.com/nodejs/node/pull/25025#issuecomment-447529575 |
| Please reload this page | https://github.com/nodejs/node/pull/25025 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 15, 2018 | https://github.com/nodejs/node/pull/25025#event-2028268823 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 17, 2018 | https://github.com/nodejs/node/pull/25025#issuecomment-447726926 |
| Please reload this page | https://github.com/nodejs/node/pull/25025 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 17, 2018 | https://github.com/nodejs/node/pull/25025#event-2029348703 |
| Trott | https://github.com/Trott |
|
Dec 17, 2018
| https://github.com/nodejs/node/pull/25025#ref-commit-b54d4a6 |
|
| https://github.com/sam-github |
|
| https://github.com/Trott |
| test: merge test with unnecessary child process | https://github.com/Trott/io.js/commit/b54d4a68e3967f0e106af520ccd95dbc375fbf22 |
| b54d4a6 | https://github.com/Trott/io.js/commit/b54d4a68e3967f0e106af520ccd95dbc375fbf22 |
| nodejs#25025 | https://github.com/nodejs/node/pull/25025 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 25, 2018
| https://github.com/nodejs/node/pull/25025#ref-commit-30b6155 |
|
| https://github.com/sam-github |
|
| https://github.com/MylesBorins |
| test: merge test with unnecessary child process | https://github.com/nodejs/node/commit/30b61554f64478935894dad7016df4de8b4aa278 |
| 30b6155 | https://github.com/nodejs/node/commit/30b61554f64478935894dad7016df4de8b4aa278 |
| #25025 | https://github.com/nodejs/node/pull/25025 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 25, 2018
| https://github.com/nodejs/node/pull/25025#ref-pullrequest-393620382 |
|
v11.6.0 proposal
#25175
| https://github.com/nodejs/node/pull/25175 |
| refack | https://github.com/refack |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/25025#ref-commit-7b77d7c |
|
| https://github.com/sam-github |
|
| https://github.com/refack |
| test: merge test with unnecessary child process | https://github.com/refack/node/commit/7b77d7cee557f6527270c9e82fe7755a3478d22f |
| 7b77d7c | https://github.com/refack/node/commit/7b77d7cee557f6527270c9e82fe7755a3478d22f |
| nodejs#25025 | https://github.com/nodejs/node/pull/25025 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/25025#ref-commit-56c6686 |
|
| https://github.com/sam-github |
|
| https://github.com/BethGriggs |
| test: merge test with unnecessary child process | https://github.com/nodejs/node/commit/56c6686fe5cbd69a6afa3efc4a8a6b1706d867fc |
| 56c6686 | https://github.com/nodejs/node/commit/56c6686fe5cbd69a6afa3efc4a8a6b1706d867fc |
| #25025 | https://github.com/nodejs/node/pull/25025 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/25025#event-2134969395 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/25025#ref-pullrequest-409543286 |
|
v10.15.3 proposal
#26063
| https://github.com/nodejs/node/pull/26063 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 20, 2019
| https://github.com/nodejs/node/pull/25025#ref-commit-e17c0c6 |
|
| https://github.com/sam-github |
|
| https://github.com/BethGriggs |
| test: merge test with unnecessary child process | https://github.com/nodejs/node/commit/e17c0c62e16727e3bf01100a5fa03cbc4f803a41 |
| e17c0c6 | https://github.com/nodejs/node/commit/e17c0c62e16727e3bf01100a5fa03cbc4f803a41 |
| #25025 | https://github.com/nodejs/node/pull/25025 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25025#ref-commit-d3c4cab |
|
| https://github.com/sam-github |
|
| https://github.com/rvagg |
| test: merge test with unnecessary child process | https://github.com/nodejs/node/commit/d3c4cabc1e7335b50c8bcf054e1919611ccad4f2 |
| d3c4cab | https://github.com/nodejs/node/commit/d3c4cabc1e7335b50c8bcf054e1919611ccad4f2 |
| #25025 | https://github.com/nodejs/node/pull/25025 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| March 20, 2019 15:28 | https://github.com/nodejs/node/pull/25025#event-2217218056 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25025 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/25025/files/0073954f33bbbb2e7f279db561b0335beba4715c |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/25025/files/0073954f33bbbb2e7f279db561b0335beba4715c |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/25025/files/081381bdfd9969dc519569619763e5435a647920 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/25025 |
|
| https://github.com/sam-github |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com/BethGriggs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |