| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:52d3f844-9ed8-86f7-35c6-6f64f69f5709 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C91E:1F0B:222A8E6:2EFFCC1:6A4F4BB3 |
| html-safe-nonce | f2a0e99da31387e6e84fdb6bfeb4d46ce4be580c2ae6dfa2fa9a4fa9fed8a2f8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTFFOjFGMEI6MjIyQThFNjoyRUZGQ0MxOjZBNEY0QkIzIiwidmlzaXRvcl9pZCI6IjI0NDE5NzE3OTMyODU1NjUzNjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fa60d199a743547081a1e6e9931fd4e236d17412567313fe920b261efe36c0f3 |
| hovercard-subject-tag | pull_request:238457404 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/25019 |
| twitter:image | https://opengraph.githubassets.com/3b4ee620a5207f2ecfde5cb7a59ab772fb03621c348962244c244436ba034dba/nodejs/node/pull/25019 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3b4ee620a5207f2ecfde5cb7a59ab772fb03621c348962244c244436ba034dba/nodejs/node/pull/25019 |
| og:image:alt | Move the apilinks.json file into out/doc so it gets cleaned when
running make docclean
When the apilinks.json generated is empty, throw a specific error
so it's easier to understand what's ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25019#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25019 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25019 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25019 |
| Reload | https://github.com/nodejs/node/pull/25019 |
| Reload | https://github.com/nodejs/node/pull/25019 |
| Please reload this page | https://github.com/nodejs/node/pull/25019 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25019 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
969
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:apilinks | https://github.com/joyeecheung/node/tree/apilinks |
| Conversation | https://github.com/nodejs/node/pull/25019 |
| Commits1 (1) | https://github.com/nodejs/node/pull/25019/commits |
| Checks | https://github.com/nodejs/node/pull/25019/checks |
| Files changed | https://github.com/nodejs/node/pull/25019/files |
| tools: make apilinks building more robust | https://github.com/nodejs/node/pull/25019#top |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:apilinks | https://github.com/joyeecheung/node/tree/apilinks |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25019#issue-390764458 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25019 |
|
| https://github.com/joyeecheung |
| tools: make apilinks building more robust | https://github.com/nodejs/node/pull/25019/commits/1cbc5e77c11839f3f0b2903d7f8de7d74eadb2dc |
| 1cbc5e7 | https://github.com/nodejs/node/pull/25019/commits/1cbc5e77c11839f3f0b2903d7f8de7d74eadb2dc |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25019#issuecomment-447037767 |
| @joyeecheung | https://github.com/joyeecheung |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1930/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1930/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25019 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25019#event-2024735837 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Dec 16, 2018
| https://github.com/nodejs/node/pull/25019#ref-pullrequest-391407202 |
|
tools: better error message for failed tools/doc/generate
#25064
| https://github.com/nodejs/node/pull/25064 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Dec 16, 2018
| https://github.com/nodejs/node/pull/25019#pullrequestreview-185372410 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25019/files/1cbc5e77c11839f3f0b2903d7f8de7d74eadb2dc |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 17, 2018
| https://github.com/nodejs/node/pull/25019#pullrequestreview-185436028 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25019/files/1cbc5e77c11839f3f0b2903d7f8de7d74eadb2dc |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 17, 2018 | https://github.com/nodejs/node/pull/25019#issuecomment-447727200 |
| Please reload this page | https://github.com/nodejs/node/pull/25019 |
| https://ci.nodejs.org/job/node-test-pull-request/19596/ | https://ci.nodejs.org/job/node-test-pull-request/19596/ |
| Please reload this page | https://github.com/nodejs/node/pull/25019 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 17, 2018 | https://github.com/nodejs/node/pull/25019#event-2029350521 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/25019#issuecomment-448091396 |
| 9190e4e | https://github.com/nodejs/node/commit/9190e4ecdf891892e479b0ef4b691252d4084806 |
| Please reload this page | https://github.com/nodejs/node/pull/25019 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/25019#event-2031991571 |
| danbev | https://github.com/danbev |
|
Dec 18, 2018
| https://github.com/nodejs/node/pull/25019#ref-commit-9190e4e |
|
| https://github.com/joyeecheung |
|
| https://github.com/danbev |
| tools: make apilinks building more robust | https://github.com/nodejs/node/commit/9190e4ecdf891892e479b0ef4b691252d4084806 |
| 9190e4e | https://github.com/nodejs/node/commit/9190e4ecdf891892e479b0ef4b691252d4084806 |
| #25019 | https://github.com/nodejs/node/pull/25019 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 25, 2018
| https://github.com/nodejs/node/pull/25019#ref-commit-a5bccc2 |
|
| https://github.com/joyeecheung |
|
| https://github.com/MylesBorins |
| tools: make apilinks building more robust | https://github.com/nodejs/node/commit/a5bccc2919817bc1ec60852fe847e13411f72fac |
| a5bccc2 | https://github.com/nodejs/node/commit/a5bccc2919817bc1ec60852fe847e13411f72fac |
| #25019 | https://github.com/nodejs/node/pull/25019 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 25, 2018
| https://github.com/nodejs/node/pull/25019#ref-pullrequest-393620382 |
|
v11.6.0 proposal
#25175
| https://github.com/nodejs/node/pull/25175 |
| refack | https://github.com/refack |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/25019#ref-commit-b2e771d |
|
| https://github.com/joyeecheung |
|
| https://github.com/refack |
| tools: make apilinks building more robust | https://github.com/refack/node/commit/b2e771da59cf2b690eae63c8f8dedd340ce77da2 |
| b2e771d | https://github.com/refack/node/commit/b2e771da59cf2b690eae63c8f8dedd340ce77da2 |
| nodejs#25019 | https://github.com/nodejs/node/pull/25019 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 29, 2019
| https://github.com/nodejs/node/pull/25019#ref-commit-c8119db |
|
| https://github.com/MylesBorins |
| assets: additional asset for v11.x | https://github.com/MylesBorins/build/commit/c8119db776956edac4e5bdc1da5b8154c65a0b09 |
| c8119db | https://github.com/MylesBorins/build/commit/c8119db776956edac4e5bdc1da5b8154c65a0b09 |
| nodejs/node#22405 | https://github.com/nodejs/node/pull/22405 |
| nodejs/node#25019 | https://github.com/nodejs/node/pull/25019 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 29, 2019
| https://github.com/nodejs/node/pull/25019#ref-pullrequest-404364786 |
|
assets: additional asset for v11.x
nodejs/build#1673
| https://github.com/nodejs/build/pull/1673 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/25019#ref-commit-027ca95 |
|
| https://github.com/joyeecheung |
|
| https://github.com/BethGriggs |
| tools: make apilinks building more robust | https://github.com/nodejs/node/commit/027ca95b46bfe9f6922c6ce170001453ab11d919 |
| 027ca95 | https://github.com/nodejs/node/commit/027ca95b46bfe9f6922c6ce170001453ab11d919 |
| #25019 | https://github.com/nodejs/node/pull/25019 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/25019#event-2134987344 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/25019#ref-pullrequest-409543286 |
|
v10.15.3 proposal
#26063
| https://github.com/nodejs/node/pull/26063 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 20, 2019
| https://github.com/nodejs/node/pull/25019#ref-commit-71fad31 |
|
| https://github.com/joyeecheung |
|
| https://github.com/BethGriggs |
| tools: make apilinks building more robust | https://github.com/nodejs/node/commit/71fad317110c7145d28508df8856c62ca1884772 |
| 71fad31 | https://github.com/nodejs/node/commit/71fad317110c7145d28508df8856c62ca1884772 |
| #25019 | https://github.com/nodejs/node/pull/25019 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25019#ref-commit-6098487 |
|
| https://github.com/MylesBorins |
|
| https://github.com/rvagg |
| assets: additional asset for v11.x | https://github.com/nodejs/build/commit/6098487294f31944da4235b55ab21d8db29e6975 |
| 6098487 | https://github.com/nodejs/build/commit/6098487294f31944da4235b55ab21d8db29e6975 |
| nodejs/node#22405 | https://github.com/nodejs/node/pull/22405 |
| nodejs/node#25019 | https://github.com/nodejs/node/pull/25019 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25019#ref-commit-ef07faa |
|
| https://github.com/joyeecheung |
|
| https://github.com/rvagg |
| tools: make apilinks building more robust | https://github.com/nodejs/node/commit/ef07faa7bb7f7678b7def3ed54890263ed157d0d |
| ef07faa | https://github.com/nodejs/node/commit/ef07faa7bb7f7678b7def3ed54890263ed157d0d |
| #25019 | https://github.com/nodejs/node/pull/25019 |
| richardlau | https://github.com/richardlau |
|
Apr 9, 2020
| https://github.com/nodejs/node/pull/25019#ref-commit-1f5e87b |
|
| https://github.com/richardlau |
| promote: add additional asset for v10.x | https://github.com/richardlau/build/commit/1f5e87bfee76ef8f1ea6808c5fdefe5daeb651ee |
| 1f5e87b | https://github.com/richardlau/build/commit/1f5e87bfee76ef8f1ea6808c5fdefe5daeb651ee |
| nodejs/node#25019 | https://github.com/nodejs/node/pull/25019 |
| nodejs#1673 | https://github.com/nodejs/build/pull/1673 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Apr 9, 2020
| https://github.com/nodejs/node/pull/25019#ref-pullrequest-597192122 |
|
Update expected assets for v10.x and add v14.x
nodejs/build#2278
| https://github.com/nodejs/build/pull/2278 |
| rvagg | https://github.com/rvagg |
|
Apr 13, 2020
| https://github.com/nodejs/node/pull/25019#ref-commit-8c2444d |
|
| https://github.com/richardlau |
|
| https://github.com/rvagg |
| promote: add additional asset for v10.x | https://github.com/nodejs/build/commit/8c2444d494474e42ee36522aeb94b72e6afccdd7 |
| 8c2444d | https://github.com/nodejs/build/commit/8c2444d494474e42ee36522aeb94b72e6afccdd7 |
| nodejs/node#25019 | https://github.com/nodejs/node/pull/25019 |
| #1673 | https://github.com/nodejs/build/pull/1673 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25019 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/25019/files/1cbc5e77c11839f3f0b2903d7f8de7d74eadb2dc |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/25019/files/1cbc5e77c11839f3f0b2903d7f8de7d74eadb2dc |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/25019 |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/danbev |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/BethGriggs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |