| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e982d28d-e4cb-8bb1-2b0f-e2a30d989e55 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CAE0:14AE18:9AF7B9:C395F4:69915228 |
| html-safe-nonce | 7d489aa752f19672c25270be07ca41b31d24b19d5f43f9aa25d1916d116d3260 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUUwOjE0QUUxODo5QUY3Qjk6QzM5NUY0OjY5OTE1MjI4IiwidmlzaXRvcl9pZCI6IjEzODY3NDE0OTE4Mjc1NTM2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 953ad2ccc7f1c13607801e63b250a2bebe55869bccc826a5a2497f4839028a79 |
| hovercard-subject-tag | pull_request:238225094 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25002/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/98cdc4e6eb5730aca8a8df1caed25aa98d304225272fd9fa3d4595044b0c7c04/nodejs/node/pull/25002 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/98cdc4e6eb5730aca8a8df1caed25aa98d304225272fd9fa3d4595044b0c7c04/nodejs/node/pull/25002 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines
Backporting T... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25002#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25002 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25002 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25002 |
| Reload | https://github.com/nodejs/node/pull/25002 |
| Reload | https://github.com/nodejs/node/pull/25002 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:v8.x-staging | https://github.com/nodejs/node/tree/v8.x-staging |
| gabrielschulhof:backport-tsfn-to-v8.x | https://github.com/gabrielschulhof/node/tree/backport-tsfn-to-v8.x |
| Conversation | https://github.com/nodejs/node/pull/25002 |
| Commits10 (10) | https://github.com/nodejs/node/pull/25002/commits |
| Checks | https://github.com/nodejs/node/pull/25002/checks |
| Files changed | https://github.com/nodejs/node/pull/25002/files |
| [v8.x backport] Backport tsfn to v8.x | https://github.com/nodejs/node/pull/25002#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:v8.x-staging | https://github.com/nodejs/node/tree/v8.x-staging |
| gabrielschulhof:backport-tsfn-to-v8.x | https://github.com/gabrielschulhof/node/tree/backport-tsfn-to-v8.x |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25002#issue-390463578 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25002#issuecomment-446793038 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1916/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1916/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25002#event-2022959550 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Dec 13, 2018
| https://github.com/nodejs/node/pull/25002#pullrequestreview-184454444 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25002/files |
| src/node_api.cc | https://github.com/nodejs/node/pull/25002/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25002#discussion_r241232645 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| src/node_api.cc | https://github.com/nodejs/node/pull/25002/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25002#discussion_r241232859 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| src/node_api.cc | https://github.com/nodejs/node/pull/25002/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25002#discussion_r241232987 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| src/node_api.cc | https://github.com/nodejs/node/pull/25002/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25002#discussion_r241233079 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25002#event-2022970012 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| addaleax | https://github.com/addaleax |
| bnoordhuis | https://github.com/bnoordhuis |
| mhdawson | https://github.com/mhdawson |
| December 13, 2018 00:20 | https://github.com/nodejs/node/pull/25002#event-2022970302 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25002#issuecomment-446795772 |
| https://ci.nodejs.org/job/node-test-pull-request/19468/ | https://ci.nodejs.org/job/node-test-pull-request/19468/ |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/25002#issuecomment-446800006 |
| #24249 | https://github.com/nodejs/node/issues/24249 |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| digitalinfinity | https://github.com/digitalinfinity |
| December 13, 2018 18:52 | https://github.com/nodejs/node/pull/25002#event-2025034833 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25002#issuecomment-447169092 |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| 2b1dd6c | https://github.com/nodejs/node/commit/2b1dd6ce3e8c4412c9d38b5ab5944409d4b5ee6f |
| 315b1c6 | https://github.com/nodejs/node/commit/315b1c656cee39c989015cc2b17fe8c864dbc3dd |
| 357aeaa | https://github.com/nodejs/node/commit/357aeaad6230d73e19994a7237b1ef8cb01c2124 |
| 403df7c | https://github.com/nodejs/node/commit/403df7c8a15a9714038c73e90371bed0d37437fa |
| 5081d96 | https://github.com/nodejs/node/commit/5081d9663f1ce50d733762b64278d99baa810c04 |
| c4de500 | https://github.com/nodejs/node/commit/c4de500c8785511eb18285a74fb9173ee06032e7 |
| 53296e8 | https://github.com/nodejs/node/commit/53296e8a3e72fe2b3c2a3391fce59d2ef0f32c59 |
| a27b0a3 | https://github.com/nodejs/node/commit/a27b0a35bde63e8dd03ca591b1cdfbc8cb6ca994 |
| 81f06ba | https://github.com/nodejs/node/commit/81f06ba7e49d9c077c209ab9c9de63bad08aa801 |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25002#issuecomment-449433334 |
| https://ci.nodejs.org/job/node-test-pull-request/19719/ | https://ci.nodejs.org/job/node-test-pull-request/19719/ |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25002#issuecomment-449433432 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/c5142b356c74b997e100202b93114abecca78f42..3af7528ac399e77eca40b2d00a39afb8dc935b95 |
| c5142b3 | https://github.com/nodejs/node/commit/c5142b356c74b997e100202b93114abecca78f42 |
| 3af7528 | https://github.com/nodejs/node/commit/3af7528ac399e77eca40b2d00a39afb8dc935b95 |
|
Compare
| https://github.com/nodejs/node/compare/c5142b356c74b997e100202b93114abecca78f42..3af7528ac399e77eca40b2d00a39afb8dc935b95 |
| December 26, 2018 16:19 | https://github.com/nodejs/node/pull/25002#event-2044788162 |
| https://github.com/pipobscure |
| pipobscure | https://github.com/pipobscure |
|
Dec 28, 2018
| https://github.com/nodejs/node/pull/25002#ref-issue-378751386 |
|
Graduate experimental N-API feature napi_threadsafe_function
#24249
| https://github.com/nodejs/node/issues/24249 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 28, 2018 | https://github.com/nodejs/node/pull/25002#issuecomment-450416108 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| December 28, 2018 12:00 | https://github.com/nodejs/node/pull/25002#commits-pushed-2e15372 |
| n-api: add API for asynchronous functions | https://github.com/nodejs/node/pull/25002/commits/2e153724e5a6363917d5ca1fa8fc3810865d819d |
| 2e15372 | https://github.com/nodejs/node/pull/25002/commits/2e153724e5a6363917d5ca1fa8fc3810865d819d |
| nodejs/help#1035 | https://github.com/nodejs/help/issues/1035 |
| nodejs#20964 | https://github.com/nodejs/node/issues/20964 |
| nodejs#13512 | https://github.com/nodejs/node/issues/13512 |
| nodejs#17887 | https://github.com/nodejs/node/pull/17887 |
|
| https://github.com/cjihrig |
| n-api: fix compiler warning | https://github.com/nodejs/node/pull/25002/commits/b285f1d2267b4ad5f8545da8b0de40eb84943ead |
| b285f1d | https://github.com/nodejs/node/pull/25002/commits/b285f1d2267b4ad5f8545da8b0de40eb84943ead |
| nodejs#21597 | https://github.com/nodejs/node/pull/21597 |
| nodejs#17887 | https://github.com/nodejs/node/pull/17887 |
| n-api: guard against cond null dereference | https://github.com/nodejs/node/pull/25002/commits/7600c04df2306f881ea96dfe4e31f2e7803a132a |
| 7600c04 | https://github.com/nodejs/node/pull/25002/commits/7600c04df2306f881ea96dfe4e31f2e7803a132a |
| nodejs/help#1387 | https://github.com/nodejs/help/issues/1387 |
| nodejs#21871 | https://github.com/nodejs/node/pull/21871 |
|
| https://github.com/mhdawson |
| src: fix may be uninitialized warning in n-api | https://github.com/nodejs/node/pull/25002/commits/796576528895acaef13ffe4c5fc24d9127d844b6 |
| 7965765 | https://github.com/nodejs/node/pull/25002/commits/796576528895acaef13ffe4c5fc24d9127d844b6 |
| nodejs#21898 | https://github.com/nodejs/node/pull/21898 |
| n-api: remove idle_running from TsFn | https://github.com/nodejs/node/pull/25002/commits/46118be491f4f0b859a49dfab965394ccd612d76 |
| 46118be | https://github.com/nodejs/node/pull/25002/commits/46118be491f4f0b859a49dfab965394ccd612d76 |
| nodejs#22520 | https://github.com/nodejs/node/pull/22520 |
| n-api: clean up thread-safe function | https://github.com/nodejs/node/pull/25002/commits/35c6b1dfade51780cab1ab5ad97925e415af7d50 |
| 35c6b1d | https://github.com/nodejs/node/pull/25002/commits/35c6b1dfade51780cab1ab5ad97925e415af7d50 |
| nodejs#22259 | https://github.com/nodejs/node/pull/22259 |
| doc: fix optional parameters in n-api.md | https://github.com/nodejs/node/pull/25002/commits/8efb65bdbf472add5f4d1da91bc9ce1f5aed9f4d |
| 8efb65b | https://github.com/nodejs/node/pull/25002/commits/8efb65bdbf472add5f4d1da91bc9ce1f5aed9f4d |
| nodejs#22998 | https://github.com/nodejs/node/pull/22998 |
|
| https://github.com/danbev |
| n-api: add missing handle scopes | https://github.com/nodejs/node/pull/25002/commits/f116dc4b2ac9074f748192d3fe3b72833ab76092 |
| f116dc4 | https://github.com/nodejs/node/pull/25002/commits/f116dc4b2ac9074f748192d3fe3b72833ab76092 |
| https://github.com/v8/v8/blob/2ef0aa662fe907a1b36ac1abe7d77ad2bcd27733 | https://github.com/v8/v8/blob/2ef0aa662fe907a1b36ac1abe7d77ad2bcd27733 |
| nodejs#24011 | https://github.com/nodejs/node/pull/24011 |
|
| https://github.com/gireeshpunathil |
| test: mark test_threadsafe_function/test as flaky | https://github.com/nodejs/node/pull/25002/commits/e0e1ac2d0317bd407bf935f1a4ecb338c650f037 |
| e0e1ac2 | https://github.com/nodejs/node/pull/25002/commits/e0e1ac2d0317bd407bf935f1a4ecb338c650f037 |
| nodejs#23621 | https://github.com/nodejs/node/issues/23621 |
| nodejs#24714 | https://github.com/nodejs/node/pull/24714 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/4f1a9fa78613c95683b6cebec15422b258a531d3..e0e1ac2d0317bd407bf935f1a4ecb338c650f037 |
| 4f1a9fa | https://github.com/nodejs/node/commit/4f1a9fa78613c95683b6cebec15422b258a531d3 |
| e0e1ac2 | https://github.com/nodejs/node/commit/e0e1ac2d0317bd407bf935f1a4ecb338c650f037 |
|
Compare
| https://github.com/nodejs/node/compare/4f1a9fa78613c95683b6cebec15422b258a531d3..e0e1ac2d0317bd407bf935f1a4ecb338c650f037 |
| December 28, 2018 20:09 | https://github.com/nodejs/node/pull/25002#event-2047667859 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 28, 2018 | https://github.com/nodejs/node/pull/25002#issuecomment-450419851 |
| https://ci.nodejs.org/job/node-test-pull-request/19859/ | https://ci.nodejs.org/job/node-test-pull-request/19859/ |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 28, 2018 | https://github.com/nodejs/node/pull/25002#issuecomment-450435120 |
| https://ci.nodejs.org/job/node-test-pull-request/19860/ | https://ci.nodejs.org/job/node-test-pull-request/19860/ |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| stale review | https://github.com/nodejs/node/pull/25002#pullrequestreview-189150742 |
| January 3, 2019 22:13 | https://github.com/nodejs/node/pull/25002#event-2053438462 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jan 3, 2019 | https://github.com/nodejs/node/pull/25002#issuecomment-451294546 |
| @tniessen | https://github.com/tniessen |
| nodejs/Release#405 | https://github.com/nodejs/Release/issues/405 |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 3, 2019 | https://github.com/nodejs/node/pull/25002#issuecomment-451296248 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/pipobscure |
| pipobscure | https://github.com/pipobscure |
| Jan 15, 2019 | https://github.com/nodejs/node/pull/25002#issuecomment-454538193 |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/pipobscure |
| pipobscure | https://github.com/pipobscure |
|
Jan 15, 2019
| https://github.com/nodejs/node/pull/25002#ref-pullrequest-394689728 |
|
Simplify/Reduce API
fsevents/fsevents#247
| https://github.com/fsevents/fsevents/pull/247 |
| https://github.com/paulmillr |
| paulmillr | https://github.com/paulmillr |
| Jan 15, 2019 | https://github.com/nodejs/node/pull/25002#issuecomment-454566687 |
| @MylesBorins | https://github.com/MylesBorins |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/25002#pullrequestreview-193961838 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25002/files/f2e451027df5c18730d22d39dd56e2f99b2f1443 |
| MylesBorins | https://github.com/MylesBorins |
| https://github.com/nodejs/node/pull/25002#pullrequestreview-193961838 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-64f232c |
|
| https://github.com/MylesBorins |
| n-api: add API for asynchronous functions | https://github.com/nodejs/node/commit/64f232cc7867af7f66bd4c1f8e09fdf383ab7218 |
| 64f232c | https://github.com/nodejs/node/commit/64f232cc7867af7f66bd4c1f8e09fdf383ab7218 |
| nodejs/help#1035 | https://github.com/nodejs/help/issues/1035 |
| #20964 | https://github.com/nodejs/node/issues/20964 |
| #13512 | https://github.com/nodejs/node/issues/13512 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-ca8ba15 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| n-api: fix compiler warning | https://github.com/nodejs/node/commit/ca8ba15fe8ede81ed74fd882af4a3cda28e51354 |
| ca8ba15 | https://github.com/nodejs/node/commit/ca8ba15fe8ede81ed74fd882af4a3cda28e51354 |
| #21597 | https://github.com/nodejs/node/pull/21597 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-7b68d89 |
|
| https://github.com/MylesBorins |
| n-api: guard against cond null dereference | https://github.com/nodejs/node/commit/7b68d89552788e9bb2197fa956d87e8d91dc1169 |
| 7b68d89 | https://github.com/nodejs/node/commit/7b68d89552788e9bb2197fa956d87e8d91dc1169 |
| nodejs/help#1387 | https://github.com/nodejs/help/issues/1387 |
| #21871 | https://github.com/nodejs/node/pull/21871 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-c275534 |
|
| https://github.com/mhdawson |
|
| https://github.com/MylesBorins |
| src: fix may be uninitialized warning in n-api | https://github.com/nodejs/node/commit/c275534d9359b09e11d0fb396d0857af18830c15 |
| c275534 | https://github.com/nodejs/node/commit/c275534d9359b09e11d0fb396d0857af18830c15 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #21898 | https://github.com/nodejs/node/pull/21898 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-311e1f1 |
|
| https://github.com/MylesBorins |
| n-api: remove idle_running from TsFn | https://github.com/nodejs/node/commit/311e1f1553a101b7541fa65babf8a8d7a0b51393 |
| 311e1f1 | https://github.com/nodejs/node/commit/311e1f1553a101b7541fa65babf8a8d7a0b51393 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #22520 | https://github.com/nodejs/node/pull/22520 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-a0fa101 |
|
| https://github.com/MylesBorins |
| n-api: clean up thread-safe function | https://github.com/nodejs/node/commit/a0fa1018c752105858c8ea90dc830b60c7115202 |
| a0fa101 | https://github.com/nodejs/node/commit/a0fa1018c752105858c8ea90dc830b60c7115202 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #22259 | https://github.com/nodejs/node/pull/22259 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-ffbfe34 |
|
| https://github.com/MylesBorins |
| doc: fix optional parameters in n-api.md | https://github.com/nodejs/node/commit/ffbfe34899270daae7250cff9f9b2e727f873226 |
| ffbfe34 | https://github.com/nodejs/node/commit/ffbfe34899270daae7250cff9f9b2e727f873226 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #22998 | https://github.com/nodejs/node/pull/22998 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-cffe85c |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
| n-api: add missing handle scopes | https://github.com/nodejs/node/commit/cffe85cd77cd2cb6d7a4735f474eda0897524b6d |
| cffe85c | https://github.com/nodejs/node/commit/cffe85cd77cd2cb6d7a4735f474eda0897524b6d |
| https://github.com/v8/v8/blob/2ef0aa662fe907a1b36ac1abe7d77ad2bcd27733 | https://github.com/v8/v8/blob/2ef0aa662fe907a1b36ac1abe7d77ad2bcd27733 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #24011 | https://github.com/nodejs/node/pull/24011 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-b44bd88 |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/MylesBorins |
| test: mark test_threadsafe_function/test as flaky | https://github.com/nodejs/node/commit/b44bd887875475dada837c3ab4ae7b1762df22af |
| b44bd88 | https://github.com/nodejs/node/commit/b44bd887875475dada837c3ab4ae7b1762df22af |
| #23621 | https://github.com/nodejs/node/issues/23621 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #24714 | https://github.com/nodejs/node/pull/24714 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jan 18, 2019 | https://github.com/nodejs/node/pull/25002#issuecomment-455441170 |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| 48da8be...b44bd88 | https://github.com/nodejs/node/compare/48da8bea1f8722236134d73c994424dcfcf04a75...b44bd887875475dada837c3ab4ae7b1762df22af |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jan 18, 2019 | https://github.com/nodejs/node/pull/25002#event-2082123085 |
| https://github.com/paulmillr |
| paulmillr | https://github.com/paulmillr |
| Jan 18, 2019 | https://github.com/nodejs/node/pull/25002#issuecomment-455472869 |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| https://github.com/pipobscure |
| pipobscure | https://github.com/pipobscure |
| Jan 18, 2019 | https://github.com/nodejs/node/pull/25002#issuecomment-455486221 |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-759a018 |
|
| https://github.com/rvagg |
| n-api: add API for asynchronous functions | https://github.com/nodejs/node/commit/759a0180b5194686692caab955e371c5efc82e4e |
| 759a018 | https://github.com/nodejs/node/commit/759a0180b5194686692caab955e371c5efc82e4e |
| nodejs/help#1035 | https://github.com/nodejs/help/issues/1035 |
| #20964 | https://github.com/nodejs/node/issues/20964 |
| #13512 | https://github.com/nodejs/node/issues/13512 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-c5a11dc |
|
| https://github.com/cjihrig |
|
| https://github.com/rvagg |
| n-api: fix compiler warning | https://github.com/nodejs/node/commit/c5a11dc58e48775dc3c510fed7fc858d54bcbd3a |
| c5a11dc | https://github.com/nodejs/node/commit/c5a11dc58e48775dc3c510fed7fc858d54bcbd3a |
| #21597 | https://github.com/nodejs/node/pull/21597 |
| #17887 | https://github.com/nodejs/node/pull/17887 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-3675059 |
|
| https://github.com/rvagg |
| n-api: guard against cond null dereference | https://github.com/nodejs/node/commit/367505940ab09369262295cf21d3ebe08b943ad5 |
| 3675059 | https://github.com/nodejs/node/commit/367505940ab09369262295cf21d3ebe08b943ad5 |
| nodejs/help#1387 | https://github.com/nodejs/help/issues/1387 |
| #21871 | https://github.com/nodejs/node/pull/21871 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-67b6e0d |
|
| https://github.com/mhdawson |
|
| https://github.com/rvagg |
| src: fix may be uninitialized warning in n-api | https://github.com/nodejs/node/commit/67b6e0d19ca2ca1fd0705f22730f1fd018568b5c |
| 67b6e0d | https://github.com/nodejs/node/commit/67b6e0d19ca2ca1fd0705f22730f1fd018568b5c |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #21898 | https://github.com/nodejs/node/pull/21898 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-09b88aa |
|
| https://github.com/rvagg |
| n-api: remove idle_running from TsFn | https://github.com/nodejs/node/commit/09b88aabb3fd5cfd2da98ae83c2f1edd82d899c5 |
| 09b88aa | https://github.com/nodejs/node/commit/09b88aabb3fd5cfd2da98ae83c2f1edd82d899c5 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #22520 | https://github.com/nodejs/node/pull/22520 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-902b079 |
|
| https://github.com/rvagg |
| n-api: clean up thread-safe function | https://github.com/nodejs/node/commit/902b07959f491e80d2f9cfc6f3ce92916f8e0cd4 |
| 902b079 | https://github.com/nodejs/node/commit/902b07959f491e80d2f9cfc6f3ce92916f8e0cd4 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #22259 | https://github.com/nodejs/node/pull/22259 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-6b7cccc |
|
| https://github.com/rvagg |
| doc: fix optional parameters in n-api.md | https://github.com/nodejs/node/commit/6b7cccc88aeb91a6e07a29ab296a7d49f80b614b |
| 6b7cccc | https://github.com/nodejs/node/commit/6b7cccc88aeb91a6e07a29ab296a7d49f80b614b |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #22998 | https://github.com/nodejs/node/pull/22998 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-fe43282 |
|
| https://github.com/danbev |
|
| https://github.com/rvagg |
| n-api: add missing handle scopes | https://github.com/nodejs/node/commit/fe4328252a95f8096dd559d981bcab26a39dd70a |
| fe43282 | https://github.com/nodejs/node/commit/fe4328252a95f8096dd559d981bcab26a39dd70a |
| https://github.com/v8/v8/blob/2ef0aa662fe907a1b36ac1abe7d77ad2bcd27733 | https://github.com/v8/v8/blob/2ef0aa662fe907a1b36ac1abe7d77ad2bcd27733 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #24011 | https://github.com/nodejs/node/pull/24011 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/25002#ref-commit-60db455 |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/rvagg |
| test: mark test_threadsafe_function/test as flaky | https://github.com/nodejs/node/commit/60db455961477244c6ca4fcf17bcd2c2e90820ca |
| 60db455 | https://github.com/nodejs/node/commit/60db455961477244c6ca4fcf17bcd2c2e90820ca |
| #23621 | https://github.com/nodejs/node/issues/23621 |
| #25002 | https://github.com/nodejs/node/pull/25002 |
| #24714 | https://github.com/nodejs/node/pull/24714 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| June 14, 2019 23:51 | https://github.com/nodejs/node/pull/25002#event-2415099496 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25002 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/25002/files/f2e451027df5c18730d22d39dd56e2f99b2f1443 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/digitalinfinity |
|
digitalinfinity
| https://github.com/digitalinfinity |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
| https://github.com/nodejs/node/pull/25002/files/f2e451027df5c18730d22d39dd56e2f99b2f1443 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/25002 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/MylesBorins |
|
| https://github.com/paulmillr |
|
| https://github.com/mhdawson |
|
| https://github.com/addaleax |
|
| https://github.com/pipobscure |
|
| https://github.com/cjihrig |
|
| https://github.com/danbev |
|
| https://github.com/gireeshpunathil |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |