René's URL Explorer Experiment


Title: [v10.x backport] tls: add min/max protocol version options by sam-github · Pull Request #24979 · nodejs/node · GitHub

Open Graph Title: [v10.x backport] tls: add min/max protocol version options by sam-github · Pull Request #24979 · nodejs/node

X Title: [v10.x backport] tls: add min/max protocol version options by sam-github · Pull Request #24979 · nodejs/node

Description: Backport of a backport... prep work for openssl 1.1.1 to land on v10.x The existing secureProtocol option only allows setting the allowed protocol to a specific version, or setting it to "all supported versions". It also used obscure strings based on OpenSSL C API functions. Directly setting the min or max is easier to use and explain. Backport-PR-URL: #24676 PR-URL: #24405 Reviewed-By: Refael Ackermann refack@gmail.com Reviewed-By: Rod Vagg rod@vagg.org Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Open Graph Description: Backport of a backport... prep work for openssl 1.1.1 to land on v10.x The existing secureProtocol option only allows setting the allowed protocol to a specific version, or setting it to "all ...

X Description: Backport of a backport... prep work for openssl 1.1.1 to land on v10.x The existing secureProtocol option only allows setting the allowed protocol to a specific version, or setting it to "...

Opengraph URL: https://github.com/nodejs/node/pull/24979

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:31ddde5d-aab8-0364-4d09-b3a6c25230cf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA802:673B1:49AA4B:5E9DE4:69928957
html-safe-nonceba29166168bb1ace3319c075bb4f9beb0dd4b7e74fd8010571c148dc854e14fa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODAyOjY3M0IxOjQ5QUE0Qjo1RTlERTQ6Njk5Mjg5NTciLCJ2aXNpdG9yX2lkIjoiNjI5NjgwMTM3MjAzODkyNDYzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9a68fc9a8b9635915801ba1fc2f704861dd408523dfde2e0beea9cb08c0f0d4e
hovercard-subject-tagpull_request:237910296
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/24979/files
twitter:imagehttps://avatars.githubusercontent.com/u/17607?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17607?s=400&v=4
og:image:altBackport of a backport... prep work for openssl 1.1.1 to land on v10.x The existing secureProtocol option only allows setting the allowed protocol to a specific version, or setting it to "all ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24979/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24979%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24979%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24979/files
Reloadhttps://github.com/nodejs/node/pull/24979/files
Reloadhttps://github.com/nodejs/node/pull/24979/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24979/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
sam-githubhttps://github.com/sam-github
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
sam-github:backport-tls-min-max-to-10.xhttps://github.com/sam-github/node/tree/backport-tls-min-max-to-10.x
Conversation 6 https://github.com/nodejs/node/pull/24979
Commits 2 https://github.com/nodejs/node/pull/24979/commits
Checks 0 https://github.com/nodejs/node/pull/24979/checks
Files changed https://github.com/nodejs/node/pull/24979/files
Please reload this pagehttps://github.com/nodejs/node/pull/24979/files
[v10.x backport] tls: add min/max protocol version options https://github.com/nodejs/node/pull/24979/files#top
Show all changes 2 commits https://github.com/nodejs/node/pull/24979/files
c62283c doc: fix REPLACEME for tls min/max protocol option sam-github Nov 30, 2018 https://github.com/nodejs/node/pull/24979/commits/c62283c6472a7a227eac9d9281f5c5e4914c1610
a8a0889 tls: add min/max protocol version options sam-github May 6, 2018 https://github.com/nodejs/node/pull/24979/commits/a8a08890605b87375c47279a0f704ab571136252
Clear filters https://github.com/nodejs/node/pull/24979/files
Please reload this pagehttps://github.com/nodejs/node/pull/24979/files
Please reload this pagehttps://github.com/nodejs/node/pull/24979/files
errors.md https://github.com/nodejs/node/pull/24979/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
tls.md https://github.com/nodejs/node/pull/24979/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
_tls_common.js https://github.com/nodejs/node/pull/24979/files#diff-e16679ca1a0c18eb3e587384f11d0710a78e379e50a102b9cffd53551fc37848
_tls_wrap.js https://github.com/nodejs/node/pull/24979/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https.js https://github.com/nodejs/node/pull/24979/files#diff-494d2deee304c672124ecd82d090283595fd3d8c5a80a1825d972a2d229e4944
errors.js https://github.com/nodejs/node/pull/24979/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
tls.js https://github.com/nodejs/node/pull/24979/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
node_constants.cc https://github.com/nodejs/node/pull/24979/files#diff-bcacb1af9448accaaa4b48951b91fc3991de2d4d1dcf355dfef619a63a5737df
node_crypto.cc https://github.com/nodejs/node/pull/24979/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
tls-connect.js https://github.com/nodejs/node/pull/24979/files#diff-7ab885f5ba4170e11410da8d8de19de73efb4d0624e19c9d6702b9b86ce8af49
test-https-agent-getname.js https://github.com/nodejs/node/pull/24979/files#diff-e00f47652f3d53a72dcb66d39e8bbeb6c9ec067c99503614a88d9598d4d560c4
test-tls-min-max-version.js https://github.com/nodejs/node/pull/24979/files#diff-5ca4e058cad07cbc1a5186ff2bc7f2b4b29cc12190049e5dbddbc26dfb088b66
doc/api/errors.mdhttps://github.com/nodejs/node/pull/24979/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
View file https://github.com/sam-github/node/blob/a8a08890605b87375c47279a0f704ab571136252/doc/api/errors.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/24979/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/24979/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
https://github.com/nodejs/node/pull/24979/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
doc/api/tls.mdhttps://github.com/nodejs/node/pull/24979/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
View file https://github.com/sam-github/node/blob/a8a08890605b87375c47279a0f704ab571136252/doc/api/tls.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/24979/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/24979/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
https://github.com/nodejs/node/pull/24979/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
https://github.com/nodejs/node/pull/24979/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
https://github.com/nodejs/node/pull/24979/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
https://github.com/nodejs/node/pull/24979/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
lib/_tls_common.jshttps://github.com/nodejs/node/pull/24979/files#diff-e16679ca1a0c18eb3e587384f11d0710a78e379e50a102b9cffd53551fc37848
View file https://github.com/sam-github/node/blob/a8a08890605b87375c47279a0f704ab571136252/lib/_tls_common.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/24979/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/24979/files#diff-e16679ca1a0c18eb3e587384f11d0710a78e379e50a102b9cffd53551fc37848
https://github.com/nodejs/node/pull/24979/files#diff-e16679ca1a0c18eb3e587384f11d0710a78e379e50a102b9cffd53551fc37848
https://github.com/nodejs/node/pull/24979/files#diff-e16679ca1a0c18eb3e587384f11d0710a78e379e50a102b9cffd53551fc37848
https://github.com/nodejs/node/pull/24979/files#diff-e16679ca1a0c18eb3e587384f11d0710a78e379e50a102b9cffd53551fc37848
lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/24979/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
View file https://github.com/sam-github/node/blob/a8a08890605b87375c47279a0f704ab571136252/lib/_tls_wrap.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/24979/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/24979/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/24979/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/24979/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/24979/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
lib/https.jshttps://github.com/nodejs/node/pull/24979/files#diff-494d2deee304c672124ecd82d090283595fd3d8c5a80a1825d972a2d229e4944
View file https://github.com/sam-github/node/blob/a8a08890605b87375c47279a0f704ab571136252/lib/https.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/24979/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/24979/files#diff-494d2deee304c672124ecd82d090283595fd3d8c5a80a1825d972a2d229e4944
https://github.com/nodejs/node/pull/24979/files#diff-494d2deee304c672124ecd82d090283595fd3d8c5a80a1825d972a2d229e4944
lib/internal/errors.jshttps://github.com/nodejs/node/pull/24979/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
View file https://github.com/sam-github/node/blob/a8a08890605b87375c47279a0f704ab571136252/lib/internal/errors.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/24979/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/24979/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
https://github.com/nodejs/node/pull/24979/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
lib/tls.jshttps://github.com/nodejs/node/pull/24979/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
View file https://github.com/sam-github/node/blob/a8a08890605b87375c47279a0f704ab571136252/lib/tls.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/24979/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/24979/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
https://github.com/nodejs/node/pull/24979/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
src/node_constants.cchttps://github.com/nodejs/node/pull/24979/files#diff-bcacb1af9448accaaa4b48951b91fc3991de2d4d1dcf355dfef619a63a5737df
View file https://github.com/sam-github/node/blob/a8a08890605b87375c47279a0f704ab571136252/src/node_constants.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/24979/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/24979/files#diff-bcacb1af9448accaaa4b48951b91fc3991de2d4d1dcf355dfef619a63a5737df
https://github.com/nodejs/node/pull/24979/files#diff-bcacb1af9448accaaa4b48951b91fc3991de2d4d1dcf355dfef619a63a5737df
src/node_crypto.cchttps://github.com/nodejs/node/pull/24979/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
View file https://github.com/sam-github/node/blob/a8a08890605b87375c47279a0f704ab571136252/src/node_crypto.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/24979/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/24979/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
https://github.com/nodejs/node/pull/24979/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
https://github.com/nodejs/node/pull/24979/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
test/fixtures/tls-connect.jshttps://github.com/nodejs/node/pull/24979/files#diff-7ab885f5ba4170e11410da8d8de19de73efb4d0624e19c9d6702b9b86ce8af49
View file https://github.com/sam-github/node/blob/a8a08890605b87375c47279a0f704ab571136252/test/fixtures/tls-connect.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/24979/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/24979/files#diff-7ab885f5ba4170e11410da8d8de19de73efb4d0624e19c9d6702b9b86ce8af49
https://github.com/nodejs/node/pull/24979/files#diff-7ab885f5ba4170e11410da8d8de19de73efb4d0624e19c9d6702b9b86ce8af49
test/parallel/test-https-agent-getname.jshttps://github.com/nodejs/node/pull/24979/files#diff-e00f47652f3d53a72dcb66d39e8bbeb6c9ec067c99503614a88d9598d4d560c4
View file https://github.com/sam-github/node/blob/a8a08890605b87375c47279a0f704ab571136252/test/parallel/test-https-agent-getname.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/24979/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/24979/files#diff-e00f47652f3d53a72dcb66d39e8bbeb6c9ec067c99503614a88d9598d4d560c4
https://github.com/nodejs/node/pull/24979/files#diff-e00f47652f3d53a72dcb66d39e8bbeb6c9ec067c99503614a88d9598d4d560c4
https://github.com/nodejs/node/pull/24979/files#diff-e00f47652f3d53a72dcb66d39e8bbeb6c9ec067c99503614a88d9598d4d560c4
Please reload this pagehttps://github.com/nodejs/node/pull/24979/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.