René's URL Explorer Experiment


Title: process: properly close file descriptor on exit by BridgeAR · Pull Request #24972 · nodejs/node · GitHub

Open Graph Title: process: properly close file descriptor on exit by BridgeAR · Pull Request #24972 · nodejs/node

X Title: process: properly close file descriptor on exit by BridgeAR · Pull Request #24972 · nodejs/node

Description: This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. This is pulled out from #24965 as suggested by @addalea...

Open Graph Description: This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. This is pulled out from #24965 as suggested by @addalea...

X Description: This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. This is pulled out from #24965 as suggested by @addalea...

Opengraph URL: https://github.com/nodejs/node/pull/24972

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:586f727e-6a6e-dee2-06c8-2b57f330eaf5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id80D4:2F843D:D08BAC:11FF0C1:696A8CE8
html-safe-nonce5871dc7a6df3f289e7bb571bd2f58b90a6bab270754a61b9dac958314d0d7761
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEQ0OjJGODQzRDpEMDhCQUM6MTFGRjBDMTo2OTZBOENFOCIsInZpc2l0b3JfaWQiOiI2NjIwNjIwNDE0MTM4MzU0OTIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac010c8d3b9be38181e8afa52019bc3868af2fc6158689c02e059ae10e62c4e0a0
hovercard-subject-tagpull_request:237848563
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24972/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/eb5bce193cac8cf2d0b83afd639f1caa871de3bfc575d6cd19c044e49090a769/nodejs/node/pull/24972
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eb5bce193cac8cf2d0b83afd639f1caa871de3bfc575d6cd19c044e49090a769/nodejs/node/pull/24972
og:image:altThis makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. This is pulled out from #24965 as suggested by @addalea...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24972#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24972
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24972
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24972
Reloadhttps://github.com/nodejs/node/pull/24972
Reloadhttps://github.com/nodejs/node/pull/24972
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24972
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/24972
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/24972#issue-comment-box
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:fix-async-warningshttps://github.com/BridgeAR/node/tree/fix-async-warnings
process: properly close file descriptor on exit https://github.com/nodejs/node/pull/24972#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:fix-async-warningshttps://github.com/BridgeAR/node/tree/fix-async-warnings
Conversation 5 https://github.com/nodejs/node/pull/24972
Commits 1 https://github.com/nodejs/node/pull/24972/commits
Checks 0 https://github.com/nodejs/node/pull/24972/checks
Files changed https://github.com/nodejs/node/pull/24972/files
Please reload this pagehttps://github.com/nodejs/node/pull/24972
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 11, 2018https://github.com/nodejs/node/pull/24972#issue-389980868
#24965https://github.com/nodejs/node/pull/24965
@addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/24965/files#r240770314https://github.com/nodejs/node/pull/24965/files#r240770314
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24972
https://github.com/BridgeAR
process: properly close file descriptor on exithttps://github.com/nodejs/node/pull/24972/commits/41e57971117609d3cd985a4e60e87253fcf04b6c
41e5797https://github.com/nodejs/node/pull/24972/commits/41e57971117609d3cd985a4e60e87253fcf04b6c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 11, 2018https://github.com/nodejs/node/pull/24972#issuecomment-446386223
@BridgeARhttps://github.com/BridgeAR
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1902/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1902/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24972
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Dec 11, 2018https://github.com/nodejs/node/pull/24972#event-2020037783
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 11, 2018 https://github.com/nodejs/node/pull/24972#ref-pullrequest-389904931
process: improve --redirect-warnings handling #24965 https://github.com/nodejs/node/pull/24965
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Dec 12, 2018 https://github.com/nodejs/node/pull/24972#pullrequestreview-183964697
View reviewed changes https://github.com/nodejs/node/pull/24972/files/41e57971117609d3cd985a4e60e87253fcf04b6c
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 12, 2018https://github.com/nodejs/node/pull/24972#issuecomment-446423757
Please reload this pagehttps://github.com/nodejs/node/pull/24972
https://ci.nodejs.org/job/node-test-pull-request/19436/https://ci.nodejs.org/job/node-test-pull-request/19436/
https://ci.nodejs.org/job/node-test-pull-request/19475/https://ci.nodejs.org/job/node-test-pull-request/19475/
https://ci.nodejs.org/job/node-test-pull-request/19483/https://ci.nodejs.org/job/node-test-pull-request/19483/
Please reload this pagehttps://github.com/nodejs/node/pull/24972
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 12, 2018https://github.com/nodejs/node/pull/24972#event-2020287552
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 12, 2018 https://github.com/nodejs/node/pull/24972#pullrequestreview-184450391
View reviewed changes https://github.com/nodejs/node/pull/24972/files/41e57971117609d3cd985a4e60e87253fcf04b6c
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/24972#issuecomment-447180928
https://ci.nodejs.org/job/node-test-pull-request/19497/https://ci.nodejs.org/job/node-test-pull-request/19497/
Please reload this pagehttps://github.com/nodejs/node/pull/24972
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/24972#issuecomment-447211534
Please reload this pagehttps://github.com/nodejs/node/pull/24972
#24921https://github.com/nodejs/node/issues/24921
@gireeshpunathilhttps://github.com/gireeshpunathil
nodejs/build#1637https://github.com/nodejs/build/issues/1637
#25029https://github.com/nodejs/node/issues/25029
https://ci.nodejs.org/job/node-test-pull-request/19503/https://ci.nodejs.org/job/node-test-pull-request/19503/
Please reload this pagehttps://github.com/nodejs/node/pull/24972
Trotthttps://github.com/Trott
Dec 14, 2018 https://github.com/nodejs/node/pull/24972#ref-commit-80ab537
https://github.com/BridgeAR
https://github.com/Trott
process: properly close file descriptor on exithttps://github.com/Trott/io.js/commit/80ab537ee6fa5513399b86ab439d954387d88772
80ab537https://github.com/Trott/io.js/commit/80ab537ee6fa5513399b86ab439d954387d88772
nodejs#24972https://github.com/nodejs/node/pull/24972
https://github.com/nodejs/node/pull/24965/files#r240770314https://github.com/nodejs/node/pull/24965/files#r240770314
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/24972#issuecomment-447235912
Please reload this pagehttps://github.com/nodejs/node/pull/24972
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/24972#event-2026133117
BethGriggshttps://github.com/BethGriggs
Dec 18, 2018 https://github.com/nodejs/node/pull/24972#ref-commit-f43f45a
https://github.com/BridgeAR
https://github.com/BethGriggs
process: properly close file descriptor on exithttps://github.com/nodejs/node/commit/f43f45a26cd0fe222d52c96a9df6df8b797b997f
f43f45ahttps://github.com/nodejs/node/commit/f43f45a26cd0fe222d52c96a9df6df8b797b997f
#24972https://github.com/nodejs/node/pull/24972
https://github.com/nodejs/node/pull/24965/files#r240770314https://github.com/nodejs/node/pull/24965/files#r240770314
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 18, 2018 https://github.com/nodejs/node/pull/24972#ref-pullrequest-391954489
V11.5.0 proposal #25102 https://github.com/nodejs/node/pull/25102
https://github.com/beevelop
beevelophttps://github.com/beevelop
Dec 18, 2018 https://github.com/nodejs/node/pull/24972#ref-issue-392300919
2018-12-18 Version 11.5.0 (Current) @BethGriggs beevelop/docker-android-nodejs#272 https://github.com/beevelop/docker-android-nodejs/issues/272
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/24972#ref-commit-e5fd8ee
https://github.com/BridgeAR
https://github.com/refack
process: properly close file descriptor on exithttps://github.com/refack/node/commit/e5fd8ee83c82cfedcabd0b3445eefd6042a60496
e5fd8eehttps://github.com/refack/node/commit/e5fd8ee83c82cfedcabd0b3445eefd6042a60496
nodejs#24972https://github.com/nodejs/node/pull/24972
https://github.com/nodejs/node/pull/24965/files#r240770314https://github.com/nodejs/node/pull/24965/files#r240770314
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/24972#ref-commit-a4068d9
https://github.com/BridgeAR
https://github.com/BethGriggs
process: properly close file descriptor on exithttps://github.com/nodejs/node/commit/a4068d9827fbbebfa1a99b6e50435e6256c4bc2a
a4068d9https://github.com/nodejs/node/commit/a4068d9827fbbebfa1a99b6e50435e6256c4bc2a
#24972https://github.com/nodejs/node/pull/24972
https://github.com/nodejs/node/pull/24965/files#r240770314https://github.com/nodejs/node/pull/24965/files#r240770314
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Feb 12, 2019https://github.com/nodejs/node/pull/24972#event-2134888246
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/24972#ref-pullrequest-409543286
v10.15.3 proposal #26063 https://github.com/nodejs/node/pull/26063
BethGriggshttps://github.com/BethGriggs
Feb 20, 2019 https://github.com/nodejs/node/pull/24972#ref-commit-0296681
https://github.com/BridgeAR
https://github.com/BethGriggs
process: properly close file descriptor on exithttps://github.com/nodejs/node/commit/0296681244d4b463b275f5d3197f753517d01d19
0296681https://github.com/nodejs/node/commit/0296681244d4b463b275f5d3197f753517d01d19
#24972https://github.com/nodejs/node/pull/24972
https://github.com/nodejs/node/pull/24965/files#r240770314https://github.com/nodejs/node/pull/24965/files#r240770314
rvagghttps://github.com/rvagg
Feb 28, 2019 https://github.com/nodejs/node/pull/24972#ref-commit-e75e1bc
https://github.com/BridgeAR
https://github.com/rvagg
process: properly close file descriptor on exithttps://github.com/nodejs/node/commit/e75e1bc31c759cae94dbe1c3163514b3c960aee8
e75e1bchttps://github.com/nodejs/node/commit/e75e1bc31c759cae94dbe1c3163514b3c960aee8
#24972https://github.com/nodejs/node/pull/24972
https://github.com/nodejs/node/pull/24965/files#r240770314https://github.com/nodejs/node/pull/24965/files#r240770314
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 11:45https://github.com/nodejs/node/pull/24972#event-2962648411
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24972
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/24972/files/41e57971117609d3cd985a4e60e87253fcf04b6c
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/24972/files/41e57971117609d3cd985a4e60e87253fcf04b6c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Please reload this pagehttps://github.com/nodejs/node/pull/24972
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/addaleax
https://github.com/Fishrock123
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.