René's URL Explorer Experiment


Title: src: emit 'params' instead of 'data' for NodeTracing.dataCollected by kjin · Pull Request #24949 · nodejs/node · GitHub

Open Graph Title: src: emit 'params' instead of 'data' for NodeTracing.dataCollected by kjin · Pull Request #24949 · nodejs/node

X Title: src: emit 'params' instead of 'data' for NodeTracing.dataCollected by kjin · Pull Request #24949 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: All inspector event emissions emit an object of the shape { method: string, params: {} } except for NodeTracing.dataCollected. This PR changes this event to emit an object with a params field inste...

X Description: All inspector event emissions emit an object of the shape { method: string, params: {} } except for NodeTracing.dataCollected. This PR changes this event to emit an object with a params field inste...

Opengraph URL: https://github.com/nodejs/node/pull/24949

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3e958cdd-8eaa-5ae6-bc31-9d0f8cf29207
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC80C:3EE845:8AA8CA4:C13AE03:6A502C7B
html-safe-noncebe465f63937ba7ce786f41ecf8a77be1683a27b5c1067cd34fad7828c4f5ffe3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODBDOjNFRTg0NTo4QUE4Q0E0OkMxM0FFMDM6NkE1MDJDN0IiLCJ2aXNpdG9yX2lkIjoiNzU1MTgzNjI0ODEwNjYwOTc4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac54d9595f1379db555265fb036ee254dd9b81b90c0216b27713fef089dec07320
hovercard-subject-tagpull_request:237506413
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24949/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1aa8e7a9ec3900766e79e26b053c251925e0962bda670ef3cbb28e50b4127008/nodejs/node/pull/24949
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1aa8e7a9ec3900766e79e26b053c251925e0962bda670ef3cbb28e50b4127008/nodejs/node/pull/24949
og:image:altAll inspector event emissions emit an object of the shape { method: string, params: {} } except for NodeTracing.dataCollected. This PR changes this event to emit an object with a params field inste...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekjin
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released90666eaf032b7eb8975a378efe38e37f4ebb96c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24949#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24949
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24949
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24949
Reloadhttps://github.com/nodejs/node/pull/24949
Reloadhttps://github.com/nodejs/node/pull/24949
Please reload this pagehttps://github.com/nodejs/node/pull/24949
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24949
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 977 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
kjinhttps://github.com/kjin
nodejs:masterhttps://github.com/nodejs/node/tree/master
kjin:inspector-trace-paramshttps://github.com/kjin/node/tree/inspector-trace-params
Conversationhttps://github.com/nodejs/node/pull/24949
Commits1 (1)https://github.com/nodejs/node/pull/24949/commits
Checkshttps://github.com/nodejs/node/pull/24949/checks
Files changedhttps://github.com/nodejs/node/pull/24949/files
src: emit 'params' instead of 'data' for NodeTracing.dataCollectedhttps://github.com/nodejs/node/pull/24949#top
kjinhttps://github.com/kjin
nodejs:masterhttps://github.com/nodejs/node/tree/master
kjin:inspector-trace-paramshttps://github.com/kjin/node/tree/inspector-trace-params
https://github.com/kjin
kjinhttps://github.com/kjin
Dec 10, 2018https://github.com/nodejs/node/pull/24949#issue-389537988
Please reload this pagehttps://github.com/nodejs/node/pull/24949
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24949
https://github.com/kjin
src: emit 'params' instead of 'data' for NodeTracing.dataCollectedhttps://github.com/nodejs/node/pull/24949/commits/c1907f84144ed91335e3891f6c06c14a1290d219
c1907f8https://github.com/nodejs/node/pull/24949/commits/c1907f84144ed91335e3891f6c06c14a1290d219
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Dec 10, 2018https://github.com/nodejs/node/pull/24949#event-2017364812
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
trace_events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atrace_events
Dec 11, 2018https://github.com/nodejs/node/pull/24949#event-2017388550
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 11, 2018 https://github.com/nodejs/node/pull/24949#pullrequestreview-183460036
View reviewed changes https://github.com/nodejs/node/pull/24949/files/c1907f84144ed91335e3891f6c06c14a1290d219
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/24949#pullrequestreview-183460036
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24949
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 11, 2018https://github.com/nodejs/node/pull/24949#issuecomment-446023518
https://ci.nodejs.org/job/node-test-pull-request/19410/https://ci.nodejs.org/job/node-test-pull-request/19410/
Please reload this pagehttps://github.com/nodejs/node/pull/24949
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Dec 11, 2018 https://github.com/nodejs/node/pull/24949#pullrequestreview-183461260
View reviewed changes https://github.com/nodejs/node/pull/24949/files/c1907f84144ed91335e3891f6c06c14a1290d219
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 11, 2018 https://github.com/nodejs/node/pull/24949#pullrequestreview-183681349
View reviewed changes https://github.com/nodejs/node/pull/24949/files/c1907f84144ed91335e3891f6c06c14a1290d219
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Dec 11, 2018 https://github.com/nodejs/node/pull/24949#pullrequestreview-183718835
View reviewed changes https://github.com/nodejs/node/pull/24949/files/c1907f84144ed91335e3891f6c06c14a1290d219
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 11, 2018https://github.com/nodejs/node/pull/24949#event-2018921494
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 11, 2018 https://github.com/nodejs/node/pull/24949#pullrequestreview-183818888
View reviewed changes https://github.com/nodejs/node/pull/24949/files/c1907f84144ed91335e3891f6c06c14a1290d219
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/24949#issuecomment-447178754
Please reload this pagehttps://github.com/nodejs/node/pull/24949
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/24949#issuecomment-447179004
https://ci.nodejs.org/job/node-test-pull-request/19495/https://ci.nodejs.org/job/node-test-pull-request/19495/
Please reload this pagehttps://github.com/nodejs/node/pull/24949
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Dec 14, 2018https://github.com/nodejs/node/pull/24949#issuecomment-447180473
Please reload this pagehttps://github.com/nodejs/node/pull/24949
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/24949#issuecomment-447202786
Please reload this pagehttps://github.com/nodejs/node/pull/24949
https://ci.nodejs.org/job/node-test-pull-request/19498/https://ci.nodejs.org/job/node-test-pull-request/19498/
Please reload this pagehttps://github.com/nodejs/node/pull/24949
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/24949#issuecomment-447212224
Please reload this pagehttps://github.com/nodejs/node/pull/24949
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/24949#event-2025975135
Trotthttps://github.com/Trott
Dec 14, 2018 https://github.com/nodejs/node/pull/24949#ref-commit-49f1db4
https://github.com/kjin
https://github.com/Trott
src: emit 'params' instead of 'data' for NodeTracing.dataCollectedhttps://github.com/Trott/io.js/commit/49f1db47e2bb0fa4f2a53f4244639502688a291b
49f1db4https://github.com/Trott/io.js/commit/49f1db47e2bb0fa4f2a53f4244639502688a291b
nodejs#24949https://github.com/nodejs/node/pull/24949
BethGriggshttps://github.com/BethGriggs
Dec 18, 2018 https://github.com/nodejs/node/pull/24949#ref-commit-5f8950b
https://github.com/kjin
https://github.com/BethGriggs
src: emit 'params' instead of 'data' for NodeTracing.dataCollectedhttps://github.com/nodejs/node/commit/5f8950b652bc6e384d266ee80b99b5ee091bdcfe
5f8950bhttps://github.com/nodejs/node/commit/5f8950b652bc6e384d266ee80b99b5ee091bdcfe
#24949https://github.com/nodejs/node/pull/24949
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 18, 2018 https://github.com/nodejs/node/pull/24949#ref-pullrequest-391954489
V11.5.0 proposal #25102 https://github.com/nodejs/node/pull/25102
https://github.com/beevelop
beevelophttps://github.com/beevelop
Dec 18, 2018 https://github.com/nodejs/node/pull/24949#ref-issue-392300919
2018-12-18 Version 11.5.0 (Current) @BethGriggs beevelop/docker-android-nodejs#272 https://github.com/beevelop/docker-android-nodejs/issues/272
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/24949#ref-commit-4a14223
https://github.com/kjin
https://github.com/refack
src: emit 'params' instead of 'data' for NodeTracing.dataCollectedhttps://github.com/refack/node/commit/4a14223a768905dbc0eb57d8bcf6d0b5410cb5f6
4a14223https://github.com/refack/node/commit/4a14223a768905dbc0eb57d8bcf6d0b5410cb5f6
nodejs#24949https://github.com/nodejs/node/pull/24949
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/24949#ref-commit-944e75d
https://github.com/kjin
https://github.com/BethGriggs
src: emit 'params' instead of 'data' for NodeTracing.dataCollectedhttps://github.com/nodejs/node/commit/944e75d10b6d6d67c565c731082fee9fcecb6c61
944e75dhttps://github.com/nodejs/node/commit/944e75d10b6d6d67c565c731082fee9fcecb6c61
#24949https://github.com/nodejs/node/pull/24949
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Feb 12, 2019https://github.com/nodejs/node/pull/24949#event-2134887815
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/24949#ref-pullrequest-409543286
v10.15.3 proposal #26063 https://github.com/nodejs/node/pull/26063
BethGriggshttps://github.com/BethGriggs
Feb 20, 2019 https://github.com/nodejs/node/pull/24949#ref-commit-2f39027
https://github.com/kjin
https://github.com/BethGriggs
src: emit 'params' instead of 'data' for NodeTracing.dataCollectedhttps://github.com/nodejs/node/commit/2f39027d4e3fe5839262d2c599d9a4398d0cecda
2f39027https://github.com/nodejs/node/commit/2f39027d4e3fe5839262d2c599d9a4398d0cecda
#24949https://github.com/nodejs/node/pull/24949
rvagghttps://github.com/rvagg
Feb 28, 2019 https://github.com/nodejs/node/pull/24949#ref-commit-38724f6
https://github.com/kjin
https://github.com/rvagg
src: emit 'params' instead of 'data' for NodeTracing.dataCollectedhttps://github.com/nodejs/node/commit/38724f6e181fae0a9758824f9aecab41830c1052
38724f6https://github.com/nodejs/node/commit/38724f6e181fae0a9758824f9aecab41830c1052
#24949https://github.com/nodejs/node/pull/24949
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24949
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/24949/files/c1907f84144ed91335e3891f6c06c14a1290d219
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/24949/files/c1907f84144ed91335e3891f6c06c14a1290d219
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/24949/files/c1907f84144ed91335e3891f6c06c14a1290d219
https://github.com/ofrobots
ofrobots https://github.com/ofrobots
https://github.com/nodejs/node/pull/24949/files/c1907f84144ed91335e3891f6c06c14a1290d219
https://github.com/antsmartian
antsmartian https://github.com/antsmartian
https://github.com/nodejs/node/pull/24949/files/c1907f84144ed91335e3891f6c06c14a1290d219
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
trace_events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atrace_events
Please reload this pagehttps://github.com/nodejs/node/pull/24949
https://github.com/kjin
https://github.com/addaleax
https://github.com/Trott
https://github.com/ofrobots
https://github.com/jasnell
https://github.com/antsmartian
https://github.com/cjihrig
https://github.com/BethGriggs
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.