René's URL Explorer Experiment


Title: lib: remove unused NativeModule.wrap and NativeModule.wrapper by joyeecheung · Pull Request #24904 · nodejs/node · GitHub

Open Graph Title: lib: remove unused NativeModule.wrap and NativeModule.wrapper by joyeecheung · Pull Request #24904 · nodejs/node

X Title: lib: remove unused NativeModule.wrap and NativeModule.wrapper by joyeecheung · Pull Request #24904 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: We now compile the native modules in C++ so these are no longer used. Refs: bd765d6 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: We now compile the native modules in C++ so these are no longer used. Refs: bd765d6 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/24904

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b3618a45-85e8-5840-2cd0-66012bd8f5ef
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD6A:E9E68:6F4F3:8F6C7:6A4ECCD5
html-safe-nonceab66b807fd44bad8bcbc4a2683292f654721c77ce4ac11d331b79a3a906a330e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDZBOkU5RTY4OjZGNEYzOjhGNkM3OjZBNEVDQ0Q1IiwidmlzaXRvcl9pZCI6IjMxOTA0MDc3NjgwNDY4Mjk2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac900db508a47c227a0171a026f6318c380495dd2caf5f8dedb50797d30c8903b8
hovercard-subject-tagpull_request:237070073
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24904/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5255335bb66ce1b5c98f35e74907156aad89d885a53e4c9aab962ca6b60f17ec/nodejs/node/pull/24904
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5255335bb66ce1b5c98f35e74907156aad89d885a53e4c9aab962ca6b60f17ec/nodejs/node/pull/24904
og:image:altWe now compile the native modules in C++ so these are no longer used. Refs: bd765d6 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24904#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24904
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24904
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24904
Reloadhttps://github.com/nodejs/node/pull/24904
Reloadhttps://github.com/nodejs/node/pull/24904
Please reload this pagehttps://github.com/nodejs/node/pull/24904
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24904
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:remove-wraphttps://github.com/joyeecheung/node/tree/remove-wrap
Conversationhttps://github.com/nodejs/node/pull/24904
Commits1 (1)https://github.com/nodejs/node/pull/24904/commits
Checkshttps://github.com/nodejs/node/pull/24904/checks
Files changedhttps://github.com/nodejs/node/pull/24904/files
lib: remove unused NativeModule.wrap and NativeModule.wrapperhttps://github.com/nodejs/node/pull/24904#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:remove-wraphttps://github.com/joyeecheung/node/tree/remove-wrap
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 8, 2018https://github.com/nodejs/node/pull/24904#issue-388925486
Please reload this pagehttps://github.com/nodejs/node/pull/24904
bd765d6https://github.com/nodejs/node/commit/bd765d61d7425d82e80bdf2f4f27c0424221837b
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24904
https://github.com/joyeecheung
lib: remove unused NativeModule.wrap and NativeModule.wrapperhttps://github.com/nodejs/node/pull/24904/commits/e2c4df42d11d5c58b26da884a36a9d59eae98712
e2c4df4https://github.com/nodejs/node/pull/24904/commits/e2c4df42d11d5c58b26da884a36a9d59eae98712
bd765d6https://github.com/joyeecheung/node/commit/bd765d61d7425d82e80bdf2f4f27c0424221837b
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 8, 2018https://github.com/nodejs/node/pull/24904#issuecomment-445462000
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1869/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1869/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24904
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Dec 8, 2018https://github.com/nodejs/node/pull/24904#event-2013995023
https://github.com/targos
targoshttps://github.com/targos
Dec 8, 2018 https://github.com/nodejs/node/pull/24904#pullrequestreview-182945520
View reviewed changes https://github.com/nodejs/node/pull/24904/files/e2c4df42d11d5c58b26da884a36a9d59eae98712
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Dec 8, 2018 https://github.com/nodejs/node/pull/24904#pullrequestreview-182945633
View reviewed changes https://github.com/nodejs/node/pull/24904/files/e2c4df42d11d5c58b26da884a36a9d59eae98712
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 8, 2018 https://github.com/nodejs/node/pull/24904#pullrequestreview-182946166
View reviewed changes https://github.com/nodejs/node/pull/24904/files/e2c4df42d11d5c58b26da884a36a9d59eae98712
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 9, 2018https://github.com/nodejs/node/pull/24904#issuecomment-445513446
https://ci.nodejs.org/job/node-test-pull-request/19348/https://ci.nodejs.org/job/node-test-pull-request/19348/
Please reload this pagehttps://github.com/nodejs/node/pull/24904
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 9, 2018 https://github.com/nodejs/node/pull/24904#pullrequestreview-182985701
View reviewed changes https://github.com/nodejs/node/pull/24904/files/e2c4df42d11d5c58b26da884a36a9d59eae98712
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 9, 2018 https://github.com/nodejs/node/pull/24904#pullrequestreview-182986869
View reviewed changes https://github.com/nodejs/node/pull/24904/files/e2c4df42d11d5c58b26da884a36a9d59eae98712
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Dec 10, 2018 https://github.com/nodejs/node/pull/24904#pullrequestreview-183014136
View reviewed changes https://github.com/nodejs/node/pull/24904/files/e2c4df42d11d5c58b26da884a36a9d59eae98712
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 10, 2018https://github.com/nodejs/node/pull/24904#event-2014951944
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 10, 2018https://github.com/nodejs/node/pull/24904#issuecomment-446000597
https://ci.nodejs.org/job/node-test-pull-request/19403/https://ci.nodejs.org/job/node-test-pull-request/19403/
Please reload this pagehttps://github.com/nodejs/node/pull/24904
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 10, 2018https://github.com/nodejs/node/pull/24904#issuecomment-446009134
Please reload this pagehttps://github.com/nodejs/node/pull/24904
https://ci.nodejs.org/job/node-test-pull-request/19405https://ci.nodejs.org/job/node-test-pull-request/19405
Please reload this pagehttps://github.com/nodejs/node/pull/24904
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 11, 2018https://github.com/nodejs/node/pull/24904#issuecomment-446069752
083b31dhttps://github.com/nodejs/node/commit/083b31d850aaee53d877162b15aaa317ae8d9f39
Please reload this pagehttps://github.com/nodejs/node/pull/24904
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 11, 2018https://github.com/nodejs/node/pull/24904#event-2017688984
danbevhttps://github.com/danbev
Dec 11, 2018 https://github.com/nodejs/node/pull/24904#ref-commit-083b31d
https://github.com/joyeecheung
https://github.com/danbev
lib: remove unused NativeModule/NativeModule wrapshttps://github.com/nodejs/node/commit/083b31d850aaee53d877162b15aaa317ae8d9f39
083b31dhttps://github.com/nodejs/node/commit/083b31d850aaee53d877162b15aaa317ae8d9f39
#24904https://github.com/nodejs/node/pull/24904
https://github.com/joyeecheung/node/commit/https://github.com/joyeecheung/node/commit/
bd765d6https://github.com/nodejs/node/commit/bd765d61d7425d82e80bdf2f4f27c0424221837b
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/24904#ref-commit-0cde1a4
https://github.com/joyeecheung
https://github.com/MylesBorins
lib: remove unused NativeModule/NativeModule wrapshttps://github.com/nodejs/node/commit/0cde1a4fdcd35724eb7e0f1408b199b7b30e070f
0cde1a4https://github.com/nodejs/node/commit/0cde1a4fdcd35724eb7e0f1408b199b7b30e070f
#24904https://github.com/nodejs/node/pull/24904
https://github.com/joyeecheung/node/commit/https://github.com/joyeecheung/node/commit/
bd765d6https://github.com/nodejs/node/commit/bd765d61d7425d82e80bdf2f4f27c0424221837b
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/24904#ref-pullrequest-393620382
v11.6.0 proposal #25175 https://github.com/nodejs/node/pull/25175
joyeecheunghttps://github.com/joyeecheung
Jan 11, 2019 https://github.com/nodejs/node/pull/24904#ref-commit-5bc4592
https://github.com/joyeecheung
lib: remove unused NativeModule/NativeModule wrapshttps://github.com/joyeecheung/node/commit/5bc459269db5a9a4af1953a0d9f0bc021943269f
5bc4592https://github.com/joyeecheung/node/commit/5bc459269db5a9a4af1953a0d9f0bc021943269f
nodejs#24904https://github.com/nodejs/node/pull/24904
https://github.com/joyeecheung/node/commit/https://github.com/joyeecheung/node/commit/
bd765d6https://github.com/joyeecheung/node/commit/bd765d61d7425d82e80bdf2f4f27c0424221837b
addaleaxhttps://github.com/addaleax
Jan 14, 2019 https://github.com/nodejs/node/pull/24904#ref-commit-d8ba520
https://github.com/joyeecheung
https://github.com/addaleax
lib: remove unused NativeModule/NativeModule wrapshttps://github.com/nodejs/node/commit/d8ba520622bc01f3487b4dd2344ad68c4f7b38b2
d8ba520https://github.com/nodejs/node/commit/d8ba520622bc01f3487b4dd2344ad68c4f7b38b2
#24904https://github.com/nodejs/node/pull/24904
https://github.com/joyeecheung/node/commit/https://github.com/joyeecheung/node/commit/
bd765d6https://github.com/nodejs/node/commit/bd765d61d7425d82e80bdf2f4f27c0424221837b
#25446https://github.com/nodejs/node/pull/25446
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/24904#ref-commit-bbc53f6
https://github.com/joyeecheung
https://github.com/refack
lib: remove unused NativeModule/NativeModule wrapshttps://github.com/refack/node/commit/bbc53f60e61a0040f9badf53cc299a2356d94c98
bbc53f6https://github.com/refack/node/commit/bbc53f60e61a0040f9badf53cc299a2356d94c98
nodejs#24904https://github.com/nodejs/node/pull/24904
https://github.com/joyeecheung/node/commit/https://github.com/joyeecheung/node/commit/
bd765d6https://github.com/refack/node/commit/bd765d61d7425d82e80bdf2f4f27c0424221837b
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 16, 2019 https://github.com/nodejs/node/pull/24904#ref-pullrequest-399868555
v11.7.0 proposal #25537 https://github.com/nodejs/node/pull/25537
BridgeARhttps://github.com/BridgeAR
Jan 16, 2019 https://github.com/nodejs/node/pull/24904#ref-commit-16c60ce
https://github.com/joyeecheung
https://github.com/BridgeAR
lib: remove unused NativeModule/NativeModule wrapshttps://github.com/BridgeAR/node/commit/16c60ce4a1d9bf35dea14b9f56fed4aef3921658
16c60cehttps://github.com/BridgeAR/node/commit/16c60ce4a1d9bf35dea14b9f56fed4aef3921658
nodejs#24904https://github.com/nodejs/node/pull/24904
https://github.com/joyeecheung/node/commit/https://github.com/joyeecheung/node/commit/
bd765d6https://github.com/BridgeAR/node/commit/bd765d61d7425d82e80bdf2f4f27c0424221837b
nodejs#25446https://github.com/nodejs/node/pull/25446
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 24, 2019 https://github.com/nodejs/node/pull/24904#ref-pullrequest-402909465
v11.8.0 proposal #25687 https://github.com/nodejs/node/pull/25687
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jul 3, 2019https://github.com/nodejs/node/pull/24904#event-2457573540
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24904
https://github.com/fhinkel
fhinkel https://github.com/fhinkel
https://github.com/nodejs/node/pull/24904/files/e2c4df42d11d5c58b26da884a36a9d59eae98712
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/24904/files/e2c4df42d11d5c58b26da884a36a9d59eae98712
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/24904/files/e2c4df42d11d5c58b26da884a36a9d59eae98712
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/24904/files/e2c4df42d11d5c58b26da884a36a9d59eae98712
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/24904/files/e2c4df42d11d5c58b26da884a36a9d59eae98712
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/24904/files/e2c4df42d11d5c58b26da884a36a9d59eae98712
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Please reload this pagehttps://github.com/nodejs/node/pull/24904
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/danbev
https://github.com/fhinkel
https://github.com/addaleax
https://github.com/lpinca
https://github.com/targos
https://github.com/cjihrig
https://github.com/devsnek
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.