| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6cffe937-92b1-7b7c-559b-fc0aacf2c3bd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EDAE:12343F:9139B0:C4F652:696AB657 |
| html-safe-nonce | 5b41cfb3f43b0c63b6fef8062b30ed8f3184f91dc6ad7afb577a0aa0b37f0f90 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREFFOjEyMzQzRjo5MTM5QjA6QzRGNjUyOjY5NkFCNjU3IiwidmlzaXRvcl9pZCI6IjU0NDQzOTI1NjE1NTc1NTA2NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3b1a408e3b0da673a1446f9bfa3837800c822bcc8715a1fd806e6a54266ff1d9 |
| hovercard-subject-tag | pull_request:236563796 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24875/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8abae25325703163d50484447182355bfc2773a874e876842eb7e10c7a9c5d5b/nodejs/node/pull/24875 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8abae25325703163d50484447182355bfc2773a874e876842eb7e10c7a9c5d5b/nodejs/node/pull/24875 |
| og:image:alt | ETA: Jan 29th, 2019 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 41f276818bd204c4a30a0281fb3c576298d9474c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/24875#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24875 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24875 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/24875 |
| Reload | https://github.com/nodejs/node/pull/24875 |
| Reload | https://github.com/nodejs/node/pull/24875 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/24875#issue-comment-box |
| targos | https://github.com/targos |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| targos:v8-7.2 | https://github.com/targos/node/tree/v8-7.2 |
|
deps: update V8 to 7.2
| https://github.com/nodejs/node/pull/24875#top |
| targos | https://github.com/targos |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| targos:v8-7.2 | https://github.com/targos/node/tree/v8-7.2 |
|
Conversation
48
| https://github.com/nodejs/node/pull/24875 |
|
Commits
10
| https://github.com/nodejs/node/pull/24875/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/24875/checks |
|
Files changed
| https://github.com/nodejs/node/pull/24875/files |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/targos |
| targos | https://github.com/targos |
| Dec 6, 2018 | https://github.com/nodejs/node/pull/24875#issue-388256876 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Dec 6, 2018 | https://github.com/nodejs/node/pull/24875#event-2010103096 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 6, 2018 | https://github.com/nodejs/node/pull/24875#issuecomment-444904170 |
| @targos | https://github.com/targos |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1853/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1853/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Dec 6, 2018 | https://github.com/nodejs/node/pull/24875#event-2010103506 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Dec 6, 2018 | https://github.com/nodejs/node/pull/24875#event-2010135580 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Dec 6, 2018 | https://github.com/nodejs/node/pull/24875#issuecomment-444908852 |
| https://ci.nodejs.org/job/node-test-pull-request/19272/ | https://ci.nodejs.org/job/node-test-pull-request/19272/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1920/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1920/ |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Dec 6, 2018 | https://github.com/nodejs/node/pull/24875#issuecomment-444924894 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| nodejs/node-v8#89 (comment) | https://github.com/nodejs/node-v8/issues/89#issuecomment-443533646 |
| @bzoz | https://github.com/bzoz |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Dec 6, 2018 | https://github.com/nodejs/node/pull/24875#issuecomment-444941439 |
| https://ci.nodejs.org/job/node-test-commit-linux/23806/nodes=centos7-64-gcc6/ | https://ci.nodejs.org/job/node-test-commit-linux/23806/nodes=centos7-64-gcc6/ |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Dec 6, 2018 | https://github.com/nodejs/node/pull/24875#issuecomment-444993117 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Dec 11, 2018
| https://github.com/nodejs/node/pull/24875#ref-pullrequest-389774831 |
|
win: add v8_init to dependencies
nodejs/node-v8#92
| https://github.com/nodejs/node-v8/pull/92 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
Dec 17, 2018
| https://github.com/nodejs/node/pull/24875#ref-issue-391375675 |
|
Ecosystem Modules that will break in Node 12
#25060
| https://github.com/nodejs/node/issues/25060 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Dec 17, 2018
| https://github.com/nodejs/node/pull/24875#ref-issue-391789868 |
|
object spread operator mutates first argument
#25089
| https://github.com/nodejs/node/issues/25089 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/14b5f746e84fb920ac6059fe037333fc2c90e47d..510797422b00e4ffca33a3062f716c9b4428b6c2 |
| 14b5f74 | https://github.com/nodejs/node/commit/14b5f746e84fb920ac6059fe037333fc2c90e47d |
| 5107974 | https://github.com/nodejs/node/commit/510797422b00e4ffca33a3062f716c9b4428b6c2 |
|
Compare
| https://github.com/nodejs/node/compare/14b5f746e84fb920ac6059fe037333fc2c90e47d..510797422b00e4ffca33a3062f716c9b4428b6c2 |
| January 1, 2019 15:53 | https://github.com/nodejs/node/pull/24875#event-2049502524 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jan 1, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-450739627 |
| https://ci.nodejs.org/job/node-test-pull-request/19904/ | https://ci.nodejs.org/job/node-test-pull-request/19904/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1975/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1975/ |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| targos | https://github.com/targos |
| January 20, 2019 08:45 | https://github.com/nodejs/node/pull/24875#commits-pushed-7d29926 |
|
| https://github.com/targos |
| deps: update V8 to 7.2.502.21 | https://github.com/nodejs/node/pull/24875/commits/7d2992668cc2a4b074f58292c8a3759fd3706912 |
| 7d29926 | https://github.com/nodejs/node/pull/24875/commits/7d2992668cc2a4b074f58292c8a3759fd3706912 |
|
| https://github.com/targos |
| build: reset embedder string to "-node.0" | https://github.com/nodejs/node/pull/24875/commits/bb0ffe77bfb22292f754251104c939a87c67951a |
| bb0ffe7 | https://github.com/nodejs/node/pull/24875/commits/bb0ffe77bfb22292f754251104c939a87c67951a |
|
| https://github.com/targos |
| src: update NODE_MODULE_VERSION to 69 | https://github.com/nodejs/node/pull/24875/commits/a9cd973f988686946cfa224008256ca4cb08b6ef |
| a9cd973 | https://github.com/nodejs/node/pull/24875/commits/a9cd973f988686946cfa224008256ca4cb08b6ef |
| https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md | https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md |
|
| https://github.com/targos |
|
| https://github.com/bzoz |
| deps: sync V8 gypfiles with 7.2 | https://github.com/nodejs/node/pull/24875/commits/d1486e9461d43d7fcea091ff877799a0fb2bbe4f |
| d1486e9 | https://github.com/nodejs/node/pull/24875/commits/d1486e9461d43d7fcea091ff877799a0fb2bbe4f |
| nodejs/node-v8#89 | https://github.com/nodejs/node-v8/issues/89 |
|
| https://github.com/ryzokuken |
|
| https://github.com/srl295 |
|
| https://github.com/targos |
| deps: bump minimum icu version to 63 | https://github.com/nodejs/node/pull/24875/commits/20721dcbaa5027346543da1c2fa54a06de8d63cb |
| 20721dc | https://github.com/nodejs/node/pull/24875/commits/20721dcbaa5027346543da1c2fa54a06de8d63cb |
| v8/v8@30a350f | https://github.com/v8/v8/commit/30a350f298732d6622712aa113d72fe3382c7f39 |
|
| https://github.com/psmarshall |
|
| https://github.com/targos |
| test: remove apply calls over 65534 arg limit | https://github.com/nodejs/node/pull/24875/commits/8c3a8c89b33321941d513698d64c2a855a35976d |
| 8c3a8c8 | https://github.com/nodejs/node/pull/24875/commits/8c3a8c89b33321941d513698d64c2a855a35976d |
|
| https://github.com/targos |
| test: update test-v8-stats | https://github.com/nodejs/node/pull/24875/commits/c04c8a20fa70155ab48d61864778d1f0ada7f007 |
| c04c8a2 | https://github.com/nodejs/node/pull/24875/commits/c04c8a20fa70155ab48d61864778d1f0ada7f007 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/510797422b00e4ffca33a3062f716c9b4428b6c2..c04c8a20fa70155ab48d61864778d1f0ada7f007 |
| 5107974 | https://github.com/nodejs/node/commit/510797422b00e4ffca33a3062f716c9b4428b6c2 |
| c04c8a2 | https://github.com/nodejs/node/commit/c04c8a20fa70155ab48d61864778d1f0ada7f007 |
|
Compare
| https://github.com/nodejs/node/compare/510797422b00e4ffca33a3062f716c9b4428b6c2..c04c8a20fa70155ab48d61864778d1f0ada7f007 |
| January 20, 2019 08:19 | https://github.com/nodejs/node/pull/24875#event-2084861814 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jan 20, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-455846694 |
| https://ci.nodejs.org/job/node-test-pull-request/20214/ | https://ci.nodejs.org/job/node-test-pull-request/20214/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/2035/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/2035/ |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jan 20, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-455848205 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jan 21, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-456221944 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| @john-yan | https://github.com/john-yan |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jan 22, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-456438890 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/2041/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/2041/ |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jan 22, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-456590170 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jan 22, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-456592021 |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Jan 22, 2019
| https://github.com/nodejs/node/pull/24875#ref-issue-401994211 |
|
Request for temporary access to rhel72-s390x
nodejs/build#1666
| https://github.com/nodejs/build/issues/1666 |
| https://github.com/schuay |
| schuay | https://github.com/schuay |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-457225920 |
| @schuay | https://github.com/schuay |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/john-yan |
| john-yan | https://github.com/john-yan |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-457247553 |
| @schuay | https://github.com/schuay |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/schuay |
| schuay | https://github.com/schuay |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-457252328 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
|
| https://github.com/addaleax |
| deps: cherry-pick | https://github.com/nodejs/node/pull/24875/commits/f9142b816db6789244acfd1a076397624ecb8262 |
| fc0ddf5 | https://github.com/targos/node/commit/fc0ddf5b7a6783a91f2d13983ddd350bbea60e43 |
| from upstream V8 | https://github.com/nodejs/node/pull/24875/commits/f9142b816db6789244acfd1a076397624ecb8262 |
| f9142b8 | https://github.com/nodejs/node/pull/24875/commits/f9142b816db6789244acfd1a076397624ecb8262 |
| nodejs#24875 | https://github.com/nodejs/node/pull/24875 |
| https://chromium-review.googlesource.com/c/1433778 | https://chromium-review.googlesource.com/c/1433778 |
| v8/v8@fc0ddf5 | https://github.com/v8/v8/commit/fc0ddf551216761f5a9ecb07958fe92bbc8a9bc2 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/dd571ca36ad0a7dbf0314b20242e83b4a81033d2..f9142b816db6789244acfd1a076397624ecb8262 |
| dd571ca | https://github.com/nodejs/node/commit/dd571ca36ad0a7dbf0314b20242e83b4a81033d2 |
| f9142b8 | https://github.com/nodejs/node/commit/f9142b816db6789244acfd1a076397624ecb8262 |
|
Compare
| https://github.com/nodejs/node/compare/dd571ca36ad0a7dbf0314b20242e83b4a81033d2..f9142b816db6789244acfd1a076397624ecb8262 |
| January 24, 2019 16:28 | https://github.com/nodejs/node/pull/24875#event-2094973807 |
|
| https://github.com/addaleax |
| deps: backport bits of 9302db480e8 from upstream V8 | https://github.com/nodejs/node/pull/24875/commits/85ffec2d8319e28dc11ef099bc0c2f9b5d43dfc1 |
| 85ffec2 | https://github.com/nodejs/node/pull/24875/commits/85ffec2d8319e28dc11ef099bc0c2f9b5d43dfc1 |
| v8/v8@9302db480e8cd7c88fd948baf0cf | https://github.com/v8/v8/commit/9302db480e8cd7c88fd948baf0cf |
| https://chromium-review.googlesource.com/c/1386492 | https://chromium-review.googlesource.com/c/1386492 |
| nodejs#58410 | https://github.com/nodejs/node/issues/58410 |
| v8/v8@9302db4 | https://github.com/v8/v8/commit/9302db480e8cd7c88fd948baf0cf05cb5fbb7502 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-457268461 |
| addaleax/node@85ffec2 | https://github.com/addaleax/node/commit/85ffec2d8319e28dc11ef099bc0c2f9b5d43dfc1 |
| https://ci.nodejs.org/job/node-test-commit/25276/ | https://ci.nodejs.org/job/node-test-commit/25276/ |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-457290210 |
| a linker error | https://ci.nodejs.org/job/node-compile-windows/23938/label=win-vs2017-x86/console |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/schuay |
| schuay | https://github.com/schuay |
| Jan 25, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-457495652 |
| Microsoft docs | https://docs.microsoft.com/en-nz/cpp/build/reference/safeseh-image-has-safe-exception-handlers?view=vs-2017 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/schuay |
| schuay | https://github.com/schuay |
| Jan 25, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-457500457 |
| another node issue | https://github.com/nodejs/node-v0.x-archive/issues/4242 |
| here | https://docs.microsoft.com/en-nz/cpp/assembler/masm/dot-safeseh?view=vs-2017 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/paolosev |
| paolosev | https://github.com/paolosev |
| Jan 26, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-457796604 |
| /safeseh | https://docs.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=vs-2017 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| brn | https://github.com/brn |
|
Jan 30, 2019
| https://github.com/nodejs/node/pull/24875#ref-commit-fc0ddf5 |
|
| https://github.com/addaleax |
| [snapshot] Always align embedded blob code pointer and size | https://github.com/brn/v8/commit/fc0ddf551216761f5a9ecb07958fe92bbc8a9bc2 |
| fc0ddf5 | https://github.com/brn/v8/commit/fc0ddf551216761f5a9ecb07958fe92bbc8a9bc2 |
| nodejs/node#24875 | https://github.com/nodejs/node/pull/24875 |
| https://chromium-review.googlesource.com/c/1433778 | https://chromium-review.googlesource.com/c/1433778 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jan 31, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-459355348 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 31, 2019
| https://github.com/nodejs/node/pull/24875#ref-pullrequest-405324419 |
|
deps: update V8 to 7.3
#25852
| https://github.com/nodejs/node/pull/25852 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jan 31, 2019 | https://github.com/nodejs/node/pull/24875#issuecomment-459407053 |
| #25852 | https://github.com/nodejs/node/pull/25852 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
| targos | https://github.com/targos |
|
Jan 31, 2019
| https://github.com/nodejs/node/pull/24875#ref-commit-1ccca91 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| deps: cherry-pick | https://github.com/targos/node/commit/1ccca91ee72e6828efee240399496b50a78db53d |
| fc0ddf5 | https://github.com/targos/node/commit/fc0ddf5b7a6783a91f2d13983ddd350bbea60e43 |
| from upstream V8 | https://github.com/targos/node/commit/1ccca91ee72e6828efee240399496b50a78db53d |
| 1ccca91 | https://github.com/targos/node/commit/1ccca91ee72e6828efee240399496b50a78db53d |
| nodejs#24875 | https://github.com/nodejs/node/pull/24875 |
| https://chromium-review.googlesource.com/c/1433778 | https://chromium-review.googlesource.com/c/1433778 |
| v8/v8@fc0ddf5 | https://github.com/v8/v8/commit/fc0ddf551216761f5a9ecb07958fe92bbc8a9bc2 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Feb 1, 2019 | https://github.com/nodejs/node/pull/24875#event-2111996909 |
| https://github.com/jkunkee |
| jkunkee | https://github.com/jkunkee |
|
Feb 8, 2019
| https://github.com/nodejs/node/pull/24875#ref-issue-407948197 |
|
Support ARM64 Windows desktop
#25998
| https://github.com/nodejs/node/issues/25998 |
| cjihrig | https://github.com/cjihrig |
|
Mar 12, 2019
| https://github.com/nodejs/node/pull/24875#ref-commit-412f8d0 |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
| deps: cherry-pick | https://github.com/cjihrig/node/commit/412f8d0e77cb65912bb148718ae4fb4af2352811 |
| fc0ddf5 | https://github.com/cjihrig/node/commit/fc0ddf5b7a6783a91f2d13983ddd350bbea60e43 |
| from upstream V8 | https://github.com/cjihrig/node/commit/412f8d0e77cb65912bb148718ae4fb4af2352811 |
| 412f8d0 | https://github.com/cjihrig/node/commit/412f8d0e77cb65912bb148718ae4fb4af2352811 |
| nodejs#24875 | https://github.com/nodejs/node/pull/24875 |
| https://chromium-review.googlesource.com/c/1433778 | https://chromium-review.googlesource.com/c/1433778 |
| v8/v8@fc0ddf5 | https://github.com/v8/v8/commit/fc0ddf551216761f5a9ecb07958fe92bbc8a9bc2 |
| targos | https://github.com/targos |
|
Mar 12, 2019
| https://github.com/nodejs/node/pull/24875#ref-commit-b53dbc6 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| deps: cherry-pick | https://github.com/targos/node/commit/b53dbc6c9f1784ce463fc029a015d9738903492b |
| fc0ddf5 | https://github.com/targos/node/commit/fc0ddf5b7a6783a91f2d13983ddd350bbea60e43 |
| from upstream V8 | https://github.com/targos/node/commit/b53dbc6c9f1784ce463fc029a015d9738903492b |
| b53dbc6 | https://github.com/targos/node/commit/b53dbc6c9f1784ce463fc029a015d9738903492b |
| nodejs#24875 | https://github.com/nodejs/node/pull/24875 |
| https://chromium-review.googlesource.com/c/1433778 | https://chromium-review.googlesource.com/c/1433778 |
| v8/v8@fc0ddf5 | https://github.com/v8/v8/commit/fc0ddf551216761f5a9ecb07958fe92bbc8a9bc2 |
| targos | https://github.com/targos |
|
Mar 14, 2019
| https://github.com/nodejs/node/pull/24875#ref-commit-44d5401 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| deps: cherry-pick | https://github.com/nodejs/node/commit/44d5401b8d64161fb9d057c8ec47bbc917e87247 |
| fc0ddf5 | https://github.com/nodejs/node/commit/fc0ddf5b7a6783a91f2d13983ddd350bbea60e43 |
| from upstream V8 | https://github.com/nodejs/node/commit/44d5401b8d64161fb9d057c8ec47bbc917e87247 |
| 44d5401 | https://github.com/nodejs/node/commit/44d5401b8d64161fb9d057c8ec47bbc917e87247 |
| #24875 | https://github.com/nodejs/node/pull/24875 |
| https://chromium-review.googlesource.com/c/1433778 | https://chromium-review.googlesource.com/c/1433778 |
| v8/v8@fc0ddf5 | https://github.com/v8/v8/commit/fc0ddf551216761f5a9ecb07958fe92bbc8a9bc2 |
| #25852 | https://github.com/nodejs/node/pull/25852 |
| https://github.com/targos |
| targos | https://github.com/targos |
| March 14, 2019 17:53 | https://github.com/nodejs/node/pull/24875#event-2204303062 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Mar 27, 2019
| https://github.com/nodejs/node/pull/24875#ref-issue-423864928 |
|
Node.js 12 SemVer Major Cut-off
#26844
| https://github.com/nodejs/node/issues/26844 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24875 |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/24875 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/bnoordhuis |
|
| https://github.com/mhdawson |
|
| https://github.com/sam-github |
|
| https://github.com/addaleax |
|
| https://github.com/joransiu |
|
| https://github.com/john-yan |
|
| https://github.com/schuay |
|
| https://github.com/paolosev |
|
| https://github.com/ryzokuken |
|
| https://github.com/psmarshall |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |