René's URL Explorer Experiment


Title: Align fs.ReadStream buffer pool writes to 8-byte boundary by trxcllnt · Pull Request #24838 · nodejs/node · GitHub

Open Graph Title: Align fs.ReadStream buffer pool writes to 8-byte boundary by trxcllnt · Pull Request #24838 · nodejs/node

X Title: Align fs.ReadStream buffer pool writes to 8-byte boundary by trxcllnt · Pull Request #24838 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: fs: align fs.ReadStream buffer pool writes to 8-byte boundary Prevents alignment issues when people create a typed array from a chunk buffer, similar to 285d8c6. Fixes #24817 Checklist make -j4 t...

X Description: fs: align fs.ReadStream buffer pool writes to 8-byte boundary Prevents alignment issues when people create a typed array from a chunk buffer, similar to 285d8c6. Fixes #24817 Checklist make -j4 t...

Opengraph URL: https://github.com/nodejs/node/pull/24838

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:204d86dd-71b9-614b-793f-d52495156348
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC48:8EB96:AF6D91:FEE8CD:6A4E1BD5
html-safe-nonce974f0c5417b10cb05607781d5861d671fbf19e9a8b7741f47255a456733bb9b5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzQ4OjhFQjk2OkFGNkQ5MTpGRUU4Q0Q6NkE0RTFCRDUiLCJ2aXNpdG9yX2lkIjoiNzE3NjM2NjAyODA4Njk3NTQ0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac28f4ed6b5884419249fa38359ff450d1258fa0f179ad7b558bd0295a8059f1ff
hovercard-subject-tagpull_request:235976638
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24838/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a40c38d9da4007c57ee02b690d77246a334cebafe5e1f74830113273b842418f/nodejs/node/pull/24838
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a40c38d9da4007c57ee02b690d77246a334cebafe5e1f74830113273b842418f/nodejs/node/pull/24838
og:image:altfs: align fs.ReadStream buffer pool writes to 8-byte boundary Prevents alignment issues when people create a typed array from a chunk buffer, similar to 285d8c6. Fixes #24817 Checklist make -j4 t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrxcllnt
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5fe497b4815fcce3df76c0e246faa739a82c3124
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24838#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24838
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24838
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24838
Reloadhttps://github.com/nodejs/node/pull/24838
Reloadhttps://github.com/nodejs/node/pull/24838
Please reload this pagehttps://github.com/nodejs/node/pull/24838
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24838
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
trxcllnthttps://github.com/trxcllnt
nodejs:masterhttps://github.com/nodejs/node/tree/master
trxcllnt:bugfix/24817https://github.com/trxcllnt/node/tree/bugfix/24817
Conversationhttps://github.com/nodejs/node/pull/24838
Commits1 (1)https://github.com/nodejs/node/pull/24838/commits
Checkshttps://github.com/nodejs/node/pull/24838/checks
Files changedhttps://github.com/nodejs/node/pull/24838/files
Align fs.ReadStream buffer pool writes to 8-byte boundaryhttps://github.com/nodejs/node/pull/24838#top
trxcllnthttps://github.com/trxcllnt
nodejs:masterhttps://github.com/nodejs/node/tree/master
trxcllnt:bugfix/24817https://github.com/trxcllnt/node/tree/bugfix/24817
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
Dec 4, 2018https://github.com/nodejs/node/pull/24838#issue-387501296
285d8c6https://github.com/nodejs/node/commit/285d8c658914d43cb39bacbde1ae62d8f6be25cf
#24817https://github.com/nodejs/node/issues/24817
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Dec 4, 2018https://github.com/nodejs/node/pull/24838#event-2005609281
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 4, 2018 https://github.com/nodejs/node/pull/24838#pullrequestreview-181512075
View reviewed changes https://github.com/nodejs/node/pull/24838/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/24838#pullrequestreview-181512075
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
force-pushedhttps://github.com/nodejs/node/compare/e44cc019493dcbf4e50480d2ea62b67802db6391..7aaae68f7db599a3c3649be4c7c00ec8b8d63830
e44cc01https://github.com/nodejs/node/commit/e44cc019493dcbf4e50480d2ea62b67802db6391
7aaae68https://github.com/nodejs/node/commit/7aaae68f7db599a3c3649be4c7c00ec8b8d63830
Compare https://github.com/nodejs/node/compare/e44cc019493dcbf4e50480d2ea62b67802db6391..7aaae68f7db599a3c3649be4c7c00ec8b8d63830
December 4, 2018 23:13https://github.com/nodejs/node/pull/24838#event-2005732805
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
Dec 4, 2018https://github.com/nodejs/node/pull/24838#issuecomment-444296333
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
force-pushedhttps://github.com/nodejs/node/compare/3c5ec58b6b6784350cac9e2fd9c3d2298b861a34..f530dc581dc26a5e8addacb7ea62876abf0174fd
3c5ec58https://github.com/nodejs/node/commit/3c5ec58b6b6784350cac9e2fd9c3d2298b861a34
f530dc5https://github.com/nodejs/node/commit/f530dc581dc26a5e8addacb7ea62876abf0174fd
Compare https://github.com/nodejs/node/compare/3c5ec58b6b6784350cac9e2fd9c3d2298b861a34..f530dc581dc26a5e8addacb7ea62876abf0174fd
December 5, 2018 05:30https://github.com/nodejs/node/pull/24838#event-2006181340
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 5, 2018 https://github.com/nodejs/node/pull/24838#pullrequestreview-181703445
View reviewed changes https://github.com/nodejs/node/pull/24838/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/24838/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
bnoordhuishttps://github.com/bnoordhuis
Dec 5, 2018https://github.com/nodejs/node/pull/24838#discussion_r239023815
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24838
trxcllnthttps://github.com/trxcllnt
Dec 5, 2018https://github.com/nodejs/node/pull/24838#discussion_r239222709
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24838
bnoordhuishttps://github.com/bnoordhuis
Dec 5, 2018https://github.com/nodejs/node/pull/24838#discussion_r239269488
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24838
trxcllnthttps://github.com/trxcllnt
Dec 5, 2018https://github.com/nodejs/node/pull/24838#discussion_r239276725
Please reload this pagehttps://github.com/nodejs/node/pull/24838
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
force-pushedhttps://github.com/nodejs/node/compare/e13a20c9af89c78fe3c4e5dc0673c6e8cd41b539..0d29ef375f958d62439874f91a4e331127966f80
e13a20chttps://github.com/nodejs/node/commit/e13a20c9af89c78fe3c4e5dc0673c6e8cd41b539
0d29ef3https://github.com/nodejs/node/commit/0d29ef375f958d62439874f91a4e331127966f80
Compare https://github.com/nodejs/node/compare/e13a20c9af89c78fe3c4e5dc0673c6e8cd41b539..0d29ef375f958d62439874f91a4e331127966f80
December 5, 2018 23:40https://github.com/nodejs/node/pull/24838#event-2008570663
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 6, 2018 https://github.com/nodejs/node/pull/24838#pullrequestreview-182403324
View reviewed changes https://github.com/nodejs/node/pull/24838/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/24838#pullrequestreview-182403324
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://ci.nodejs.org/job/node-test-pull-request/19282/https://ci.nodejs.org/job/node-test-pull-request/19282/
Please reload this pagehttps://github.com/nodejs/node/pull/24838
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/24838/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
bnoordhuishttps://github.com/bnoordhuis
Dec 6, 2018https://github.com/nodejs/node/pull/24838#discussion_r239579138
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24838
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/24838/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
bnoordhuishttps://github.com/bnoordhuis
Dec 6, 2018https://github.com/nodejs/node/pull/24838#discussion_r239579881
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
force-pushedhttps://github.com/nodejs/node/compare/899e641523022395f0d301ecb6e7e5179e414838..73d1ca22ffa511d0caf8f0059f472a19d7e027ed
899e641https://github.com/nodejs/node/commit/899e641523022395f0d301ecb6e7e5179e414838
73d1ca2https://github.com/nodejs/node/commit/73d1ca22ffa511d0caf8f0059f472a19d7e027ed
Compare https://github.com/nodejs/node/compare/899e641523022395f0d301ecb6e7e5179e414838..73d1ca22ffa511d0caf8f0059f472a19d7e027ed
December 6, 2018 23:34https://github.com/nodejs/node/pull/24838#event-2011231476
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 8, 2018 https://github.com/nodejs/node/pull/24838#pullrequestreview-182959444
View reviewed changes https://github.com/nodejs/node/pull/24838/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/24838#pullrequestreview-182959444
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://ci.nodejs.org/job/node-test-pull-request/19338/https://ci.nodejs.org/job/node-test-pull-request/19338/
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
Dec 14, 2018https://github.com/nodejs/node/pull/24838#issuecomment-447472964
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 8, 2019https://github.com/nodejs/node/pull/24838#issuecomment-452262014
https://ci.nodejs.org/job/node-test-pull-request/19989/https://ci.nodejs.org/job/node-test-pull-request/19989/
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 8, 2019 https://github.com/nodejs/node/pull/24838#pullrequestreview-190386544
View reviewed changes https://github.com/nodejs/node/pull/24838/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019https://github.com/nodejs/node/pull/24838#issuecomment-456208894
@trxcllnthttps://github.com/trxcllnt
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
Jan 21, 2019https://github.com/nodejs/node/pull/24838#issuecomment-456213513
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019https://github.com/nodejs/node/pull/24838#issuecomment-456213959
@trxcllnthttps://github.com/trxcllnt
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
force-pushedhttps://github.com/nodejs/node/compare/01b5fd8288c21d2961c0afab18fa305af498c644..82ec8d3aff4c97f1e55b95617b60d2cd5da61444
01b5fd8https://github.com/nodejs/node/commit/01b5fd8288c21d2961c0afab18fa305af498c644
82ec8d3https://github.com/nodejs/node/commit/82ec8d3aff4c97f1e55b95617b60d2cd5da61444
Compare https://github.com/nodejs/node/compare/01b5fd8288c21d2961c0afab18fa305af498c644..82ec8d3aff4c97f1e55b95617b60d2cd5da61444
January 21, 2019 23:47https://github.com/nodejs/node/pull/24838#event-2087509129
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
Jan 21, 2019https://github.com/nodejs/node/pull/24838#issuecomment-456226760
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
Mar 31, 2019https://github.com/nodejs/node/pull/24838#issuecomment-478307308
Please reload this pagehttps://github.com/nodejs/node/pull/24838
@bnoordhuishttps://github.com/bnoordhuis
@addaleaxhttps://github.com/addaleax
workaroundhttps://github.com/apache/arrow/blob/114985c3ca8570a683dbc61062ed781daa3ddc8e/js/src/ipc/message.ts#L120-L130
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 31, 2019https://github.com/nodejs/node/pull/24838#issuecomment-478325275
@trxcllnthttps://github.com/trxcllnt
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
force-pushedhttps://github.com/nodejs/node/compare/d6d9c3f008902d19de066030608d0903b7891449..bdc2ba47fcef89468853edc6d0392203bc3f975b
d6d9c3fhttps://github.com/nodejs/node/commit/d6d9c3f008902d19de066030608d0903b7891449
bdc2ba4https://github.com/nodejs/node/commit/bdc2ba47fcef89468853edc6d0392203bc3f975b
Compare https://github.com/nodejs/node/compare/d6d9c3f008902d19de066030608d0903b7891449..bdc2ba47fcef89468853edc6d0392203bc3f975b
April 1, 2019 00:26https://github.com/nodejs/node/pull/24838#event-2241881146
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
Apr 1, 2019https://github.com/nodejs/node/pull/24838#issuecomment-478400250
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 1, 2019https://github.com/nodejs/node/pull/24838#issuecomment-478461841
https://ci.nodejs.org/job/node-test-pull-request/22092/https://ci.nodejs.org/job/node-test-pull-request/22092/
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/trxcllnt
fs: align fs.ReadStream buffer pool writes to 8-byte boundaryhttps://github.com/nodejs/node/pull/24838/commits/f2e1ed3689b24fdb136efc8501f81317834534a2
f2e1ed3https://github.com/nodejs/node/pull/24838/commits/f2e1ed3689b24fdb136efc8501f81317834534a2
nodejs#24817https://github.com/nodejs/node/issues/24817
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
force-pushedhttps://github.com/nodejs/node/compare/bdc2ba47fcef89468853edc6d0392203bc3f975b..f2e1ed3689b24fdb136efc8501f81317834534a2
bdc2ba4https://github.com/nodejs/node/commit/bdc2ba47fcef89468853edc6d0392203bc3f975b
f2e1ed3https://github.com/nodejs/node/commit/f2e1ed3689b24fdb136efc8501f81317834534a2
Compare https://github.com/nodejs/node/compare/bdc2ba47fcef89468853edc6d0392203bc3f975b..f2e1ed3689b24fdb136efc8501f81317834534a2
April 14, 2019 00:24https://github.com/nodejs/node/pull/24838#event-2274478953
https://github.com/trxcllnt
trxcllnthttps://github.com/trxcllnt
May 1, 2019https://github.com/nodejs/node/pull/24838#issuecomment-488165510
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 1, 2019 https://github.com/nodejs/node/pull/24838#pullrequestreview-232777283
View reviewed changes https://github.com/nodejs/node/pull/24838/files/f2e1ed3689b24fdb136efc8501f81317834534a2
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 1, 2019https://github.com/nodejs/node/pull/24838#issuecomment-488448593
https://ci.nodejs.org/job/node-test-pull-request/22866/https://ci.nodejs.org/job/node-test-pull-request/22866/
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 2, 2019https://github.com/nodejs/node/pull/24838#issuecomment-488509893
b884cebhttps://github.com/nodejs/node/commit/b884ceb518d5a63c1d5a85ca9b7e87b04e02ab4b
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 2, 2019https://github.com/nodejs/node/pull/24838#event-2313267293
addaleaxhttps://github.com/addaleax
May 2, 2019 https://github.com/nodejs/node/pull/24838#ref-commit-b884ceb
https://github.com/trxcllnt
https://github.com/addaleax
fs: align fs.ReadStream buffer pool writes to 8-byte boundaryhttps://github.com/nodejs/node/commit/b884ceb518d5a63c1d5a85ca9b7e87b04e02ab4b
b884cebhttps://github.com/nodejs/node/commit/b884ceb518d5a63c1d5a85ca9b7e87b04e02ab4b
#24817https://github.com/nodejs/node/issues/24817
#24838https://github.com/nodejs/node/pull/24838
targoshttps://github.com/targos
May 4, 2019 https://github.com/nodejs/node/pull/24838#ref-commit-a0353fd
https://github.com/trxcllnt
https://github.com/targos
fs: align fs.ReadStream buffer pool writes to 8-byte boundaryhttps://github.com/nodejs/node/commit/a0353fdbe2ce725e06dab0acbd0326d1c163667c
a0353fdhttps://github.com/nodejs/node/commit/a0353fdbe2ce725e06dab0acbd0326d1c163667c
#24817https://github.com/nodejs/node/issues/24817
#24838https://github.com/nodejs/node/pull/24838
https://github.com/targos
targoshttps://github.com/targos
May 6, 2019 https://github.com/nodejs/node/pull/24838#ref-pullrequest-440681623
v12.2.0 proposal #27578 https://github.com/nodejs/node/pull/27578
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#281 https://github.com/beevelop/docker-nodejs/issues/281
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#309 https://github.com/beevelop/docker-android-nodejs/issues/309
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#282 https://github.com/beevelop/docker-nodejs/issues/282
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#310 https://github.com/beevelop/docker-android-nodejs/issues/310
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#283 https://github.com/beevelop/docker-nodejs/issues/283
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#311 https://github.com/beevelop/docker-android-nodejs/issues/311
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#284 https://github.com/beevelop/docker-nodejs/issues/284
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#312 https://github.com/beevelop/docker-android-nodejs/issues/312
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-nodejs#285 https://github.com/beevelop/docker-nodejs/issues/285
2019-05-07 Version 12.2.0 (Current) @targos beevelop/docker-android-nodejs#313 https://github.com/beevelop/docker-android-nodejs/issues/313
https://github.com/Zclhlmgqzc
Zclhlmgqzchttps://github.com/Zclhlmgqzc
Oct 2, 2020 https://github.com/nodejs/node/pull/24838#ref-issue-713718656
[Bug report] fs.createReadStream set highWaterMark, the same file get different result #35465 https://github.com/nodejs/node/issues/35465
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24838
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/24838/files/73d1ca22ffa511d0caf8f0059f472a19d7e027ed
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/24838/files/73d1ca22ffa511d0caf8f0059f472a19d7e027ed
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/24838/files/f2e1ed3689b24fdb136efc8501f81317834534a2
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Unaligned writes to fs.ReadStream internal Buffer pool leads to misaligned reads https://github.com/nodejs/node/issues/24817
Please reload this pagehttps://github.com/nodejs/node/pull/24838
https://github.com/trxcllnt
https://github.com/bnoordhuis
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.