| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:204d86dd-71b9-614b-793f-d52495156348 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC48:8EB96:AF6D91:FEE8CD:6A4E1BD5 |
| html-safe-nonce | 974f0c5417b10cb05607781d5861d671fbf19e9a8b7741f47255a456733bb9b5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzQ4OjhFQjk2OkFGNkQ5MTpGRUU4Q0Q6NkE0RTFCRDUiLCJ2aXNpdG9yX2lkIjoiNzE3NjM2NjAyODA4Njk3NTQ0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 28f4ed6b5884419249fa38359ff450d1258fa0f179ad7b558bd0295a8059f1ff |
| hovercard-subject-tag | pull_request:235976638 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24838/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a40c38d9da4007c57ee02b690d77246a334cebafe5e1f74830113273b842418f/nodejs/node/pull/24838 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a40c38d9da4007c57ee02b690d77246a334cebafe5e1f74830113273b842418f/nodejs/node/pull/24838 |
| og:image:alt | fs: align fs.ReadStream buffer pool writes to 8-byte boundary
Prevents alignment issues when people create a typed array from a chunk buffer, similar to 285d8c6.
Fixes #24817
Checklist
make -j4 t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | trxcllnt |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5fe497b4815fcce3df76c0e246faa739a82c3124 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/24838#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24838 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24838 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/24838 |
| Reload | https://github.com/nodejs/node/pull/24838 |
| Reload | https://github.com/nodejs/node/pull/24838 |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| trxcllnt | https://github.com/trxcllnt |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| trxcllnt:bugfix/24817 | https://github.com/trxcllnt/node/tree/bugfix/24817 |
| Conversation | https://github.com/nodejs/node/pull/24838 |
| Commits1 (1) | https://github.com/nodejs/node/pull/24838/commits |
| Checks | https://github.com/nodejs/node/pull/24838/checks |
| Files changed | https://github.com/nodejs/node/pull/24838/files |
| Align fs.ReadStream buffer pool writes to 8-byte boundary | https://github.com/nodejs/node/pull/24838#top |
| trxcllnt | https://github.com/trxcllnt |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| trxcllnt:bugfix/24817 | https://github.com/trxcllnt/node/tree/bugfix/24817 |
|
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| Dec 4, 2018 | https://github.com/nodejs/node/pull/24838#issue-387501296 |
| 285d8c6 | https://github.com/nodejs/node/commit/285d8c658914d43cb39bacbde1ae62d8f6be25cf |
| #24817 | https://github.com/nodejs/node/issues/24817 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Dec 4, 2018 | https://github.com/nodejs/node/pull/24838#event-2005609281 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Dec 4, 2018
| https://github.com/nodejs/node/pull/24838#pullrequestreview-181512075 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24838/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/24838#pullrequestreview-181512075 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| force-pushed | https://github.com/nodejs/node/compare/e44cc019493dcbf4e50480d2ea62b67802db6391..7aaae68f7db599a3c3649be4c7c00ec8b8d63830 |
| e44cc01 | https://github.com/nodejs/node/commit/e44cc019493dcbf4e50480d2ea62b67802db6391 |
| 7aaae68 | https://github.com/nodejs/node/commit/7aaae68f7db599a3c3649be4c7c00ec8b8d63830 |
|
Compare
| https://github.com/nodejs/node/compare/e44cc019493dcbf4e50480d2ea62b67802db6391..7aaae68f7db599a3c3649be4c7c00ec8b8d63830 |
| December 4, 2018 23:13 | https://github.com/nodejs/node/pull/24838#event-2005732805 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| Dec 4, 2018 | https://github.com/nodejs/node/pull/24838#issuecomment-444296333 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| force-pushed | https://github.com/nodejs/node/compare/3c5ec58b6b6784350cac9e2fd9c3d2298b861a34..f530dc581dc26a5e8addacb7ea62876abf0174fd |
| 3c5ec58 | https://github.com/nodejs/node/commit/3c5ec58b6b6784350cac9e2fd9c3d2298b861a34 |
| f530dc5 | https://github.com/nodejs/node/commit/f530dc581dc26a5e8addacb7ea62876abf0174fd |
|
Compare
| https://github.com/nodejs/node/compare/3c5ec58b6b6784350cac9e2fd9c3d2298b861a34..f530dc581dc26a5e8addacb7ea62876abf0174fd |
| December 5, 2018 05:30 | https://github.com/nodejs/node/pull/24838#event-2006181340 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Dec 5, 2018
| https://github.com/nodejs/node/pull/24838#pullrequestreview-181703445 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24838/files |
| lib/internal/fs/streams.js | https://github.com/nodejs/node/pull/24838/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b |
| bnoordhuis | https://github.com/bnoordhuis |
| Dec 5, 2018 | https://github.com/nodejs/node/pull/24838#discussion_r239023815 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| trxcllnt | https://github.com/trxcllnt |
| Dec 5, 2018 | https://github.com/nodejs/node/pull/24838#discussion_r239222709 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| bnoordhuis | https://github.com/bnoordhuis |
| Dec 5, 2018 | https://github.com/nodejs/node/pull/24838#discussion_r239269488 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| trxcllnt | https://github.com/trxcllnt |
| Dec 5, 2018 | https://github.com/nodejs/node/pull/24838#discussion_r239276725 |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| force-pushed | https://github.com/nodejs/node/compare/e13a20c9af89c78fe3c4e5dc0673c6e8cd41b539..0d29ef375f958d62439874f91a4e331127966f80 |
| e13a20c | https://github.com/nodejs/node/commit/e13a20c9af89c78fe3c4e5dc0673c6e8cd41b539 |
| 0d29ef3 | https://github.com/nodejs/node/commit/0d29ef375f958d62439874f91a4e331127966f80 |
|
Compare
| https://github.com/nodejs/node/compare/e13a20c9af89c78fe3c4e5dc0673c6e8cd41b539..0d29ef375f958d62439874f91a4e331127966f80 |
| December 5, 2018 23:40 | https://github.com/nodejs/node/pull/24838#event-2008570663 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Dec 6, 2018
| https://github.com/nodejs/node/pull/24838#pullrequestreview-182403324 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24838/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/24838#pullrequestreview-182403324 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://ci.nodejs.org/job/node-test-pull-request/19282/ | https://ci.nodejs.org/job/node-test-pull-request/19282/ |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| lib/internal/fs/streams.js | https://github.com/nodejs/node/pull/24838/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b |
| bnoordhuis | https://github.com/bnoordhuis |
| Dec 6, 2018 | https://github.com/nodejs/node/pull/24838#discussion_r239579138 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| lib/internal/fs/streams.js | https://github.com/nodejs/node/pull/24838/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b |
| bnoordhuis | https://github.com/bnoordhuis |
| Dec 6, 2018 | https://github.com/nodejs/node/pull/24838#discussion_r239579881 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| force-pushed | https://github.com/nodejs/node/compare/899e641523022395f0d301ecb6e7e5179e414838..73d1ca22ffa511d0caf8f0059f472a19d7e027ed |
| 899e641 | https://github.com/nodejs/node/commit/899e641523022395f0d301ecb6e7e5179e414838 |
| 73d1ca2 | https://github.com/nodejs/node/commit/73d1ca22ffa511d0caf8f0059f472a19d7e027ed |
|
Compare
| https://github.com/nodejs/node/compare/899e641523022395f0d301ecb6e7e5179e414838..73d1ca22ffa511d0caf8f0059f472a19d7e027ed |
| December 6, 2018 23:34 | https://github.com/nodejs/node/pull/24838#event-2011231476 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Dec 8, 2018
| https://github.com/nodejs/node/pull/24838#pullrequestreview-182959444 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24838/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/24838#pullrequestreview-182959444 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://ci.nodejs.org/job/node-test-pull-request/19338/ | https://ci.nodejs.org/job/node-test-pull-request/19338/ |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/24838#issuecomment-447472964 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Jan 8, 2019 | https://github.com/nodejs/node/pull/24838#issuecomment-452262014 |
| https://ci.nodejs.org/job/node-test-pull-request/19989/ | https://ci.nodejs.org/job/node-test-pull-request/19989/ |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 8, 2019
| https://github.com/nodejs/node/pull/24838#pullrequestreview-190386544 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24838/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 21, 2019 | https://github.com/nodejs/node/pull/24838#issuecomment-456208894 |
| @trxcllnt | https://github.com/trxcllnt |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| Jan 21, 2019 | https://github.com/nodejs/node/pull/24838#issuecomment-456213513 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 21, 2019 | https://github.com/nodejs/node/pull/24838#issuecomment-456213959 |
| @trxcllnt | https://github.com/trxcllnt |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| force-pushed | https://github.com/nodejs/node/compare/01b5fd8288c21d2961c0afab18fa305af498c644..82ec8d3aff4c97f1e55b95617b60d2cd5da61444 |
| 01b5fd8 | https://github.com/nodejs/node/commit/01b5fd8288c21d2961c0afab18fa305af498c644 |
| 82ec8d3 | https://github.com/nodejs/node/commit/82ec8d3aff4c97f1e55b95617b60d2cd5da61444 |
|
Compare
| https://github.com/nodejs/node/compare/01b5fd8288c21d2961c0afab18fa305af498c644..82ec8d3aff4c97f1e55b95617b60d2cd5da61444 |
| January 21, 2019 23:47 | https://github.com/nodejs/node/pull/24838#event-2087509129 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| Jan 21, 2019 | https://github.com/nodejs/node/pull/24838#issuecomment-456226760 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| Mar 31, 2019 | https://github.com/nodejs/node/pull/24838#issuecomment-478307308 |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| @bnoordhuis | https://github.com/bnoordhuis |
| @addaleax | https://github.com/addaleax |
| workaround | https://github.com/apache/arrow/blob/114985c3ca8570a683dbc61062ed781daa3ddc8e/js/src/ipc/message.ts#L120-L130 |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Mar 31, 2019 | https://github.com/nodejs/node/pull/24838#issuecomment-478325275 |
| @trxcllnt | https://github.com/trxcllnt |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| force-pushed | https://github.com/nodejs/node/compare/d6d9c3f008902d19de066030608d0903b7891449..bdc2ba47fcef89468853edc6d0392203bc3f975b |
| d6d9c3f | https://github.com/nodejs/node/commit/d6d9c3f008902d19de066030608d0903b7891449 |
| bdc2ba4 | https://github.com/nodejs/node/commit/bdc2ba47fcef89468853edc6d0392203bc3f975b |
|
Compare
| https://github.com/nodejs/node/compare/d6d9c3f008902d19de066030608d0903b7891449..bdc2ba47fcef89468853edc6d0392203bc3f975b |
| April 1, 2019 00:26 | https://github.com/nodejs/node/pull/24838#event-2241881146 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| Apr 1, 2019 | https://github.com/nodejs/node/pull/24838#issuecomment-478400250 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 1, 2019 | https://github.com/nodejs/node/pull/24838#issuecomment-478461841 |
| https://ci.nodejs.org/job/node-test-pull-request/22092/ | https://ci.nodejs.org/job/node-test-pull-request/22092/ |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
|
| https://github.com/trxcllnt |
| fs: align fs.ReadStream buffer pool writes to 8-byte boundary | https://github.com/nodejs/node/pull/24838/commits/f2e1ed3689b24fdb136efc8501f81317834534a2 |
| f2e1ed3 | https://github.com/nodejs/node/pull/24838/commits/f2e1ed3689b24fdb136efc8501f81317834534a2 |
| nodejs#24817 | https://github.com/nodejs/node/issues/24817 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| force-pushed | https://github.com/nodejs/node/compare/bdc2ba47fcef89468853edc6d0392203bc3f975b..f2e1ed3689b24fdb136efc8501f81317834534a2 |
| bdc2ba4 | https://github.com/nodejs/node/commit/bdc2ba47fcef89468853edc6d0392203bc3f975b |
| f2e1ed3 | https://github.com/nodejs/node/commit/f2e1ed3689b24fdb136efc8501f81317834534a2 |
|
Compare
| https://github.com/nodejs/node/compare/bdc2ba47fcef89468853edc6d0392203bc3f975b..f2e1ed3689b24fdb136efc8501f81317834534a2 |
| April 14, 2019 00:24 | https://github.com/nodejs/node/pull/24838#event-2274478953 |
| https://github.com/trxcllnt |
| trxcllnt | https://github.com/trxcllnt |
| May 1, 2019 | https://github.com/nodejs/node/pull/24838#issuecomment-488165510 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 1, 2019
| https://github.com/nodejs/node/pull/24838#pullrequestreview-232777283 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24838/files/f2e1ed3689b24fdb136efc8501f81317834534a2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 1, 2019 | https://github.com/nodejs/node/pull/24838#issuecomment-488448593 |
| https://ci.nodejs.org/job/node-test-pull-request/22866/ | https://ci.nodejs.org/job/node-test-pull-request/22866/ |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 2, 2019 | https://github.com/nodejs/node/pull/24838#issuecomment-488509893 |
| b884ceb | https://github.com/nodejs/node/commit/b884ceb518d5a63c1d5a85ca9b7e87b04e02ab4b |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 2, 2019 | https://github.com/nodejs/node/pull/24838#event-2313267293 |
| addaleax | https://github.com/addaleax |
|
May 2, 2019
| https://github.com/nodejs/node/pull/24838#ref-commit-b884ceb |
|
| https://github.com/trxcllnt |
|
| https://github.com/addaleax |
| fs: align fs.ReadStream buffer pool writes to 8-byte boundary | https://github.com/nodejs/node/commit/b884ceb518d5a63c1d5a85ca9b7e87b04e02ab4b |
| b884ceb | https://github.com/nodejs/node/commit/b884ceb518d5a63c1d5a85ca9b7e87b04e02ab4b |
| #24817 | https://github.com/nodejs/node/issues/24817 |
| #24838 | https://github.com/nodejs/node/pull/24838 |
| targos | https://github.com/targos |
|
May 4, 2019
| https://github.com/nodejs/node/pull/24838#ref-commit-a0353fd |
|
| https://github.com/trxcllnt |
|
| https://github.com/targos |
| fs: align fs.ReadStream buffer pool writes to 8-byte boundary | https://github.com/nodejs/node/commit/a0353fdbe2ce725e06dab0acbd0326d1c163667c |
| a0353fd | https://github.com/nodejs/node/commit/a0353fdbe2ce725e06dab0acbd0326d1c163667c |
| #24817 | https://github.com/nodejs/node/issues/24817 |
| #24838 | https://github.com/nodejs/node/pull/24838 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 6, 2019
| https://github.com/nodejs/node/pull/24838#ref-pullrequest-440681623 |
|
v12.2.0 proposal
#27578
| https://github.com/nodejs/node/pull/27578 |
|
2019-05-07 Version 12.2.0 (Current) @targos
beevelop/docker-nodejs#281
| https://github.com/beevelop/docker-nodejs/issues/281 |
|
2019-05-07 Version 12.2.0 (Current) @targos
beevelop/docker-android-nodejs#309
| https://github.com/beevelop/docker-android-nodejs/issues/309 |
|
2019-05-07 Version 12.2.0 (Current) @targos
beevelop/docker-nodejs#282
| https://github.com/beevelop/docker-nodejs/issues/282 |
|
2019-05-07 Version 12.2.0 (Current) @targos
beevelop/docker-android-nodejs#310
| https://github.com/beevelop/docker-android-nodejs/issues/310 |
|
2019-05-07 Version 12.2.0 (Current) @targos
beevelop/docker-nodejs#283
| https://github.com/beevelop/docker-nodejs/issues/283 |
|
2019-05-07 Version 12.2.0 (Current) @targos
beevelop/docker-android-nodejs#311
| https://github.com/beevelop/docker-android-nodejs/issues/311 |
|
2019-05-07 Version 12.2.0 (Current) @targos
beevelop/docker-nodejs#284
| https://github.com/beevelop/docker-nodejs/issues/284 |
|
2019-05-07 Version 12.2.0 (Current) @targos
beevelop/docker-android-nodejs#312
| https://github.com/beevelop/docker-android-nodejs/issues/312 |
|
2019-05-07 Version 12.2.0 (Current) @targos
beevelop/docker-nodejs#285
| https://github.com/beevelop/docker-nodejs/issues/285 |
|
2019-05-07 Version 12.2.0 (Current) @targos
beevelop/docker-android-nodejs#313
| https://github.com/beevelop/docker-android-nodejs/issues/313 |
| https://github.com/Zclhlmgqzc |
| Zclhlmgqzc | https://github.com/Zclhlmgqzc |
|
Oct 2, 2020
| https://github.com/nodejs/node/pull/24838#ref-issue-713718656 |
|
[Bug report] fs.createReadStream set highWaterMark, the same file get different result
#35465
| https://github.com/nodejs/node/issues/35465 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24838 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/24838/files/73d1ca22ffa511d0caf8f0059f472a19d7e027ed |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/24838/files/73d1ca22ffa511d0caf8f0059f472a19d7e027ed |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/24838/files/f2e1ed3689b24fdb136efc8501f81317834534a2 |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
Unaligned writes to fs.ReadStream internal Buffer pool leads to misaligned reads
| https://github.com/nodejs/node/issues/24817 |
| Please reload this page | https://github.com/nodejs/node/pull/24838 |
|
| https://github.com/trxcllnt |
|
| https://github.com/bnoordhuis |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |