René's URL Explorer Experiment


Title: [8.x] assert: revert breaking change by BridgeAR · Pull Request #24786 · nodejs/node · GitHub

Open Graph Title: [8.x] assert: revert breaking change by BridgeAR · Pull Request #24786 · nodejs/node

X Title: [8.x] assert: revert breaking change by BridgeAR · Pull Request #24786 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: It was not intended to change the assert.doesNotThrow() message with #23223. This reverts the breaking behavior to the one before. Refs: #23223 (comment) I guess it won't hurt much if we keep t...

X Description: It was not intended to change the assert.doesNotThrow() message with #23223. This reverts the breaking behavior to the one before. Refs: #23223 (comment) I guess it won't hurt much if we ke...

Opengraph URL: https://github.com/nodejs/node/pull/24786

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5c9119a3-07a5-c287-d2f3-68f41ac8d129
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEAF2:D24C7:2A6AB65:3654C2C:699030A1
html-safe-nonce2143ae025869436bdebd867aa6a950797a12ab435489746f4a36c6a5dc195957
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUYyOkQyNEM3OjJBNkFCNjU6MzY1NEMyQzo2OTkwMzBBMSIsInZpc2l0b3JfaWQiOiI5NTIxNDg3NTkwMDA2NTgwODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdf932d7c3fe3f59f7b36957dee37f99e3a8d312feb3c82d1844891f72fce503e
hovercard-subject-tagpull_request:235258303
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24786/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c7de142c5a31cba2169da744412a5bcf43a25857a88df4f3eba55bcb10c4df36/nodejs/node/pull/24786
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c7de142c5a31cba2169da744412a5bcf43a25857a88df4f3eba55bcb10c4df36/nodejs/node/pull/24786
og:image:altIt was not intended to change the assert.doesNotThrow() message with #23223. This reverts the breaking behavior to the one before. Refs: #23223 (comment) I guess it won't hurt much if we keep t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24786#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24786
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24786
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24786
Reloadhttps://github.com/nodejs/node/pull/24786
Reloadhttps://github.com/nodejs/node/pull/24786
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24786
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:v8.x-staginghttps://github.com/nodejs/node/tree/v8.x-staging
BridgeAR:revert-major-changehttps://github.com/BridgeAR/node/tree/revert-major-change
Conversationhttps://github.com/nodejs/node/pull/24786
Commits2 (2)https://github.com/nodejs/node/pull/24786/commits
Checkshttps://github.com/nodejs/node/pull/24786/checks
Files changedhttps://github.com/nodejs/node/pull/24786/files
[8.x] assert: revert breaking changehttps://github.com/nodejs/node/pull/24786#top
BridgeARhttps://github.com/BridgeAR
nodejs:v8.x-staginghttps://github.com/nodejs/node/tree/v8.x-staging
BridgeAR:revert-major-changehttps://github.com/BridgeAR/node/tree/revert-major-change
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 2, 2018https://github.com/nodejs/node/pull/24786#issue-386558797
#23223https://github.com/nodejs/node/pull/23223
#23223 (comment)https://github.com/nodejs/node/pull/23223#issuecomment-443493425
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24786
https://github.com/BridgeAR
assert: revert breaking changehttps://github.com/nodejs/node/pull/24786/commits/bd7004fed4e29bf5b14662aca6acc2f250cb7238
bd7004fhttps://github.com/nodejs/node/pull/24786/commits/bd7004fed4e29bf5b14662aca6acc2f250cb7238
nodejs#23223https://github.com/nodejs/node/pull/23223
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 2, 2018https://github.com/nodejs/node/pull/24786#issuecomment-443506829
@BridgeARhttps://github.com/BridgeAR
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1795/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1795/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24786
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x
Dec 2, 2018https://github.com/nodejs/node/pull/24786#event-1999950593
https://github.com/BridgeAR
fixuphttps://github.com/nodejs/node/pull/24786/commits/3e6e2000a7dc14c299d11d5df201d39887fd39bf
3e6e200https://github.com/nodejs/node/pull/24786/commits/3e6e2000a7dc14c299d11d5df201d39887fd39bf
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 2, 2018https://github.com/nodejs/node/pull/24786#issuecomment-443511580
Please reload this pagehttps://github.com/nodejs/node/pull/24786
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 3, 2018https://github.com/nodejs/node/pull/24786#issuecomment-443782530
Please reload this pagehttps://github.com/nodejs/node/pull/24786
https://github.com/rvagg
rvagghttps://github.com/rvagg
Dec 3, 2018https://github.com/nodejs/node/pull/24786#issuecomment-443888446
Please reload this pagehttps://github.com/nodejs/node/pull/24786
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 3, 2018https://github.com/nodejs/node/pull/24786#issuecomment-443895287
Please reload this pagehttps://github.com/nodejs/node/pull/24786
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Dec 4, 2018https://github.com/nodejs/node/pull/24786#issuecomment-444158425
https://github.com/nodejs/node/pull/24786/fileshttps://github.com/nodejs/node/pull/24786/files
Please reload this pagehttps://github.com/nodejs/node/pull/24786
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 4, 2018https://github.com/nodejs/node/pull/24786#issuecomment-444160283
Please reload this pagehttps://github.com/nodejs/node/pull/24786
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 5, 2018https://github.com/nodejs/node/pull/24786#issuecomment-444495312
@BethGriggshttps://github.com/BethGriggs
Please reload this pagehttps://github.com/nodejs/node/pull/24786
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 5, 2018 https://github.com/nodejs/node/pull/24786#pullrequestreview-181796759
View reviewed changes https://github.com/nodejs/node/pull/24786/files/3e6e2000a7dc14c299d11d5df201d39887fd39bf
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 5, 2018 https://github.com/nodejs/node/pull/24786#ref-pullrequest-387422551
v8.14.1 proposal #24832 https://github.com/nodejs/node/pull/24832
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 6, 2018https://github.com/nodejs/node/pull/24786#issuecomment-444749258
@BridgeARhttps://github.com/BridgeAR
@rvagghttps://github.com/rvagg
https://ci.nodejs.org/job/node-test-pull-request/192561https://ci.nodejs.org/job/node-test-pull-request/192561
Please reload this pagehttps://github.com/nodejs/node/pull/24786
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 6, 2018https://github.com/nodejs/node/pull/24786#issuecomment-444976212
Please reload this pagehttps://github.com/nodejs/node/pull/24786
BethGriggshttps://github.com/BethGriggs
Dec 11, 2018 https://github.com/nodejs/node/pull/24786#ref-commit-62fb5db
https://github.com/BridgeAR
https://github.com/BethGriggs
assert: revert breaking changehttps://github.com/nodejs/node/commit/62fb5dbec557745f9f828d728ca25f327ca5300c
62fb5dbhttps://github.com/nodejs/node/commit/62fb5dbec557745f9f828d728ca25f327ca5300c
#23223https://github.com/nodejs/node/pull/23223
#24786https://github.com/nodejs/node/pull/24786
#23223https://github.com/nodejs/node/pull/23223
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 11, 2018https://github.com/nodejs/node/pull/24786#issuecomment-446248361
62fb5dbhttps://github.com/nodejs/node/commit/62fb5dbec557745f9f828d728ca25f327ca5300c
Please reload this pagehttps://github.com/nodejs/node/pull/24786
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 11, 2018https://github.com/nodejs/node/pull/24786#event-2019055901
BethGriggshttps://github.com/BethGriggs
Dec 11, 2018 https://github.com/nodejs/node/pull/24786#ref-commit-9fc8d9a
https://github.com/BethGriggs
2018-12-18, Version 8.14.1 'Carbon' (LTS)https://github.com/nodejs/node/commit/9fc8d9ac5dd6d1514a44740e896bb50e803a8c55
9fc8d9ahttps://github.com/nodejs/node/commit/9fc8d9ac5dd6d1514a44740e896bb50e803a8c55
#24786https://github.com/nodejs/node/pull/24786
#24786https://github.com/nodejs/node/pull/24786
#24789https://github.com/nodejs/node/pull/24789
#24789https://github.com/nodejs/node/pull/24789
#24832https://github.com/nodejs/node/pull/24832
MylesBorinshttps://github.com/MylesBorins
Dec 18, 2018 https://github.com/nodejs/node/pull/24786#ref-commit-187694e
https://github.com/BethGriggs
https://github.com/MylesBorins
2018-12-18, Version 8.14.1 'Carbon' (LTS)https://github.com/nodejs/node/commit/187694e2fa59d71577f9ee99c6d1a3d04c80c37d
187694ehttps://github.com/nodejs/node/commit/187694e2fa59d71577f9ee99c6d1a3d04c80c37d
#24786https://github.com/nodejs/node/pull/24786
#24786https://github.com/nodejs/node/pull/24786
#24789https://github.com/nodejs/node/pull/24789
#24789https://github.com/nodejs/node/pull/24789
#24832https://github.com/nodejs/node/pull/24832
MylesBorinshttps://github.com/MylesBorins
Dec 18, 2018 https://github.com/nodejs/node/pull/24786#ref-commit-1cbd377
https://github.com/BethGriggs
https://github.com/MylesBorins
2018-12-18, Version 8.14.1 'Carbon' (LTS)https://github.com/nodejs/node/commit/1cbd377078cd07447a6877fb9f844dd949a1cd43
1cbd377https://github.com/nodejs/node/commit/1cbd377078cd07447a6877fb9f844dd949a1cd43
#24786https://github.com/nodejs/node/pull/24786
#24786https://github.com/nodejs/node/pull/24786
#24789https://github.com/nodejs/node/pull/24789
#24789https://github.com/nodejs/node/pull/24789
#24832https://github.com/nodejs/node/pull/24832
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#267 https://github.com/beevelop/docker-android-nodejs/issues/267
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#268 https://github.com/beevelop/docker-android-nodejs/issues/268
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#269 https://github.com/beevelop/docker-android-nodejs/issues/269
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#270 https://github.com/beevelop/docker-android-nodejs/issues/270
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#271 https://github.com/beevelop/docker-android-nodejs/issues/271
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/24786#ref-commit-d28c3af
https://github.com/BethGriggs
https://github.com/refack
2018-12-18, Version 8.14.1 'Carbon' (LTS)https://github.com/refack/node/commit/d28c3af828986ce8b7286d103c1167a402e29cfb
d28c3afhttps://github.com/refack/node/commit/d28c3af828986ce8b7286d103c1167a402e29cfb
nodejs#24786https://github.com/nodejs/node/pull/24786
nodejs#24786https://github.com/nodejs/node/pull/24786
nodejs#24789https://github.com/nodejs/node/pull/24789
nodejs#24789https://github.com/nodejs/node/pull/24789
nodejs#24832https://github.com/nodejs/node/pull/24832
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 11:43https://github.com/nodejs/node/pull/24786#event-2962640965
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24786
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/24786/files/3e6e2000a7dc14c299d11d5df201d39887fd39bf
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
Please reload this pagehttps://github.com/nodejs/node/pull/24786
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com/BethGriggs
https://github.com/rvagg
https://github.com/sam-github
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.