René's URL Explorer Experiment


Title: http: make parser choice a runtime flag by addaleax · Pull Request #24739 · nodejs/node · GitHub

Open Graph Title: http: make parser choice a runtime flag by addaleax · Pull Request #24739 · nodejs/node

X Title: http: make parser choice a runtime flag by addaleax · Pull Request #24739 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Add a --http-parser=llhttp vs --http-parser=legacy command line switch, to make testing and comparing the new llhttp-based implementation easier. Refs: #24730 Checklist make -j4 test (UNIX), or...

X Description: Add a --http-parser=llhttp vs --http-parser=legacy command line switch, to make testing and comparing the new llhttp-based implementation easier. Refs: #24730 Checklist make -j4 test (UNIX), or...

Opengraph URL: https://github.com/nodejs/node/pull/24739

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f355e3ed-6c53-a63d-48f3-136b7943150e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC56A:7B3E:6D353F:8CAFBB:6990BD93
html-safe-nonce74cd9e546d7276e0d538bf55241d9eedf060625518cdcdd67600dfa957f9ba3d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTZBOjdCM0U6NkQzNTNGOjhDQUZCQjo2OTkwQkQ5MyIsInZpc2l0b3JfaWQiOiI4MjI0MTY2MjMyNDI2ODU1ODI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac62c61d4605a3425b2affb427f59ef6aa5169d49a87d8e0ecdfbc5709edc75a06
hovercard-subject-tagpull_request:234895610
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24739/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7441793c354e1d4c0e100d6024181936863f6059d815b135d6d006fb72694c9d/nodejs/node/pull/24739
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7441793c354e1d4c0e100d6024181936863f6059d815b135d6d006fb72694c9d/nodejs/node/pull/24739
og:image:altAdd a --http-parser=llhttp vs --http-parser=legacy command line switch, to make testing and comparing the new llhttp-based implementation easier. Refs: #24730 Checklist make -j4 test (UNIX), or...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24739#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24739
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24739
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24739
Reloadhttps://github.com/nodejs/node/pull/24739
Reloadhttps://github.com/nodejs/node/pull/24739
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24739
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 705 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:llhttp-runtime-switchhttps://github.com/addaleax/node/tree/llhttp-runtime-switch
Conversationhttps://github.com/nodejs/node/pull/24739
Commits5 (5)https://github.com/nodejs/node/pull/24739/commits
Checkshttps://github.com/nodejs/node/pull/24739/checks
Files changedhttps://github.com/nodejs/node/pull/24739/files
http: make parser choice a runtime flaghttps://github.com/nodejs/node/pull/24739#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:llhttp-runtime-switchhttps://github.com/addaleax/node/tree/llhttp-runtime-switch
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 30, 2018https://github.com/nodejs/node/pull/24739#issue-386069364
Please reload this pagehttps://github.com/nodejs/node/pull/24739
#24730https://github.com/nodejs/node/issues/24730
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
http_parser https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp_parser
Nov 30, 2018https://github.com/nodejs/node/pull/24739#event-1997236688
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
indutnyhttps://github.com/indutny
November 30, 2018 07:28https://github.com/nodejs/node/pull/24739#event-1997236706
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 30, 2018https://github.com/nodejs/node/pull/24739#issuecomment-443116141
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1736/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1736/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Nov 30, 2018https://github.com/nodejs/node/pull/24739#event-1997236780
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 30, 2018 https://github.com/nodejs/node/pull/24739#ref-issue-385904198
Make llhttp default HTTP parser #24730 https://github.com/nodejs/node/issues/24730
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 30, 2018https://github.com/nodejs/node/pull/24739#issuecomment-443116325
https://ci.nodejs.org/job/node-test-pull-request/19078/https://ci.nodejs.org/job/node-test-pull-request/19078/
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 30, 2018 https://github.com/nodejs/node/pull/24739#pullrequestreview-180167463
View reviewed changes https://github.com/nodejs/node/pull/24739/files
joyeecheunghttps://github.com/joyeecheung
https://github.com/nodejs/node/pull/24739#pullrequestreview-180167463
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24739
doc/api/cli.mdhttps://github.com/nodejs/node/pull/24739/files#diff-7349c17bce4d97526eefcb6f8291d617e7edb92ed9927fd3b9264e8014fc4e7c
Please reload this pagehttps://github.com/nodejs/node/pull/24739
lib/_http_common.jshttps://github.com/nodejs/node/pull/24739/files#diff-c53157e76b3e2712347a8cadde9d676026c82b00c3c1569e4932ec3ff3c9fa9b
Please reload this pagehttps://github.com/nodejs/node/pull/24739
src/node_http_parser_llhttp.cchttps://github.com/nodejs/node/pull/24739/files#diff-0b9e53d2a2c500473e71ae05755fc915d678f08a20612d65e1d4eecc5a35801e
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 30, 2018 https://github.com/nodejs/node/pull/24739#pullrequestreview-180271984
View reviewed changes https://github.com/nodejs/node/pull/24739/files
cjihrighttps://github.com/cjihrig
https://github.com/nodejs/node/pull/24739#pullrequestreview-180271984
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 30, 2018https://github.com/nodejs/node/pull/24739#issuecomment-443209723
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/indutny
indutnyhttps://github.com/indutny
Nov 30, 2018https://github.com/nodejs/node/pull/24739#issuecomment-443238400
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/indutny
indutnyhttps://github.com/indutny
Nov 30, 2018 https://github.com/nodejs/node/pull/24739#pullrequestreview-180317957
View reviewed changes https://github.com/nodejs/node/pull/24739/files
indutnyhttps://github.com/indutny
https://github.com/nodejs/node/pull/24739#pullrequestreview-180317957
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/indutny
indutnyhttps://github.com/indutny
Nov 30, 2018https://github.com/nodejs/node/pull/24739#issuecomment-443241074
#24738https://github.com/nodejs/node/pull/24738
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Nov 30, 2018https://github.com/nodejs/node/pull/24739#issuecomment-443241258
commenthttps://github.com/nodejs/node/issues/24730#issuecomment-443240207
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 30, 2018https://github.com/nodejs/node/pull/24739#issuecomment-443242641
Please reload this pagehttps://github.com/nodejs/node/pull/24739
@ofrobotshttps://github.com/ofrobots
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 30, 2018 https://github.com/nodejs/node/pull/24739#pullrequestreview-180331403
View reviewed changes https://github.com/nodejs/node/pull/24739/files
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 30, 2018https://github.com/nodejs/node/pull/24739#issuecomment-443269189
Please reload this pagehttps://github.com/nodejs/node/pull/24739
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Nov 30, 2018 https://github.com/nodejs/node/pull/24739#pullrequestreview-180460942
View reviewed changes https://github.com/nodejs/node/pull/24739/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 1, 2018https://github.com/nodejs/node/pull/24739#issuecomment-443409357
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 1, 2018 https://github.com/nodejs/node/pull/24739#pullrequestreview-180539305
View reviewed changes https://github.com/nodejs/node/pull/24739/files
doc/api/cli.mdhttps://github.com/nodejs/node/pull/24739/files#diff-7349c17bce4d97526eefcb6f8291d617e7edb92ed9927fd3b9264e8014fc4e7c
joyeecheunghttps://github.com/joyeecheung
Dec 1, 2018https://github.com/nodejs/node/pull/24739#discussion_r238077474
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24739
addaleaxhttps://github.com/addaleax
Dec 2, 2018https://github.com/nodejs/node/pull/24739#discussion_r238087928
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24739
joyeecheunghttps://github.com/joyeecheung
Dec 2, 2018https://github.com/nodejs/node/pull/24739#discussion_r238093474
Please reload this pagehttps://github.com/nodejs/node/pull/24739
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24739
addaleaxhttps://github.com/addaleax
Dec 2, 2018https://github.com/nodejs/node/pull/24739#discussion_r238100494
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24739
joyeecheunghttps://github.com/joyeecheung
Dec 2, 2018https://github.com/nodejs/node/pull/24739#discussion_r238107571
Please reload this pagehttps://github.com/nodejs/node/pull/24739
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/24739
addaleaxhttps://github.com/addaleax
Dec 4, 2018https://github.com/nodejs/node/pull/24739#discussion_r238566326
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/24739
joyeecheunghttps://github.com/joyeecheung
Dec 4, 2018https://github.com/nodejs/node/pull/24739#discussion_r238572696
Please reload this pagehttps://github.com/nodejs/node/pull/24739
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/24739
addaleaxhttps://github.com/addaleax
December 4, 2018 09:44https://github.com/nodejs/node/pull/24739#commits-pushed-3587d21
https://github.com/addaleax
http: make parser choice a runtime flaghttps://github.com/nodejs/node/pull/24739/commits/3587d21e2701c9ca44c1a83bbd53bba105ae4a69
3587d21https://github.com/nodejs/node/pull/24739/commits/3587d21e2701c9ca44c1a83bbd53bba105ae4a69
nodejs#24730https://github.com/nodejs/node/issues/24730
https://github.com/addaleax
squash! http: make parser choice a runtime flaghttps://github.com/nodejs/node/pull/24739/commits/9b48c54f2c0688359b17b44b5fe2e549a47b15e6
9b48c54https://github.com/nodejs/node/pull/24739/commits/9b48c54f2c0688359b17b44b5fe2e549a47b15e6
https://github.com/addaleax
fixup! http: make parser choice a runtime flaghttps://github.com/nodejs/node/pull/24739/commits/ff9d9ccc452a7fda6a9ac322895c0a290fa1a6e8
ff9d9cchttps://github.com/nodejs/node/pull/24739/commits/ff9d9ccc452a7fda6a9ac322895c0a290fa1a6e8
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/c54665ad581be5a402c13be636056d78ff7f0e87..ff9d9ccc452a7fda6a9ac322895c0a290fa1a6e8
c54665ahttps://github.com/nodejs/node/commit/c54665ad581be5a402c13be636056d78ff7f0e87
ff9d9cchttps://github.com/nodejs/node/commit/ff9d9ccc452a7fda6a9ac322895c0a290fa1a6e8
Compare https://github.com/nodejs/node/compare/c54665ad581be5a402c13be636056d78ff7f0e87..ff9d9ccc452a7fda6a9ac322895c0a290fa1a6e8
December 4, 2018 08:53https://github.com/nodejs/node/pull/24739#event-2003633982
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 4, 2018https://github.com/nodejs/node/pull/24739#issuecomment-444020420
https://ci.nodejs.org/job/node-test-pull-request/19179/https://ci.nodejs.org/job/node-test-pull-request/19179/
@ofrobotshttps://github.com/ofrobots
ff9d9cchttps://github.com/nodejs/node/commit/ff9d9ccc452a7fda6a9ac322895c0a290fa1a6e8
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
tsc-review https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-review
Dec 4, 2018https://github.com/nodejs/node/pull/24739#event-2003637854
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 4, 2018https://github.com/nodejs/node/pull/24739#issuecomment-444022151
Please reload this pagehttps://github.com/nodejs/node/pull/24739
@addaleaxhttps://github.com/addaleax
#24739 (review)https://github.com/nodejs/node/pull/24739#pullrequestreview-180539305
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 4, 2018https://github.com/nodejs/node/pull/24739#issuecomment-444024148
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 4, 2018 https://github.com/nodejs/node/pull/24739#pullrequestreview-181369125
View reviewed changes https://github.com/nodejs/node/pull/24739/files/ff9d9ccc452a7fda6a9ac322895c0a290fa1a6e8
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/24739#pullrequestreview-181369125
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 5, 2018https://github.com/nodejs/node/pull/24739#issuecomment-444540793
https://ci.nodejs.org/job/node-test-pull-request/19227/https://ci.nodejs.org/job/node-test-pull-request/19227/
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 5, 2018https://github.com/nodejs/node/pull/24739#issuecomment-444576674
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://ci.nodejs.org/job/node-test-pull-request/19233/https://ci.nodejs.org/job/node-test-pull-request/19233/
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 5, 2018https://github.com/nodejs/node/pull/24739#issuecomment-444619026
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://ci.nodejs.org/job/node-test-pull-request/19236/https://ci.nodejs.org/job/node-test-pull-request/19236/
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 5, 2018https://github.com/nodejs/node/pull/24739#issuecomment-444619460
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 5, 2018https://github.com/nodejs/node/pull/24739#issuecomment-444623783
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 6, 2018https://github.com/nodejs/node/pull/24739#issuecomment-444744453
aa943d0https://github.com/nodejs/node/commit/aa943d098e0299ea87485a607353d152f5ea5012
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 6, 2018https://github.com/nodejs/node/pull/24739#event-2008901332
danbevhttps://github.com/danbev
Dec 6, 2018 https://github.com/nodejs/node/pull/24739#ref-commit-aa943d0
https://github.com/addaleax
https://github.com/danbev
http: make parser choice a runtime flaghttps://github.com/nodejs/node/commit/aa943d098e0299ea87485a607353d152f5ea5012
aa943d0https://github.com/nodejs/node/commit/aa943d098e0299ea87485a607353d152f5ea5012
#24739https://github.com/nodejs/node/pull/24739
#24730https://github.com/nodejs/node/issues/24730
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
December 6, 2018 09:23https://github.com/nodejs/node/pull/24739#event-2009317255
addaleaxhttps://github.com/addaleax
Dec 6, 2018 https://github.com/nodejs/node/pull/24739#ref-commit-790300d
https://github.com/addaleax
http: switch default parser to llhttphttps://github.com/addaleax/node/commit/790300ddceb417f8ab63ad71d6ba0b0994ac342b
790300dhttps://github.com/addaleax/node/commit/790300ddceb417f8ab63ad71d6ba0b0994ac342b
nodejs#24739https://github.com/nodejs/node/pull/24739
nodejs#24730https://github.com/nodejs/node/issues/24730
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 6, 2018 https://github.com/nodejs/node/pull/24739#ref-pullrequest-388124429
http: switch default parser to llhttp #24870 https://github.com/nodejs/node/pull/24870
BridgeARhttps://github.com/BridgeAR
Dec 6, 2018 https://github.com/nodejs/node/pull/24739#ref-commit-4296e73
https://github.com/addaleax
https://github.com/BridgeAR
http: make parser choice a runtime flaghttps://github.com/nodejs/node/commit/4296e736efaced47b7d60c1f87f164ac1014a821
4296e73https://github.com/nodejs/node/commit/4296e736efaced47b7d60c1f87f164ac1014a821
#24739https://github.com/nodejs/node/pull/24739
#24730https://github.com/nodejs/node/issues/24730
BridgeARhttps://github.com/BridgeAR
Dec 6, 2018 https://github.com/nodejs/node/pull/24739#ref-commit-758cb07
https://github.com/BridgeAR
2018-12-06, Version 11.4.0 (Current)https://github.com/nodejs/node/commit/758cb07b3d0d7a178e08f8670847b4480b1af0c4
758cb07https://github.com/nodejs/node/commit/758cb07b3d0d7a178e08f8670847b4480b1af0c4
#23708https://github.com/nodejs/node/pull/23708
#24326https://github.com/nodejs/node/pull/24326
#23798https://github.com/nodejs/node/pull/23798
#24739https://github.com/nodejs/node/pull/24739
#23916https://github.com/nodejs/node/pull/23916
#24804https://github.com/nodejs/node/pull/24804
#24405https://github.com/nodejs/node/pull/24405
#24358https://github.com/nodejs/node/pull/24358
#23720https://github.com/nodejs/node/pull/23720
#24677https://github.com/nodejs/node/pull/24677
#24233https://github.com/nodejs/node/pull/24233
https://github.com/antsmartianhttps://github.com/antsmartian
#24655https://github.com/nodejs/node/pull/24655
#24854https://github.com/nodejs/node/pull/24854
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 6, 2018 https://github.com/nodejs/node/pull/24739#ref-pullrequest-387948820
v11.4.0 proposal #24854 https://github.com/nodejs/node/pull/24854
BridgeARhttps://github.com/BridgeAR
Dec 7, 2018 https://github.com/nodejs/node/pull/24739#ref-commit-c8d5e31
https://github.com/addaleax
https://github.com/BridgeAR
http: make parser choice a runtime flaghttps://github.com/nodejs/node/commit/c8d5e31db43fb46f1d2db79e015d909c6a702eef
c8d5e31https://github.com/nodejs/node/commit/c8d5e31db43fb46f1d2db79e015d909c6a702eef
#24739https://github.com/nodejs/node/pull/24739
#24730https://github.com/nodejs/node/issues/24730
BridgeARhttps://github.com/BridgeAR
Dec 7, 2018 https://github.com/nodejs/node/pull/24739#ref-commit-5ab22c8
https://github.com/addaleax
https://github.com/BridgeAR
http: make parser choice a runtime flaghttps://github.com/nodejs/node/commit/5ab22c8f20b982daf32870a07b153057d6254e35
5ab22c8https://github.com/nodejs/node/commit/5ab22c8f20b982daf32870a07b153057d6254e35
#24739https://github.com/nodejs/node/pull/24739
#24730https://github.com/nodejs/node/issues/24730
BridgeARhttps://github.com/BridgeAR
Dec 7, 2018 https://github.com/nodejs/node/pull/24739#ref-commit-4f1297f
https://github.com/BridgeAR
2018-12-07, Version 11.4.0 (Current)https://github.com/nodejs/node/commit/4f1297f259b09d129ac01afbd4c674263b7ac124
4f1297fhttps://github.com/nodejs/node/commit/4f1297f259b09d129ac01afbd4c674263b7ac124
#23708https://github.com/nodejs/node/pull/23708
#24326https://github.com/nodejs/node/pull/24326
#23798https://github.com/nodejs/node/pull/23798
#24739https://github.com/nodejs/node/pull/24739
#23916https://github.com/nodejs/node/pull/23916
#24804https://github.com/nodejs/node/pull/24804
#24405https://github.com/nodejs/node/pull/24405
#24358https://github.com/nodejs/node/pull/24358
#23720https://github.com/nodejs/node/pull/23720
#24677https://github.com/nodejs/node/pull/24677
#24233https://github.com/nodejs/node/pull/24233
https://github.com/antsmartianhttps://github.com/antsmartian
#24655https://github.com/nodejs/node/pull/24655
#24854https://github.com/nodejs/node/pull/24854
BridgeARhttps://github.com/BridgeAR
Dec 7, 2018 https://github.com/nodejs/node/pull/24739#ref-commit-bcef949
https://github.com/BridgeAR
2018-12-07, Version 11.4.0 (Current)https://github.com/nodejs/node/commit/bcef949c931f54e3d8ae2a1701f2538262e6bec9
bcef949https://github.com/nodejs/node/commit/bcef949c931f54e3d8ae2a1701f2538262e6bec9
#23708https://github.com/nodejs/node/pull/23708
#24326https://github.com/nodejs/node/pull/24326
#23798https://github.com/nodejs/node/pull/23798
#24739https://github.com/nodejs/node/pull/24739
#23916https://github.com/nodejs/node/pull/23916
#24804https://github.com/nodejs/node/pull/24804
#24405https://github.com/nodejs/node/pull/24405
#24358https://github.com/nodejs/node/pull/24358
#23720https://github.com/nodejs/node/pull/23720
#24677https://github.com/nodejs/node/pull/24677
#24233https://github.com/nodejs/node/pull/24233
https://github.com/antsmartianhttps://github.com/antsmartian
#24655https://github.com/nodejs/node/pull/24655
#24854https://github.com/nodejs/node/pull/24854
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261 https://github.com/beevelop/docker-android-nodejs/issues/261
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262 https://github.com/beevelop/docker-android-nodejs/issues/262
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263 https://github.com/beevelop/docker-android-nodejs/issues/263
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264 https://github.com/beevelop/docker-android-nodejs/issues/264
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265 https://github.com/beevelop/docker-android-nodejs/issues/265
addaleaxhttps://github.com/addaleax
Dec 9, 2018 https://github.com/nodejs/node/pull/24739#ref-commit-2cb8f24
https://github.com/addaleax
http: switch default parser to llhttphttps://github.com/nodejs/node/commit/2cb8f247512d611d3dfe81c2441e8028bfb0e8f0
2cb8f24https://github.com/nodejs/node/commit/2cb8f247512d611d3dfe81c2441e8028bfb0e8f0
#24739https://github.com/nodejs/node/pull/24739
#24730https://github.com/nodejs/node/issues/24730
#24870https://github.com/nodejs/node/pull/24870
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/24739#ref-commit-dd48879
https://github.com/refack
http: make parser choice a runtime flaghttps://github.com/refack/node/commit/dd4887914467e90732cb48a69bce881a89e1f4c0
dd48879https://github.com/refack/node/commit/dd4887914467e90732cb48a69bce881a89e1f4c0
nodejs#24739https://github.com/nodejs/node/pull/24739
nodejs#24730https://github.com/nodejs/node/issues/24730
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/24739#ref-commit-5912f6d
https://github.com/BridgeAR
https://github.com/refack
2018-12-07, Version 11.4.0 (Current)https://github.com/refack/node/commit/5912f6d859f18535af44c15d8b16035403fa1b62
5912f6dhttps://github.com/refack/node/commit/5912f6d859f18535af44c15d8b16035403fa1b62
nodejs#23708https://github.com/nodejs/node/pull/23708
nodejs#24326https://github.com/nodejs/node/pull/24326
nodejs#23798https://github.com/nodejs/node/pull/23798
nodejs#24739https://github.com/nodejs/node/pull/24739
nodejs#23916https://github.com/nodejs/node/pull/23916
nodejs#24804https://github.com/nodejs/node/pull/24804
nodejs#24405https://github.com/nodejs/node/pull/24405
nodejs#24358https://github.com/nodejs/node/pull/24358
nodejs#23720https://github.com/nodejs/node/pull/23720
nodejs#24677https://github.com/nodejs/node/pull/24677
nodejs#24233https://github.com/nodejs/node/pull/24233
https://github.com/antsmartianhttps://github.com/antsmartian
nodejs#24655https://github.com/nodejs/node/pull/24655
nodejs#24854https://github.com/nodejs/node/pull/24854
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/24739#ref-commit-a843199
https://github.com/refack
http: switch default parser to llhttphttps://github.com/refack/node/commit/a843199a0da1f809ecef4110fd630624b5e1608c
a843199https://github.com/refack/node/commit/a843199a0da1f809ecef4110fd630624b5e1608c
nodejs#24739https://github.com/nodejs/node/pull/24739
nodejs#24730https://github.com/nodejs/node/issues/24730
nodejs#24870https://github.com/nodejs/node/pull/24870
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Sep 3, 2019https://github.com/nodejs/node/pull/24739#event-2603954105
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24739
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/24739/files/ff9d9ccc452a7fda6a9ac322895c0a290fa1a6e8
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/24739/files/ff9d9ccc452a7fda6a9ac322895c0a290fa1a6e8
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/24739/files/c54665ad581be5a402c13be636056d78ff7f0e87
https://github.com/ofrobots
ofrobots https://github.com/ofrobots
https://github.com/nodejs/node/pull/24739/files/ff9d9ccc452a7fda6a9ac322895c0a290fa1a6e8
https://github.com/indutny
indutny https://github.com/indutny
https://github.com/nodejs/node/pull/24739/files/c54665ad581be5a402c13be636056d78ff7f0e87
https://github.com/mmarchini
mmarchini https://github.com/mmarchini
https://github.com/nodejs/node/pull/24739/files/c54665ad581be5a402c13be636056d78ff7f0e87
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/24739/files/c54665ad581be5a402c13be636056d78ff7f0e87
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http_parser https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp_parser
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/24739
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/indutny
https://github.com/ofrobots
https://github.com/joyeecheung
https://github.com/mmarchini
https://github.com/Trott
https://github.com/danbev
https://github.com/mcollina
https://github.com/cjihrig
https://github.com/devsnek
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.