| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5105e3bc-7af5-5335-7093-9c1a8a567457 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E438:F834C:1018EFD:14CA740:6990C96E |
| html-safe-nonce | 3fc4096655c1803c24276d65e62442ccfa44b3aa0010ac5ac28468ef0b7fec9a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDM4OkY4MzRDOjEwMThFRkQ6MTRDQTc0MDo2OTkwQzk2RSIsInZpc2l0b3JfaWQiOiI0NTU4OTg3MDQyMDU5NTAzOTgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f6182cafd1e88ee86a17e080e8e4b6434b202de865b50160c514fa663df8465a |
| hovercard-subject-tag | pull_request:234033829 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24678/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3e713480756b0ed5b2983f2a510c77ee3c3dda7dc67910f81b990f34d6410698/nodejs/node/pull/24678 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3e713480756b0ed5b2983f2a510c77ee3c3dda7dc67910f81b990f34d6410698/nodejs/node/pull/24678 |
| og:image:alt | PR-URL: #23972
Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or be... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sam-github |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/24678#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24678 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24678 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/24678 |
| Reload | https://github.com/nodejs/node/pull/24678 |
| Reload | https://github.com/nodejs/node/pull/24678 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/24678 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
704
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| sam-github | https://github.com/sam-github |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| sam-github:backport-23972-to-v10.x | https://github.com/sam-github/node/tree/backport-23972-to-v10.x |
| Conversation | https://github.com/nodejs/node/pull/24678 |
| Commits61 (61) | https://github.com/nodejs/node/pull/24678/commits |
| Checks | https://github.com/nodejs/node/pull/24678/checks |
| Files changed | https://github.com/nodejs/node/pull/24678/files |
| [v10.x backport] doc: sort markdown refs in errors | https://github.com/nodejs/node/pull/24678#top |
| sam-github | https://github.com/sam-github |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| sam-github:backport-23972-to-v10.x | https://github.com/sam-github/node/tree/backport-23972-to-v10.x |
|
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Nov 27, 2018 | https://github.com/nodejs/node/pull/24678#issue-384952006 |
| #23972 | https://github.com/nodejs/node/pull/23972 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/24678 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 27, 2018 | https://github.com/nodejs/node/pull/24678#issuecomment-442187269 |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/24678 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
| Nov 27, 2018 | https://github.com/nodejs/node/pull/24678#event-1990556489 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/868c7fd29e6b2438570081545086b27628c27bdf..7411da4ec431bc618e6dd3cb1d872bb4c99034f6 |
| 868c7fd | https://github.com/nodejs/node/commit/868c7fd29e6b2438570081545086b27628c27bdf |
| 7411da4 | https://github.com/nodejs/node/commit/7411da4ec431bc618e6dd3cb1d872bb4c99034f6 |
|
Compare
| https://github.com/nodejs/node/compare/868c7fd29e6b2438570081545086b27628c27bdf..7411da4ec431bc618e6dd3cb1d872bb4c99034f6 |
| November 27, 2018 19:33 | https://github.com/nodejs/node/pull/24678#event-1990558107 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 27, 2018 | https://github.com/nodejs/node/pull/24678#event-1990562467 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Nov 27, 2018 | https://github.com/nodejs/node/pull/24678#issuecomment-442208604 |
| #24681 | https://github.com/nodejs/node/pull/24681 |
| #24679 | https://github.com/nodejs/node/pull/24679 |
| Please reload this page | https://github.com/nodejs/node/pull/24678 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| force-pushed | https://github.com/nodejs/node/compare/e66c09e459ef969a3d309c894b00b366e8032e1a..391f8bf77956e19364ccddb1ec5255e272aa69e1 |
| e66c09e | https://github.com/nodejs/node/commit/e66c09e459ef969a3d309c894b00b366e8032e1a |
| 391f8bf | https://github.com/nodejs/node/commit/391f8bf77956e19364ccddb1ec5255e272aa69e1 |
|
Compare
| https://github.com/nodejs/node/compare/e66c09e459ef969a3d309c894b00b366e8032e1a..391f8bf77956e19364ccddb1ec5255e272aa69e1 |
| November 28, 2018 00:35 | https://github.com/nodejs/node/pull/24678#event-1991149283 |
| refack | https://github.com/refack |
| November 29, 2018 11:39 | https://github.com/nodejs/node/pull/24678#commits-pushed-24dd67f |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| build: configure default v8_optimized_debug | https://github.com/nodejs/node/pull/24678/commits/24dd67fe8fbfbe754d8ddf652ed8790e59d1542f |
| 24dd67f | https://github.com/nodejs/node/pull/24678/commits/24dd67fe8fbfbe754d8ddf652ed8790e59d1542f |
| nodejs#23704 | https://github.com/nodejs/node/pull/23704 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| deps,v8: fix gypfile bug | https://github.com/nodejs/node/pull/24678/commits/c9ecaefb88aee98cc988ea19ea298f7d4203631a |
| c9ecaef | https://github.com/nodejs/node/pull/24678/commits/c9ecaefb88aee98cc988ea19ea298f7d4203631a |
| nodejs#23704 | https://github.com/nodejs/node/pull/23704 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| build: add -Werror=undefined-inline to clang builds | https://github.com/nodejs/node/pull/24678/commits/a1b56439e35e3e539d86d31f0e2965387e053adf |
| a1b5643 | https://github.com/nodejs/node/pull/24678/commits/a1b56439e35e3e539d86d31f0e2965387e053adf |
| nodejs#23961 | https://github.com/nodejs/node/pull/23961 |
| nodejs#23954 | https://github.com/nodejs/node/pull/23954 |
| nodejs#23910 | https://github.com/nodejs/node/pull/23910 |
| nodejs#23880 | https://github.com/nodejs/node/pull/23880 |
|
| https://github.com/suresh-srinivas |
|
| https://github.com/MylesBorins |
| src: fix fully-static & large-pages combination | https://github.com/nodejs/node/pull/24678/commits/6f249bca80b4e20ff92d030bfe8fcee41f4ce185 |
| 6f249bc | https://github.com/nodejs/node/pull/24678/commits/6f249bca80b4e20ff92d030bfe8fcee41f4ce185 |
| nodejs#23906 | https://github.com/nodejs/node/issues/23906 |
| nodejs#22079 | https://github.com/nodejs/node/pull/22079 |
| nodejs#23964 | https://github.com/nodejs/node/pull/23964 |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
| build: make benchmark/napi all prereq order-only | https://github.com/nodejs/node/pull/24678/commits/cc72b2a4a3585309cd75a23ce8b1ec9926590116 |
| cc72b2a | https://github.com/nodejs/node/pull/24678/commits/cc72b2a4a3585309cd75a23ce8b1ec9926590116 |
| nodejs#23951 | https://github.com/nodejs/node/pull/23951 |
|
| https://github.com/oyyd |
|
| https://github.com/MylesBorins |
| doc: add types and their corresponding return values | https://github.com/nodejs/node/pull/24678/commits/9be73ea1537b6008b166e642ebd1b0a717a18a69 |
| 9be73ea | https://github.com/nodejs/node/pull/24678/commits/9be73ea1537b6008b166e642ebd1b0a717a18a69 |
| nodejs#23998 | https://github.com/nodejs/node/pull/23998 |
|
| https://github.com/jagannathBhat |
|
| https://github.com/MylesBorins |
| doc: improve BUILDING.md | https://github.com/nodejs/node/pull/24678/commits/f1f1ae4387e2c8835b8317e5bcdb01a7d7f37c2d |
| f1f1ae4 | https://github.com/nodejs/node/pull/24678/commits/f1f1ae4387e2c8835b8317e5bcdb01a7d7f37c2d |
| nodejs#23976 | https://github.com/nodejs/node/pull/23976 |
|
| https://github.com/jagannathBhat |
|
| https://github.com/MylesBorins |
| doc: improve COLLABORATOR_GUIDE | https://github.com/nodejs/node/pull/24678/commits/00c0539625dfd8d68b2710a4ae02117a166bef19 |
| 00c0539 | https://github.com/nodejs/node/pull/24678/commits/00c0539625dfd8d68b2710a4ae02117a166bef19 |
| nodejs#23977 | https://github.com/nodejs/node/pull/23977 |
|
| https://github.com/ofrobots |
|
| https://github.com/MylesBorins |
| test: fix test-fs-watch-system-limit | https://github.com/nodejs/node/pull/24678/commits/0ca364655f3e87d4bd4ff99fde17a0d2a66b0f6a |
| 0ca3646 | https://github.com/nodejs/node/pull/24678/commits/0ca364655f3e87d4bd4ff99fde17a0d2a66b0f6a |
| nodejs#23986 | https://github.com/nodejs/node/pull/23986 |
|
| https://github.com/shobhitchittora |
|
| https://github.com/MylesBorins |
| child_process: handle undefined/null for fork() args | https://github.com/nodejs/node/pull/24678/commits/db4f92d081b5dbf49fce9acf163ca0173635aa26 |
| db4f92d | https://github.com/nodejs/node/pull/24678/commits/db4f92d081b5dbf49fce9acf163ca0173635aa26 |
| nodejs#22416 | https://github.com/nodejs/node/pull/22416 |
| nodejs#20749 | https://github.com/nodejs/node/issues/20749 |
|
| https://github.com/mritunjayz |
|
| https://github.com/MylesBorins |
| test: add property for RangeError in test-buffer-copy | https://github.com/nodejs/node/pull/24678/commits/0ed9aaa7bf6bcab7e7bce903497122da284a63f6 |
| 0ed9aaa | https://github.com/nodejs/node/pull/24678/commits/0ed9aaa7bf6bcab7e7bce903497122da284a63f6 |
| nodejs#23968 | https://github.com/nodejs/node/pull/23968 |
|
| https://github.com/Westixy |
|
| https://github.com/MylesBorins |
| test: fix strictEqual arguments order | https://github.com/nodejs/node/pull/24678/commits/e0902c8b4ffa7b24ba2c513c2546f1d8737238f1 |
| e0902c8 | https://github.com/nodejs/node/pull/24678/commits/e0902c8b4ffa7b24ba2c513c2546f1d8737238f1 |
| nodejs#23956 | https://github.com/nodejs/node/pull/23956 |
|
| https://github.com/jeromecovington |
|
| https://github.com/MylesBorins |
| test: assert that invalidcmd throws error code | https://github.com/nodejs/node/pull/24678/commits/3c314d14adeb79d635627335bffd29bede6d770d |
| 3c314d1 | https://github.com/nodejs/node/pull/24678/commits/3c314d14adeb79d635627335bffd29bede6d770d |
| nodejs#23942 | https://github.com/nodejs/node/pull/23942 |
|
| https://github.com/richardlau |
|
| https://github.com/MylesBorins |
| tools: update alternative docs versions | https://github.com/nodejs/node/pull/24678/commits/add267b3ebc36d94eea8ba4854a252ea58f4d914 |
| add267b | https://github.com/nodejs/node/pull/24678/commits/add267b3ebc36d94eea8ba4854a252ea58f4d914 |
| nodejs#23980 | https://github.com/nodejs/node/pull/23980 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: revise CHANGELOG.md text | https://github.com/nodejs/node/pull/24678/commits/559ce1cd19f8922b230faaee138cf23054805a1d |
| 559ce1c | https://github.com/nodejs/node/pull/24678/commits/559ce1cd19f8922b230faaee138cf23054805a1d |
| nodejs#23988 | https://github.com/nodejs/node/pull/23988 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: simplify CODE_OF_CONDUCT.md | https://github.com/nodejs/node/pull/24678/commits/1956800ebeff20be82f3a8c25583a2b9ea157a90 |
| 1956800 | https://github.com/nodejs/node/pull/24678/commits/1956800ebeff20be82f3a8c25583a2b9ea157a90 |
| nodejs#23989 | https://github.com/nodejs/node/pull/23989 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: revise COLLABORATOR_GUIDE.md | https://github.com/nodejs/node/pull/24678/commits/e8e59267762065fc66c543e78bb72c525abcac0e |
| e8e5926 | https://github.com/nodejs/node/pull/24678/commits/e8e59267762065fc66c543e78bb72c525abcac0e |
| nodejs#23990 | https://github.com/nodejs/node/pull/23990 |
|
| https://github.com/jagannathBhat |
|
| https://github.com/MylesBorins |
| doc: address bits of proof reading work | https://github.com/nodejs/node/pull/24678/commits/0c923cff930decffd98dad9b0804efc9bbac7bcc |
| 0c923cf | https://github.com/nodejs/node/pull/24678/commits/0c923cff930decffd98dad9b0804efc9bbac7bcc |
| nodejs#23978 | https://github.com/nodejs/node/pull/23978 |
|
| https://github.com/prog1dev |
|
| https://github.com/MylesBorins |
| doc: fix dublication in net.createServer() docs | https://github.com/nodejs/node/pull/24678/commits/579bcd1e1d4c9fbd8e6fe3631b3248b3d0f32070 |
| 579bcd1 | https://github.com/nodejs/node/pull/24678/commits/579bcd1e1d4c9fbd8e6fe3631b3248b3d0f32070 |
| nodejs#24026 | https://github.com/nodejs/node/pull/24026 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| deps: cherry-pick 2987946 from upstream V8 | https://github.com/nodejs/node/pull/24678/commits/24a5c56f13827e9a396dec5499c8eed8f35a3dd7 |
| 24a5c56 | https://github.com/nodejs/node/pull/24678/commits/24a5c56f13827e9a396dec5499c8eed8f35a3dd7 |
| https://chromium-review.googlesource.com/1186625 | https://chromium-review.googlesource.com/1186625 |
| nodejs#55401 | https://github.com/nodejs/node/pull/55401 |
| v8/v8@2987946 | https://github.com/v8/v8/commit/29879461ceb4bc9b84b0ec38e4dd192fbf884dc2 |
| nodejs#24555 | https://github.com/nodejs/node/pull/24555 |
| nodejs#20891 | https://github.com/nodejs/node/issues/20891 |
|
| https://github.com/rvagg |
|
| https://github.com/MylesBorins |
| build: only check REPLACEME & DEP...X for releases | https://github.com/nodejs/node/pull/24678/commits/d9e10fbf1a473b171151c0f55e7949613a5f0774 |
| d9e10fb | https://github.com/nodejs/node/pull/24678/commits/d9e10fbf1a473b171151c0f55e7949613a5f0774 |
| nodejs#24575 | https://github.com/nodejs/node/pull/24575 |
| nodejs#24551 | https://github.com/nodejs/node/pull/24551 |
| nodejs#12958 | https://github.com/nodejs/node/pull/12958 |
| nodejs#12957 | https://github.com/nodejs/node/pull/12957 |
| nodejs#8325 | https://github.com/nodejs/node/pull/8325 |
| November 29, 2018 11:39 | https://github.com/nodejs/node/pull/24678#commits-pushed-bb4c086 |
|
| https://github.com/MylesBorins |
| lib:fix grammar error and make it clearer for comments | https://github.com/nodejs/node/pull/24678/commits/bb4c08641f3fcf3daf8777b264d2e8d447adac84 |
| bb4c086 | https://github.com/nodejs/node/pull/24678/commits/bb4c08641f3fcf3daf8777b264d2e8d447adac84 |
| nodejs#23799 | https://github.com/nodejs/node/pull/23799 |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
| test: add crypto check to test-benchmark-http2 | https://github.com/nodejs/node/pull/24678/commits/d30e57385745bb82bad6bbf59d1066abc39efb1b |
| d30e573 | https://github.com/nodejs/node/pull/24678/commits/d30e57385745bb82bad6bbf59d1066abc39efb1b |
| nodejs#24096 | https://github.com/nodejs/node/pull/24096 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: fix minor text issues in stream.md | https://github.com/nodejs/node/pull/24678/commits/290796fcc5956f5e7487fdbce59addc5d3fbb52e |
| 290796f | https://github.com/nodejs/node/pull/24678/commits/290796fcc5956f5e7487fdbce59addc5d3fbb52e |
| nodejs#24116 | https://github.com/nodejs/node/pull/24116 |
|
| https://github.com/ChALkeR |
|
| https://github.com/MylesBorins |
| doc: inspector security warning for changing host | https://github.com/nodejs/node/pull/24678/commits/a77dc9a93017fa827f9b37f8eaa47aa3be0be51d |
| a77dc9a | https://github.com/nodejs/node/pull/24678/commits/a77dc9a93017fa827f9b37f8eaa47aa3be0be51d |
| nodejs#23444 | https://github.com/nodejs/node/issues/23444 |
| nodejs#21774 | https://github.com/nodejs/node/issues/21774 |
| nodejs#23640 | https://github.com/nodejs/node/pull/23640 |
|
| https://github.com/vdeturckheim |
|
| https://github.com/MylesBorins |
| vm: clarify timeout option in vm | https://github.com/nodejs/node/pull/24678/commits/3999710e6e1718041eeba7896db80876fa9e7f44 |
| 3999710 | https://github.com/nodejs/node/pull/24678/commits/3999710e6e1718041eeba7896db80876fa9e7f44 |
| nodejs#23512 | https://github.com/nodejs/node/pull/23512 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: implement minor text fixes to path.md | https://github.com/nodejs/node/pull/24678/commits/45a3278b435cf3ea8d6f7e40f7461065d3991c12 |
| 45a3278 | https://github.com/nodejs/node/pull/24678/commits/45a3278b435cf3ea8d6f7e40f7461065d3991c12 |
| nodejs#24118 | https://github.com/nodejs/node/pull/24118 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
| deps: remove old c-ares configure files | https://github.com/nodejs/node/pull/24678/commits/4eaab7c47def01cb11dd7d2336d059baea73e8d0 |
| 4eaab7c | https://github.com/nodejs/node/pull/24678/commits/4eaab7c47def01cb11dd7d2336d059baea73e8d0 |
| 58e4eda | https://github.com/sam-github/node/commit/58e4edaf6855025099d400ccc1ac23291b109a41 |
| nodejs#23854 | https://github.com/nodejs/node/pull/23854 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
| deps: upgrade to c-ares v1.15.0 | https://github.com/nodejs/node/pull/24678/commits/209b1d50a8a28472dcec29be14cc81bda44a3785 |
| 209b1d5 | https://github.com/nodejs/node/pull/24678/commits/209b1d50a8a28472dcec29be14cc81bda44a3785 |
| 2b6bb9f | https://github.com/sam-github/node/commit/2b6bb9f588aa791a385c8a5075ab5e207f9a739d |
| nodejs#23854 | https://github.com/nodejs/node/pull/23854 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
| deps: c-ares float, version number patch | https://github.com/nodejs/node/pull/24678/commits/d89bae88325a24c9310945f74ffb3f3fffa1aa05 |
| d89bae8 | https://github.com/nodejs/node/pull/24678/commits/d89bae88325a24c9310945f74ffb3f3fffa1aa05 |
| c-ares/c-ares#229 | https://github.com/c-ares/c-ares/issues/229 |
| nodejs#23854 | https://github.com/nodejs/node/pull/23854 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| build,meta: don't fail Travis for commit message | https://github.com/nodejs/node/pull/24678/commits/61458c4eafb58a19a25aa637db4ab22edb7d5250 |
| 61458c4 | https://github.com/nodejs/node/pull/24678/commits/61458c4eafb58a19a25aa637db4ab22edb7d5250 |
| nodejs#23739 | https://github.com/nodejs/node/pull/23739 |
| nodejs#23737 | https://github.com/nodejs/node/issues/23737 |
| nodejs#22452 | https://github.com/nodejs/node/pull/22452 |
|
| https://github.com/MylesBorins |
| doc: add shisama to collaborators | https://github.com/nodejs/node/pull/24678/commits/f80423b974e75d3d3c66159aad47bed75fe60494 |
| f80423b | https://github.com/nodejs/node/pull/24678/commits/f80423b974e75d3d3c66159aad47bed75fe60494 |
| nodejs#24136 | https://github.com/nodejs/node/pull/24136 |
| nodejs#23850 | https://github.com/nodejs/node/issues/23850 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| build: use latest node on travis | https://github.com/nodejs/node/pull/24678/commits/2983df8d446b561510004fdc736013c689511b4b |
| 2983df8 | https://github.com/nodejs/node/pull/24678/commits/2983df8d446b561510004fdc736013c689511b4b |
| nodejs#24198 | https://github.com/nodejs/node/pull/24198 |
|
| https://github.com/psmarshall |
|
| https://github.com/MylesBorins |
| doc: add psmarshall to collaborators | https://github.com/nodejs/node/pull/24678/commits/d242a66317224fefcbfb391e2cae9e7b331c4537 |
| d242a66 | https://github.com/nodejs/node/pull/24678/commits/d242a66317224fefcbfb391e2cae9e7b331c4537 |
| nodejs#24170 | https://github.com/nodejs/node/pull/24170 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| test: disable color formating for test-internal-errors.js | https://github.com/nodejs/node/pull/24678/commits/f20bf8c6fd6a3b8272a78ead77af73b014c249f7 |
| f20bf8c | https://github.com/nodejs/node/pull/24678/commits/f20bf8c6fd6a3b8272a78ead77af73b014c249f7 |
| nodejs#24204 | https://github.com/nodejs/node/pull/24204 |
| nodejs#24193 | https://github.com/nodejs/node/issues/24193 |
| nodejs#19723 | https://github.com/nodejs/node/pull/19723 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: update System Errors documentation | https://github.com/nodejs/node/pull/24678/commits/3102bce4d959175d344850891ef421c7e52df474 |
| 3102bce | https://github.com/nodejs/node/pull/24678/commits/3102bce4d959175d344850891ef421c7e52df474 |
| nodejs#24090 | https://github.com/nodejs/node/pull/24090 |
| nodejs#23975 | https://github.com/nodejs/node/issues/23975 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: add text about error.code stability | https://github.com/nodejs/node/pull/24678/commits/c4e34cccde25dc51ebc1b85edac183ab187a4ab7 |
| c4e34cc | https://github.com/nodejs/node/pull/24678/commits/c4e34cccde25dc51ebc1b85edac183ab187a4ab7 |
| nodejs#23975 | https://github.com/nodejs/node/issues/23975 |
| nodejs#24090 | https://github.com/nodejs/node/pull/24090 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: wrap GOVERNANCE.md at 80 characters | https://github.com/nodejs/node/pull/24678/commits/0e121bf6397eeb540ceb157a02f2bd89c3fe45f8 |
| 0e121bf | https://github.com/nodejs/node/pull/24678/commits/0e121bf6397eeb540ceb157a02f2bd89c3fe45f8 |
| nodejs#24094 | https://github.com/nodejs/node/pull/24094 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: enable 80-char line length markdown linting | https://github.com/nodejs/node/pull/24678/commits/20157126fc14ab8bce0b664a851ff4f40031afaf |
| 2015712 | https://github.com/nodejs/node/pull/24678/commits/20157126fc14ab8bce0b664a851ff4f40031afaf |
| nodejs#24094 | https://github.com/nodejs/node/pull/24094 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| doc: fix linting errors | https://github.com/nodejs/node/pull/24678/commits/219040d95d66144aaa5cec2eacee807f70546f38 |
| 219040d | https://github.com/nodejs/node/pull/24678/commits/219040d95d66144aaa5cec2eacee807f70546f38 |
| nodejs#24229 | https://github.com/nodejs/node/pull/24229 |
|
| https://github.com/codebytere |
|
| https://github.com/MylesBorins |
| src: prefer param function check over args length | https://github.com/nodejs/node/pull/24678/commits/a273da96fa2179ba94557ffb17175a2f87340261 |
| a273da9 | https://github.com/nodejs/node/pull/24678/commits/a273da96fa2179ba94557ffb17175a2f87340261 |
| nodejs#23835 | https://github.com/nodejs/node/pull/23835 |
|
| https://github.com/mritunjayz |
|
| https://github.com/MylesBorins |
| build: change repo to https protocol in Makefile | https://github.com/nodejs/node/pull/24678/commits/69360601aa8360ea1bf64dadf3e2106e3b5bb891 |
| 6936060 | https://github.com/nodejs/node/pull/24678/commits/69360601aa8360ea1bf64dadf3e2106e3b5bb891 |
| nodejs#24073 | https://github.com/nodejs/node/pull/24073 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/bda1cc703a252c0ebbda8388278764559ada7eff..69360601aa8360ea1bf64dadf3e2106e3b5bb891 |
| bda1cc7 | https://github.com/nodejs/node/commit/bda1cc703a252c0ebbda8388278764559ada7eff |
| 6936060 | https://github.com/nodejs/node/commit/69360601aa8360ea1bf64dadf3e2106e3b5bb891 |
|
Compare
| https://github.com/nodejs/node/compare/bda1cc703a252c0ebbda8388278764559ada7eff..69360601aa8360ea1bf64dadf3e2106e3b5bb891 |
| November 29, 2018 16:40 | https://github.com/nodejs/node/pull/24678#event-1995776975 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Nov 29, 2018 | https://github.com/nodejs/node/pull/24678#issuecomment-442938015 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1730/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1730/ |
| Please reload this page | https://github.com/nodejs/node/pull/24678 |
|
| https://github.com/sam-github |
| doc: sort markdown refs in errors | https://github.com/nodejs/node/pull/24678/commits/4cc8ec2ddc67a075a239b86a3d8bce230e311de7 |
| 4cc8ec2 | https://github.com/nodejs/node/pull/24678/commits/4cc8ec2ddc67a075a239b86a3d8bce230e311de7 |
| nodejs#24678 | https://github.com/nodejs/node/pull/24678 |
| nodejs#23972 | https://github.com/nodejs/node/pull/23972 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/7411da4ec431bc618e6dd3cb1d872bb4c99034f6..4cc8ec2ddc67a075a239b86a3d8bce230e311de7 |
| 7411da4 | https://github.com/nodejs/node/commit/7411da4ec431bc618e6dd3cb1d872bb4c99034f6 |
| 4cc8ec2 | https://github.com/nodejs/node/commit/4cc8ec2ddc67a075a239b86a3d8bce230e311de7 |
|
Compare
| https://github.com/nodejs/node/compare/7411da4ec431bc618e6dd3cb1d872bb4c99034f6..4cc8ec2ddc67a075a239b86a3d8bce230e311de7 |
| November 29, 2018 18:23 | https://github.com/nodejs/node/pull/24678#event-1996036164 |
|
| https://github.com/sam-github |
| fixup! doc: sort markdown refs in errors | https://github.com/nodejs/node/pull/24678/commits/2a9f701acf48eba00e8673bca34dafc557942e81 |
| 2a9f701 | https://github.com/nodejs/node/pull/24678/commits/2a9f701acf48eba00e8673bca34dafc557942e81 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/4864cb0038b4081bc956551bafe8b326ec64050c..4035ca16c512eac0c58fbb0ba0053b52cd91e437 |
| 4864cb0 | https://github.com/nodejs/node/commit/4864cb0038b4081bc956551bafe8b326ec64050c |
| 4035ca1 | https://github.com/nodejs/node/commit/4035ca16c512eac0c58fbb0ba0053b52cd91e437 |
|
Compare
| https://github.com/nodejs/node/compare/4864cb0038b4081bc956551bafe8b326ec64050c..4035ca16c512eac0c58fbb0ba0053b52cd91e437 |
| December 3, 2018 18:33 | https://github.com/nodejs/node/pull/24678#event-2002235838 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Dec 3, 2018 | https://github.com/nodejs/node/pull/24678#issuecomment-443883294 |
| #24681 | https://github.com/nodejs/node/pull/24681 |
| Please reload this page | https://github.com/nodejs/node/pull/24678 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Dec 7, 2018 | https://github.com/nodejs/node/pull/24678#event-2013090370 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| December 7, 2018 18:16 | https://github.com/nodejs/node/pull/24678#event-2013090798 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24678 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
| Please reload this page | https://github.com/nodejs/node/pull/24678 |
|
| https://github.com/sam-github |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/refack |
|
| https://github.com/suresh-srinivas |
|
| https://github.com/danbev |
|
| https://github.com/oyyd |
|
| https://github.com/jagannathBhat |
|
| https://github.com/ofrobots |
|
| https://github.com/shobhitchittora |
|
| https://github.com/mritunjayz |
|
| https://github.com/Westixy |
|
| https://github.com/jeromecovington |
|
| https://github.com/richardlau |
|
| https://github.com/Trott |
|
| https://github.com/prog1dev |
|
| https://github.com/rvagg |
|
| https://github.com/joyeecheung |
|
| https://github.com/starkwang |
|
| https://github.com/warnerp18 |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |