| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6ab27ce7-5713-4c00-6623-b72e437e5e62 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EB28:103D95:204D17:299A73:69903094 |
| html-safe-nonce | 3f57404caa5102aabf1f82d95ef1211a091ecf4cea21cdfa86b2ecb096f0fed7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjI4OjEwM0Q5NToyMDREMTc6Mjk5QTczOjY5OTAzMDk0IiwidmlzaXRvcl9pZCI6IjY4MTM1NzQ3Mjc2MDY0ODEwNDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 45c238c052bdc7f5b0cf9a221a05404ef34d7cbae5127b043a01365888903974 |
| hovercard-subject-tag | pull_request:233913830 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24671/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c0c39938c67d1151e3c483269fa6b8cffa4df120283309e95a41714f5c3e59d3/nodejs/node/pull/24671 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c0c39938c67d1151e3c483269fa6b8cffa4df120283309e95a41714f5c3e59d3/nodejs/node/pull/24671 |
| og:image:alt | Refs: #23934
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ZYSzys |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/24671#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24671 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24671 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/24671 |
| Reload | https://github.com/nodejs/node/pull/24671 |
| Reload | https://github.com/nodejs/node/pull/24671 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/24671 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
709
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ZYSzys | https://github.com/ZYSzys |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| Conversation | https://github.com/nodejs/node/pull/24671 |
| Commits327 (327) | https://github.com/nodejs/node/pull/24671/commits |
| Checks | https://github.com/nodejs/node/pull/24671/checks |
| Files changed | https://github.com/nodejs/node/pull/24671/files |
| [v10.x backport] src: use v8:: for consistency in util | https://github.com/nodejs/node/pull/24671#top |
| ZYSzys | https://github.com/ZYSzys |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
|
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
| Nov 27, 2018 | https://github.com/nodejs/node/pull/24671#issue-384798739 |
| Please reload this page | https://github.com/nodejs/node/pull/24671 |
| #23934 | https://github.com/nodejs/node/pull/23934 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/24671 |
| devsnek | https://github.com/devsnek |
| October 30, 2018 04:43 | https://github.com/nodejs/node/pull/24671#commits-pushed-c39b910 |
|
| https://github.com/devsnek |
|
| https://github.com/MylesBorins |
| bootstrapper: move internalBinding to NativeModule | https://github.com/nodejs/node/pull/24671/commits/c39b910f6e750cacb69c3dc3e2609eaa43ed9f49 |
| c39b910 | https://github.com/nodejs/node/pull/24671/commits/c39b910f6e750cacb69c3dc3e2609eaa43ed9f49 |
| #23025 | https://github.com/nodejs/node/pull/23025 |
| 2a9eb31 | https://github.com/nodejs/node/commit/2a9eb31 |
| #23661 | https://github.com/nodejs/node/pull/23661 |
|
| https://github.com/rxiayth |
|
| https://github.com/MylesBorins |
| lib: migrate to getOptions in loaders.js | https://github.com/nodejs/node/pull/24671/commits/6acc89172f3d7df7d71545be1ad9f29b4f38bc19 |
| 6acc891 | https://github.com/nodejs/node/pull/24671/commits/6acc89172f3d7df7d71545be1ad9f29b4f38bc19 |
| #23455 | https://github.com/nodejs/node/pull/23455 |
|
| https://github.com/madeinjam |
|
| https://github.com/MylesBorins |
| lib: migrate from process.binding to internalBinding | https://github.com/nodejs/node/pull/24671/commits/26f356f7abaead8ee46cff4adac48022e433a8a5 |
| 26f356f | https://github.com/nodejs/node/pull/24671/commits/26f356f7abaead8ee46cff4adac48022e433a8a5 |
| #23586 | https://github.com/nodejs/node/pull/23586 |
|
| https://github.com/annatangzhao |
|
| https://github.com/MylesBorins |
| test: change to arrow functions in send-bad-arguments | https://github.com/nodejs/node/pull/24671/commits/bf20cf8ba25f4697deb32bd86832fb71328d145d |
| bf20cf8 | https://github.com/nodejs/node/pull/24671/commits/bf20cf8ba25f4697deb32bd86832fb71328d145d |
| #23483 | https://github.com/nodejs/node/pull/23483 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| tools: update ESLint to 5.7.0 | https://github.com/nodejs/node/pull/24671/commits/6af2f9f94639c01520b148ba4aefba6f0594fccd |
| 6af2f9f | https://github.com/nodejs/node/pull/24671/commits/6af2f9f94639c01520b148ba4aefba6f0594fccd |
| #23629 | https://github.com/nodejs/node/pull/23629 |
|
| https://github.com/MylesBorins |
| crypto: move field initialization to class | https://github.com/nodejs/node/pull/24671/commits/86a5690e385284be77a7b3b75cf4515bf5faa893 |
| 86a5690 | https://github.com/nodejs/node/pull/24671/commits/86a5690e385284be77a7b3b75cf4515bf5faa893 |
| #23610 | https://github.com/nodejs/node/pull/23610 |
|
| https://github.com/ChALkeR |
|
| https://github.com/MylesBorins |
| doc: wrap links in <> | https://github.com/nodejs/node/pull/24671/commits/5ee0d90b6e1f4d8e3d851d637c1c0a72d9ad6eec |
| 5ee0d90 | https://github.com/nodejs/node/pull/24671/commits/5ee0d90b6e1f4d8e3d851d637c1c0a72d9ad6eec |
| #23359 | https://github.com/nodejs/node/pull/23359 |
|
| https://github.com/ChALkeR |
|
| https://github.com/MylesBorins |
| doc: fix pr-url in repl.md | https://github.com/nodejs/node/pull/24671/commits/43d4977c96954ba317717401792b7f1ffed857c2 |
| 43d4977 | https://github.com/nodejs/node/pull/24671/commits/43d4977c96954ba317717401792b7f1ffed857c2 |
| #23359 | https://github.com/nodejs/node/pull/23359 |
|
| https://github.com/ChALkeR |
|
| https://github.com/MylesBorins |
| doc: use reserved domains for examples in url.md | https://github.com/nodejs/node/pull/24671/commits/272d4faadfb1c2184ef91025e2098f512b20987d |
| 272d4fa | https://github.com/nodejs/node/pull/24671/commits/272d4faadfb1c2184ef91025e2098f512b20987d |
| #23359 | https://github.com/nodejs/node/pull/23359 |
| https://www.iana.org/domains/reserved | https://www.iana.org/domains/reserved |
|
| https://github.com/ChALkeR |
|
| https://github.com/MylesBorins |
| doc: fix url example to match behavior | https://github.com/nodejs/node/pull/24671/commits/00c028fb1dd3f23ee8ea4166a94d45aab2146c34 |
| 00c028f | https://github.com/nodejs/node/pull/24671/commits/00c028fb1dd3f23ee8ea4166a94d45aab2146c34 |
| #23359 | https://github.com/nodejs/node/pull/23359 |
| #22653 | https://github.com/nodejs/node/issues/22653 |
|
| https://github.com/Chrn |
|
| https://github.com/MylesBorins |
| test: fix assertion order | https://github.com/nodejs/node/pull/24671/commits/ac0a03a278d61f7a30d814064c4520f15fb86514 |
| ac0a03a | https://github.com/nodejs/node/pull/24671/commits/ac0a03a278d61f7a30d814064c4520f15fb86514 |
| #23533 | https://github.com/nodejs/node/pull/23533 |
|
| https://github.com/MylesBorins |
| test: fix assertion order test-tls-server-verify | https://github.com/nodejs/node/pull/24671/commits/16175c1b89407e2f99a6eab3ea86725cabed5ec4 |
| 16175c1 | https://github.com/nodejs/node/pull/24671/commits/16175c1b89407e2f99a6eab3ea86725cabed5ec4 |
| #23549 | https://github.com/nodejs/node/pull/23549 |
|
| https://github.com/DrakiaXYZ |
|
| https://github.com/MylesBorins |
| lib: switch to internalBinding for cjs loader | https://github.com/nodejs/node/pull/24671/commits/c634698d5c1bd4a17672e7ff50fc93986d3c69be |
| c634698 | https://github.com/nodejs/node/pull/24671/commits/c634698d5c1bd4a17672e7ff50fc93986d3c69be |
| #23492 | https://github.com/nodejs/node/pull/23492 |
|
| https://github.com/carlrc |
|
| https://github.com/MylesBorins |
| test: fix assertion argument order | https://github.com/nodejs/node/pull/24671/commits/7e56801ddd2c3ac698437787a77c14669ebce3c5 |
| 7e56801 | https://github.com/nodejs/node/pull/24671/commits/7e56801ddd2c3ac698437787a77c14669ebce3c5 |
| #23489 | https://github.com/nodejs/node/pull/23489 |
|
| https://github.com/kaltepeter |
|
| https://github.com/MylesBorins |
| test: rename process.argv[0] to process.execPath, rename ex to err | https://github.com/nodejs/node/pull/24671/commits/58aaa613636368a722e9b6c1fb666c541bc3e7b7 |
| 58aaa61 | https://github.com/nodejs/node/pull/24671/commits/58aaa613636368a722e9b6c1fb666c541bc3e7b7 |
| #23488 | https://github.com/nodejs/node/pull/23488 |
|
| https://github.com/fastereder |
|
| https://github.com/MylesBorins |
| test: fix strictEqual argument order | https://github.com/nodejs/node/pull/24671/commits/01d599cffe9d715a38278660e458615f439e9548 |
| 01d599c | https://github.com/nodejs/node/pull/24671/commits/01d599cffe9d715a38278660e458615f439e9548 |
| #23490 | https://github.com/nodejs/node/pull/23490 |
|
| https://github.com/chrisforrette |
|
| https://github.com/MylesBorins |
| test: modernizing test-dgram-listen-after-bind with arrow functions | https://github.com/nodejs/node/pull/24671/commits/e0a3e238bb0b94b93dda053c5f9dbb881bdab894 |
| e0a3e23 | https://github.com/nodejs/node/pull/24671/commits/e0a3e238bb0b94b93dda053c5f9dbb881bdab894 |
| #23500 | https://github.com/nodejs/node/pull/23500 |
|
| https://github.com/MylesBorins |
| test: fix argument order in asserts | https://github.com/nodejs/node/pull/24671/commits/13afb68e8a8b2dfec221c2a05e23f32151a1e8c6 |
| 13afb68 | https://github.com/nodejs/node/pull/24671/commits/13afb68e8a8b2dfec221c2a05e23f32151a1e8c6 |
| #23499 | https://github.com/nodejs/node/pull/23499 |
|
| https://github.com/jennazee |
|
| https://github.com/MylesBorins |
| test: use arrow functions in test-exception-handler | https://github.com/nodejs/node/pull/24671/commits/627e3ad241788270224f7877073cf91825cb5030 |
| 627e3ad | https://github.com/nodejs/node/pull/24671/commits/627e3ad241788270224f7877073cf91825cb5030 |
| #23498 | https://github.com/nodejs/node/pull/23498 |
|
| https://github.com/MylesBorins |
| lib: removed unused variable | https://github.com/nodejs/node/pull/24671/commits/5a0b9faab8caa3299e5c2d70616dec14370aa7d2 |
| 5a0b9fa | https://github.com/nodejs/node/pull/24671/commits/5a0b9faab8caa3299e5c2d70616dec14370aa7d2 |
| #23497 | https://github.com/nodejs/node/pull/23497 |
|
| https://github.com/ggoforth |
|
| https://github.com/MylesBorins |
| test: modernized test to use arrow functions | https://github.com/nodejs/node/pull/24671/commits/f1fb2bea5e76d313a39deab032dc483810a992a6 |
| f1fb2be | https://github.com/nodejs/node/pull/24671/commits/f1fb2bea5e76d313a39deab032dc483810a992a6 |
| #23496 | https://github.com/nodejs/node/pull/23496 |
|
| https://github.com/scabhi |
|
| https://github.com/MylesBorins |
| test: reversed arguments in strictqual to reflect documentation | https://github.com/nodejs/node/pull/24671/commits/e9f17464a836b648abafd48c67069cda99913624 |
| e9f1746 | https://github.com/nodejs/node/pull/24671/commits/e9f17464a836b648abafd48c67069cda99913624 |
| #23494 | https://github.com/nodejs/node/pull/23494 |
|
| https://github.com/RobertMonks |
|
| https://github.com/MylesBorins |
| test: update function keywords to fat arrows | https://github.com/nodejs/node/pull/24671/commits/fd5290e68cfa9571b0fa4b5beea7f36f7a81a186 |
| fd5290e | https://github.com/nodejs/node/pull/24671/commits/fd5290e68cfa9571b0fa4b5beea7f36f7a81a186 |
| #23493 | https://github.com/nodejs/node/pull/23493 |
|
| https://github.com/maccuaa |
|
| https://github.com/MylesBorins |
| test: fix ordering of assertion values | https://github.com/nodejs/node/pull/24671/commits/d156d093ff713b2c2b69c9c82205ce8e37bfb4bf |
| d156d09 | https://github.com/nodejs/node/pull/24671/commits/d156d093ff713b2c2b69c9c82205ce8e37bfb4bf |
|
| https://github.com/a0viedo |
|
| https://github.com/MylesBorins |
| test: fix strictEqual assertion arguments | https://github.com/nodejs/node/pull/24671/commits/6f590be5396c4c69acbabcc239e90c8fa89e4d1e |
| 6f590be | https://github.com/nodejs/node/pull/24671/commits/6f590be5396c4c69acbabcc239e90c8fa89e4d1e |
| #23508 | https://github.com/nodejs/node/pull/23508 |
|
| https://github.com/milsosa |
|
| https://github.com/MylesBorins |
| test: fix assertions args order in test/parallel/test-fs-chmod.js | https://github.com/nodejs/node/pull/24671/commits/119fc3abdd8c4b6733542834aa3beb94d04b3b55 |
| 119fc3a | https://github.com/nodejs/node/pull/24671/commits/119fc3abdd8c4b6733542834aa3beb94d04b3b55 |
| #23507 | https://github.com/nodejs/node/pull/23507 |
|
| https://github.com/MylesBorins |
| test: fix argument order in assertions | https://github.com/nodejs/node/pull/24671/commits/d590aa858d733748baa556f9bf7492af2402be23 |
| d590aa8 | https://github.com/nodejs/node/pull/24671/commits/d590aa858d733748baa556f9bf7492af2402be23 |
| #23506 | https://github.com/nodejs/node/pull/23506 |
|
| https://github.com/jfarseneau-wb |
|
| https://github.com/MylesBorins |
| test: put expected assert value in correct place | https://github.com/nodejs/node/pull/24671/commits/23d6932c6146b62f404f74ec93760627c41491a3 |
| 23d6932 | https://github.com/nodejs/node/pull/24671/commits/23d6932c6146b62f404f74ec93760627c41491a3 |
| #23505 | https://github.com/nodejs/node/pull/23505 |
|
| https://github.com/MylesBorins |
| test: modernize test-child-process-flush-stdio | https://github.com/nodejs/node/pull/24671/commits/28b6129a7b2c77a51686c9f90c82728662e622b8 |
| 28b6129 | https://github.com/nodejs/node/pull/24671/commits/28b6129a7b2c77a51686c9f90c82728662e622b8 |
| #23504 | https://github.com/nodejs/node/pull/23504 |
|
| https://github.com/DavidRS91 |
|
| https://github.com/MylesBorins |
| test: properly order test assertion variables | https://github.com/nodejs/node/pull/24671/commits/66c82adb0ecfcef0c669789b3d60452103397baa |
| 66c82ad | https://github.com/nodejs/node/pull/24671/commits/66c82adb0ecfcef0c669789b3d60452103397baa |
| #23503 | https://github.com/nodejs/node/pull/23503 |
| oyyd | https://github.com/oyyd |
| November 26, 2018 20:06 | https://github.com/nodejs/node/pull/24671#commits-pushed-592f5bd |
|
| https://github.com/oyyd |
|
| https://github.com/MylesBorins |
| src: use "constants" string instead of creating new one | https://github.com/nodejs/node/pull/24671/commits/592f5bd49cd57b114c48446238d78afc7e7bb664 |
| 592f5bd | https://github.com/nodejs/node/pull/24671/commits/592f5bd49cd57b114c48446238d78afc7e7bb664 |
| #23894 | https://github.com/nodejs/node/pull/23894 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| build: configure default v8_optimized_debug | https://github.com/nodejs/node/pull/24671/commits/51947a515d3977dab388801888beb43591edac2c |
| 51947a5 | https://github.com/nodejs/node/pull/24671/commits/51947a515d3977dab388801888beb43591edac2c |
| #23704 | https://github.com/nodejs/node/pull/23704 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| deps,v8: fix gypfile bug | https://github.com/nodejs/node/pull/24671/commits/67f5d3052d2d8e451bf3801cab1ab0da1ee719f6 |
| 67f5d30 | https://github.com/nodejs/node/pull/24671/commits/67f5d3052d2d8e451bf3801cab1ab0da1ee719f6 |
| #23704 | https://github.com/nodejs/node/pull/23704 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| build: add -Werror=undefined-inline to clang builds | https://github.com/nodejs/node/pull/24671/commits/bd73da00f2258bf658e043b12bd3e27e21286166 |
| bd73da0 | https://github.com/nodejs/node/pull/24671/commits/bd73da00f2258bf658e043b12bd3e27e21286166 |
| #23961 | https://github.com/nodejs/node/pull/23961 |
| #23954 | https://github.com/nodejs/node/pull/23954 |
| #23910 | https://github.com/nodejs/node/pull/23910 |
| #23880 | https://github.com/nodejs/node/pull/23880 |
|
| https://github.com/suresh-srinivas |
|
| https://github.com/MylesBorins |
| src: fix fully-static & large-pages combination | https://github.com/nodejs/node/pull/24671/commits/d25e94b795f886a268d4f08b41f65151a331fa14 |
| d25e94b | https://github.com/nodejs/node/pull/24671/commits/d25e94b795f886a268d4f08b41f65151a331fa14 |
| #23906 | https://github.com/nodejs/node/issues/23906 |
| #22079 | https://github.com/nodejs/node/pull/22079 |
| #23964 | https://github.com/nodejs/node/pull/23964 |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
| build: make benchmark/napi all prereq order-only | https://github.com/nodejs/node/pull/24671/commits/74f128a3cd2c43352448eb59ea9e9cff33267573 |
| 74f128a | https://github.com/nodejs/node/pull/24671/commits/74f128a3cd2c43352448eb59ea9e9cff33267573 |
| #23951 | https://github.com/nodejs/node/pull/23951 |
|
| https://github.com/oyyd |
|
| https://github.com/MylesBorins |
| doc: add types and their corresponding return values | https://github.com/nodejs/node/pull/24671/commits/a35e8f1666598a3b5ad72ee4dcc17e833bbcc50e |
| a35e8f1 | https://github.com/nodejs/node/pull/24671/commits/a35e8f1666598a3b5ad72ee4dcc17e833bbcc50e |
| #23998 | https://github.com/nodejs/node/pull/23998 |
|
| https://github.com/jagannathBhat |
|
| https://github.com/MylesBorins |
| doc: improve BUILDING.md | https://github.com/nodejs/node/pull/24671/commits/a9dcf6f0cef58d7d21205fc18302571f3d39d4e7 |
| a9dcf6f | https://github.com/nodejs/node/pull/24671/commits/a9dcf6f0cef58d7d21205fc18302571f3d39d4e7 |
| #23976 | https://github.com/nodejs/node/pull/23976 |
|
| https://github.com/jagannathBhat |
|
| https://github.com/MylesBorins |
| doc: improve COLLABORATOR_GUIDE | https://github.com/nodejs/node/pull/24671/commits/17c2ddd71d32944a726826245b76d82d851031e0 |
| 17c2ddd | https://github.com/nodejs/node/pull/24671/commits/17c2ddd71d32944a726826245b76d82d851031e0 |
| #23977 | https://github.com/nodejs/node/pull/23977 |
|
| https://github.com/ofrobots |
|
| https://github.com/MylesBorins |
| test: fix test-fs-watch-system-limit | https://github.com/nodejs/node/pull/24671/commits/b89297b618483392ca53d8fde82e10179df008a8 |
| b89297b | https://github.com/nodejs/node/pull/24671/commits/b89297b618483392ca53d8fde82e10179df008a8 |
| #23986 | https://github.com/nodejs/node/pull/23986 |
|
| https://github.com/shobhitchittora |
|
| https://github.com/MylesBorins |
| child_process: handle undefined/null for fork() args | https://github.com/nodejs/node/pull/24671/commits/d1ac8029891b964a527c73b1928f5cadfe3ad6ec |
| d1ac802 | https://github.com/nodejs/node/pull/24671/commits/d1ac8029891b964a527c73b1928f5cadfe3ad6ec |
| #22416 | https://github.com/nodejs/node/pull/22416 |
| #20749 | https://github.com/nodejs/node/issues/20749 |
|
| https://github.com/mritunjayz |
|
| https://github.com/MylesBorins |
| test: add property for RangeError in test-buffer-copy | https://github.com/nodejs/node/pull/24671/commits/a15de4876a0a3c014c491086940bac579d88d805 |
| a15de48 | https://github.com/nodejs/node/pull/24671/commits/a15de4876a0a3c014c491086940bac579d88d805 |
| #23968 | https://github.com/nodejs/node/pull/23968 |
|
| https://github.com/Westixy |
|
| https://github.com/MylesBorins |
| test: fix strictEqual arguments order | https://github.com/nodejs/node/pull/24671/commits/31eff105e0ff9f57d4ac45017ed5fe2b79beea63 |
| 31eff10 | https://github.com/nodejs/node/pull/24671/commits/31eff105e0ff9f57d4ac45017ed5fe2b79beea63 |
| #23956 | https://github.com/nodejs/node/pull/23956 |
|
| https://github.com/jeromecovington |
|
| https://github.com/MylesBorins |
| test: assert that invalidcmd throws error code | https://github.com/nodejs/node/pull/24671/commits/203c42002510c12234e6fc63c4cc79457b074d22 |
| 203c420 | https://github.com/nodejs/node/pull/24671/commits/203c42002510c12234e6fc63c4cc79457b074d22 |
| #23942 | https://github.com/nodejs/node/pull/23942 |
|
| https://github.com/richardlau |
|
| https://github.com/MylesBorins |
| tools: update alternative docs versions | https://github.com/nodejs/node/pull/24671/commits/e973b5df74e72b4aefd819a7a6efbfcf48793770 |
| e973b5d | https://github.com/nodejs/node/pull/24671/commits/e973b5df74e72b4aefd819a7a6efbfcf48793770 |
| #23980 | https://github.com/nodejs/node/pull/23980 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: revise CHANGELOG.md text | https://github.com/nodejs/node/pull/24671/commits/5c6d49b48660d4afbcfd9c53284d02d6ebdbc56a |
| 5c6d49b | https://github.com/nodejs/node/pull/24671/commits/5c6d49b48660d4afbcfd9c53284d02d6ebdbc56a |
| #23988 | https://github.com/nodejs/node/pull/23988 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: simplify CODE_OF_CONDUCT.md | https://github.com/nodejs/node/pull/24671/commits/8f782fbe272d84f7219f6b7044dccad49d1060a3 |
| 8f782fb | https://github.com/nodejs/node/pull/24671/commits/8f782fbe272d84f7219f6b7044dccad49d1060a3 |
| #23989 | https://github.com/nodejs/node/pull/23989 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: revise COLLABORATOR_GUIDE.md | https://github.com/nodejs/node/pull/24671/commits/514b53760413d59943e7c6a8bdad9bc0a919687f |
| 514b537 | https://github.com/nodejs/node/pull/24671/commits/514b53760413d59943e7c6a8bdad9bc0a919687f |
| #23990 | https://github.com/nodejs/node/pull/23990 |
|
| https://github.com/jagannathBhat |
|
| https://github.com/MylesBorins |
| doc: address bits of proof reading work | https://github.com/nodejs/node/pull/24671/commits/435e7b467306c59e553d29ef148824a865517914 |
| 435e7b4 | https://github.com/nodejs/node/pull/24671/commits/435e7b467306c59e553d29ef148824a865517914 |
| #23978 | https://github.com/nodejs/node/pull/23978 |
|
| https://github.com/prog1dev |
|
| https://github.com/MylesBorins |
| doc: fix dublication in net.createServer() docs | https://github.com/nodejs/node/pull/24671/commits/a66d8774ac3c22c3d06fb16e65418bd7a6d0b841 |
| a66d877 | https://github.com/nodejs/node/pull/24671/commits/a66d8774ac3c22c3d06fb16e65418bd7a6d0b841 |
| #24026 | https://github.com/nodejs/node/pull/24026 |
|
| https://github.com/ZYSzys |
| src: use v8:: for consistency in util | https://github.com/nodejs/node/pull/24671/commits/d4dfdf11b38e3c0bd345d0280525012d2a2e98bb |
| d4dfdf1 | https://github.com/nodejs/node/pull/24671/commits/d4dfdf11b38e3c0bd345d0280525012d2a2e98bb |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
| Nov 27, 2018 | https://github.com/nodejs/node/pull/24671#event-1989591773 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| force-pushed | https://github.com/nodejs/node/compare/e66c09e459ef969a3d309c894b00b366e8032e1a..391f8bf77956e19364ccddb1ec5255e272aa69e1 |
| e66c09e | https://github.com/nodejs/node/commit/e66c09e459ef969a3d309c894b00b366e8032e1a |
| 391f8bf | https://github.com/nodejs/node/commit/391f8bf77956e19364ccddb1ec5255e272aa69e1 |
|
Compare
| https://github.com/nodejs/node/compare/e66c09e459ef969a3d309c894b00b366e8032e1a..391f8bf77956e19364ccddb1ec5255e272aa69e1 |
| November 28, 2018 00:35 | https://github.com/nodejs/node/pull/24671#event-1991149277 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
| Nov 28, 2018 | https://github.com/nodejs/node/pull/24671#event-1992424498 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/4864cb0038b4081bc956551bafe8b326ec64050c..4035ca16c512eac0c58fbb0ba0053b52cd91e437 |
| 4864cb0 | https://github.com/nodejs/node/commit/4864cb0038b4081bc956551bafe8b326ec64050c |
| 4035ca1 | https://github.com/nodejs/node/commit/4035ca16c512eac0c58fbb0ba0053b52cd91e437 |
|
Compare
| https://github.com/nodejs/node/compare/4864cb0038b4081bc956551bafe8b326ec64050c..4035ca16c512eac0c58fbb0ba0053b52cd91e437 |
| December 3, 2018 18:33 | https://github.com/nodejs/node/pull/24671#event-2002235826 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/24671#event-2023110834 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
| December 13, 2018 02:16 | https://github.com/nodejs/node/pull/24671#event-2023110938 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24671 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Please reload this page | https://github.com/nodejs/node/pull/24671 |
|
| https://github.com/ZYSzys |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/devsnek |
|
| https://github.com/rxiayth |
|
| https://github.com/madeinjam |
|
| https://github.com/annatangzhao |
|
| https://github.com/cjihrig |
|
| https://github.com/ChALkeR |
|
| https://github.com/Chrn |
|
| https://github.com/DrakiaXYZ |
|
| https://github.com/carlrc |
|
| https://github.com/kaltepeter |
|
| https://github.com/fastereder |
|
| https://github.com/chrisforrette |
|
| https://github.com/jennazee |
|
| https://github.com/ggoforth |
|
| https://github.com/scabhi |
|
| https://github.com/RobertMonks |
|
| https://github.com/maccuaa |
|
| https://github.com/a0viedo |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |