René's URL Explorer Experiment


Title: doc: revise accepting-modifications in guide by Trott · Pull Request #24650 · nodejs/node · GitHub

Open Graph Title: doc: revise accepting-modifications in guide by Trott · Pull Request #24650 · nodejs/node

X Title: doc: revise accepting-modifications in guide by Trott · Pull Request #24650 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Revise the "Accepting Modifications" section of the Collaborator Guide. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes documentation is changed or added commit mes...

X Description: Revise the "Accepting Modifications" section of the Collaborator Guide. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes documentation is changed or added co...

Opengraph URL: https://github.com/nodejs/node/pull/24650

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8eb02199-3395-d731-a84c-f4124446f2b3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id80EA:B6C89:7B59F25:ACC509F:6A501F2C
html-safe-noncea54ec557ba28db92de104ceadf5a651fefd67c1cd0af10c9abf862f26cad10dd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEVBOkI2Qzg5OjdCNTlGMjU6QUNDNTA5Rjo2QTUwMUYyQyIsInZpc2l0b3JfaWQiOiI4NDgwMDkxMjM0Njg1MTY1MzU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4c0e9654b146d423b555d5bb16ebd4917217be5f9899a4eb6fb4481697657b8e
hovercard-subject-tagpull_request:233438535
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24650/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/40a3887f7c18fb0cf7299abd6452ec6489e39500d3d443eb8e3414befea41406/nodejs/node/pull/24650
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/40a3887f7c18fb0cf7299abd6452ec6489e39500d3d443eb8e3414befea41406/nodejs/node/pull/24650
og:image:altRevise the "Accepting Modifications" section of the Collaborator Guide. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes documentation is changed or added commit mes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None14f013003d3992e8746116a6f2f55cd2fdaccd329ee0423392831ae051ecb535
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26ee7c1a62943cf19a6fcc1d1ac93ac83465c885
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24650#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24650
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24650
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24650
Reloadhttps://github.com/nodejs/node/pull/24650
Reloadhttps://github.com/nodejs/node/pull/24650
Please reload this pagehttps://github.com/nodejs/node/pull/24650
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24650
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 977 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:acceptinghttps://github.com/Trott/io.js/tree/accepting
Conversationhttps://github.com/nodejs/node/pull/24650
Commits2 (2)https://github.com/nodejs/node/pull/24650/commits
Checkshttps://github.com/nodejs/node/pull/24650/checks
Files changedhttps://github.com/nodejs/node/pull/24650/files
doc: revise accepting-modifications in guidehttps://github.com/nodejs/node/pull/24650#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:acceptinghttps://github.com/Trott/io.js/tree/accepting
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 26, 2018https://github.com/nodejs/node/pull/24650#issue-384174167
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24650
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 26, 2018https://github.com/nodejs/node/pull/24650#issuecomment-441518987
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/24650
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Nov 26, 2018https://github.com/nodejs/node/pull/24650#event-1985839122
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 26, 2018 https://github.com/nodejs/node/pull/24650#pullrequestreview-178317932
View reviewed changes https://github.com/nodejs/node/pull/24650/files
https://github.com/targos
targoshttps://github.com/targos
Nov 26, 2018 https://github.com/nodejs/node/pull/24650#pullrequestreview-178332317
View reviewed changes https://github.com/nodejs/node/pull/24650/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Nov 26, 2018 https://github.com/nodejs/node/pull/24650#pullrequestreview-178335064
View reviewed changes https://github.com/nodejs/node/pull/24650/files
COLLABORATOR_GUIDE.mdhttps://github.com/nodejs/node/pull/24650/files#diff-ea0ecc2df076bab3682fd852974e605206ffbffd6fa35eb05e8e7db428efcf69
Please reload this pagehttps://github.com/nodejs/node/pull/24650
COLLABORATOR_GUIDE.mdhttps://github.com/nodejs/node/pull/24650/files#diff-ea0ecc2df076bab3682fd852974e605206ffbffd6fa35eb05e8e7db428efcf69
richardlauhttps://github.com/richardlau
Nov 26, 2018https://github.com/nodejs/node/pull/24650#discussion_r236296944
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24650
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 26, 2018 https://github.com/nodejs/node/pull/24650#pullrequestreview-178495495
View reviewed changes https://github.com/nodejs/node/pull/24650/files
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 27, 2018 https://github.com/nodejs/node/pull/24650#pullrequestreview-178723917
View reviewed changes https://github.com/nodejs/node/pull/24650/files
https://github.com/Trott
doc: revise accepting-modifications in guidehttps://github.com/nodejs/node/pull/24650/commits/24e7827ad60679240c0f7bc680be1f5ab664f5a8
24e7827https://github.com/nodejs/node/pull/24650/commits/24e7827ad60679240c0f7bc680be1f5ab664f5a8
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/98f53c1d217315ed2025110d13a5322a46ed092f..24e7827ad60679240c0f7bc680be1f5ab664f5a8
98f53c1https://github.com/nodejs/node/commit/98f53c1d217315ed2025110d13a5322a46ed092f
24e7827https://github.com/nodejs/node/commit/24e7827ad60679240c0f7bc680be1f5ab664f5a8
Compare https://github.com/nodejs/node/compare/98f53c1d217315ed2025110d13a5322a46ed092f..24e7827ad60679240c0f7bc680be1f5ab664f5a8
November 28, 2018 03:07https://github.com/nodejs/node/pull/24650#event-1991338340
https://github.com/Trott
fixup! doc: revise accepting-modifications in guidehttps://github.com/nodejs/node/pull/24650/commits/44ca697fe76df32e90d72878b4565bb925221f69
44ca697https://github.com/nodejs/node/pull/24650/commits/44ca697fe76df32e90d72878b4565bb925221f69
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 28, 2018https://github.com/nodejs/node/pull/24650#issuecomment-442303699
@richardlauhttps://github.com/richardlau
Please reload this pagehttps://github.com/nodejs/node/pull/24650
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 28, 2018https://github.com/nodejs/node/pull/24650#issuecomment-442303792
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1702/https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1702/
Please reload this pagehttps://github.com/nodejs/node/pull/24650
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Nov 28, 2018 https://github.com/nodejs/node/pull/24650#pullrequestreview-179112699
View reviewed changes https://github.com/nodejs/node/pull/24650/files/44ca697fe76df32e90d72878b4565bb925221f69
Trotthttps://github.com/Trott
Nov 28, 2018 https://github.com/nodejs/node/pull/24650#ref-commit-7d18e92
https://github.com/Trott
doc: revise accepting-modifications in guidehttps://github.com/Trott/io.js/commit/7d18e922ab093c9c85b365dbc7fd01984316abc3
7d18e92https://github.com/Trott/io.js/commit/7d18e922ab093c9c85b365dbc7fd01984316abc3
nodejs#24650https://github.com/nodejs/node/pull/24650
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 28, 2018https://github.com/nodejs/node/pull/24650#issuecomment-442329976
7d18e92https://github.com/nodejs/node/commit/7d18e922ab093c9c85b365dbc7fd01984316abc3
Please reload this pagehttps://github.com/nodejs/node/pull/24650
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 28, 2018https://github.com/nodejs/node/pull/24650#event-1991517947
targoshttps://github.com/targos
Nov 28, 2018 https://github.com/nodejs/node/pull/24650#ref-commit-85aa030
https://github.com/Trott
https://github.com/targos
doc: revise accepting-modifications in guidehttps://github.com/nodejs/node/commit/85aa03085da5fcf4344950dd581de2b37d6402ff
85aa030https://github.com/nodejs/node/commit/85aa03085da5fcf4344950dd581de2b37d6402ff
#24650https://github.com/nodejs/node/pull/24650
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 5, 2018 https://github.com/nodejs/node/pull/24650#ref-pullrequest-387948820
v11.4.0 proposal #24854 https://github.com/nodejs/node/pull/24854
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261 https://github.com/beevelop/docker-android-nodejs/issues/261
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262 https://github.com/beevelop/docker-android-nodejs/issues/262
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263 https://github.com/beevelop/docker-android-nodejs/issues/263
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264 https://github.com/beevelop/docker-android-nodejs/issues/264
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265 https://github.com/beevelop/docker-android-nodejs/issues/265
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/24650#ref-commit-932ab7b
https://github.com/Trott
https://github.com/refack
doc: revise accepting-modifications in guidehttps://github.com/refack/node/commit/932ab7bd59e7031f81ac091d7c0180527822890c
932ab7bhttps://github.com/refack/node/commit/932ab7bd59e7031f81ac091d7c0180527822890c
nodejs#24650https://github.com/nodejs/node/pull/24650
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/24650#ref-commit-fe698d8
https://github.com/Trott
https://github.com/BethGriggs
doc: revise accepting-modifications in guidehttps://github.com/nodejs/node/commit/fe698d8ca054c21b4757b8cb954757fabcfde4ae
fe698d8https://github.com/nodejs/node/commit/fe698d8ca054c21b4757b8cb954757fabcfde4ae
#24650https://github.com/nodejs/node/pull/24650
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Feb 12, 2019https://github.com/nodejs/node/pull/24650#event-2132206846
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/24650#ref-pullrequest-409543286
v10.15.3 proposal #26063 https://github.com/nodejs/node/pull/26063
rvagghttps://github.com/rvagg
Feb 28, 2019 https://github.com/nodejs/node/pull/24650#ref-commit-be7f1a8
https://github.com/Trott
https://github.com/rvagg
doc: revise accepting-modifications in guidehttps://github.com/nodejs/node/commit/be7f1a8bee9ed886d1cc2d6dfcb92c3a4de272bb
be7f1a8https://github.com/nodejs/node/commit/be7f1a8bee9ed886d1cc2d6dfcb92c3a4de272bb
#24650https://github.com/nodejs/node/pull/24650
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:50https://github.com/nodejs/node/pull/24650#event-5890970393
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24650
https://github.com/fhinkel
fhinkel https://github.com/fhinkel
https://github.com/nodejs/node/pull/24650/files/3a1c1cce73a0a3627cd9ae39ab142d2067086284
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/24650/files/3a1c1cce73a0a3627cd9ae39ab142d2067086284
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/24650/files/3a1c1cce73a0a3627cd9ae39ab142d2067086284
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/24650/files/3a1c1cce73a0a3627cd9ae39ab142d2067086284
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/24650/files/44ca697fe76df32e90d72878b4565bb925221f69
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Please reload this pagehttps://github.com/nodejs/node/pull/24650
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/fhinkel
https://github.com/lpinca
https://github.com/targos
https://github.com/cjihrig
https://github.com/richardlau
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.