René's URL Explorer Experiment


Title: promises: emit unhandled warning immediately by apapirovski · Pull Request #24632 · nodejs/node · GitHub

Open Graph Title: promises: emit unhandled warning immediately by apapirovski · Pull Request #24632 · nodejs/node

X Title: promises: emit unhandled warning immediately by apapirovski · Pull Request #24632 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #24209 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

X Description: Fixes: #24209 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/24632

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5745cc22-0e68-78bf-b9f9-d2c994420dd7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCF6:141FAF:77BEDFD:A832BCB:6A4FF431
html-safe-nonceb6b0f892a0491933da77279b2244a4e1660c51f33966cf3de671ece9c693189f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0Y2OjE0MUZBRjo3N0JFREZEOkE4MzJCQ0I6NkE0RkY0MzEiLCJ2aXNpdG9yX2lkIjoiNDI5NDE3NjY0MTU0OTA3MTQwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd257d843488d847a5fa8d1d5e33dd3b1df9bc14ee454225cf02a0e6e2be431e3
hovercard-subject-tagpull_request:233338025
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24632/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d60538e9b876ad740ce83560769dfc1bc2b2938c0e5eab43566c7bd0ddb24a2d/nodejs/node/pull/24632
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d60538e9b876ad740ce83560769dfc1bc2b2938c0e5eab43566c7bd0ddb24a2d/nodejs/node/pull/24632
og:image:altFixes: #24209 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameapapirovski
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef7e270be010aa4de2871991025fbb97f3afe2bcb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24632#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24632
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24632
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24632
Reloadhttps://github.com/nodejs/node/pull/24632
Reloadhttps://github.com/nodejs/node/pull/24632
Please reload this pagehttps://github.com/nodejs/node/pull/24632
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24632
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 976 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
apapirovskihttps://github.com/apapirovski
nodejs:masterhttps://github.com/nodejs/node/tree/master
apapirovski:fix-promise-rejection-warning-timinghttps://github.com/apapirovski/node/tree/fix-promise-rejection-warning-timing
Conversationhttps://github.com/nodejs/node/pull/24632
Commits1 (1)https://github.com/nodejs/node/pull/24632/commits
Checkshttps://github.com/nodejs/node/pull/24632/checks
Files changedhttps://github.com/nodejs/node/pull/24632/files
promises: emit unhandled warning immediatelyhttps://github.com/nodejs/node/pull/24632#top
apapirovskihttps://github.com/apapirovski
nodejs:masterhttps://github.com/nodejs/node/tree/master
apapirovski:fix-promise-rejection-warning-timinghttps://github.com/apapirovski/node/tree/fix-promise-rejection-warning-timing
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Nov 24, 2018https://github.com/nodejs/node/pull/24632#issue-384018601
Please reload this pagehttps://github.com/nodejs/node/pull/24632
#24209https://github.com/nodejs/node/issues/24209
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24632
https://github.com/apapirovski
promises: emit unhandled warning immediatelyhttps://github.com/nodejs/node/pull/24632/commits/13a641375803fc58b6f2671f78dce79ab0ebcf2a
13a6413https://github.com/nodejs/node/pull/24632/commits/13a641375803fc58b6f2671f78dce79ab0ebcf2a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 24, 2018https://github.com/nodejs/node/pull/24632#issuecomment-441392940
@apapirovskihttps://github.com/apapirovski
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1697/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1697/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24632
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Nov 24, 2018https://github.com/nodejs/node/pull/24632#event-1985126375
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Nov 24, 2018 https://github.com/nodejs/node/pull/24632#ref-issue-378076739
regression: UnhandledPromiseRejection is not fired until process is terminated #24209 https://github.com/nodejs/node/issues/24209
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 25, 2018https://github.com/nodejs/node/pull/24632#issuecomment-441409736
https://ci.nodejs.org/job/node-test-pull-request/18947/https://ci.nodejs.org/job/node-test-pull-request/18947/
Please reload this pagehttps://github.com/nodejs/node/pull/24632
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 25, 2018 https://github.com/nodejs/node/pull/24632#pullrequestreview-178067527
View reviewed changes https://github.com/nodejs/node/pull/24632/files/13a641375803fc58b6f2671f78dce79ab0ebcf2a
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 25, 2018 https://github.com/nodejs/node/pull/24632#pullrequestreview-178076787
View reviewed changes https://github.com/nodejs/node/pull/24632/files/13a641375803fc58b6f2671f78dce79ab0ebcf2a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 25, 2018https://github.com/nodejs/node/pull/24632#issuecomment-441431342
https://ci.nodejs.org/job/node-test-pull-request/18960/https://ci.nodejs.org/job/node-test-pull-request/18960/
Please reload this pagehttps://github.com/nodejs/node/pull/24632
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 25, 2018https://github.com/nodejs/node/pull/24632#event-1985330779
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Nov 27, 2018 https://github.com/nodejs/node/pull/24632#pullrequestreview-178724470
View reviewed changes https://github.com/nodejs/node/pull/24632/files/13a641375803fc58b6f2671f78dce79ab0ebcf2a
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 28, 2018https://github.com/nodejs/node/pull/24632#issuecomment-442312829
https://ci.nodejs.org/job/node-test-pull-request/18974/https://ci.nodejs.org/job/node-test-pull-request/18974/
Please reload this pagehttps://github.com/nodejs/node/pull/24632
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 28, 2018https://github.com/nodejs/node/pull/24632#issuecomment-442316631
https://ci.nodejs.org/job/node-test-pull-request/18979/https://ci.nodejs.org/job/node-test-pull-request/18979/
Please reload this pagehttps://github.com/nodejs/node/pull/24632
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 28, 2018https://github.com/nodejs/node/pull/24632#issuecomment-442333416
3ce9305https://github.com/nodejs/node/commit/3ce9305a705a0ea521a82afb0e4a2bef079d9548
Please reload this pagehttps://github.com/nodejs/node/pull/24632
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 28, 2018https://github.com/nodejs/node/pull/24632#event-1991542460
Trotthttps://github.com/Trott
Nov 28, 2018 https://github.com/nodejs/node/pull/24632#ref-commit-3ce9305
https://github.com/apapirovski
https://github.com/Trott
process: emit unhandled warning immediatelyhttps://github.com/Trott/io.js/commit/3ce9305a705a0ea521a82afb0e4a2bef079d9548
3ce9305https://github.com/Trott/io.js/commit/3ce9305a705a0ea521a82afb0e4a2bef079d9548
nodejs#24632https://github.com/nodejs/node/pull/24632
nodejs#24209https://github.com/nodejs/node/issues/24209
targoshttps://github.com/targos
Nov 28, 2018 https://github.com/nodejs/node/pull/24632#ref-commit-81b42d2
https://github.com/apapirovski
https://github.com/targos
process: emit unhandled warning immediatelyhttps://github.com/nodejs/node/commit/81b42d225881199ce875b06fbe507a727ba50190
81b42d2https://github.com/nodejs/node/commit/81b42d225881199ce875b06fbe507a727ba50190
#24632https://github.com/nodejs/node/pull/24632
#24209https://github.com/nodejs/node/issues/24209
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 5, 2018 https://github.com/nodejs/node/pull/24632#ref-pullrequest-387948820
v11.4.0 proposal #24854 https://github.com/nodejs/node/pull/24854
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261 https://github.com/beevelop/docker-android-nodejs/issues/261
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262 https://github.com/beevelop/docker-android-nodejs/issues/262
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263 https://github.com/beevelop/docker-android-nodejs/issues/263
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264 https://github.com/beevelop/docker-android-nodejs/issues/264
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265 https://github.com/beevelop/docker-android-nodejs/issues/265
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/24632#ref-commit-2650643
https://github.com/apapirovski
https://github.com/refack
process: emit unhandled warning immediatelyhttps://github.com/refack/node/commit/2650643e8986deddeda1ac458d64173e8e10d158
2650643https://github.com/refack/node/commit/2650643e8986deddeda1ac458d64173e8e10d158
nodejs#24632https://github.com/nodejs/node/pull/24632
nodejs#24209https://github.com/nodejs/node/issues/24209
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/24632#ref-commit-5bca4c7
https://github.com/apapirovski
https://github.com/BethGriggs
process: emit unhandled warning immediatelyhttps://github.com/nodejs/node/commit/5bca4c7cc0c7e712d70347fa84f8b015f0c5fadd
5bca4c7https://github.com/nodejs/node/commit/5bca4c7cc0c7e712d70347fa84f8b015f0c5fadd
#24632https://github.com/nodejs/node/pull/24632
#24209https://github.com/nodejs/node/issues/24209
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Feb 12, 2019https://github.com/nodejs/node/pull/24632#event-2132349107
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/24632#ref-pullrequest-409543286
v10.15.3 proposal #26063 https://github.com/nodejs/node/pull/26063
rvagghttps://github.com/rvagg
Feb 28, 2019 https://github.com/nodejs/node/pull/24632#ref-commit-664eed6
https://github.com/apapirovski
https://github.com/rvagg
process: emit unhandled warning immediatelyhttps://github.com/nodejs/node/commit/664eed6274003000ded4c7495d12fe2454fa4c30
664eed6https://github.com/nodejs/node/commit/664eed6274003000ded4c7495d12fe2454fa4c30
#24632https://github.com/nodejs/node/pull/24632
#24209https://github.com/nodejs/node/issues/24209
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24632
https://github.com/fhinkel
fhinkel https://github.com/fhinkel
https://github.com/nodejs/node/pull/24632/files/13a641375803fc58b6f2671f78dce79ab0ebcf2a
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/24632/files/13a641375803fc58b6f2671f78dce79ab0ebcf2a
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/24632/files/13a641375803fc58b6f2671f78dce79ab0ebcf2a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
regression: UnhandledPromiseRejection is not fired until process is terminated https://github.com/nodejs/node/issues/24209
Please reload this pagehttps://github.com/nodejs/node/pull/24632
https://github.com/apapirovski
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/addaleax
https://github.com/fhinkel
https://github.com/benjamingr
https://github.com/devsnek
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.