| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:617b62a7-9724-e053-0f6b-9e92d1dd131d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C652:C8AE2:784A1B9:A920298:6A50234E |
| html-safe-nonce | 9dfc6ec4024f393b1c14ffbcec5ee37d284404963655d51f8a9142ca4272577e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjUyOkM4QUUyOjc4NEExQjk6QTkyMDI5ODo2QTUwMjM0RSIsInZpc2l0b3JfaWQiOiIyMTYzMDI3NDMyNzgwNjA0MjM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0ca9d9cd1fd7eff9e5d84413589324c3317477160492efb2d6d16be4d5e3db65 |
| hovercard-subject-tag | pull_request:233305621 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24594/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6a639f1c987d377b4386a08d4e7adc2f6a6b5c08c8b3aaad1ef762d0b038b5e2/nodejs/node/pull/24594 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6a639f1c987d377b4386a08d4e7adc2f6a6b5c08c8b3aaad1ef762d0b038b5e2/nodejs/node/pull/24594 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hyokenmi |
| hostname | github.com |
| expected-hostname | github.com |
| None | a08040246389072795e3b4e7b33c6d9a0c564eee02e829a809326d67c418b069 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d1b91b18e7330fc458dfd824c61eaed7daa830d6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/24594#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24594 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24594 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/24594 |
| Reload | https://github.com/nodejs/node/pull/24594 |
| Reload | https://github.com/nodejs/node/pull/24594 |
| Please reload this page | https://github.com/nodejs/node/pull/24594 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/24594 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
977
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| hyokenmi | https://github.com/hyokenmi |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| hyokenmi:bugfix-test-child-process-cwd | https://github.com/hyokenmi/node/tree/bugfix-test-child-process-cwd |
| Conversation | https://github.com/nodejs/node/pull/24594 |
| Commits1 (1) | https://github.com/nodejs/node/pull/24594/commits |
| Checks | https://github.com/nodejs/node/pull/24594/checks |
| Files changed | https://github.com/nodejs/node/pull/24594/files |
| test: fix assert.strictEqual | https://github.com/nodejs/node/pull/24594#top |
| hyokenmi | https://github.com/hyokenmi |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| hyokenmi:bugfix-test-child-process-cwd | https://github.com/hyokenmi/node/tree/bugfix-test-child-process-cwd |
|
| https://github.com/hyokenmi |
| hyokenmi | https://github.com/hyokenmi |
| Nov 24, 2018 | https://github.com/nodejs/node/pull/24594#issue-383966684 |
| Please reload this page | https://github.com/nodejs/node/pull/24594 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/24594 |
| test: fix assert.strictEqual | https://github.com/nodejs/node/pull/24594/commits/ad01b3fe7e9e458df136e1bdf7ed148c2a5a928a |
| ad01b3f | https://github.com/nodejs/node/pull/24594/commits/ad01b3fe7e9e458df136e1bdf7ed148c2a5a928a |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 24, 2018 | https://github.com/nodejs/node/pull/24594#event-1984898584 |
| https://github.com/ronkorving |
| ronkorving | https://github.com/ronkorving |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 24, 2018 | https://github.com/nodejs/node/pull/24594#event-1984899097 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 24, 2018
| https://github.com/nodejs/node/pull/24594#pullrequestreview-178042924 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24594/files/ad01b3fe7e9e458df136e1bdf7ed148c2a5a928a |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 24, 2018 | https://github.com/nodejs/node/pull/24594#issuecomment-441349969 |
| #24592 | https://github.com/nodejs/node/pull/24592 |
| @na9amura | https://github.com/na9amura |
| Please reload this page | https://github.com/nodejs/node/pull/24594 |
| https://github.com/Leko |
| Leko | https://github.com/Leko |
|
Nov 24, 2018
| https://github.com/nodejs/node/pull/24594#pullrequestreview-178044112 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24594/files/ad01b3fe7e9e458df136e1bdf7ed148c2a5a928a |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 24, 2018
| https://github.com/nodejs/node/pull/24594#pullrequestreview-178048664 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24594/files/ad01b3fe7e9e458df136e1bdf7ed148c2a5a928a |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 25, 2018 | https://github.com/nodejs/node/pull/24594#issuecomment-441410006 |
| https://ci.nodejs.org/job/node-test-pull-request/18948/ | https://ci.nodejs.org/job/node-test-pull-request/18948/ |
| Please reload this page | https://github.com/nodejs/node/pull/24594 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 25, 2018 | https://github.com/nodejs/node/pull/24594#event-1985214579 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 25, 2018 | https://github.com/nodejs/node/pull/24594#issuecomment-441412579 |
| @24592 | https://github.com/24592 |
| #24610 | https://github.com/nodejs/node/pull/24610 |
| Please reload this page | https://github.com/nodejs/node/pull/24594 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 28, 2018 | https://github.com/nodejs/node/pull/24594#issuecomment-442308395 |
| https://ci.nodejs.org/job/node-test-pull-request/18971/ | https://ci.nodejs.org/job/node-test-pull-request/18971/ |
| Please reload this page | https://github.com/nodejs/node/pull/24594 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 28, 2018 | https://github.com/nodejs/node/pull/24594#issuecomment-442316223 |
| https://ci.nodejs.org/job/node-test-pull-request/18976/ | https://ci.nodejs.org/job/node-test-pull-request/18976/ |
| Please reload this page | https://github.com/nodejs/node/pull/24594 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 28, 2018 | https://github.com/nodejs/node/pull/24594#issuecomment-442318350 |
| https://ci.nodejs.org/job/node-test-pull-request/18981/ | https://ci.nodejs.org/job/node-test-pull-request/18981/ |
| Please reload this page | https://github.com/nodejs/node/pull/24594 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 28, 2018 | https://github.com/nodejs/node/pull/24594#issuecomment-442327802 |
| 46094e4 | https://github.com/nodejs/node/commit/46094e42c362979d69bbad901e8c626d5af29ee1 |
| https://www.nodetodo.org/next-steps/ | https://www.nodetodo.org/next-steps/ |
| Please reload this page | https://github.com/nodejs/node/pull/24594 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 28, 2018 | https://github.com/nodejs/node/pull/24594#event-1991503167 |
| Trott | https://github.com/Trott |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/24594#ref-commit-46094e4 |
|
| https://github.com/Trott |
| test: fix argument order in assert.strictEqual | https://github.com/Trott/io.js/commit/46094e42c362979d69bbad901e8c626d5af29ee1 |
| 46094e4 | https://github.com/Trott/io.js/commit/46094e42c362979d69bbad901e8c626d5af29ee1 |
| nodejs#24594 | https://github.com/nodejs/node/pull/24594 |
| https://github.com/hyokenmi |
| hyokenmi | https://github.com/hyokenmi |
| November 28, 2018 11:57 | https://github.com/nodejs/node/pull/24594#event-1992229644 |
| targos | https://github.com/targos |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/24594#ref-commit-3b99191 |
|
| https://github.com/targos |
| test: fix argument order in assert.strictEqual | https://github.com/nodejs/node/commit/3b99191e1392e1b742f885c2dd996062766a1de5 |
| 3b99191 | https://github.com/nodejs/node/commit/3b99191e1392e1b742f885c2dd996062766a1de5 |
| #24594 | https://github.com/nodejs/node/pull/24594 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 5, 2018
| https://github.com/nodejs/node/pull/24594#ref-pullrequest-387948820 |
|
v11.4.0 proposal
#24854
| https://github.com/nodejs/node/pull/24854 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#261
| https://github.com/beevelop/docker-android-nodejs/issues/261 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#262
| https://github.com/beevelop/docker-android-nodejs/issues/262 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#263
| https://github.com/beevelop/docker-android-nodejs/issues/263 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#264
| https://github.com/beevelop/docker-android-nodejs/issues/264 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#265
| https://github.com/beevelop/docker-android-nodejs/issues/265 |
| refack | https://github.com/refack |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/24594#ref-commit-879a8c3 |
|
| https://github.com/refack |
| test: fix argument order in assert.strictEqual | https://github.com/refack/node/commit/879a8c3f3746e0d6570a0d93021f4de9f42320ad |
| 879a8c3 | https://github.com/refack/node/commit/879a8c3f3746e0d6570a0d93021f4de9f42320ad |
| nodejs#24594 | https://github.com/nodejs/node/pull/24594 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/24594#ref-commit-ec7bd18 |
|
| https://github.com/BethGriggs |
| test: fix argument order in assert.strictEqual | https://github.com/nodejs/node/commit/ec7bd1814667afae800ade7286b902e181d541ad |
| ec7bd18 | https://github.com/nodejs/node/commit/ec7bd1814667afae800ade7286b902e181d541ad |
| #24594 | https://github.com/nodejs/node/pull/24594 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/24594#event-2132253862 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/24594#ref-pullrequest-409543286 |
|
v10.15.3 proposal
#26063
| https://github.com/nodejs/node/pull/26063 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/24594#ref-commit-73cfbb0 |
|
| https://github.com/rvagg |
| test: fix argument order in assert.strictEqual | https://github.com/nodejs/node/commit/73cfbb0259b98d13a53cda57f8b8ba8c8d2856cd |
| 73cfbb0 | https://github.com/nodejs/node/commit/73cfbb0259b98d13a53cda57f8b8ba8c8d2856cd |
| #24594 | https://github.com/nodejs/node/pull/24594 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24594 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/24594/files/ad01b3fe7e9e458df136e1bdf7ed148c2a5a928a |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/24594/files/ad01b3fe7e9e458df136e1bdf7ed148c2a5a928a |
|
| https://github.com/Leko |
|
Leko
| https://github.com/Leko |
|
| https://github.com/nodejs/node/pull/24594/files/ad01b3fe7e9e458df136e1bdf7ed148c2a5a928a |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/24594 |
|
| https://github.com/hyokenmi |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/Leko |
|
| https://github.com/cjihrig |
|
| https://github.com/ronkorving |
|
| https://github.com/BethGriggs |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |