| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:faa85cc0-93a4-5bdd-daee-8a263af4b9b5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C90C:1A9D32:9E5B8:CDFFA:6991C35A |
| html-safe-nonce | 404b5af284092ce3cff73733f241bf7930d3e0f7a491e139935069b37ce6f9d7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTBDOjFBOUQzMjo5RTVCODpDREZGQTo2OTkxQzM1QSIsInZpc2l0b3JfaWQiOiI0NDc4MTkzMDU5MzM5ODEzNzIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c239ffe4eb8e571ecc8261d8efdc9311296e02c73aadad7864eb28ef0c0b9977 |
| hovercard-subject-tag | pull_request:232381071 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24520/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0e9a8da1235b022fc8c55c33eb749dc508fdb8ecb8060231f2fcd1ede853839e/nodejs/node/pull/24520 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0e9a8da1235b022fc8c55c33eb749dc508fdb8ecb8060231f2fcd1ede853839e/nodejs/node/pull/24520 |
| og:image:alt | Alternative to #24004
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | refack |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/24520#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24520 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24520 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/24520 |
| Reload | https://github.com/nodejs/node/pull/24520 |
| Reload | https://github.com/nodejs/node/pull/24520 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
713
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| refack:fixmaccppcoverage | https://github.com/refack/node/tree/fixmaccppcoverage |
| Conversation | https://github.com/nodejs/node/pull/24520 |
| Commits1 (1) | https://github.com/nodejs/node/pull/24520/commits |
| Checks | https://github.com/nodejs/node/pull/24520/checks |
| Files changed | https://github.com/nodejs/node/pull/24520/files |
| build: fix c++ code coverage on macOS | https://github.com/nodejs/node/pull/24520#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| refack:fixmaccppcoverage | https://github.com/refack/node/tree/fixmaccppcoverage |
|
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24520#issue-382745095 |
| #24004 | https://github.com/nodejs/node/pull/24004 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24520#issuecomment-440336539 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24520#event-1977839378 |
| https://github.com/refack |
| refack | https://github.com/refack |
| evanlucas | https://github.com/evanlucas |
| lundibundi | https://github.com/lundibundi |
| yhwang | https://github.com/yhwang |
| November 20, 2018 16:28 | https://github.com/nodejs/node/pull/24520#event-1977839560 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 20, 2018
| https://github.com/nodejs/node/pull/24520#ref-pullrequest-376119837 |
|
tools: fix c++ code coverage on macOS
#24004
| https://github.com/nodejs/node/pull/24004 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24520#issuecomment-440337844 |
| https://ci.nodejs.org/job/node-test-pull-request/18809/ | https://ci.nodejs.org/job/node-test-pull-request/18809/ |
| https://ci.nodejs.org/job/node-test-commit-linux-coverage/841/ | https://ci.nodejs.org/job/node-test-commit-linux-coverage/841/ |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
macos
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amacos |
|
coverage
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acoverage |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24520#event-1977865222 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 20, 2018
| https://github.com/nodejs/node/pull/24520#pullrequestreview-176862288 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24520/files |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24520#issuecomment-440339926 |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24520#event-1977879944 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24520#issuecomment-440359084 |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
| https://ci.nodejs.org/computer/test-macstadium-macos10.12-x64-1/ | https://ci.nodejs.org/computer/test-macstadium-macos10.12-x64-1/ |
| node.zip | https://github.com/nodejs/node/files/2600845/node.zip |
| nyc.zip | https://github.com/nodejs/node/files/2600860/nyc.zip |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 26, 2018 | https://github.com/nodejs/node/pull/24520#issuecomment-441810144 |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 1, 2018 | https://github.com/nodejs/node/pull/24520#issuecomment-443401622 |
| https://ci.nodejs.org/job/node-test-pull-request/19111/ | https://ci.nodejs.org/job/node-test-pull-request/19111/ |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 1, 2018 | https://github.com/nodejs/node/pull/24520#issuecomment-443403733 |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
| https://ci.nodejs.org/job/node-test-pull-request/19115/ | https://ci.nodejs.org/job/node-test-pull-request/19115/ |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
|
| https://github.com/refack |
|
| https://github.com/Trott |
| build: fix c++ code coverage on macOS | https://github.com/nodejs/node/pull/24520/commits/eb6741b15ebd93ffdd71e87cbc1350b9e94ef222 |
| eb6741b | https://github.com/nodejs/node/pull/24520/commits/eb6741b15ebd93ffdd71e87cbc1350b9e94ef222 |
| nodejs#24520 | https://github.com/nodejs/node/pull/24520 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/2818472b5f9c74dd077965abbfc7070aeb95dc8d..eb6741b15ebd93ffdd71e87cbc1350b9e94ef222 |
| 2818472 | https://github.com/nodejs/node/commit/2818472b5f9c74dd077965abbfc7070aeb95dc8d |
| eb6741b | https://github.com/nodejs/node/commit/eb6741b15ebd93ffdd71e87cbc1350b9e94ef222 |
|
Compare
| https://github.com/nodejs/node/compare/2818472b5f9c74dd077965abbfc7070aeb95dc8d..eb6741b15ebd93ffdd71e87cbc1350b9e94ef222 |
| December 1, 2018 15:22 | https://github.com/nodejs/node/pull/24520#event-1999549231 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| eb6741b | https://github.com/nodejs/node/commit/eb6741b15ebd93ffdd71e87cbc1350b9e94ef222 |
| Dec 1, 2018 | https://github.com/nodejs/node/pull/24520#event-1999549823 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 1, 2018 | https://github.com/nodejs/node/pull/24520#issuecomment-443433974 |
| eb6741b | https://github.com/nodejs/node/commit/eb6741b15ebd93ffdd71e87cbc1350b9e94ef222 |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 5, 2018
| https://github.com/nodejs/node/pull/24520#ref-commit-3fe4498 |
|
| https://github.com/refack |
|
| https://github.com/BridgeAR |
| build: fix c++ code coverage on macOS | https://github.com/nodejs/node/commit/3fe4498fe1e6335637b7bacec01c419f0a6f09fa |
| 3fe4498 | https://github.com/nodejs/node/commit/3fe4498fe1e6335637b7bacec01c419f0a6f09fa |
| #24520 | https://github.com/nodejs/node/pull/24520 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 5, 2018
| https://github.com/nodejs/node/pull/24520#ref-pullrequest-387948820 |
|
v11.4.0 proposal
#24854
| https://github.com/nodejs/node/pull/24854 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#261
| https://github.com/beevelop/docker-android-nodejs/issues/261 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#262
| https://github.com/beevelop/docker-android-nodejs/issues/262 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#263
| https://github.com/beevelop/docker-android-nodejs/issues/263 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#264
| https://github.com/beevelop/docker-android-nodejs/issues/264 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#265
| https://github.com/beevelop/docker-android-nodejs/issues/265 |
| https://github.com/refack |
| refack | https://github.com/refack |
| December 21, 2018 01:31 | https://github.com/nodejs/node/pull/24520#event-2039792565 |
| https://github.com/boneskull |
| boneskull | https://github.com/boneskull |
|
Dec 22, 2018
| https://github.com/nodejs/node/pull/24520#ref-issue-301027060 |
|
Error while running coverage
#19057
| https://github.com/nodejs/node/issues/19057 |
| refack | https://github.com/refack |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/24520#ref-commit-d12c1cd |
|
| https://github.com/refack |
| build: fix c++ code coverage on macOS | https://github.com/refack/node/commit/d12c1cdf55377c9e8305d0b28f63ad07fe046b8f |
| d12c1cd | https://github.com/refack/node/commit/d12c1cdf55377c9e8305d0b28f63ad07fe046b8f |
| nodejs#24520 | https://github.com/nodejs/node/pull/24520 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/24520#ref-commit-c57008e |
|
| https://github.com/refack |
|
| https://github.com/BethGriggs |
| build: fix c++ code coverage on macOS | https://github.com/nodejs/node/commit/c57008e5499c739273bfcb7a6175f92a8a44e755 |
| c57008e | https://github.com/nodejs/node/commit/c57008e5499c739273bfcb7a6175f92a8a44e755 |
| #24520 | https://github.com/nodejs/node/pull/24520 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/24520#event-2134156061 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/24520#ref-pullrequest-409543286 |
|
v10.15.3 proposal
#26063
| https://github.com/nodejs/node/pull/26063 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/24520#ref-commit-9b55ee2 |
|
| https://github.com/refack |
|
| https://github.com/rvagg |
| build: fix c++ code coverage on macOS | https://github.com/nodejs/node/commit/9b55ee294bdc1da7dc28f9bc2bcc05ead8b7def2 |
| 9b55ee2 | https://github.com/nodejs/node/commit/9b55ee294bdc1da7dc28f9bc2bcc05ead8b7def2 |
| #24520 | https://github.com/nodejs/node/pull/24520 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Mar 11, 2019 | https://github.com/nodejs/node/pull/24520#event-2192631670 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24520 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/24520/files/2818472b5f9c74dd077965abbfc7070aeb95dc8d |
|
| https://github.com/lundibundi |
|
lundibundi
| https://github.com/lundibundi |
|
| https://github.com/yhwang |
|
yhwang
| https://github.com/yhwang |
|
| https://github.com/evanlucas |
|
evanlucas
| https://github.com/evanlucas |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
coverage
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acoverage |
|
macos
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amacos |
| Please reload this page | https://github.com/nodejs/node/pull/24520 |
|
| https://github.com/refack |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/BethGriggs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |