| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c4662f60-b38b-729d-3da0-a4d43cefd332 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D874:1960:564A7BF:797C412:6A506E98 |
| html-safe-nonce | ff7bf321bce8dfac449981ef55cfa502af7ba44b05558dc184f9de426a24773c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODc0OjE5NjA6NTY0QTdCRjo3OTdDNDEyOjZBNTA2RTk4IiwidmlzaXRvcl9pZCI6IjM4NjYwMTEwMTk5NzE0MTY1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cdb753a75dced225d7014b2a178a56a693158d6cc03aa3dbbeff27cbfb97d28c |
| hovercard-subject-tag | pull_request:231934589 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24486/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0e9a8da1235b022fc8c55c33eb749dc508fdb8ecb8060231f2fcd1ede853839e/nodejs/node/pull/24486 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0e9a8da1235b022fc8c55c33eb749dc508fdb8ecb8060231f2fcd1ede853839e/nodejs/node/pull/24486 |
| og:image:alt | A subset of #23669 to simplify the review process. @refack @addaleax
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is cha... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cclauss |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/24486#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24486 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24486 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/24486 |
| Reload | https://github.com/nodejs/node/pull/24486 |
| Reload | https://github.com/nodejs/node/pull/24486 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
979
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cclauss:tools-print-function | https://github.com/cclauss/node/tree/tools-print-function |
| Conversation | https://github.com/nodejs/node/pull/24486 |
| Commits1 (1) | https://github.com/nodejs/node/pull/24486/commits |
| Checks | https://github.com/nodejs/node/pull/24486/checks |
| Files changed | https://github.com/nodejs/node/pull/24486/files |
| tools: Use print() function on both Python 2 and 3 | https://github.com/nodejs/node/pull/24486#top |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cclauss:tools-print-function | https://github.com/cclauss/node/tree/tools-print-function |
|
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/24486#issue-382165285 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| #23669 | https://github.com/nodejs/node/pull/23669 |
| @refack | https://github.com/refack |
| @addaleax | https://github.com/addaleax |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/24486#event-1974337236 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 19, 2018
| https://github.com/nodejs/node/pull/24486#pullrequestreview-176248350 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24486/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-439858491 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-439862538 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| @addaleax | https://github.com/addaleax |
| Working on that | https://github.com/nodejs/node-gyp/pulls?q=is%3Apr+author%3Acclauss+is%3Aclosed |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/6651436c8f22452633c65e282f2e51f5ed55eda0..d0b33fb17589c3382f1e525dd0865562cf9a24ca |
| 6651436 | https://github.com/nodejs/node/commit/6651436c8f22452633c65e282f2e51f5ed55eda0 |
| d0b33fb | https://github.com/nodejs/node/commit/d0b33fb17589c3382f1e525dd0865562cf9a24ca |
|
Compare
| https://github.com/nodejs/node/compare/6651436c8f22452633c65e282f2e51f5ed55eda0..d0b33fb17589c3382f1e525dd0865562cf9a24ca |
| November 19, 2018 11:55 | https://github.com/nodejs/node/pull/24486#event-1974427673 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-439904403 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 19, 2018
| https://github.com/nodejs/node/pull/24486#pullrequestreview-176318283 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24486/files |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-440020642 |
| @cclauss | https://github.com/cclauss |
| nodejs/node-gyp#1335 | https://github.com/nodejs/node-gyp/pull/1335 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/24486#event-1975602402 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 19, 2018
| https://github.com/nodejs/node/pull/24486#pullrequestreview-176470200 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24486/files |
| refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/nodejs/node/pull/24486#pullrequestreview-176470200 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-440020919 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/24486#event-1975603969 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/d0b33fb17589c3382f1e525dd0865562cf9a24ca..4021ecd7cfa51b41d828edfb4892322fc27825a8 |
| d0b33fb | https://github.com/nodejs/node/commit/d0b33fb17589c3382f1e525dd0865562cf9a24ca |
| 4021ecd | https://github.com/nodejs/node/commit/4021ecd7cfa51b41d828edfb4892322fc27825a8 |
|
Compare
| https://github.com/nodejs/node/compare/d0b33fb17589c3382f1e525dd0865562cf9a24ca..4021ecd7cfa51b41d828edfb4892322fc27825a8 |
| November 19, 2018 21:56 | https://github.com/nodejs/node/pull/24486#event-1975852532 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Nov 20, 2018
| https://github.com/nodejs/node/pull/24486#pullrequestreview-176581311 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24486/files |
| tools/inspector_protocol/ConvertProtocolToJSON.py | https://github.com/nodejs/node/pull/24486/files#diff-402232578c0ecad9b89182184b28ec2dc63afd08f80061a3d401bc6f7a4fdf89 |
| thefourtheye | https://github.com/thefourtheye |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#discussion_r234850696 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#discussion_r234852768 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://chromium.googlesource.com/deps/inspector_protocol/ | https://chromium.googlesource.com/deps/inspector_protocol/ |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| thefourtheye | https://github.com/thefourtheye |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#discussion_r234853696 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#discussion_r234853814 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @cclauss | https://github.com/cclauss |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| cclauss | https://github.com/cclauss |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#discussion_r234886264 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Their GitHub mirror does not accept pull requests | https://github.com/v8/v8/pull/26 |
| @hugovk | https://github.com/hugovk |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#discussion_r235011794 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://v8.dev/docs/contribute | https://v8.dev/docs/contribute |
| @aslushnikov | https://github.com/aslushnikov |
| @ak239 | https://github.com/ak239 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| aslushnikov | https://github.com/aslushnikov |
| Nov 26, 2018 | https://github.com/nodejs/node/pull/24486#discussion_r236369517 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://chromium.googlesource.com/deps/inspector_protocol/ | https://chromium.googlesource.com/deps/inspector_protocol/ |
| https://www.chromium.org/developers/contributing-code#TOC-Uploading-a-change-for-review | https://www.chromium.org/developers/contributing-code#TOC-Uploading-a-change-for-review |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-440117248 |
| @srl295 | https://github.com/srl295 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-440118575 |
| https://ci.nodejs.org/job/node-test-pull-request/18783/ | https://ci.nodejs.org/job/node-test-pull-request/18783/ |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 20, 2018
| https://github.com/nodejs/node/pull/24486#pullrequestreview-176777841 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24486/files |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-440287005 |
| @cclauss | https://github.com/cclauss |
| #22680 | https://github.com/nodejs/node/pull/22680 |
| https://github.com/nodejs/node/blob/master/deps/v8/gypfiles/v8.gyp | https://github.com/nodejs/node/blob/master/deps/v8/gypfiles/v8.gyp |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 20, 2018
| https://github.com/nodejs/node/pull/24486#ref-pullrequest-356629612 |
|
build: simplify build of inspector protocol
#22680
| https://github.com/nodejs/node/pull/22680 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-440290565 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#event-1977531770 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-440297692 |
| https://ci.nodejs.org/job/node-test-pull-request/18805/ | https://ci.nodejs.org/job/node-test-pull-request/18805/ |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Nov 20, 2018
| https://github.com/nodejs/node/pull/24486#pullrequestreview-176827794 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24486/files |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-440316950 |
| @srl295 | https://github.com/srl295 |
| @srl295 | https://github.com/srl295 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#event-1977752384 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-440325339 |
| @srl295 | https://github.com/srl295 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Nov 25, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-441480073 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| targos | https://github.com/targos |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/24486#ref-commit-8bf67c8 |
|
| https://github.com/targos |
| tools: use print() function on both Python 2 and 3 | https://github.com/nodejs/node/commit/8bf67c811c992cab096c4b12c361281acee54080 |
| 8bf67c8 | https://github.com/nodejs/node/commit/8bf67c811c992cab096c4b12c361281acee54080 |
| #24486 | https://github.com/nodejs/node/pull/24486 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/24486#ref-commit-23d8152 |
|
| https://github.com/rvagg |
| tools: use print() function on both Python 2 and 3 | https://github.com/nodejs/node/commit/23d815292fa27f91a465f12de5c32276d845afe6 |
| 23d8152 | https://github.com/nodejs/node/commit/23d815292fa27f91a465f12de5c32276d845afe6 |
| #24486 | https://github.com/nodejs/node/pull/24486 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 30, 2018
| https://github.com/nodejs/node/pull/24486#ref-pullrequest-386194652 |
|
build: fix line length off by one error
#24748
| https://github.com/nodejs/node/pull/24748 |
| danbev | https://github.com/danbev |
|
Dec 3, 2018
| https://github.com/nodejs/node/pull/24486#ref-commit-3099647 |
|
| https://github.com/BridgeAR |
|
| https://github.com/danbev |
| build: fix line length off by one error | https://github.com/nodejs/node/commit/30996479027464d252236b4e00fc62a5421a8296 |
| 3099647 | https://github.com/nodejs/node/commit/30996479027464d252236b4e00fc62a5421a8296 |
| #24748 | https://github.com/nodejs/node/pull/24748 |
| #24486 | https://github.com/nodejs/node/pull/24486 |
| danbev | https://github.com/danbev |
|
Dec 3, 2018
| https://github.com/nodejs/node/pull/24486#ref-commit-5b90902 |
|
| https://github.com/BridgeAR |
|
| https://github.com/danbev |
| build: add line break as soon tests are done | https://github.com/nodejs/node/commit/5b90902b8bf260518d73aa2afbccb10dcf82e78a |
| 5b90902 | https://github.com/nodejs/node/commit/5b90902b8bf260518d73aa2afbccb10dcf82e78a |
| #24748 | https://github.com/nodejs/node/pull/24748 |
| #24486 | https://github.com/nodejs/node/pull/24486 |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 5, 2018
| https://github.com/nodejs/node/pull/24486#ref-commit-e0e15da |
|
| https://github.com/BridgeAR |
| build: fix line length off by one error | https://github.com/nodejs/node/commit/e0e15da6ca30ed4d6ef25916e6c4ef4519b1bde0 |
| e0e15da | https://github.com/nodejs/node/commit/e0e15da6ca30ed4d6ef25916e6c4ef4519b1bde0 |
| #24748 | https://github.com/nodejs/node/pull/24748 |
| #24486 | https://github.com/nodejs/node/pull/24486 |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 5, 2018
| https://github.com/nodejs/node/pull/24486#ref-commit-6b71099 |
|
| https://github.com/BridgeAR |
| build: add line break as soon tests are done | https://github.com/nodejs/node/commit/6b710993036493cbef80f06d38e1a274a28d930e |
| 6b71099 | https://github.com/nodejs/node/commit/6b710993036493cbef80f06d38e1a274a28d930e |
| #24748 | https://github.com/nodejs/node/pull/24748 |
| #24486 | https://github.com/nodejs/node/pull/24486 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 5, 2018
| https://github.com/nodejs/node/pull/24486#ref-pullrequest-387948820 |
|
v11.4.0 proposal
#24854
| https://github.com/nodejs/node/pull/24854 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#261
| https://github.com/beevelop/docker-android-nodejs/issues/261 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#262
| https://github.com/beevelop/docker-android-nodejs/issues/262 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#263
| https://github.com/beevelop/docker-android-nodejs/issues/263 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#264
| https://github.com/beevelop/docker-android-nodejs/issues/264 |
|
2018-12-07 Version 11.4.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#265
| https://github.com/beevelop/docker-android-nodejs/issues/265 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-448364527 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
|
Dec 18, 2018
| https://github.com/nodejs/node/pull/24486#pullrequestreview-186295399 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24486/files/b507783bc116d6703f374d1d096b057df51191be |
| srl295 | https://github.com/srl295 |
| https://github.com/nodejs/node/pull/24486#pullrequestreview-186295399 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Dec 19, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-448566764 |
| @srl295 | https://github.com/srl295 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
| Dec 19, 2018 | https://github.com/nodejs/node/pull/24486#issuecomment-448694216 |
| #25136 | https://github.com/nodejs/node/issues/25136 |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
| refack | https://github.com/refack |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/24486#ref-commit-c7e78f7 |
|
| https://github.com/refack |
| tools: use print() function on both Python 2 and 3 | https://github.com/refack/node/commit/c7e78f713d4829a958fb34bed0cd34c75f20baa1 |
| c7e78f7 | https://github.com/refack/node/commit/c7e78f713d4829a958fb34bed0cd34c75f20baa1 |
| nodejs#24486 | https://github.com/nodejs/node/pull/24486 |
| refack | https://github.com/refack |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/24486#ref-commit-6b3b868 |
|
| https://github.com/BridgeAR |
|
| https://github.com/refack |
| build: fix line length off by one error | https://github.com/refack/node/commit/6b3b868b0079ebcb09ea63966701d88360b76454 |
| 6b3b868 | https://github.com/refack/node/commit/6b3b868b0079ebcb09ea63966701d88360b76454 |
| nodejs#24748 | https://github.com/nodejs/node/pull/24748 |
| nodejs#24486 | https://github.com/nodejs/node/pull/24486 |
| refack | https://github.com/refack |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/24486#ref-commit-87881b4 |
|
| https://github.com/BridgeAR |
|
| https://github.com/refack |
| build: add line break as soon tests are done | https://github.com/refack/node/commit/87881b49c4c7f6e0e7676056fcbac0f0eb04c530 |
| 87881b4 | https://github.com/refack/node/commit/87881b49c4c7f6e0e7676056fcbac0f0eb04c530 |
| nodejs#24748 | https://github.com/nodejs/node/pull/24748 |
| nodejs#24486 | https://github.com/nodejs/node/pull/24486 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 11, 2019
| https://github.com/nodejs/node/pull/24486#ref-commit-8a5b5e1 |
|
| https://github.com/BethGriggs |
| tools: use print() function on both Python 2 and 3 | https://github.com/nodejs/node/commit/8a5b5e1fd081d72a8da9382f28f6228c19c6f808 |
| 8a5b5e1 | https://github.com/nodejs/node/commit/8a5b5e1fd081d72a8da9382f28f6228c19c6f808 |
| #24486 | https://github.com/nodejs/node/pull/24486 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x |
| Feb 11, 2019 | https://github.com/nodejs/node/pull/24486#event-2132065934 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/24486#ref-commit-18d81c9 |
|
| https://github.com/BridgeAR |
|
| https://github.com/BethGriggs |
| build: add line break as soon tests are done | https://github.com/nodejs/node/commit/18d81c94a6ca550cd0289b0d97c72af424bd0476 |
| 18d81c9 | https://github.com/nodejs/node/commit/18d81c94a6ca550cd0289b0d97c72af424bd0476 |
| #24748 | https://github.com/nodejs/node/pull/24748 |
| #24486 | https://github.com/nodejs/node/pull/24486 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/24486#ref-commit-b72bc11 |
|
| https://github.com/BridgeAR |
|
| https://github.com/BethGriggs |
| build: fix line length off by one error | https://github.com/nodejs/node/commit/b72bc11a939a526a66ff02f9405ff9f670a28e56 |
| b72bc11 | https://github.com/nodejs/node/commit/b72bc11a939a526a66ff02f9405ff9f670a28e56 |
| #24748 | https://github.com/nodejs/node/pull/24748 |
| #24486 | https://github.com/nodejs/node/pull/24486 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/24486#ref-pullrequest-409543286 |
|
v10.15.3 proposal
#26063
| https://github.com/nodejs/node/pull/26063 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/24486#ref-commit-5493261 |
|
| https://github.com/rvagg |
| tools: use print() function on both Python 2 and 3 | https://github.com/nodejs/node/commit/549326121fe76d3244a0adb5295f525cefda1993 |
| 5493261 | https://github.com/nodejs/node/commit/549326121fe76d3244a0adb5295f525cefda1993 |
| #24486 | https://github.com/nodejs/node/pull/24486 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/24486#ref-commit-5844a06 |
|
| https://github.com/BridgeAR |
|
| https://github.com/rvagg |
| build: add line break as soon tests are done | https://github.com/nodejs/node/commit/5844a0653dd4a456bca969c29891cea1219c78c9 |
| 5844a06 | https://github.com/nodejs/node/commit/5844a0653dd4a456bca969c29891cea1219c78c9 |
| #24748 | https://github.com/nodejs/node/pull/24748 |
| #24486 | https://github.com/nodejs/node/pull/24486 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/24486#ref-commit-84353ac |
|
| https://github.com/BridgeAR |
|
| https://github.com/rvagg |
| build: fix line length off by one error | https://github.com/nodejs/node/commit/84353ac4c6cb0ef3bf2d8ecc17c78e6103b021eb |
| 84353ac | https://github.com/nodejs/node/commit/84353ac4c6cb0ef3bf2d8ecc17c78e6103b021eb |
| #24748 | https://github.com/nodejs/node/pull/24748 |
| #24486 | https://github.com/nodejs/node/pull/24486 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Mar 11, 2019 | https://github.com/nodejs/node/pull/24486#event-2192631667 |
| BaochengSu | https://github.com/BaochengSu |
|
Oct 20, 2020
| https://github.com/nodejs/node/pull/24486#ref-commit-32bfb79 |
|
| https://github.com/BaochengSu |
| tools: use print() function on both Python 2 and 3 | https://github.com/BaochengSu/node/commit/32bfb799abb028d1a60401366cdabbef15205685 |
| 32bfb79 | https://github.com/BaochengSu/node/commit/32bfb799abb028d1a60401366cdabbef15205685 |
| nodejs#24486 | https://github.com/nodejs/node/pull/24486 |
| b507783 | https://github.com/BaochengSu/node/commit/b507783bc116d6703f374d1d096b057df51191be |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24486 |
|
| https://github.com/srl295 |
|
srl295
| https://github.com/srl295 |
|
| https://github.com/nodejs/node/pull/24486/files/b507783bc116d6703f374d1d096b057df51191be |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/24486/files/d0b33fb17589c3382f1e525dd0865562cf9a24ca |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/24486/files/6651436c8f22452633c65e282f2e51f5ed55eda0 |
|
| https://github.com/aslushnikov |
|
aslushnikov
| https://github.com/aslushnikov |
|
| https://github.com/nodejs/node/pull/24486/files/b507783bc116d6703f374d1d096b057df51191be |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/24486/files/2df7e0e1639314e20d74e20b84112c37d93aef8d |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/24486/files/2df7e0e1639314e20d74e20b84112c37d93aef8d |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/24486 |
|
| https://github.com/cclauss |
|
| https://github.com/addaleax |
|
| https://github.com/Trott |
|
| https://github.com/refack |
|
| https://github.com/thefourtheye |
|
| https://github.com/srl295 |
|
| https://github.com/jasnell |
|
| https://github.com/aslushnikov |
|
| https://github.com/BethGriggs |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |