| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e32f83f6-2f95-c2a2-6479-47550683e2d7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 94FC:1A1F1B:1E85D0C:2A114FB:6A4ECD02 |
| html-safe-nonce | 2a6f0c093c1be18e73d37392b55ad6db7d34bf0fe8ffc2da36effc6181be795a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEZDOjFBMUYxQjoxRTg1RDBDOjJBMTE0RkI6NkE0RUNEMDIiLCJ2aXNpdG9yX2lkIjoiMTAxMTM3ODA1MDI0MjEwNDU3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9eb0fa8f78d0969f63d461d1a69aea0919a62494480b225e51c4e0b3ef62bd68 |
| hovercard-subject-tag | pull_request:230742756 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24359/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/10aa513a336b4fe955dad7295114bd0e2e82a02380dd568296477bf1c5dec840/nodejs/node/pull/24359 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/10aa513a336b4fe955dad7295114bd0e2e82a02380dd568296477bf1c5dec840/nodejs/node/pull/24359 |
| og:image:alt | Refactored and removed some debug #ifdef statements. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kiyomizumia |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/24359#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24359 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24359 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/24359 |
| Reload | https://github.com/nodejs/node/pull/24359 |
| Reload | https://github.com/nodejs/node/pull/24359 |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| kiyomizumia | https://github.com/kiyomizumia |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| kiyomizumia:cppcode | https://github.com/kiyomizumia/node/tree/cppcode |
| Conversation | https://github.com/nodejs/node/pull/24359 |
| Commits5 (5) | https://github.com/nodejs/node/pull/24359/commits |
| Checks | https://github.com/nodejs/node/pull/24359/checks |
| Files changed | https://github.com/nodejs/node/pull/24359/files |
| src: add DCHECK macros | https://github.com/nodejs/node/pull/24359#top |
| kiyomizumia | https://github.com/kiyomizumia |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| kiyomizumia:cppcode | https://github.com/kiyomizumia/node/tree/cppcode |
|
| https://github.com/kiyomizumia |
| kiyomizumia | https://github.com/kiyomizumia |
| Nov 14, 2018 | https://github.com/nodejs/node/pull/24359#issue-380578706 |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Nov 14, 2018 | https://github.com/nodejs/node/pull/24359#event-1965150489 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 14, 2018
| https://github.com/nodejs/node/pull/24359#pullrequestreview-174817194 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24359/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/24359#pullrequestreview-174817194 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 14, 2018
| https://github.com/nodejs/node/pull/24359#pullrequestreview-174878354 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24359/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 14, 2018 | https://github.com/nodejs/node/pull/24359#issuecomment-438678685 |
| @kiyomizumia | https://github.com/kiyomizumia |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/kiyomizumia |
| kiyomizumia | https://github.com/kiyomizumia |
| force-pushed | https://github.com/nodejs/node/compare/53039ba98edf4d17a03366406443c1cc784813aa..602eb98fa615c6a26821a0b46b48431203bf265d |
| 53039ba | https://github.com/nodejs/node/commit/53039ba98edf4d17a03366406443c1cc784813aa |
| 602eb98 | https://github.com/nodejs/node/commit/602eb98fa615c6a26821a0b46b48431203bf265d |
|
Compare
| https://github.com/nodejs/node/compare/53039ba98edf4d17a03366406443c1cc784813aa..602eb98fa615c6a26821a0b46b48431203bf265d |
| November 15, 2018 12:19 | https://github.com/nodejs/node/pull/24359#event-1968481927 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 16, 2018 | https://github.com/nodejs/node/pull/24359#issuecomment-439368386 |
| @kiyomizumia | https://github.com/kiyomizumia |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| kiyomizumia | https://github.com/kiyomizumia |
| November 19, 2018 11:41 | https://github.com/nodejs/node/pull/24359#commits-pushed-22ef1c9 |
|
| https://github.com/kiyomizumia |
| src: added check statements for debugging | https://github.com/nodejs/node/pull/24359/commits/22ef1c95c5f63ae7da8f9d152823bbbb5a4e4750 |
| 22ef1c9 | https://github.com/nodejs/node/pull/24359/commits/22ef1c95c5f63ae7da8f9d152823bbbb5a4e4750 |
|
| https://github.com/kiyomizumia |
| src: refactored and removed some ifdef debug statements | https://github.com/nodejs/node/pull/24359/commits/4f6fdbd31a840356d3f1f9a36396fadd97f1909c |
| 4f6fdbd | https://github.com/nodejs/node/pull/24359/commits/4f6fdbd31a840356d3f1f9a36396fadd97f1909c |
| https://github.com/kiyomizumia |
| kiyomizumia | https://github.com/kiyomizumia |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/24359#issuecomment-439756898 |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/kiyomizumia |
| kiyomizumia | https://github.com/kiyomizumia |
| force-pushed | https://github.com/nodejs/node/compare/602eb98fa615c6a26821a0b46b48431203bf265d..07c92d3803c913dc3a1ef4b3037d7ce86ade8a6d |
| 602eb98 | https://github.com/nodejs/node/commit/602eb98fa615c6a26821a0b46b48431203bf265d |
| 07c92d3 | https://github.com/nodejs/node/commit/07c92d3803c913dc3a1ef4b3037d7ce86ade8a6d |
|
Compare
| https://github.com/nodejs/node/compare/602eb98fa615c6a26821a0b46b48431203bf265d..07c92d3803c913dc3a1ef4b3037d7ce86ade8a6d |
| November 19, 2018 03:20 | https://github.com/nodejs/node/pull/24359#event-1973609071 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/24359#issuecomment-439847341 |
| @kiyomizumia | https://github.com/kiyomizumia |
| https://ci.nodejs.org/job/node-test-pull-request/18748/ | https://ci.nodejs.org/job/node-test-pull-request/18748/ |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 22, 2018
| https://github.com/nodejs/node/pull/24359#ref-pullrequest-383404468 |
|
src: add DCHECK macros
#24563
| https://github.com/nodejs/node/pull/24563 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 22, 2018
| https://github.com/nodejs/node/pull/24359#pullrequestreview-177604086 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24359/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/24359#pullrequestreview-177604086 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 22, 2018
| https://github.com/nodejs/node/pull/24359#pullrequestreview-177608891 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24359/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/24359#pullrequestreview-177608891 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| src/stream_base.cc | https://github.com/nodejs/node/pull/24359/files#diff-8aa3ffa0df16e1ec3bcedb6c8af59c612201517302d738cd2f40263f1eb39a19 |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/kiyomizumia |
| kiyomizumia | https://github.com/kiyomizumia |
| force-pushed | https://github.com/nodejs/node/compare/07c92d3803c913dc3a1ef4b3037d7ce86ade8a6d..4f6fdbd31a840356d3f1f9a36396fadd97f1909c |
| 07c92d3 | https://github.com/nodejs/node/commit/07c92d3803c913dc3a1ef4b3037d7ce86ade8a6d |
| 4f6fdbd | https://github.com/nodejs/node/commit/4f6fdbd31a840356d3f1f9a36396fadd97f1909c |
|
Compare
| https://github.com/nodejs/node/compare/07c92d3803c913dc3a1ef4b3037d7ce86ade8a6d..4f6fdbd31a840356d3f1f9a36396fadd97f1909c |
| November 24, 2018 06:49 | https://github.com/nodejs/node/pull/24359#event-1984890725 |
|
| https://github.com/kiyomizumia |
| src: fixed DCHECK statements | https://github.com/nodejs/node/pull/24359/commits/799e6d51185fc2836bb67b2417c2959b9a98712f |
| 799e6d5 | https://github.com/nodejs/node/pull/24359/commits/799e6d51185fc2836bb67b2417c2959b9a98712f |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 24, 2018
| https://github.com/nodejs/node/pull/24359#pullrequestreview-178042873 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24359/files/799e6d51185fc2836bb67b2417c2959b9a98712f |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 24, 2018 | https://github.com/nodejs/node/pull/24359#issuecomment-441349391 |
| https://ci.nodejs.org/job/node-test-pull-request/18915/ | https://ci.nodejs.org/job/node-test-pull-request/18915/ |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 24, 2018 | https://github.com/nodejs/node/pull/24359#event-1984900343 |
|
| https://github.com/kiyomizumia |
| src: added ifndef for decheck | https://github.com/nodejs/node/pull/24359/commits/2002e03ee6d1fb47b46f7bc8d32e8af59f6ef179 |
| 2002e03 | https://github.com/nodejs/node/pull/24359/commits/2002e03ee6d1fb47b46f7bc8d32e8af59f6ef179 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 24, 2018
| https://github.com/nodejs/node/pull/24359#pullrequestreview-178043838 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24359/files/2002e03ee6d1fb47b46f7bc8d32e8af59f6ef179 |
| src/inspector/node_string.h | https://github.com/nodejs/node/pull/24359/files/2002e03ee6d1fb47b46f7bc8d32e8af59f6ef179#diff-f0736393375d67fde103d79cf303e2ba20521383b718d1a0d9324792babe1a52 |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 24, 2018
| https://github.com/nodejs/node/pull/24359#pullrequestreview-178043903 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24359/files/2002e03ee6d1fb47b46f7bc8d32e8af59f6ef179 |
| src/inspector/node_string.h | https://github.com/nodejs/node/pull/24359/files/2002e03ee6d1fb47b46f7bc8d32e8af59f6ef179#diff-f0736393375d67fde103d79cf303e2ba20521383b718d1a0d9324792babe1a52 |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 25, 2018 | https://github.com/nodejs/node/pull/24359#event-1985242281 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/24359#ref-pullrequest-383968686 |
|
src: migrate to new V8 array API
#24613
| https://github.com/nodejs/node/pull/24613 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 28, 2018 | https://github.com/nodejs/node/pull/24359#issuecomment-442444253 |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| @kiyomizumia | https://github.com/kiyomizumia |
| #24359 (comment) | https://github.com/nodejs/node/pull/24359#discussion_r236035585 |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Dec 6, 2018 | https://github.com/nodejs/node/pull/24359#issuecomment-445055384 |
| @kiyomizumia | https://github.com/kiyomizumia |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/kiyomizumia |
| kiyomizumia | https://github.com/kiyomizumia |
| Dec 7, 2018 | https://github.com/nodejs/node/pull/24359#issuecomment-445269095 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
|
| https://github.com/joyeecheung |
|
| https://github.com/kiyomizumia |
| Update src/inspector/node_string.h | https://github.com/nodejs/node/pull/24359/commits/90de2f3776cd8abb3b63e5caacd8f87875c91fe5 |
| 90de2f3 | https://github.com/nodejs/node/pull/24359/commits/90de2f3776cd8abb3b63e5caacd8f87875c91fe5 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 7, 2018 | https://github.com/nodejs/node/pull/24359#issuecomment-445314873 |
| https://ci.nodejs.org/job/node-test-pull-request/19306/ | https://ci.nodejs.org/job/node-test-pull-request/19306/ |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 19, 2018 | https://github.com/nodejs/node/pull/24359#event-2036732663 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 19, 2018 | https://github.com/nodejs/node/pull/24359#issuecomment-448739701 |
| https://ci.nodejs.org/job/node-test-pull-request/19684/ | https://ci.nodejs.org/job/node-test-pull-request/19684/ |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 24, 2018 | https://github.com/nodejs/node/pull/24359#issuecomment-449674054 |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://ci.nodejs.org/job/node-test-pull-request/19778/ | https://ci.nodejs.org/job/node-test-pull-request/19778/ |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Dec 24, 2018 | https://github.com/nodejs/node/pull/24359#event-2042663618 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 24, 2018
| https://github.com/nodejs/node/pull/24359#pullrequestreview-187667737 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24359/files/90de2f3776cd8abb3b63e5caacd8f87875c91fe5 |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 24, 2018
| https://github.com/nodejs/node/pull/24359#ref-commit-71bc7e1 |
|
| https://github.com/kiyomizumia |
|
| https://github.com/BridgeAR |
| src: add DCHECK macros | https://github.com/BridgeAR/node/commit/71bc7e1ce6881b4e6fe50459cc9866d47f96e4a4 |
| 71bc7e1 | https://github.com/BridgeAR/node/commit/71bc7e1ce6881b4e6fe50459cc9866d47f96e4a4 |
| nodejs#24359 | https://github.com/nodejs/node/pull/24359 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 24, 2018 | https://github.com/nodejs/node/pull/24359#issuecomment-449710749 |
| 71bc7e1 | https://github.com/nodejs/node/commit/71bc7e1ce6881b4e6fe50459cc9866d47f96e4a4 |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 24, 2018 | https://github.com/nodejs/node/pull/24359#event-2042927237 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 25, 2018
| https://github.com/nodejs/node/pull/24359#ref-commit-e624713 |
|
| https://github.com/kiyomizumia |
|
| https://github.com/MylesBorins |
| src: add DCHECK macros | https://github.com/nodejs/node/commit/e62471394ccf69b75d21923e0e2dae4604660e90 |
| e624713 | https://github.com/nodejs/node/commit/e62471394ccf69b75d21923e0e2dae4604660e90 |
| #24359 | https://github.com/nodejs/node/pull/24359 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 25, 2018
| https://github.com/nodejs/node/pull/24359#ref-pullrequest-393620382 |
|
v11.6.0 proposal
#25175
| https://github.com/nodejs/node/pull/25175 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 26, 2018
| https://github.com/nodejs/node/pull/24359#ref-commit-c9f809e |
|
| https://github.com/kiyomizumia |
|
| https://github.com/MylesBorins |
| src: add DCHECK macros | https://github.com/nodejs/node/commit/c9f809e36f8b600a0770714a4842e7ccd109f3c8 |
| c9f809e | https://github.com/nodejs/node/commit/c9f809e36f8b600a0770714a4842e7ccd109f3c8 |
| #24359 | https://github.com/nodejs/node/pull/24359 |
| refack | https://github.com/refack |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/24359#ref-commit-2369ace |
|
| https://github.com/kiyomizumia |
|
| https://github.com/refack |
| src: add DCHECK macros | https://github.com/refack/node/commit/2369acebbeb4263b8097a7cde6b6cbd52ac0ba29 |
| 2369ace | https://github.com/refack/node/commit/2369acebbeb4263b8097a7cde6b6cbd52ac0ba29 |
| nodejs#24359 | https://github.com/nodejs/node/pull/24359 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
backport-requested-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x |
| Jul 2, 2019 | https://github.com/nodejs/node/pull/24359#event-2454939573 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24359 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/24359/files/2002e03ee6d1fb47b46f7bc8d32e8af59f6ef179 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/24359/files/2002e03ee6d1fb47b46f7bc8d32e8af59f6ef179 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/24359/files/53039ba98edf4d17a03366406443c1cc784813aa |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/24359/files/90de2f3776cd8abb3b63e5caacd8f87875c91fe5 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/24359 |
|
| https://github.com/kiyomizumia |
|
| https://github.com/addaleax |
|
| https://github.com/joyeecheung |
|
| https://github.com/Trott |
|
| https://github.com/BridgeAR |
|
| https://github.com/cjihrig |
|
| https://github.com/BethGriggs |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |