René's URL Explorer Experiment


Title: lib: fix - invalid timer priority queue order by mareksrom · Pull Request #24318 · nodejs/node · GitHub

Open Graph Title: lib: fix - invalid timer priority queue order by mareksrom · Pull Request #24318 · nodejs/node

X Title: lib: fix - invalid timer priority queue order by mareksrom · Pull Request #24318 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: in lib/timers.js PriorityQueue.percolateDown cannot be used for rescheduling list, because it does not work in all cases updated item does not have to be root of the heap when new timers are creat...

X Description: in lib/timers.js PriorityQueue.percolateDown cannot be used for rescheduling list, because it does not work in all cases updated item does not have to be root of the heap when new timers are creat...

Opengraph URL: https://github.com/nodejs/node/pull/24318

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:33b40614-2797-bc94-832b-d0800c360e64
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE8C:13A543:24F0225:2EE8DE9:6991B5DD
html-safe-nonce4b0f98af0b6d80ee59dc029351703030b3f328079f8370f5951c43c042a7c679
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRThDOjEzQTU0MzoyNEYwMjI1OjJFRThERTk6Njk5MUI1REQiLCJ2aXNpdG9yX2lkIjoiMjYwMTcwMzM4Nzk0Nzk3MjA2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac51f7ab7a429f6463ceef009e9e5f6afdbeae7a03f49bd0cf04abb30a93b25fb8
hovercard-subject-tagpull_request:230107245
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24318/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8cea702c581c198f785ee1ff606b961dd9173694cbb597ce77dde6c7e9f3663c/nodejs/node/pull/24318
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8cea702c581c198f785ee1ff606b961dd9173694cbb597ce77dde6c7e9f3663c/nodejs/node/pull/24318
og:image:altin lib/timers.js PriorityQueue.percolateDown cannot be used for rescheduling list, because it does not work in all cases updated item does not have to be root of the heap when new timers are creat...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemareksrom
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24318#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24318
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24318
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24318
Reloadhttps://github.com/nodejs/node/pull/24318
Reloadhttps://github.com/nodejs/node/pull/24318
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24318
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mareksromhttps://github.com/mareksrom
nodejs:masterhttps://github.com/nodejs/node/tree/master
mareksrom:masterhttps://github.com/mareksrom/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/24318
Commits2 (2)https://github.com/nodejs/node/pull/24318/commits
Checkshttps://github.com/nodejs/node/pull/24318/checks
Files changedhttps://github.com/nodejs/node/pull/24318/files
lib: fix - invalid timer priority queue orderhttps://github.com/nodejs/node/pull/24318#top
mareksromhttps://github.com/mareksrom
nodejs:masterhttps://github.com/nodejs/node/tree/master
mareksrom:masterhttps://github.com/mareksrom/node/tree/master
https://github.com/mareksrom
mareksromhttps://github.com/mareksrom
Nov 12, 2018https://github.com/nodejs/node/pull/24318#issue-379741117
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24318
https://github.com/mareksrom
lib: fix - invalid timer priority queue orderhttps://github.com/nodejs/node/pull/24318/commits/fa558e6a88935e6ba5102850e03276da4f6068bd
fa558e6https://github.com/nodejs/node/pull/24318/commits/fa558e6a88935e6ba5102850e03276da4f6068bd
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
timers https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers
Nov 12, 2018https://github.com/nodejs/node/pull/24318#event-1960065094
https://github.com/mareksrom
mareksromhttps://github.com/mareksrom
Nov 12, 2018 https://github.com/nodejs/node/pull/24318#ref-issue-374746822
Infinite loop in timers in Node 11 #23935 https://github.com/nodejs/node/issues/23935
https://github.com/mareksrom
lib: fix test build inconsistencieshttps://github.com/nodejs/node/pull/24318/commits/04f408b2649dcd4b5bf3bfa8a1adc67b97c8982c
04f408bhttps://github.com/nodejs/node/pull/24318/commits/04f408b2649dcd4b5bf3bfa8a1adc67b97c8982c
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 12, 2018 https://github.com/nodejs/node/pull/24318#ref-issue-379784294
timers: timer starvation #24320 https://github.com/nodejs/node/issues/24320
https://github.com/mareksrom
mareksromhttps://github.com/mareksrom
Nov 12, 2018https://github.com/nodejs/node/pull/24318#issuecomment-437896926
Please reload this pagehttps://github.com/nodejs/node/pull/24318
https://github.com/mareksrom
mareksromhttps://github.com/mareksrom
Nov 12, 2018https://github.com/nodejs/node/pull/24318#issuecomment-437924061
Please reload this pagehttps://github.com/nodejs/node/pull/24318
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Fishrock123https://github.com/Fishrock123
apapirovskihttps://github.com/apapirovski
November 12, 2018 16:35https://github.com/nodejs/node/pull/24318#event-1960790844
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Nov 12, 2018https://github.com/nodejs/node/pull/24318#issuecomment-437960562
Please reload this pagehttps://github.com/nodejs/node/pull/24318
@mareksromhttps://github.com/mareksrom
#24322https://github.com/nodejs/node/pull/24322
Please reload this pagehttps://github.com/nodejs/node/pull/24318
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Nov 15, 2018https://github.com/nodejs/node/pull/24318#issuecomment-439167210
#24322https://github.com/nodejs/node/pull/24322
@mareksromhttps://github.com/mareksrom
Please reload this pagehttps://github.com/nodejs/node/pull/24318
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Nov 15, 2018https://github.com/nodejs/node/pull/24318#event-1969592489
https://github.com/refack
refackhttps://github.com/refack
superseded https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asuperseded
Nov 15, 2018https://github.com/nodejs/node/pull/24318#event-1969643062
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24318
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
timers https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers
Please reload this pagehttps://github.com/nodejs/node/pull/24318
https://github.com/mareksrom
https://github.com/apapirovski
https://github.com/Fishrock123
https://github.com/refack
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.