| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:986af4a1-50da-5745-b27c-7092b9d3e81d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C9D4:229272:285B814:339476D:6991C324 |
| html-safe-nonce | 6f60bcddad062fc4c1221f5b671243deb76bb40fe5489a93e5684464c4d40315 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUQ0OjIyOTI3MjoyODVCODE0OjMzOTQ3NkQ6Njk5MUMzMjQiLCJ2aXNpdG9yX2lkIjoiMzA4NDU1Njc0NTM3NDI4NjYyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0979c7f60ba2114bd16b2a497ac46179822a4c86fc16700238f16870aa1eac9b |
| hovercard-subject-tag | pull_request:229964876 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24309/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1b896aad21f82209090a3205c766093865421c058afcd7c54f796c2ad5f771ad/nodejs/node/pull/24309 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1b896aad21f82209090a3205c766093865421c058afcd7c54f796c2ad5f771ad/nodejs/node/pull/24309 |
| og:image:alt | cc @Trott @refack
Refs: nodejs/build#1568
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/24309#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24309 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24309 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/24309 |
| Reload | https://github.com/nodejs/node/pull/24309 |
| Reload | https://github.com/nodejs/node/pull/24309 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
713
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:addon-js | https://github.com/joyeecheung/node/tree/addon-js |
| Conversation | https://github.com/nodejs/node/pull/24309 |
| Commits1 (1) | https://github.com/nodejs/node/pull/24309/commits |
| Checks | https://github.com/nodejs/node/pull/24309/checks |
| Files changed | https://github.com/nodejs/node/pull/24309/files |
| benchmark: try building the addons in napi benchmarks | https://github.com/nodejs/node/pull/24309#top |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:addon-js | https://github.com/joyeecheung/node/tree/addon-js |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#issue-379542580 |
| @Trott | https://github.com/Trott |
| @refack | https://github.com/refack |
| nodejs/build#1568 | https://github.com/nodejs/build/issues/1568 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#issuecomment-437687221 |
| @joyeecheung | https://github.com/joyeecheung |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1579/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1579/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#event-1958953860 |
|
| https://github.com/joyeecheung |
| benchmark: try building the addons in napi benchmarks | https://github.com/nodejs/node/pull/24309/commits/afe014c311ebf161076305515bb6c16295fa1cdb |
| afe014c | https://github.com/nodejs/node/pull/24309/commits/afe014c311ebf161076305515bb6c16295fa1cdb |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#issuecomment-437687552 |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/349a07da1c29e4c5f1d9dcbef2d67b4e95e67a4a..afe014c311ebf161076305515bb6c16295fa1cdb |
| 349a07d | https://github.com/nodejs/node/commit/349a07da1c29e4c5f1d9dcbef2d67b4e95e67a4a |
| afe014c | https://github.com/nodejs/node/commit/afe014c311ebf161076305515bb6c16295fa1cdb |
|
Compare
| https://github.com/nodejs/node/compare/349a07da1c29e4c5f1d9dcbef2d67b4e95e67a4a..afe014c311ebf161076305515bb6c16295fa1cdb |
| November 11, 2018 17:17 | https://github.com/nodejs/node/pull/24309#event-1958955840 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#event-1958955902 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 11, 2018
| https://github.com/nodejs/node/pull/24309#ref-issue-379496180 |
|
Run benchmark test suite nightly
nodejs/build#1568
| https://github.com/nodejs/build/issues/1568 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#issuecomment-437687743 |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#issuecomment-437687833 |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#issuecomment-437687902 |
| node/Makefile | https://github.com/nodejs/node/blob/e854cf911e7acf64242a8e27c4f4b87cdcd25f89/Makefile#L1051-L1054 |
| e854cf9 | https://github.com/nodejs/node/commit/e854cf911e7acf64242a8e27c4f4b87cdcd25f89 |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#issuecomment-437687979 |
| #24307 | https://github.com/nodejs/node/pull/24307 |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#issuecomment-437688285 |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#issuecomment-437688829 |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#issuecomment-437689274 |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#issuecomment-437689540 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24309#issuecomment-437689803 |
| https://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.md | https://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.md |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 12, 2018
| https://github.com/nodejs/node/pull/24309#pullrequestreview-173994402 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24309/files/afe014c311ebf161076305515bb6c16295fa1cdb |
| benchmark/napi/function_args/index.js | https://github.com/nodejs/node/pull/24309/files/afe014c311ebf161076305515bb6c16295fa1cdb#diff-7e92a98c942bbf66356cbeac8936e9493ac661cab2d8621a6bbf01d2483d2ecc |
| BridgeAR | https://github.com/BridgeAR |
| Nov 12, 2018 | https://github.com/nodejs/node/pull/24309#discussion_r232732430 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
| 1ecc406 | https://github.com/nodejs/node/commit/1ecc406b77ba7573ed0b982a7e6654514c71a7a2 |
| 49cf67e | https://github.com/nodejs/node/commit/49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
|
Compare
| https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
| September 17, 2019 16:51 | https://github.com/nodejs/node/pull/24309#event-2640607458 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
| force-pushed | https://github.com/nodejs/node/compare/e8a45686c7512211f96c0fe8153b5253cf5923a6..5289f80eadafcc508b24d5817f0ec416eccf8404 |
| e8a4568 | https://github.com/nodejs/node/commit/e8a45686c7512211f96c0fe8153b5253cf5923a6 |
| 5289f80 | https://github.com/nodejs/node/commit/5289f80eadafcc508b24d5817f0ec416eccf8404 |
|
Compare
| https://github.com/nodejs/node/compare/e8a45686c7512211f96c0fe8153b5253cf5923a6..5289f80eadafcc508b24d5817f0ec416eccf8404 |
| December 26, 2019 19:46 | https://github.com/nodejs/node/pull/24309#event-2909598607 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| force-pushed | https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5 |
| 8ae28ff | https://github.com/nodejs/node/commit/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda |
| 2935f72 | https://github.com/nodejs/node/commit/2935f72ae1b991c64118031dec12e7d7db7714a5 |
|
Compare
| https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5 |
| May 31, 2020 12:19 | https://github.com/nodejs/node/pull/24309#event-3390559851 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Jun 25, 2020 | https://github.com/nodejs/node/pull/24309#event-3484425758 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 25, 2020 | https://github.com/nodejs/node/pull/24309#issuecomment-649856849 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 6, 2020 | https://github.com/nodejs/node/pull/24309#issuecomment-654392815 |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 6, 2020 | https://github.com/nodejs/node/pull/24309#event-3517134506 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24309 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/24309/files/afe014c311ebf161076305515bb6c16295fa1cdb |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Please reload this page | https://github.com/nodejs/node/pull/24309 |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/refack |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |