René's URL Explorer Experiment


Title: src: remove pushValueToArray and setupProcessObject by joyeecheung · Pull Request #24264 · nodejs/node · GitHub

Open Graph Title: src: remove pushValueToArray and setupProcessObject by joyeecheung · Pull Request #24264 · nodejs/node

X Title: src: remove pushValueToArray and setupProcessObject by joyeecheung · Pull Request #24264 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR removes pushValueToArray NODE_PUSH_VAL_TO_ARRAY_MAX env->env->push_values_to_array_function() In favor of the new V8 C++ API that constructs an Array from a C++ array directly. Also...

X Description: This PR removes pushValueToArray NODE_PUSH_VAL_TO_ARRAY_MAX env->env->push_values_to_array_function() In favor of the new V8 C++ API that constructs an Array from a C++ array direct...

Opengraph URL: https://github.com/nodejs/node/pull/24264

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7e5f466a-0ab2-a5d8-f16b-82b73d971acd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84F8:202BCA:DCBD49:11891C8:69914CDE
html-safe-nonce73fd49c3bc95565cc6e7b69da5f35b0c3ba95cde9cc21de6173285a4173e1e52
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEY4OjIwMkJDQTpEQ0JENDk6MTE4OTFDODo2OTkxNENERSIsInZpc2l0b3JfaWQiOiIxMDM2NTc4MDc5MzQ5MjMwODE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3d44e8af41519e68719163cced64e664fac5136949b44f7e6cbb44c7dba0dd98
hovercard-subject-tagpull_request:229597170
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24264/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c79e67377d53831d7b1461847bf54625afe35a9ea0e88979a9c4428bbdc7920c/nodejs/node/pull/24264
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c79e67377d53831d7b1461847bf54625afe35a9ea0e88979a9c4428bbdc7920c/nodejs/node/pull/24264
og:image:altThis PR removes pushValueToArray NODE_PUSH_VAL_TO_ARRAY_MAX env->env->push_values_to_array_function() In favor of the new V8 C++ API that constructs an Array from a C++ array directly. Also...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24264#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24264
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24264
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24264
Reloadhttps://github.com/nodejs/node/pull/24264
Reloadhttps://github.com/nodejs/node/pull/24264
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24264
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:remove-pushhttps://github.com/joyeecheung/node/tree/remove-push
Conversationhttps://github.com/nodejs/node/pull/24264
Commits12 (12)https://github.com/nodejs/node/pull/24264/commits
Checkshttps://github.com/nodejs/node/pull/24264/checks
Files changedhttps://github.com/nodejs/node/pull/24264/files
src: remove pushValueToArray and setupProcessObjecthttps://github.com/nodejs/node/pull/24264#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:remove-pushhttps://github.com/joyeecheung/node/tree/remove-push
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 9, 2018https://github.com/nodejs/node/pull/24264#issue-379035213
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 9, 2018https://github.com/nodejs/node/pull/24264#issuecomment-437260339
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1550/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1550/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Nov 9, 2018https://github.com/nodejs/node/pull/24264#event-1956101416
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 9, 2018https://github.com/nodejs/node/pull/24264#issuecomment-437260717
Please reload this pagehttps://github.com/nodejs/node/pull/24264
the new APIhttps://chromium-review.googlesource.com/c/v8/v8/+/1317049
@bmeurerhttps://github.com/bmeurer
#24125https://github.com/nodejs/node/pull/24125
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://github.com/bmeurer
bmeurerhttps://github.com/bmeurer
Nov 9, 2018 https://github.com/nodejs/node/pull/24264#pullrequestreview-173309236
View reviewed changes https://github.com/nodejs/node/pull/24264/files
bmeurerhttps://github.com/bmeurer
https://github.com/nodejs/node/pull/24264#pullrequestreview-173309236
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
src/node_http2.cchttps://github.com/nodejs/node/pull/24264/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
bmeurerhttps://github.com/bmeurer
Nov 9, 2018https://github.com/nodejs/node/pull/24264#discussion_r232170894
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
joyeecheunghttps://github.com/joyeecheung
Nov 11, 2018https://github.com/nodejs/node/pull/24264#discussion_r232500072
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
src/node_http_parser.cchttps://github.com/nodejs/node/pull/24264/files#diff-bbcf7a115fe4680f3a7c076a487c89bd4ce935e7d2a726cfcb3f69331705e25e
bmeurerhttps://github.com/bmeurer
Nov 9, 2018https://github.com/nodejs/node/pull/24264#discussion_r232170985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
joyeecheunghttps://github.com/joyeecheung
Nov 11, 2018https://github.com/nodejs/node/pull/24264#discussion_r232500061
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
refackhttps://github.com/refack
Nov 11, 2018https://github.com/nodejs/node/pull/24264#discussion_r232505475
Please reload this pagehttps://github.com/nodejs/node/pull/24264
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
joyeecheunghttps://github.com/joyeecheung
November 12, 2018 03:44https://github.com/nodejs/node/pull/24264#commits-pushed-a9f8f33
https://github.com/joyeecheung
http2: remove pushValueToArray in Http2Session::HandleHeadersFramehttps://github.com/nodejs/node/pull/24264/commits/a9f8f332dbf445795f270581d6f52b428c5e6d10
a9f8f33https://github.com/nodejs/node/pull/24264/commits/a9f8f332dbf445795f270581d6f52b428c5e6d10
https://github.com/joyeecheung
http2: remove pushValueToArray in Http2Session::HandleOriginFramehttps://github.com/nodejs/node/pull/24264/commits/3e3e9b7097e0b51bb0ecc956422119cf6dc6952e
3e3e9b7https://github.com/nodejs/node/pull/24264/commits/3e3e9b7097e0b51bb0ecc956422119cf6dc6952e
https://github.com/joyeecheung
http_parser: remove pushValueToArray in CreateHeadershttps://github.com/nodejs/node/pull/24264/commits/fa1c240cb5667f56c408b3ccb764882cb63d86ec
fa1c240https://github.com/nodejs/node/pull/24264/commits/fa1c240cb5667f56c408b3ccb764882cb63d86ec
https://github.com/joyeecheung
process: remove pushValueToArray in EnvEnumeratorhttps://github.com/nodejs/node/pull/24264/commits/a96a222a1b655685d2494e4174bcac5689a4f7ce
a96a222https://github.com/nodejs/node/pull/24264/commits/a96a222a1b655685d2494e4174bcac5689a4f7ce
https://github.com/joyeecheung
process: remove pushValueToArray in GetActiveRequestshttps://github.com/nodejs/node/pull/24264/commits/d79ed5dc45dde378484074b86fd644e388424767
d79ed5dhttps://github.com/nodejs/node/pull/24264/commits/d79ed5dc45dde378484074b86fd644e388424767
https://github.com/joyeecheung
process: remove pushValueToArray in GetActiveHandleshttps://github.com/nodejs/node/pull/24264/commits/70fa3c1a8f7710884393430188ca00842cd35bfc
70fa3c1https://github.com/nodejs/node/pull/24264/commits/70fa3c1a8f7710884393430188ca00842cd35bfc
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/3cb8bf91a4e29df2c921b1ff52651e5ab3e4eb6f..cc511fbecbe7b3b773ca38221175dc562576519d
3cb8bf9https://github.com/nodejs/node/commit/3cb8bf91a4e29df2c921b1ff52651e5ab3e4eb6f
cc511fbhttps://github.com/nodejs/node/commit/cc511fbecbe7b3b773ca38221175dc562576519d
Compare https://github.com/nodejs/node/compare/3cb8bf91a4e29df2c921b1ff52651e5ab3e4eb6f..cc511fbecbe7b3b773ca38221175dc562576519d
November 11, 2018 19:44https://github.com/nodejs/node/pull/24264#event-1959014236
joyeecheunghttps://github.com/joyeecheung
November 12, 2018 05:14https://github.com/nodejs/node/pull/24264#commits-pushed-a54d0c6
https://github.com/joyeecheung
os: do not call into JS to push values to an array in GetCPUInfohttps://github.com/nodejs/node/pull/24264/commits/a54d0c62d3051d55ef2cfbe60e82883487b8b4a7
a54d0c6https://github.com/nodejs/node/pull/24264/commits/a54d0c62d3051d55ef2cfbe60e82883487b8b4a7
https://github.com/joyeecheung
src: remove pushValueToArray and SetupProcessObjecthttps://github.com/nodejs/node/pull/24264/commits/db5e5fa4780c0dd1f6ccc1faaf278f1056819a44
db5e5fahttps://github.com/nodejs/node/pull/24264/commits/db5e5fa4780c0dd1f6ccc1faaf278f1056819a44
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/cc511fbecbe7b3b773ca38221175dc562576519d..db5e5fa4780c0dd1f6ccc1faaf278f1056819a44
cc511fbhttps://github.com/nodejs/node/commit/cc511fbecbe7b3b773ca38221175dc562576519d
db5e5fahttps://github.com/nodejs/node/commit/db5e5fa4780c0dd1f6ccc1faaf278f1056819a44
Compare https://github.com/nodejs/node/compare/cc511fbecbe7b3b773ca38221175dc562576519d..db5e5fa4780c0dd1f6ccc1faaf278f1056819a44
November 11, 2018 21:21https://github.com/nodejs/node/pull/24264#event-1959053562
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 11, 2018https://github.com/nodejs/node/pull/24264#issuecomment-437706619
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://github.com/joyeecheung
fixup! process: remove pushValueToArray in EnvEnumeratorhttps://github.com/nodejs/node/pull/24264/commits/0b3568c87b58caa8e3f4cab9172159845bf28622
0b3568chttps://github.com/nodejs/node/pull/24264/commits/0b3568c87b58caa8e3f4cab9172159845bf28622
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 11, 2018https://github.com/nodejs/node/pull/24264#issuecomment-437706973
https://ci.nodejs.org/job/node-test-pull-request/18540/https://ci.nodejs.org/job/node-test-pull-request/18540/
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://github.com/refack
refackhttps://github.com/refack
Nov 11, 2018 https://github.com/nodejs/node/pull/24264#pullrequestreview-173714060
View reviewed changes https://github.com/nodejs/node/pull/24264/files
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/24264#pullrequestreview-173714060
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
lib/os.jshttps://github.com/nodejs/node/pull/24264/files#diff-169b839d55312a439ec3709adaa8422a38a872d610dc33bb8151e3ffacc9265f
Please reload this pagehttps://github.com/nodejs/node/pull/24264
src/node_http2.cchttps://github.com/nodejs/node/pull/24264/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
Please reload this pagehttps://github.com/nodejs/node/pull/24264
src/node_http2.cchttps://github.com/nodejs/node/pull/24264/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
refackhttps://github.com/refack
Nov 11, 2018https://github.com/nodejs/node/pull/24264#discussion_r232504020
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
joyeecheunghttps://github.com/joyeecheung
Nov 11, 2018https://github.com/nodejs/node/pull/24264#discussion_r232506171
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
addaleaxhttps://github.com/addaleax
Nov 12, 2018https://github.com/nodejs/node/pull/24264#discussion_r232639957
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
src/node_http2.cchttps://github.com/nodejs/node/pull/24264/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
Please reload this pagehttps://github.com/nodejs/node/pull/24264
src/node_http2.cchttps://github.com/nodejs/node/pull/24264/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
Please reload this pagehttps://github.com/nodejs/node/pull/24264
src/node_http2.cchttps://github.com/nodejs/node/pull/24264/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
refackhttps://github.com/refack
Nov 11, 2018https://github.com/nodejs/node/pull/24264#discussion_r232504536
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
src/node_http_parser.cchttps://github.com/nodejs/node/pull/24264/files#diff-bbcf7a115fe4680f3a7c076a487c89bd4ce935e7d2a726cfcb3f69331705e25e
Please reload this pagehttps://github.com/nodejs/node/pull/24264
src/node_os.cchttps://github.com/nodejs/node/pull/24264/files#diff-d7e4bd6c075665cd9b102228c64daf3fb862630a5d3120d535a2e27cc647422a
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://github.com/refack
refackhttps://github.com/refack
Nov 11, 2018 https://github.com/nodejs/node/pull/24264#pullrequestreview-173716115
View reviewed changes https://github.com/nodejs/node/pull/24264/files/0b3568c87b58caa8e3f4cab9172159845bf28622
lib/os.jshttps://github.com/nodejs/node/pull/24264/files/0b3568c87b58caa8e3f4cab9172159845bf28622#diff-169b839d55312a439ec3709adaa8422a38a872d610dc33bb8151e3ffacc9265f
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://github.com/joyeecheung
fixup! http2: remove pushValueToArray in Http2Session::HandleHeadersF…https://github.com/nodejs/node/pull/24264/commits/a44e978df626a6df427ec91f6d27d0f0a65e26c8
a44e978https://github.com/nodejs/node/pull/24264/commits/a44e978df626a6df427ec91f6d27d0f0a65e26c8
https://github.com/refack
refackhttps://github.com/refack
Nov 11, 2018 https://github.com/nodejs/node/pull/24264#pullrequestreview-173718868
View reviewed changes https://github.com/nodejs/node/pull/24264/files/0b3568c87b58caa8e3f4cab9172159845bf28622
lib/os.jshttps://github.com/nodejs/node/pull/24264/files/0b3568c87b58caa8e3f4cab9172159845bf28622#diff-169b839d55312a439ec3709adaa8422a38a872d610dc33bb8151e3ffacc9265f
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://github.com/refack
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24264
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 12, 2018 https://github.com/nodejs/node/pull/24264#pullrequestreview-173878140
View reviewed changes https://github.com/nodejs/node/pull/24264/files/0b3568c87b58caa8e3f4cab9172159845bf28622
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/24264#pullrequestreview-173878140
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/24264
src/node_http2.cchttps://github.com/nodejs/node/pull/24264/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
addaleaxhttps://github.com/addaleax
Nov 12, 2018https://github.com/nodejs/node/pull/24264#discussion_r232639957
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
src/node_http2.cchttps://github.com/nodejs/node/pull/24264/files/0b3568c87b58caa8e3f4cab9172159845bf28622#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
addaleaxhttps://github.com/addaleax
Nov 12, 2018https://github.com/nodejs/node/pull/24264#discussion_r232640860
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://github.com/danbev
danbevhttps://github.com/danbev
Nov 13, 2018 https://github.com/nodejs/node/pull/24264#pullrequestreview-174191672
View reviewed changes https://github.com/nodejs/node/pull/24264/files/0b3568c87b58caa8e3f4cab9172159845bf28622
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 13, 2018 https://github.com/nodejs/node/pull/24264#ref-pullrequest-379578132
doc: make C++ core guidelines a reference #24315 https://github.com/nodejs/node/pull/24315
joyeecheunghttps://github.com/joyeecheung
November 13, 2018 21:01https://github.com/nodejs/node/pull/24264#commits-pushed-fcaf05a
https://github.com/joyeecheung
fixup! http2: remove pushValueToArray in Http2Session::HandleOriginFramehttps://github.com/nodejs/node/pull/24264/commits/fcaf05ad98c132412dd2245b28ffc4d0da61ab9f
fcaf05ahttps://github.com/nodejs/node/pull/24264/commits/fcaf05ad98c132412dd2245b28ffc4d0da61ab9f
https://github.com/joyeecheung
fixup! os: do not call into JS to push values to an array in GetCPUInfohttps://github.com/nodejs/node/pull/24264/commits/07b541734546aa86d87fbba766d21b4e07f733ed
07b5417https://github.com/nodejs/node/pull/24264/commits/07b541734546aa86d87fbba766d21b4e07f733ed
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 13, 2018https://github.com/nodejs/node/pull/24264#issuecomment-438267591
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://ci.nodejs.org/job/node-test-pull-request/18576/https://ci.nodejs.org/job/node-test-pull-request/18576/
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 13, 2018https://github.com/nodejs/node/pull/24264#event-1963068601
joyeecheunghttps://github.com/joyeecheung
Nov 13, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-51cea61
https://github.com/joyeecheung
os: do not call into JS to push values to an array in GetCPUInfohttps://github.com/nodejs/node/commit/51cea618e21ba88bc20feb537a72c1b831a94b46
51cea61https://github.com/nodejs/node/commit/51cea618e21ba88bc20feb537a72c1b831a94b46
#24264https://github.com/nodejs/node/pull/24264
joyeecheunghttps://github.com/joyeecheung
Nov 13, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-5877836
https://github.com/joyeecheung
src: remove pushValueToArray and SetupProcessObjecthttps://github.com/nodejs/node/commit/5877836a33c23dfa591f75005182fb4ab379bcdc
5877836https://github.com/nodejs/node/commit/5877836a33c23dfa591f75005182fb4ab379bcdc
#24264https://github.com/nodejs/node/pull/24264
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-7ffbb1f
https://github.com/joyeecheung
https://github.com/BridgeAR
http2: remove pushValueToArray in Http2Session::HandleHeadersFramehttps://github.com/nodejs/node/commit/7ffbb1f55fc65779e7053a36865cd5d56ffaba76
7ffbb1fhttps://github.com/nodejs/node/commit/7ffbb1f55fc65779e7053a36865cd5d56ffaba76
#24264https://github.com/nodejs/node/pull/24264
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-62fefd8
https://github.com/joyeecheung
https://github.com/BridgeAR
http2: remove pushValueToArray in Http2Session::HandleOriginFramehttps://github.com/nodejs/node/commit/62fefd8aeb39e468f729b8edccf324da1b33db18
62fefd8https://github.com/nodejs/node/commit/62fefd8aeb39e468f729b8edccf324da1b33db18
#24264https://github.com/nodejs/node/pull/24264
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-86aa27f
https://github.com/joyeecheung
https://github.com/BridgeAR
http: remove pushValueToArray in Parser::CreateHeaders()https://github.com/nodejs/node/commit/86aa27f85dc7cb1976b90c3338694ca735dddaf5
86aa27fhttps://github.com/nodejs/node/commit/86aa27f85dc7cb1976b90c3338694ca735dddaf5
#24264https://github.com/nodejs/node/pull/24264
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-e588846
https://github.com/joyeecheung
https://github.com/BridgeAR
process: remove pushValueToArray in EnvEnumeratorhttps://github.com/nodejs/node/commit/e5888462f6fbcc9e28e7d6d9eb4b4702242d84ed
e588846https://github.com/nodejs/node/commit/e5888462f6fbcc9e28e7d6d9eb4b4702242d84ed
#24264https://github.com/nodejs/node/pull/24264
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-ba4337d
https://github.com/joyeecheung
https://github.com/BridgeAR
process: remove pushValueToArray in GetActiveRequestshttps://github.com/nodejs/node/commit/ba4337d77d9e27b9bfc81269c9b695d0d6a6425a
ba4337dhttps://github.com/nodejs/node/commit/ba4337d77d9e27b9bfc81269c9b695d0d6a6425a
#24264https://github.com/nodejs/node/pull/24264
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-ccc3bb7
https://github.com/joyeecheung
https://github.com/BridgeAR
process: remove pushValueToArray in GetActiveHandleshttps://github.com/nodejs/node/commit/ccc3bb73db4068bcc40171995236c7879dba81f8
ccc3bb7https://github.com/nodejs/node/commit/ccc3bb73db4068bcc40171995236c7879dba81f8
#24264https://github.com/nodejs/node/pull/24264
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-293983a
https://github.com/joyeecheung
https://github.com/BridgeAR
os: do not call into JS to push values to an array in GetCPUInfohttps://github.com/nodejs/node/commit/293983a11220c07dc64c1c6816a66c70c1b4c5c1
293983ahttps://github.com/nodejs/node/commit/293983a11220c07dc64c1c6816a66c70c1b4c5c1
#24264https://github.com/nodejs/node/pull/24264
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-f8ed673
https://github.com/joyeecheung
https://github.com/BridgeAR
src: remove pushValueToArray and SetupProcessObjecthttps://github.com/nodejs/node/commit/f8ed673308b1d504390bb4bce7643b0de455cd74
f8ed673https://github.com/nodejs/node/commit/f8ed673308b1d504390bb4bce7643b0de455cd74
#24264https://github.com/nodejs/node/pull/24264
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24264#ref-pullrequest-380492752
Release proposal: v11.2 #24350 https://github.com/nodejs/node/pull/24350
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-32cb403
https://github.com/joyeecheung
https://github.com/kiyomizumia
http2: remove pushValueToArray in Http2Session::HandleHeadersFramehttps://github.com/kiyomizumia/node/commit/32cb40301169cf6148c5892af8d9d3109ac1421c
32cb403https://github.com/kiyomizumia/node/commit/32cb40301169cf6148c5892af8d9d3109ac1421c
nodejs#24264https://github.com/nodejs/node/pull/24264
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-263e50a
https://github.com/joyeecheung
https://github.com/kiyomizumia
http2: remove pushValueToArray in Http2Session::HandleOriginFramehttps://github.com/kiyomizumia/node/commit/263e50a7cb8ae93a630763b26b016c2ae5600335
263e50ahttps://github.com/kiyomizumia/node/commit/263e50a7cb8ae93a630763b26b016c2ae5600335
nodejs#24264https://github.com/nodejs/node/pull/24264
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-524bdb3
https://github.com/joyeecheung
https://github.com/kiyomizumia
http: remove pushValueToArray in Parser::CreateHeaders()https://github.com/kiyomizumia/node/commit/524bdb323ca7afc4e033b489700e149a4ed89282
524bdb3https://github.com/kiyomizumia/node/commit/524bdb323ca7afc4e033b489700e149a4ed89282
nodejs#24264https://github.com/nodejs/node/pull/24264
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-41189d5
https://github.com/joyeecheung
https://github.com/kiyomizumia
process: remove pushValueToArray in EnvEnumeratorhttps://github.com/kiyomizumia/node/commit/41189d5d4355c2f9e76309ef6e5fcb0682b34e77
41189d5https://github.com/kiyomizumia/node/commit/41189d5d4355c2f9e76309ef6e5fcb0682b34e77
nodejs#24264https://github.com/nodejs/node/pull/24264
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-35297d6
https://github.com/joyeecheung
https://github.com/kiyomizumia
process: remove pushValueToArray in GetActiveRequestshttps://github.com/kiyomizumia/node/commit/35297d6adff8d07dec2e79a5d9f515d9429b6bc5
35297d6https://github.com/kiyomizumia/node/commit/35297d6adff8d07dec2e79a5d9f515d9429b6bc5
nodejs#24264https://github.com/nodejs/node/pull/24264
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-d2e630e
https://github.com/joyeecheung
https://github.com/kiyomizumia
process: remove pushValueToArray in GetActiveHandleshttps://github.com/kiyomizumia/node/commit/d2e630eac5d22b8651347a6d15730eb265efd0d9
d2e630ehttps://github.com/kiyomizumia/node/commit/d2e630eac5d22b8651347a6d15730eb265efd0d9
nodejs#24264https://github.com/nodejs/node/pull/24264
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-11604c7
https://github.com/joyeecheung
https://github.com/kiyomizumia
os: do not call into JS to push values to an array in GetCPUInfohttps://github.com/kiyomizumia/node/commit/11604c73958a33124373e6c9f84f1962f8b1d44f
11604c7https://github.com/kiyomizumia/node/commit/11604c73958a33124373e6c9f84f1962f8b1d44f
nodejs#24264https://github.com/nodejs/node/pull/24264
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24264#ref-commit-15527d3
https://github.com/joyeecheung
https://github.com/kiyomizumia
src: remove pushValueToArray and SetupProcessObjecthttps://github.com/kiyomizumia/node/commit/15527d35a5593c9d0b5f237691f0d69bea23e857
15527d3https://github.com/kiyomizumia/node/commit/15527d35a5593c9d0b5f237691f0d69bea23e857
nodejs#24264https://github.com/nodejs/node/pull/24264
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232 https://github.com/beevelop/docker-nodejs/issues/232
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249 https://github.com/beevelop/docker-android-nodejs/issues/249
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233 https://github.com/beevelop/docker-nodejs/issues/233
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234 https://github.com/beevelop/docker-nodejs/issues/234
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235 https://github.com/beevelop/docker-nodejs/issues/235
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236 https://github.com/beevelop/docker-nodejs/issues/236
doc: include undefined in os.cpus() return values #24408 https://github.com/nodejs/node/pull/24408
os needs fix to detect CPUs or fall back to 1 #19022 https://github.com/nodejs/node/issues/19022
https://github.com/targos
targoshttps://github.com/targos
Nov 28, 2018 https://github.com/nodejs/node/pull/24264#ref-pullrequest-374073297
src: fix compiler warnings #23880 https://github.com/nodejs/node/pull/23880
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jan 12, 2019https://github.com/nodejs/node/pull/24264#issuecomment-453783305
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://github.com/codebytere
codebyterehttps://github.com/codebytere
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jan 12, 2019https://github.com/nodejs/node/pull/24264#event-2070278802
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24264
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/24264/files/0b3568c87b58caa8e3f4cab9172159845bf28622
https://github.com/bmeurer
bmeurer https://github.com/bmeurer
https://github.com/nodejs/node/pull/24264/files/3cb8bf91a4e29df2c921b1ff52651e5ab3e4eb6f
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/24264/files/07b541734546aa86d87fbba766d21b4e07f733ed
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/24264/files/0b3568c87b58caa8e3f4cab9172159845bf28622
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/24264
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/refack
https://github.com/addaleax
https://github.com/codebytere
https://github.com/danbev
https://github.com/bmeurer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.