| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f8338887-649f-e561-33b3-b6685c3766be |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AFF0:AFE03:22A910:2B907E:69911817 |
| html-safe-nonce | 8beb8be843ba369d8b16bb3caab93835e2229039ec6884d438c2474bcc324599 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkYwOkFGRTAzOjIyQTkxMDoyQjkwN0U6Njk5MTE4MTciLCJ2aXNpdG9yX2lkIjoiNjIxNjI3MTY2Mjk1MTc2NjAzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 409b697fd7914f4e716e194e859fc9fc64064aa030b12af24b410aa930bf8430 |
| hovercard-subject-tag | pull_request:229190604 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24237/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9ab8cac21aed41a0ad004f814bdefd9cb81be7cca5727b5c5227899f3377911b/nodejs/node/pull/24237 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9ab8cac21aed41a0ad004f814bdefd9cb81be7cca5727b5c5227899f3377911b/nodejs/node/pull/24237 |
| og:image:alt | An alternative UX idea:
At the end of the installer open the created Shortcut dir, where the users can explicitly call the new Install Additional Tools for Node.js shortcut.
Refs: #22645
Fixes: #23... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | refack |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/24237#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24237 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24237 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/24237 |
| Reload | https://github.com/nodejs/node/pull/24237 |
| Reload | https://github.com/nodejs/node/pull/24237 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
704
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| refack:change-win-installer-tools-behaviur | https://github.com/refack/node/tree/change-win-installer-tools-behaviur |
| Conversation | https://github.com/nodejs/node/pull/24237 |
| Commits6 (6) | https://github.com/nodejs/node/pull/24237/commits |
| Checks | https://github.com/nodejs/node/pull/24237/checks |
| Files changed | https://github.com/nodejs/node/pull/24237/files |
| build,win: open shortcut folder instead of running script | https://github.com/nodejs/node/pull/24237#top |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| refack:change-win-installer-tools-behaviur | https://github.com/refack/node/tree/change-win-installer-tools-behaviur |
|
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 7, 2018 | https://github.com/nodejs/node/pull/24237#issue-378497960 |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| #22645 | https://github.com/nodejs/node/pull/22645 |
| #23838 | https://github.com/nodejs/node/issues/23838 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
|
| https://github.com/refack |
| build,win: open shortcut folder instead of running script | https://github.com/nodejs/node/pull/24237/commits/dab27c03eafe0e29fce9bc7650323c4c69e98a7f |
| dab27c0 | https://github.com/nodejs/node/pull/24237/commits/dab27c03eafe0e29fce9bc7650323c4c69e98a7f |
| https://github.com/refack |
| refack | https://github.com/refack |
| bzoz | https://github.com/bzoz |
| joaocgreis | https://github.com/joaocgreis |
| richardlau | https://github.com/richardlau |
| tniessen | https://github.com/tniessen |
| November 7, 2018 22:32 | https://github.com/nodejs/node/pull/24237#event-1952912375 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 7, 2018 | https://github.com/nodejs/node/pull/24237#issuecomment-436802331 |
| @refack | https://github.com/refack |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1534/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1534/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
install
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainstall |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Nov 7, 2018 | https://github.com/nodejs/node/pull/24237#event-1952912455 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Nov 8, 2018 | https://github.com/nodejs/node/pull/24237#issuecomment-436859721 |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 8, 2018 | https://github.com/nodejs/node/pull/24237#issuecomment-437031983 |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
regression
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aregression |
| Nov 8, 2018 | https://github.com/nodejs/node/pull/24237#event-1954554683 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 8, 2018 | https://github.com/nodejs/node/pull/24237#issuecomment-437032914 |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| https://github.com/refack |
| refack | https://github.com/refack |
| jdalton | https://github.com/jdalton |
| November 8, 2018 15:26 | https://github.com/nodejs/node/pull/24237#event-1954579486 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Nov 8, 2018 | https://github.com/nodejs/node/pull/24237#issuecomment-437046816 |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| https://nodejs.org/download/test/v12.0.0-test20181108dab27c03ea/ | https://nodejs.org/download/test/v12.0.0-test20181108dab27c03ea/ |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Nov 8, 2018
| https://github.com/nodejs/node/pull/24237#pullrequestreview-173127374 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24237/files/dab27c03eafe0e29fce9bc7650323c4c69e98a7f |
| tools/msvs/msi/product.wxs | https://github.com/nodejs/node/pull/24237/files/dab27c03eafe0e29fce9bc7650323c4c69e98a7f#diff-0ded7f95b8bdacc06cb87526e7144e7feaf1726a00ca7885db7002c34492d25e |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| tools/msvs/msi/product.wxs | https://github.com/nodejs/node/pull/24237/files/dab27c03eafe0e29fce9bc7650323c4c69e98a7f#diff-0ded7f95b8bdacc06cb87526e7144e7feaf1726a00ca7885db7002c34492d25e |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| richardlau | https://github.com/richardlau |
| November 8, 2018 14:27 | https://github.com/nodejs/node/pull/24237#commits-pushed-5d9cd8f |
|
| https://github.com/richardlau |
|
| https://github.com/refack |
| Update tools/msvs/msi/product.wxs | https://github.com/nodejs/node/pull/24237/commits/5d9cd8fc216e10b7c6fdcda93bd5cf4e36c354ba |
| 5d9cd8f | https://github.com/nodejs/node/pull/24237/commits/5d9cd8fc216e10b7c6fdcda93bd5cf4e36c354ba |
|
| https://github.com/richardlau |
|
| https://github.com/refack |
| Update tools/msvs/msi/product.wxs | https://github.com/nodejs/node/pull/24237/commits/9f70c62b0fac2198e36f66b1f56a5a59095fe08e |
| 9f70c62 | https://github.com/nodejs/node/pull/24237/commits/9f70c62b0fac2198e36f66b1f56a5a59095fe08e |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 8, 2018 | https://github.com/nodejs/node/pull/24237#issuecomment-437142075 |
| node-v12.0.0-test20181108dab27c03ea-x64.zip | https://github.com/nodejs/node/files/2563440/node-v12.0.0-test20181108dab27c03ea-x64.zip |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 8, 2018 | https://github.com/nodejs/node/pull/24237#issuecomment-437142626 |
| https://user-images.githubusercontent.com/96947/48225160-084b6f00-e36a-11e8-9b6d-86d08b95cd09.png |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Nov 8, 2018 | https://github.com/nodejs/node/pull/24237#issuecomment-437152165 |
| https://user-images.githubusercontent.com/96947/48225160-084b6f00-e36a-11e8-9b6d-86d08b95cd09.png |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
|
| https://github.com/refack |
| build,win: make installer res files ready for translation | https://github.com/nodejs/node/pull/24237/commits/905d7c74878409ccc19b44593ca02d99d5a2adc1 |
| 905d7c7 | https://github.com/nodejs/node/pull/24237/commits/905d7c74878409ccc19b44593ca02d99d5a2adc1 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Nov 8, 2018
| https://github.com/nodejs/node/pull/24237#ref-pullrequest-356239498 |
|
win,msi: install tools for native modules
#22645
| https://github.com/nodejs/node/pull/22645 |
| refack | https://github.com/refack |
| November 8, 2018 19:31 | https://github.com/nodejs/node/pull/24237#commits-pushed-00742b0 |
|
| https://github.com/refack |
| fixup! | https://github.com/nodejs/node/pull/24237/commits/00742b0612683dc233bd41e4df5e1ac9f15dccdf |
| 00742b0 | https://github.com/nodejs/node/pull/24237/commits/00742b0612683dc233bd41e4df5e1ac9f15dccdf |
|
| https://github.com/refack |
| fixup!! | https://github.com/nodejs/node/pull/24237/commits/590b1d53e7b3d13f37634f8713b9cf256d21d896 |
| 590b1d5 | https://github.com/nodejs/node/pull/24237/commits/590b1d53e7b3d13f37634f8713b9cf256d21d896 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 9, 2018 | https://github.com/nodejs/node/pull/24237#issuecomment-437218867 |
| https://user-images.githubusercontent.com/96947/48237627-7a857900-e395-11e8-8683-42619a9764cf.png |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 21, 2018 | https://github.com/nodejs/node/pull/24237#issuecomment-440514343 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Nov 26, 2018 | https://github.com/nodejs/node/pull/24237#event-1987983079 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/24237#event-2039792800 |
| https://github.com/refack |
| refack | https://github.com/refack |
| December 21, 2018 01:31 | https://github.com/nodejs/node/pull/24237#event-2039792802 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24237 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/24237/files/dab27c03eafe0e29fce9bc7650323c4c69e98a7f |
|
| https://github.com/joaocgreis |
|
joaocgreis
| https://github.com/joaocgreis |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/bzoz |
|
bzoz
| https://github.com/bzoz |
|
| https://github.com/jdalton |
|
jdalton
| https://github.com/jdalton |
|
install
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainstall |
|
regression
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aregression |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
|
Node v11.0 windows installation opting into chocolatey+boxstarter results in infinite reboots
| https://github.com/nodejs/node/issues/23838 |
| Please reload this page | https://github.com/nodejs/node/pull/24237 |
|
| https://github.com/refack |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/joaocgreis |
|
| https://github.com/richardlau |
|
| https://github.com/Trott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |