René's URL Explorer Experiment


Title: src: compile native modules and their code cache in C++ by joyeecheung · Pull Request #24221 · nodejs/node · GitHub

Open Graph Title: src: compile native modules and their code cache in C++ by joyeecheung · Pull Request #24221 · nodejs/node

X Title: src: compile native modules and their code cache in C++ by joyeecheung · Pull Request #24221 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR contains two patch. The first one, a benchmark patch, is only here so that we can run the benchmark CI with more options. I have opened another PR for that patch: #24220 The second patch mo...

X Description: This PR contains two patch. The first one, a benchmark patch, is only here so that we can run the benchmark CI with more options. I have opened another PR for that patch: #24220 The second patch mo...

Opengraph URL: https://github.com/nodejs/node/pull/24221

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c49283e3-b6c1-3bec-832b-1a36c3661e81
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB0D0:1DC05B:4C284:61F10:69901BBE
html-safe-nonce3381770329d76a2c74f4218afaa5d978a0d198fc87f9967875e6cbfac27f3009
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEQwOjFEQzA1Qjo0QzI4NDo2MUYxMDo2OTkwMUJCRSIsInZpc2l0b3JfaWQiOiI1NTc2MDM2ODEzODc1NzE1MDA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5f39bee8f712b09d288c39ec08b788b046693faf17b25cfb8813b879f1ddcf97
hovercard-subject-tagpull_request:228989578
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24221/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cc099c5c859fc9f2826583e99c4410288937a52cf84043b2c21b48f6188110cf/nodejs/node/pull/24221
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cc099c5c859fc9f2826583e99c4410288937a52cf84043b2c21b48f6188110cf/nodejs/node/pull/24221
og:image:altThis PR contains two patch. The first one, a benchmark patch, is only here so that we can run the benchmark CI with more options. I have opened another PR for that patch: #24220 The second patch mo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24221#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24221
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24221
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24221
Reloadhttps://github.com/nodejs/node/pull/24221
Reloadhttps://github.com/nodejs/node/pull/24221
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24221
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:native-modulehttps://github.com/joyeecheung/node/tree/native-module
Conversationhttps://github.com/nodejs/node/pull/24221
Commits3 (3)https://github.com/nodejs/node/pull/24221/commits
Checkshttps://github.com/nodejs/node/pull/24221/checks
Files changedhttps://github.com/nodejs/node/pull/24221/files
src: compile native modules and their code cache in C++https://github.com/nodejs/node/pull/24221#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:native-modulehttps://github.com/joyeecheung/node/tree/native-module
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 7, 2018https://github.com/nodejs/node/pull/24221#issue-378238583
Please reload this pagehttps://github.com/nodejs/node/pull/24221
#24220https://github.com/nodejs/node/pull/24220
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 7, 2018https://github.com/nodejs/node/pull/24221#issuecomment-436585954
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1526/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1526/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Nov 7, 2018https://github.com/nodejs/node/pull/24221#event-1951316706
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 7, 2018https://github.com/nodejs/node/pull/24221#issuecomment-436586695
https://ci.nodejs.org/job/node-test-pull-request/18401/https://ci.nodejs.org/job/node-test-pull-request/18401/
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/260/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/260/
#23837https://github.com/nodejs/node/pull/23837
@ryzokukenhttps://github.com/ryzokuken
@addaleaxhttps://github.com/addaleax
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 7, 2018https://github.com/nodejs/node/pull/24221#issuecomment-436586962
@bcoehttps://github.com/bcoe
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 7, 2018https://github.com/nodejs/node/pull/24221#issuecomment-436669591
https://ci.nodejs.org/job/node-test-pull-request/18403/https://ci.nodejs.org/job/node-test-pull-request/18403/
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 7, 2018https://github.com/nodejs/node/pull/24221#issuecomment-436699860
Please reload this pagehttps://github.com/nodejs/node/pull/24221
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/bcoe
bcoehttps://github.com/bcoe
Nov 7, 2018https://github.com/nodejs/node/pull/24221#issuecomment-436718779
@joyeecheunghttps://github.com/joyeecheung
#23941https://github.com/nodejs/node/pull/23941
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 8, 2018https://github.com/nodejs/node/pull/24221#issuecomment-436913077
@bcoehttps://github.com/bcoe
https://coverage.nodejs.org/coverage-7cf56797dddc7a00/root/internal/bootstrap/loaders.js.htmlhttps://coverage.nodejs.org/coverage-7cf56797dddc7a00/root/internal/bootstrap/loaders.js.html
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
src: compile native modules and their code cache in C++https://github.com/nodejs/node/pull/24221/commits/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f
56fb2abhttps://github.com/nodejs/node/pull/24221/commits/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/2d84ae0082385067ed39124aa447ef3fa29e18a0..56fb2ab8735c0accfecd67bd72dbd1bca1faf84f
2d84ae0https://github.com/nodejs/node/commit/2d84ae0082385067ed39124aa447ef3fa29e18a0
56fb2abhttps://github.com/nodejs/node/commit/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f
Compare https://github.com/nodejs/node/compare/2d84ae0082385067ed39124aa447ef3fa29e18a0..56fb2ab8735c0accfecd67bd72dbd1bca1faf84f
November 13, 2018 20:01https://github.com/nodejs/node/pull/24221#event-1964091612
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 13, 2018https://github.com/nodejs/node/pull/24221#issuecomment-438416717
https://ci.nodejs.org/job/node-test-pull-request/18586/https://ci.nodejs.org/job/node-test-pull-request/18586/
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 13, 2018https://github.com/nodejs/node/pull/24221#issuecomment-438417160
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/273/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/273/
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 13, 2018https://github.com/nodejs/node/pull/24221#issuecomment-438438496
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Nov 13, 2018 https://github.com/nodejs/node/pull/24221#pullrequestreview-174601024
View reviewed changes https://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f
src/env.hhttps://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
TimothyGuhttps://github.com/TimothyGu
Nov 13, 2018https://github.com/nodejs/node/pull/24221#discussion_r233232996
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
src/env.hhttps://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
TimothyGuhttps://github.com/TimothyGu
Nov 13, 2018https://github.com/nodejs/node/pull/24221#discussion_r233233296
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
src/node_native_module.cchttps://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f#diff-e7c74467cd2c46418346e6d4c2f28ecba6bdb8f42f1977c799bd52ddb10f979b
Please reload this pagehttps://github.com/nodejs/node/pull/24221
src/node_native_module.cchttps://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f#diff-e7c74467cd2c46418346e6d4c2f28ecba6bdb8f42f1977c799bd52ddb10f979b
TimothyGuhttps://github.com/TimothyGu
Nov 13, 2018https://github.com/nodejs/node/pull/24221#discussion_r233236466
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233271422
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
test/code-cache/test-code-cache.jshttps://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f#diff-6a1798f9cedf2ce95f236c8a92b2a4b8a3a6ddc739f4a1c964c262407a18bd8a
TimothyGuhttps://github.com/TimothyGu
Nov 13, 2018https://github.com/nodejs/node/pull/24221#discussion_r233236969
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233271655
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
src/node_native_module.cchttps://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f#diff-e7c74467cd2c46418346e6d4c2f28ecba6bdb8f42f1977c799bd52ddb10f979b
TimothyGuhttps://github.com/TimothyGu
Nov 13, 2018https://github.com/nodejs/node/pull/24221#discussion_r233238036
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/src/util.hhttps://github.com/nodejs/node/blob/0603c0a53fc7051260f3f3d3de9582bc3e6af7c9/src/util.h#L385-L394
0603c0ahttps://github.com/nodejs/node/commit/0603c0a53fc7051260f3f3d3de9582bc3e6af7c9
Please reload this pagehttps://github.com/nodejs/node/pull/24221
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233283774
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
refackhttps://github.com/refack
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233286737
Please reload this pagehttps://github.com/nodejs/node/pull/24221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
src/node_native_module.cchttps://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f#diff-e7c74467cd2c46418346e6d4c2f28ecba6bdb8f42f1977c799bd52ddb10f979b
TimothyGuhttps://github.com/TimothyGu
Nov 13, 2018https://github.com/nodejs/node/pull/24221#discussion_r233238197
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
src/node_native_module.cchttps://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f#diff-e7c74467cd2c46418346e6d4c2f28ecba6bdb8f42f1977c799bd52ddb10f979b
TimothyGuhttps://github.com/TimothyGu
Nov 13, 2018https://github.com/nodejs/node/pull/24221#discussion_r233238301
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
src/node_native_module.cchttps://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f#diff-e7c74467cd2c46418346e6d4c2f28ecba6bdb8f42f1977c799bd52ddb10f979b
TimothyGuhttps://github.com/TimothyGu
Nov 13, 2018https://github.com/nodejs/node/pull/24221#discussion_r233238352
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
src/node_native_module.cchttps://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f#diff-e7c74467cd2c46418346e6d4c2f28ecba6bdb8f42f1977c799bd52ddb10f979b
TimothyGuhttps://github.com/TimothyGu
Nov 13, 2018https://github.com/nodejs/node/pull/24221#discussion_r233238610
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/refack
refackhttps://github.com/refack
Nov 14, 2018 https://github.com/nodejs/node/pull/24221#pullrequestreview-174654044
View reviewed changes https://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f
src/node_native_module.cchttps://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f#diff-e7c74467cd2c46418346e6d4c2f28ecba6bdb8f42f1977c799bd52ddb10f979b
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/refack
refackhttps://github.com/refack
Nov 14, 2018 https://github.com/nodejs/node/pull/24221#pullrequestreview-174655337
View reviewed changes https://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/24221#pullrequestreview-174655337
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
fixup! src: compile native modules and their code cache in C++https://github.com/nodejs/node/pull/24221/commits/7f8e120c77033bfb240f20d52c5ecdac02b16c00
7f8e120https://github.com/nodejs/node/pull/24221/commits/7f8e120c77033bfb240f20d52c5ecdac02b16c00
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#issuecomment-438501935
https://ci.nodejs.org/job/node-test-pull-request/18596/https://ci.nodejs.org/job/node-test-pull-request/18596/
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#issuecomment-438625680
Please reload this pagehttps://github.com/nodejs/node/pull/24221
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 14, 2018 https://github.com/nodejs/node/pull/24221#pullrequestreview-174825795
View reviewed changes https://github.com/nodejs/node/pull/24221/files/7f8e120c77033bfb240f20d52c5ecdac02b16c00
src/env.hhttps://github.com/nodejs/node/pull/24221/files/7f8e120c77033bfb240f20d52c5ecdac02b16c00#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
addaleaxhttps://github.com/addaleax
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233419482
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233472058
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
src/node_code_cache.hhttps://github.com/nodejs/node/pull/24221/files/7f8e120c77033bfb240f20d52c5ecdac02b16c00#diff-9c4027d9d862b1a8efec3cba1e91dff9cf85e827e62fb80e5eeca419728706a6
addaleaxhttps://github.com/addaleax
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233419776
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
refackhttps://github.com/refack
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233477965
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233533396
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/24221
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233533771
Please reload this pagehttps://github.com/nodejs/node/pull/24221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
refackhttps://github.com/refack
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233539629
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/24221
refackhttps://github.com/refack
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233540744
Please reload this pagehttps://github.com/nodejs/node/pull/24221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
src/node_native_module.cchttps://github.com/nodejs/node/pull/24221/files/7f8e120c77033bfb240f20d52c5ecdac02b16c00#diff-e7c74467cd2c46418346e6d4c2f28ecba6bdb8f42f1977c799bd52ddb10f979b
addaleaxhttps://github.com/addaleax
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233420176
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233474597
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
addaleaxhttps://github.com/addaleax
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233477880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
refackhttps://github.com/refack
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233482571
Please reload this pagehttps://github.com/nodejs/node/pull/24221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
addaleaxhttps://github.com/addaleax
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233483448
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#discussion_r233536617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
fixup! fixup! src: compile native modules and their code cache in C++https://github.com/nodejs/node/pull/24221/commits/c7b7706add6eb678f9cdacc7df911ef727858053
c7b7706https://github.com/nodejs/node/pull/24221/commits/c7b7706add6eb678f9cdacc7df911ef727858053
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#issuecomment-438720246
https://ci.nodejs.org/job/node-test-pull-request/18611/https://ci.nodejs.org/job/node-test-pull-request/18611/
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/refack
refackhttps://github.com/refack
Nov 14, 2018https://github.com/nodejs/node/pull/24221#issuecomment-438737031
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#issuecomment-438739841
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#issuecomment-438762419
https://ci.nodejs.org/job/node-test-binary-windows/21540/https://ci.nodejs.org/job/node-test-binary-windows/21540/
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#issuecomment-438768784
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018https://github.com/nodejs/node/pull/24221#event-1966669822
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Nov 14, 2018https://github.com/nodejs/node/pull/24221#event-1966672644
joyeecheunghttps://github.com/joyeecheung
Nov 14, 2018 https://github.com/nodejs/node/pull/24221#ref-commit-bd765d6
https://github.com/joyeecheung
src: compile native modules and their code cache in C++https://github.com/nodejs/node/commit/bd765d61d7425d82e80bdf2f4f27c0424221837b
bd765d6https://github.com/nodejs/node/commit/bd765d61d7425d82e80bdf2f4f27c0424221837b
#24221https://github.com/nodejs/node/pull/24221
BridgeARhttps://github.com/BridgeAR
Nov 15, 2018 https://github.com/nodejs/node/pull/24221#ref-commit-b7aded3
https://github.com/joyeecheung
https://github.com/BridgeAR
src: compile native modules and their code cache in C++https://github.com/nodejs/node/commit/b7aded3300269bc36d1a14b474c4a85e185189d4
b7aded3https://github.com/nodejs/node/commit/b7aded3300269bc36d1a14b474c4a85e185189d4
#24221https://github.com/nodejs/node/pull/24221
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 15, 2018 https://github.com/nodejs/node/pull/24221#ref-pullrequest-380492752
Release proposal: v11.2 #24350 https://github.com/nodejs/node/pull/24350
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232 https://github.com/beevelop/docker-nodejs/issues/232
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249 https://github.com/beevelop/docker-android-nodejs/issues/249
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233 https://github.com/beevelop/docker-nodejs/issues/233
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234 https://github.com/beevelop/docker-nodejs/issues/234
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235 https://github.com/beevelop/docker-nodejs/issues/235
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236 https://github.com/beevelop/docker-nodejs/issues/236
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 24, 2018https://github.com/nodejs/node/pull/24221#issuecomment-441334583
Please reload this pagehttps://github.com/nodejs/node/pull/24221
lib: move module exports proxy into a separate method #24057https://github.com/nodejs/node/pull/24057
lib: fix code cache generation, add more tests and enable them by default #23855https://github.com/nodejs/node/pull/23855
lib: fix code cache generation, add more tests and enable them by default #23855https://github.com/nodejs/node/pull/23855
vm: add dynamic import support #22381https://github.com/nodejs/node/pull/22381
bootstrapper: move internalBinding to NativeModule wrapper #23025https://github.com/nodejs/node/pull/23025
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Nov 25, 2018https://github.com/nodejs/node/pull/24221#issuecomment-441424722
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 25, 2018https://github.com/nodejs/node/pull/24221#issuecomment-441429432
Please reload this pagehttps://github.com/nodejs/node/pull/24221
@ryzokukenhttps://github.com/ryzokuken
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24221
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/24221/files/7f8e120c77033bfb240f20d52c5ecdac02b16c00
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/24221/files/c7b7706add6eb678f9cdacc7df911ef727858053
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/24221/files/56fb2ab8735c0accfecd67bd72dbd1bca1faf84f
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Please reload this pagehttps://github.com/nodejs/node/pull/24221
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/bcoe
https://github.com/refack
https://github.com/ryzokuken
https://github.com/addaleax
https://github.com/TimothyGu
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.