René's URL Explorer Experiment


Title: lib: removed redundant checking of bad importModuleDynamically throwing `ERR_VM_MODULE_NOT_MODULE` by alyssaq · Pull Request #24201 · nodejs/node · GitHub

Open Graph Title: lib: removed redundant checking of bad importModuleDynamically throwing `ERR_VM_MODULE_NOT_MODULE` by alyssaq · Pull Request #24201 · nodejs/node

X Title: lib: removed redundant checking of bad importModuleDynamically throwing `ERR_VM_MODULE_NOT_MODULE` by alyssaq · Pull Request #24201 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: ERR_VM_MODULE_NOT_MODULE error is already checked in linkingStatusMap.get. Thrown in source_text_module.js#L188 Tests are in #24161 make -j4 test (UNIX) passes commit message follows [commit gui...

X Description: ERR_VM_MODULE_NOT_MODULE error is already checked in linkingStatusMap.get. Thrown in source_text_module.js#L188 Tests are in #24161 make -j4 test (UNIX) passes commit message follows [commit gui...

Opengraph URL: https://github.com/nodejs/node/pull/24201

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:de78afbf-d82c-f269-83ab-2d128e13b79f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D8A:127F9C:281EA6:3216A8:69911714
html-safe-noncedf811cb79b55bde6357476b2a5dcd52fcf17aa853007ae7516008eb9971146fa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDhBOjEyN0Y5QzoyODFFQTY6MzIxNkE4OjY5OTExNzE0IiwidmlzaXRvcl9pZCI6IjI1Mjg5MjM1NDc5MTQ1NDA4MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace6b15b6fd1a22445e148604a494bb1536fcc7f3aa17b1f5b6c6c2434cc2090cb
hovercard-subject-tagpull_request:228792205
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24201/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fb85422de7d320314561ecee3d3a7721736ab9612520778f3cddf24f5d64fee4/nodejs/node/pull/24201
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fb85422de7d320314561ecee3d3a7721736ab9612520778f3cddf24f5d64fee4/nodejs/node/pull/24201
og:image:altERR_VM_MODULE_NOT_MODULE error is already checked in linkingStatusMap.get. Thrown in source_text_module.js#L188 Tests are in #24161 make -j4 test (UNIX) passes commit message follows [commit gui...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealyssaq
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24201#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24201
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24201
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24201
Reloadhttps://github.com/nodejs/node/pull/24201
Reloadhttps://github.com/nodejs/node/pull/24201
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24201
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
alyssaqhttps://github.com/alyssaq
nodejs:masterhttps://github.com/nodejs/node/tree/master
alyssaq:vmhttps://github.com/alyssaq/node/tree/vm
Conversationhttps://github.com/nodejs/node/pull/24201
Commits1 (1)https://github.com/nodejs/node/pull/24201/commits
Checkshttps://github.com/nodejs/node/pull/24201/checks
Files changedhttps://github.com/nodejs/node/pull/24201/files
lib: removed redundant checking of bad importModuleDynamically throwing ERR_VM_MODULE_NOT_MODULEhttps://github.com/nodejs/node/pull/24201#top
alyssaqhttps://github.com/alyssaq
nodejs:masterhttps://github.com/nodejs/node/tree/master
alyssaq:vmhttps://github.com/alyssaq/node/tree/vm
https://github.com/alyssaq
alyssaqhttps://github.com/alyssaq
Nov 6, 2018https://github.com/nodejs/node/pull/24201#issue-377978299
Please reload this pagehttps://github.com/nodejs/node/pull/24201
source_text_module.js#L188https://github.com/nodejs/node/blob/master/lib/internal/vm/source_text_module.js#L188
#24161https://github.com/nodejs/node/pull/24161
Please reload this pagehttps://github.com/nodejs/node/pull/24201
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Nov 6, 2018https://github.com/nodejs/node/pull/24201#event-1949752248
https://github.com/alyssaq
lib/vm.js: removed redundant checking of bad importModuleDynamicallyhttps://github.com/nodejs/node/pull/24201/commits/0b5d900788ff38184422cc0d187646bbb7f0c65d
0b5d900https://github.com/nodejs/node/pull/24201/commits/0b5d900788ff38184422cc0d187646bbb7f0c65d
https://github.com/alyssaq
alyssaqhttps://github.com/alyssaq
force-pushedhttps://github.com/nodejs/node/compare/b979b67fed1fbcce613bef3a0a572e714173a0a6..0b5d900788ff38184422cc0d187646bbb7f0c65d
b979b67https://github.com/nodejs/node/commit/b979b67fed1fbcce613bef3a0a572e714173a0a6
0b5d900https://github.com/nodejs/node/commit/0b5d900788ff38184422cc0d187646bbb7f0c65d
Compare https://github.com/nodejs/node/compare/b979b67fed1fbcce613bef3a0a572e714173a0a6..0b5d900788ff38184422cc0d187646bbb7f0c65d
November 6, 2018 18:44https://github.com/nodejs/node/pull/24201#event-1949782151
https://github.com/alyssaq
alyssaqhttps://github.com/alyssaq
Nov 6, 2018https://github.com/nodejs/node/pull/24201#event-1949783108
https://github.com/alyssaq
alyssaqhttps://github.com/alyssaq
Nov 6, 2018https://github.com/nodejs/node/pull/24201#event-1949812188
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24201
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Please reload this pagehttps://github.com/nodejs/node/pull/24201
https://github.com/alyssaq
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.