René's URL Explorer Experiment


Title: test: check for invalid importModuleDynamically type in vm.js by alyssaq · Pull Request #24161 · nodejs/node · GitHub

Open Graph Title: test: check for invalid importModuleDynamically type in vm.js by alyssaq · Pull Request #24161 · nodejs/node

X Title: test: check for invalid importModuleDynamically type in vm.js by alyssaq · Pull Request #24161 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Added test for checking the thrown error when the option importModuleDynamically is not a function.

X Description: Added test for checking the thrown error when the option importModuleDynamically is not a function.

Opengraph URL: https://github.com/nodejs/node/pull/24161

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c03650e3-5cb8-5d46-cc26-815ccfe79655
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB52:21A2D5:1033854:150BD05:6990C86D
html-safe-nonce2a95c05df3f8cc1da03e9e83b6b164e8408559ce79f3ebe15338d90ab2b43c7b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjUyOjIxQTJENToxMDMzODU0OjE1MEJEMDU6Njk5MEM4NkQiLCJ2aXNpdG9yX2lkIjoiMTgxMzg4NjU1NTAzMzk0OTI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0d20fd4dcfb017b11d24ec8aa6a518421c9d63c82b0c193ab3dadadb11f9ee08
hovercard-subject-tagpull_request:228736630
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24161/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8386193d231796d6c7eef5f4602ad4b71041d0fab7f7ca1a301269d27d245735/nodejs/node/pull/24161
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8386193d231796d6c7eef5f4602ad4b71041d0fab7f7ca1a301269d27d245735/nodejs/node/pull/24161
og:image:altAdded test for checking the thrown error when the option importModuleDynamically is not a function.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealyssaq
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24161#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24161
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24161
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24161
Reloadhttps://github.com/nodejs/node/pull/24161
Reloadhttps://github.com/nodejs/node/pull/24161
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24161
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
alyssaqhttps://github.com/alyssaq
nodejs:masterhttps://github.com/nodejs/node/tree/master
alyssaq:vmtesthttps://github.com/alyssaq/node/tree/vmtest
Conversationhttps://github.com/nodejs/node/pull/24161
Commits1 (1)https://github.com/nodejs/node/pull/24161/commits
Checkshttps://github.com/nodejs/node/pull/24161/checks
Files changedhttps://github.com/nodejs/node/pull/24161/files
test: check for invalid importModuleDynamically type in vm.jshttps://github.com/nodejs/node/pull/24161#top
alyssaqhttps://github.com/alyssaq
nodejs:masterhttps://github.com/nodejs/node/tree/master
alyssaq:vmtesthttps://github.com/alyssaq/node/tree/vmtest
https://github.com/alyssaq
alyssaqhttps://github.com/alyssaq
Nov 6, 2018https://github.com/nodejs/node/pull/24161#issue-377905477
Please reload this pagehttps://github.com/nodejs/node/pull/24161
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Nov 6, 2018https://github.com/nodejs/node/pull/24161#event-1949298608
https://github.com/alyssaq
alyssaqhttps://github.com/alyssaq
force-pushedhttps://github.com/nodejs/node/compare/345cbb3fb48dc9124b4f74d4d87ce26fd2885433..8d1a3422ba9e1536e46d61d0ca54abb8a032ec22
345cbb3https://github.com/nodejs/node/commit/345cbb3fb48dc9124b4f74d4d87ce26fd2885433
8d1a342https://github.com/nodejs/node/commit/8d1a3422ba9e1536e46d61d0ca54abb8a032ec22
Compare https://github.com/nodejs/node/compare/345cbb3fb48dc9124b4f74d4d87ce26fd2885433..8d1a3422ba9e1536e46d61d0ca54abb8a032ec22
November 6, 2018 15:48https://github.com/nodejs/node/pull/24161#event-1949314133
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 6, 2018 https://github.com/nodejs/node/pull/24161#pullrequestreview-172092605
View reviewed changes https://github.com/nodejs/node/pull/24161/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Nov 6, 2018https://github.com/nodejs/node/pull/24161#event-1949361761
https://github.com/alyssaq
alyssaqhttps://github.com/alyssaq
force-pushedhttps://github.com/nodejs/node/compare/8d1a3422ba9e1536e46d61d0ca54abb8a032ec22..1ecfd6cee7ca0d2e7757ee218e874b21b0c652da
8d1a342https://github.com/nodejs/node/commit/8d1a3422ba9e1536e46d61d0ca54abb8a032ec22
1ecfd6chttps://github.com/nodejs/node/commit/1ecfd6cee7ca0d2e7757ee218e874b21b0c652da
Compare https://github.com/nodejs/node/compare/8d1a3422ba9e1536e46d61d0ca54abb8a032ec22..1ecfd6cee7ca0d2e7757ee218e874b21b0c652da
November 6, 2018 16:24https://github.com/nodejs/node/pull/24161#event-1949427067
https://github.com/alyssaq
alyssaqhttps://github.com/alyssaq
Nov 6, 2018 https://github.com/nodejs/node/pull/24161#ref-pullrequest-377978299
lib: removed redundant checking of bad importModuleDynamically throwing ERR_VM_MODULE_NOT_MODULE #24201 https://github.com/nodejs/node/pull/24201
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 6, 2018 https://github.com/nodejs/node/pull/24161#pullrequestreview-172187290
View reviewed changes https://github.com/nodejs/node/pull/24161/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 10, 2018 https://github.com/nodejs/node/pull/24161#pullrequestreview-173670548
View reviewed changes https://github.com/nodejs/node/pull/24161/files
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 11, 2018https://github.com/nodejs/node/pull/24161#issuecomment-437655099
https://ci.nodejs.org/job/node-test-pull-request/18524/https://ci.nodejs.org/job/node-test-pull-request/18524/
Please reload this pagehttps://github.com/nodejs/node/pull/24161
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 12, 2018 https://github.com/nodejs/node/pull/24161#pullrequestreview-173789361
View reviewed changes https://github.com/nodejs/node/pull/24161/files
test/parallel/test-vm-module-dynamic-import.jshttps://github.com/nodejs/node/pull/24161/files#diff-eae55cd300c71348b8ea0ffcf32d9be884565b84f512b29b1474f1b969ee6f71
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 12, 2018https://github.com/nodejs/node/pull/24161#discussion_r232566525
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@alyssaqhttps://github.com/alyssaq
Please reload this pagehttps://github.com/nodejs/node/pull/24161
alyssaqhttps://github.com/alyssaq
Nov 12, 2018https://github.com/nodejs/node/pull/24161#discussion_r232677531
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24161
https://github.com/alyssaq
test: check for invalid importModuleDynamically type in vm.js for Scripthttps://github.com/nodejs/node/pull/24161/commits/2d08864fbb39fcde8a3106d67b013f8fbe71dd8a
2d08864https://github.com/nodejs/node/pull/24161/commits/2d08864fbb39fcde8a3106d67b013f8fbe71dd8a
https://github.com/alyssaq
alyssaqhttps://github.com/alyssaq
force-pushedhttps://github.com/nodejs/node/compare/1ecfd6cee7ca0d2e7757ee218e874b21b0c652da..2d08864fbb39fcde8a3106d67b013f8fbe71dd8a
1ecfd6chttps://github.com/nodejs/node/commit/1ecfd6cee7ca0d2e7757ee218e874b21b0c652da
2d08864https://github.com/nodejs/node/commit/2d08864fbb39fcde8a3106d67b013f8fbe71dd8a
Compare https://github.com/nodejs/node/compare/1ecfd6cee7ca0d2e7757ee218e874b21b0c652da..2d08864fbb39fcde8a3106d67b013f8fbe71dd8a
November 12, 2018 14:29https://github.com/nodejs/node/pull/24161#event-1960437485
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 13, 2018https://github.com/nodejs/node/pull/24161#issuecomment-438130211
https://ci.nodejs.org/job/node-test-pull-request/18568/https://ci.nodejs.org/job/node-test-pull-request/18568/
Please reload this pagehttps://github.com/nodejs/node/pull/24161
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 13, 2018 https://github.com/nodejs/node/pull/24161#pullrequestreview-174189108
View reviewed changes https://github.com/nodejs/node/pull/24161/files/2d08864fbb39fcde8a3106d67b013f8fbe71dd8a
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 13, 2018https://github.com/nodejs/node/pull/24161#issuecomment-438145008
dde9b3ahttps://github.com/nodejs/node/commit/dde9b3a0d3a206bd43946b2087f0d39ccc967c48
Please reload this pagehttps://github.com/nodejs/node/pull/24161
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 13, 2018https://github.com/nodejs/node/pull/24161#event-1962099720
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 13, 2018 https://github.com/nodejs/node/pull/24161#ref-commit-dde9b3a
https://github.com/alyssaq
https://github.com/gireeshpunathil
test: check for invalid module type in vm.jshttps://github.com/nodejs/node/commit/dde9b3a0d3a206bd43946b2087f0d39ccc967c48
dde9b3ahttps://github.com/nodejs/node/commit/dde9b3a0d3a206bd43946b2087f0d39ccc967c48
#24161https://github.com/nodejs/node/pull/24161
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24161#ref-commit-dd9864b
https://github.com/alyssaq
https://github.com/BridgeAR
test: check for invalid module type in vm.jshttps://github.com/nodejs/node/commit/dd9864b8d743c1f6c311e85735b7f84523ec95de
dd9864bhttps://github.com/nodejs/node/commit/dd9864b8d743c1f6c311e85735b7f84523ec95de
#24161https://github.com/nodejs/node/pull/24161
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24161#ref-pullrequest-380492752
Release proposal: v11.2 #24350 https://github.com/nodejs/node/pull/24350
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24161#ref-commit-18981e8
https://github.com/alyssaq
https://github.com/kiyomizumia
test: check for invalid module type in vm.jshttps://github.com/kiyomizumia/node/commit/18981e802f9c7a5728278e9c4d0db1e11d474462
18981e8https://github.com/kiyomizumia/node/commit/18981e802f9c7a5728278e9c4d0db1e11d474462
nodejs#24161https://github.com/nodejs/node/pull/24161
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232 https://github.com/beevelop/docker-nodejs/issues/232
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249 https://github.com/beevelop/docker-android-nodejs/issues/249
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233 https://github.com/beevelop/docker-nodejs/issues/233
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234 https://github.com/beevelop/docker-nodejs/issues/234
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235 https://github.com/beevelop/docker-nodejs/issues/235
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236 https://github.com/beevelop/docker-nodejs/issues/236
https://github.com/codebytere
codebyterehttps://github.com/codebytere
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Jan 12, 2019https://github.com/nodejs/node/pull/24161#event-2070230845
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24161
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/24161/files/1ecfd6cee7ca0d2e7757ee218e874b21b0c652da
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/24161/files/8d1a3422ba9e1536e46d61d0ca54abb8a032ec22
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/24161/files/2d08864fbb39fcde8a3106d67b013f8fbe71dd8a
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/24161/files/1ecfd6cee7ca0d2e7757ee218e874b21b0c652da
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/24161
https://github.com/alyssaq
https://github.com/gireeshpunathil
https://github.com/jasnell
https://github.com/addaleax
https://github.com/BridgeAR
https://github.com/codebytere
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.