| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:29202daf-94e6-a3ea-543a-5d3e67e4324b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9BD4:C9248:1B93D2:23B037:69903AD4 |
| html-safe-nonce | ed56d7b7366e97fe564755c217a11323f47220b71afb94e9cbf28f8e71f61004 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkQ0OkM5MjQ4OjFCOTNEMjoyM0IwMzc6Njk5MDNBRDQiLCJ2aXNpdG9yX2lkIjoiNjE0NDQyNjUyMzc2NjA0NTM5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8ab36b66bf58df346b4099c7d489600b06793d1810b17c06177ed2ee331411d6 |
| hovercard-subject-tag | pull_request:228732542 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24159/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d7085b7287b8ab1bc03e981a51570de05bd06ffaaefe0939f9f2a0b2d1b4a17f/nodejs/node/pull/24159 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d7085b7287b8ab1bc03e981a51570de05bd06ffaaefe0939f9f2a0b2d1b4a17f/nodejs/node/pull/24159 |
| og:image:alt | This PR removes an unnecessary parameter and if case in the function uvExceptionWithHostPort, since there is no call site that has a fifth argument.
From the NodeConf EU Code and Learn 💃
Checklist
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | msmichellegar |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/24159#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24159 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24159 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/24159 |
| Reload | https://github.com/nodejs/node/pull/24159 |
| Reload | https://github.com/nodejs/node/pull/24159 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/24159 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
708
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| msmichellegar | https://github.com/msmichellegar |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| msmichellegar:uvExceptionWithHostPort-params | https://github.com/msmichellegar/node/tree/uvExceptionWithHostPort-params |
| Conversation | https://github.com/nodejs/node/pull/24159 |
| Commits1 (1) | https://github.com/nodejs/node/pull/24159/commits |
| Checks | https://github.com/nodejs/node/pull/24159/checks |
| Files changed | https://github.com/nodejs/node/pull/24159/files |
| lib: remove additional param from uvExceptionWithHostPort | https://github.com/nodejs/node/pull/24159#top |
| msmichellegar | https://github.com/msmichellegar |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| msmichellegar:uvExceptionWithHostPort-params | https://github.com/msmichellegar/node/tree/uvExceptionWithHostPort-params |
|
| https://github.com/msmichellegar |
| msmichellegar | https://github.com/msmichellegar |
| Nov 6, 2018 | https://github.com/nodejs/node/pull/24159#issue-377900289 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/24159 |
|
| https://github.com/msmichellegar |
| lib: remove additional param from uvExceptionWithHostPort | https://github.com/nodejs/node/pull/24159/commits/4e5f3e110f4023598c18738447aea47073e8aaf4 |
| 4e5f3e1 | https://github.com/nodejs/node/pull/24159/commits/4e5f3e110f4023598c18738447aea47073e8aaf4 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
| Nov 6, 2018 | https://github.com/nodejs/node/pull/24159#event-1949265643 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 6, 2018
| https://github.com/nodejs/node/pull/24159#pullrequestreview-172082908 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24159/files/4e5f3e110f4023598c18738447aea47073e8aaf4 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 6, 2018 | https://github.com/nodejs/node/pull/24159#event-1949293861 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 6, 2018
| https://github.com/nodejs/node/pull/24159#pullrequestreview-172189245 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24159/files/4e5f3e110f4023598c18738447aea47073e8aaf4 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 10, 2018
| https://github.com/nodejs/node/pull/24159#pullrequestreview-173670543 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24159/files/4e5f3e110f4023598c18738447aea47073e8aaf4 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 11, 2018 | https://github.com/nodejs/node/pull/24159#issuecomment-437655038 |
| https://ci.nodejs.org/job/node-test-pull-request/18523/ | https://ci.nodejs.org/job/node-test-pull-request/18523/ |
| Please reload this page | https://github.com/nodejs/node/pull/24159 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 12, 2018 | https://github.com/nodejs/node/pull/24159#issuecomment-437795043 |
| https://ci.nodejs.org/job/node-test-pull-request/18547/ | https://ci.nodejs.org/job/node-test-pull-request/18547/ |
| Please reload this page | https://github.com/nodejs/node/pull/24159 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 12, 2018 | https://github.com/nodejs/node/pull/24159#issuecomment-437822167 |
| 4aec421 | https://github.com/nodejs/node/commit/4aec4216a0e3c24fffc428f11ed40b0157401365 |
| @msmichellegar | https://github.com/msmichellegar |
| https://www.nodetodo.org/next-steps | https://www.nodetodo.org/next-steps |
| Please reload this page | https://github.com/nodejs/node/pull/24159 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 12, 2018 | https://github.com/nodejs/node/pull/24159#event-1959829212 |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 12, 2018
| https://github.com/nodejs/node/pull/24159#ref-commit-4aec421 |
|
| https://github.com/msmichellegar |
|
| https://github.com/gireeshpunathil |
| lib: adjust params from uvExceptionWithHostPort | https://github.com/nodejs/node/commit/4aec4216a0e3c24fffc428f11ed40b0157401365 |
| 4aec421 | https://github.com/nodejs/node/commit/4aec4216a0e3c24fffc428f11ed40b0157401365 |
| #24159 | https://github.com/nodejs/node/pull/24159 |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 14, 2018
| https://github.com/nodejs/node/pull/24159#ref-commit-d8d9344 |
|
| https://github.com/msmichellegar |
|
| https://github.com/BridgeAR |
| lib: adjust params from uvExceptionWithHostPort | https://github.com/nodejs/node/commit/d8d93442aa96504e9f401a7ead8bf6c6022904c9 |
| d8d9344 | https://github.com/nodejs/node/commit/d8d93442aa96504e9f401a7ead8bf6c6022904c9 |
| #24159 | https://github.com/nodejs/node/pull/24159 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 14, 2018
| https://github.com/nodejs/node/pull/24159#ref-pullrequest-380492752 |
|
Release proposal: v11.2
#24350
| https://github.com/nodejs/node/pull/24350 |
| kiyomizumia | https://github.com/kiyomizumia |
|
Nov 15, 2018
| https://github.com/nodejs/node/pull/24159#ref-commit-213c4b6 |
|
| https://github.com/msmichellegar |
|
| https://github.com/kiyomizumia |
| lib: adjust params from uvExceptionWithHostPort | https://github.com/kiyomizumia/node/commit/213c4b689260341cfd0a7bcf25a6091d3b41d8b8 |
| 213c4b6 | https://github.com/kiyomizumia/node/commit/213c4b689260341cfd0a7bcf25a6091d3b41d8b8 |
| nodejs#24159 | https://github.com/nodejs/node/pull/24159 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#232
| https://github.com/beevelop/docker-nodejs/issues/232 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#249
| https://github.com/beevelop/docker-android-nodejs/issues/249 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#233
| https://github.com/beevelop/docker-nodejs/issues/233 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#234
| https://github.com/beevelop/docker-nodejs/issues/234 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#235
| https://github.com/beevelop/docker-nodejs/issues/235 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#236
| https://github.com/beevelop/docker-nodejs/issues/236 |
| codebytere | https://github.com/codebytere |
|
Jan 12, 2019
| https://github.com/nodejs/node/pull/24159#ref-commit-7527632 |
|
| https://github.com/msmichellegar |
|
| https://github.com/codebytere |
| lib: adjust params from uvExceptionWithHostPort | https://github.com/nodejs/node/commit/7527632235cf1681fa76e852a08940e1b4b127c9 |
| 7527632 | https://github.com/nodejs/node/commit/7527632235cf1681fa76e852a08940e1b4b127c9 |
| #24159 | https://github.com/nodejs/node/pull/24159 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jan 15, 2019
| https://github.com/nodejs/node/pull/24159#ref-pullrequest-396037210 |
|
v10.15.1 proposal
#25346
| https://github.com/nodejs/node/pull/25346 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-android-nodejs#280
| https://github.com/beevelop/docker-android-nodejs/issues/280 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-nodejs#258
| https://github.com/beevelop/docker-nodejs/issues/258 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-android-nodejs#281
| https://github.com/beevelop/docker-android-nodejs/issues/281 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-nodejs#259
| https://github.com/beevelop/docker-nodejs/issues/259 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-android-nodejs#282
| https://github.com/beevelop/docker-android-nodejs/issues/282 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-nodejs#260
| https://github.com/beevelop/docker-nodejs/issues/260 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-android-nodejs#283
| https://github.com/beevelop/docker-android-nodejs/issues/283 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-nodejs#261
| https://github.com/beevelop/docker-nodejs/issues/261 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-android-nodejs#284
| https://github.com/beevelop/docker-android-nodejs/issues/284 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-nodejs#262
| https://github.com/beevelop/docker-nodejs/issues/262 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24159 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/24159/files/4e5f3e110f4023598c18738447aea47073e8aaf4 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/24159/files/4e5f3e110f4023598c18738447aea47073e8aaf4 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/24159/files/4e5f3e110f4023598c18738447aea47073e8aaf4 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
| Please reload this page | https://github.com/nodejs/node/pull/24159 |
|
| https://github.com/msmichellegar |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/BridgeAR |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |