| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:aecaccdf-fbd5-7a9d-7bca-cfb989e18599 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ACEA:12AD09:FCA6:143AE:69902920 |
| html-safe-nonce | 95083c18966aaeb1a54ab46ab60248b6a310c92a56a5e9f0700e9c7d5e449efb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQ0VBOjEyQUQwOTpGQ0E2OjE0M0FFOjY5OTAyOTIwIiwidmlzaXRvcl9pZCI6IjY1NjI5MDY5MzcxMjk3MDc4MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 787062280cbfebe88a854128e0a3720c004aca5309cadb90aa46706b751f9e1e |
| hovercard-subject-tag | pull_request:228728693 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24151/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4bc9af85172c81309f20d3f2987f6739189dc82d7886238ba44a9db794d0a299/nodejs/node/pull/24151 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4bc9af85172c81309f20d3f2987f6739189dc82d7886238ba44a9db794d0a299/nodejs/node/pull/24151 |
| og:image:alt | the actual and expected arguments in assert.strictEqual() calls are in
the wrong order. Any literal value should be the second argument while
the first argument should be the value returned by a fu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | simonaco |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/24151#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24151 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24151 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/24151 |
| Reload | https://github.com/nodejs/node/pull/24151 |
| Reload | https://github.com/nodejs/node/pull/24151 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/24151 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
709
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| simonaco | https://github.com/simonaco |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| simonaco:codeandlearn | https://github.com/simonaco/node/tree/codeandlearn |
| Conversation | https://github.com/nodejs/node/pull/24151 |
| Commits1 (1) | https://github.com/nodejs/node/pull/24151/commits |
| Checks | https://github.com/nodejs/node/pull/24151/checks |
| Files changed | https://github.com/nodejs/node/pull/24151/files |
| test: fix arguments order | https://github.com/nodejs/node/pull/24151#top |
| simonaco | https://github.com/simonaco |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| simonaco:codeandlearn | https://github.com/simonaco/node/tree/codeandlearn |
|
| https://github.com/simonaco |
| simonaco | https://github.com/simonaco |
| Nov 6, 2018 | https://github.com/nodejs/node/pull/24151#issue-377895321 |
| @jasnell | https://github.com/jasnell |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/24151 |
|
| https://github.com/simonaco |
| test: fix arguments order | https://github.com/nodejs/node/pull/24151/commits/1cfc9e02bbc6f363bde05f8ffd609fa3f17a0d80 |
| 1cfc9e0 | https://github.com/nodejs/node/pull/24151/commits/1cfc9e02bbc6f363bde05f8ffd609fa3f17a0d80 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 6, 2018 | https://github.com/nodejs/node/pull/24151#event-1949233458 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 6, 2018
| https://github.com/nodejs/node/pull/24151#pullrequestreview-172072653 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24151/files/1cfc9e02bbc6f363bde05f8ffd609fa3f17a0d80 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 6, 2018
| https://github.com/nodejs/node/pull/24151#pullrequestreview-172072846 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24151/files/1cfc9e02bbc6f363bde05f8ffd609fa3f17a0d80 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 6, 2018
| https://github.com/nodejs/node/pull/24151#pullrequestreview-172199806 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24151/files/1cfc9e02bbc6f363bde05f8ffd609fa3f17a0d80 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 6, 2018 | https://github.com/nodejs/node/pull/24151#event-1949923686 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Nov 7, 2018
| https://github.com/nodejs/node/pull/24151#pullrequestreview-172304913 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/24151/files/1cfc9e02bbc6f363bde05f8ffd609fa3f17a0d80 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 9, 2018 | https://github.com/nodejs/node/pull/24151#issuecomment-437258327 |
| https://ci.nodejs.org/job/node-test-pull-request/18436/ | https://ci.nodejs.org/job/node-test-pull-request/18436/ |
| Please reload this page | https://github.com/nodejs/node/pull/24151 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 9, 2018 | https://github.com/nodejs/node/pull/24151#issuecomment-437280561 |
| Please reload this page | https://github.com/nodejs/node/pull/24151 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 9, 2018 | https://github.com/nodejs/node/pull/24151#event-1956242775 |
| Trott | https://github.com/Trott |
|
Nov 9, 2018
| https://github.com/nodejs/node/pull/24151#ref-commit-e1c4e91 |
|
| https://github.com/simonaco |
|
| https://github.com/Trott |
| test: fix arguments order | https://github.com/Trott/io.js/commit/e1c4e918c37da28debfb730987c36d6e5b053289 |
| e1c4e91 | https://github.com/Trott/io.js/commit/e1c4e918c37da28debfb730987c36d6e5b053289 |
| nodejs#24151 | https://github.com/nodejs/node/pull/24151 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 9, 2018 | https://github.com/nodejs/node/pull/24151#issuecomment-437280583 |
| https://www.nodetodo.org/next-steps/ | https://www.nodetodo.org/next-steps/ |
| Please reload this page | https://github.com/nodejs/node/pull/24151 |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 14, 2018
| https://github.com/nodejs/node/pull/24151#ref-commit-6c8b128 |
|
| https://github.com/simonaco |
|
| https://github.com/BridgeAR |
| test: fix arguments order | https://github.com/nodejs/node/commit/6c8b128fcc6746a22c96b368bcdfe51f7ab5f7d0 |
| 6c8b128 | https://github.com/nodejs/node/commit/6c8b128fcc6746a22c96b368bcdfe51f7ab5f7d0 |
| #24151 | https://github.com/nodejs/node/pull/24151 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 14, 2018
| https://github.com/nodejs/node/pull/24151#ref-pullrequest-380492752 |
|
Release proposal: v11.2
#24350
| https://github.com/nodejs/node/pull/24350 |
| kiyomizumia | https://github.com/kiyomizumia |
|
Nov 15, 2018
| https://github.com/nodejs/node/pull/24151#ref-commit-601803f |
|
| https://github.com/simonaco |
|
| https://github.com/kiyomizumia |
| test: fix arguments order | https://github.com/kiyomizumia/node/commit/601803f5f72cfc2e55f5f8b577bf5d92e3f0f5e5 |
| 601803f | https://github.com/kiyomizumia/node/commit/601803f5f72cfc2e55f5f8b577bf5d92e3f0f5e5 |
| nodejs#24151 | https://github.com/nodejs/node/pull/24151 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#232
| https://github.com/beevelop/docker-nodejs/issues/232 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#249
| https://github.com/beevelop/docker-android-nodejs/issues/249 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#233
| https://github.com/beevelop/docker-nodejs/issues/233 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#234
| https://github.com/beevelop/docker-nodejs/issues/234 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#235
| https://github.com/beevelop/docker-nodejs/issues/235 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#236
| https://github.com/beevelop/docker-nodejs/issues/236 |
| codebytere | https://github.com/codebytere |
|
Dec 13, 2018
| https://github.com/nodejs/node/pull/24151#ref-commit-1d88f01 |
|
| https://github.com/simonaco |
|
| https://github.com/codebytere |
| test: fix arguments order | https://github.com/nodejs/node/commit/1d88f01be2cca783926f7b588218da843f783a1f |
| 1d88f01 | https://github.com/nodejs/node/commit/1d88f01be2cca783926f7b588218da843f783a1f |
| #24151 | https://github.com/nodejs/node/pull/24151 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
backported-to-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x |
| Dec 13, 2018 | https://github.com/nodejs/node/pull/24151#event-2025445366 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 26, 2018
| https://github.com/nodejs/node/pull/24151#ref-commit-8f2bdac |
|
| https://github.com/simonaco |
|
| https://github.com/MylesBorins |
| test: fix arguments order | https://github.com/nodejs/node/commit/8f2bdaca69ec7d2b1f6623eef03a7bcd3446d6f1 |
| 8f2bdac | https://github.com/nodejs/node/commit/8f2bdaca69ec7d2b1f6623eef03a7bcd3446d6f1 |
| #24151 | https://github.com/nodejs/node/pull/24151 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jan 4, 2019
| https://github.com/nodejs/node/pull/24151#ref-pullrequest-396037210 |
|
v10.15.1 proposal
#25346
| https://github.com/nodejs/node/pull/25346 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-android-nodejs#280
| https://github.com/beevelop/docker-android-nodejs/issues/280 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-nodejs#258
| https://github.com/beevelop/docker-nodejs/issues/258 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-android-nodejs#281
| https://github.com/beevelop/docker-android-nodejs/issues/281 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-nodejs#259
| https://github.com/beevelop/docker-nodejs/issues/259 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-android-nodejs#282
| https://github.com/beevelop/docker-android-nodejs/issues/282 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-nodejs#260
| https://github.com/beevelop/docker-nodejs/issues/260 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-android-nodejs#283
| https://github.com/beevelop/docker-android-nodejs/issues/283 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-nodejs#261
| https://github.com/beevelop/docker-nodejs/issues/261 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-android-nodejs#284
| https://github.com/beevelop/docker-android-nodejs/issues/284 |
|
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere
beevelop/docker-nodejs#262
| https://github.com/beevelop/docker-nodejs/issues/262 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24151 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/24151/files/1cfc9e02bbc6f363bde05f8ffd609fa3f17a0d80 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/24151/files/1cfc9e02bbc6f363bde05f8ffd609fa3f17a0d80 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/24151/files/1cfc9e02bbc6f363bde05f8ffd609fa3f17a0d80 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/24151/files/1cfc9e02bbc6f363bde05f8ffd609fa3f17a0d80 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/24151 |
|
| https://github.com/simonaco |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/Trott |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
|
| https://github.com/trivikr |
|
| https://github.com/codebytere |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |