René's URL Explorer Experiment


Title: build: only try to run node when it's needed by the target by joyeecheung · Pull Request #24115 · nodejs/node · GitHub

Open Graph Title: build: only try to run node when it's needed by the target by joyeecheung · Pull Request #24115 · nodejs/node

X Title: build: only try to run node when it's needed by the target by joyeecheung · Pull Request #24115 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Right now node -p process.versions.openssl always gets run in the Makefile even when it's not needed by the target (e.g. make clean, make test-only). This patch makes it a run time call instead...

X Description: Right now node -p process.versions.openssl always gets run in the Makefile even when it's not needed by the target (e.g. make clean, make test-only). This patch makes it a run time call ins...

Opengraph URL: https://github.com/nodejs/node/pull/24115

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f22b1199-53bc-663b-1b41-56cfa2434bc3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id86BA:272222:89E921:B0D65A:6990546F
html-safe-nonce7e423b71baa2582fa6e99dcdfd2ae5cf950eb51ea4ddcc4f16668a0949fd266a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkJBOjI3MjIyMjo4OUU5MjE6QjBENjVBOjY5OTA1NDZGIiwidmlzaXRvcl9pZCI6IjEzNzk4ODk1NzcxMjEwNDM1NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacef740ac714872003a4e563725aa00a11db710ecfe2a9691051b5e69910ac57a2
hovercard-subject-tagpull_request:228560097
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24115/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/af607161581365ff8474a719f07baaa64b4b898a2f31552afc2fff5dda6c6982/nodejs/node/pull/24115
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/af607161581365ff8474a719f07baaa64b4b898a2f31552afc2fff5dda6c6982/nodejs/node/pull/24115
og:image:altRight now node -p process.versions.openssl always gets run in the Makefile even when it's not needed by the target (e.g. make clean, make test-only). This patch makes it a run time call instead...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24115#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24115
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24115
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24115
Reloadhttps://github.com/nodejs/node/pull/24115
Reloadhttps://github.com/nodejs/node/pull/24115
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24115
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:run-use-opensslhttps://github.com/joyeecheung/node/tree/run-use-openssl
Conversationhttps://github.com/nodejs/node/pull/24115
Commits2 (2)https://github.com/nodejs/node/pull/24115/commits
Checkshttps://github.com/nodejs/node/pull/24115/checks
Files changedhttps://github.com/nodejs/node/pull/24115/files
build: only try to run node when it's needed by the targethttps://github.com/nodejs/node/pull/24115#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:run-use-opensslhttps://github.com/joyeecheung/node/tree/run-use-openssl
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 6, 2018https://github.com/nodejs/node/pull/24115#issue-377672913
Please reload this pagehttps://github.com/nodejs/node/pull/24115
https://github.com/joyeecheung
build: only try to find node when it's needed by the targethttps://github.com/nodejs/node/pull/24115/commits/8baeddcc1717e920ea051cb6481627d7e7d2eca3
8baeddchttps://github.com/nodejs/node/pull/24115/commits/8baeddcc1717e920ea051cb6481627d7e7d2eca3
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
danbevhttps://github.com/danbev
November 6, 2018 03:01https://github.com/nodejs/node/pull/24115#event-1947911398
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 6, 2018https://github.com/nodejs/node/pull/24115#issuecomment-436115250
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1502/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1502/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24115
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Nov 6, 2018https://github.com/nodejs/node/pull/24115#event-1947911448
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 6, 2018https://github.com/nodejs/node/pull/24115#issuecomment-436115357
https://ci.nodejs.org/job/node-test-pull-request/18344/https://ci.nodejs.org/job/node-test-pull-request/18344/
Please reload this pagehttps://github.com/nodejs/node/pull/24115
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Nov 6, 2018 https://github.com/nodejs/node/pull/24115#pullrequestreview-171851905
View reviewed changes https://github.com/nodejs/node/pull/24115/files/8baeddcc1717e920ea051cb6481627d7e7d2eca3
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 6, 2018https://github.com/nodejs/node/pull/24115#event-1947933122
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 6, 2018https://github.com/nodejs/node/pull/24115#issuecomment-436118728
Please reload this pagehttps://github.com/nodejs/node/pull/24115
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 6, 2018https://github.com/nodejs/node/pull/24115#issuecomment-436119071
#22148 (comment)https://github.com/nodejs/node/pull/22148#issuecomment-435561251
Please reload this pagehttps://github.com/nodejs/node/pull/24115
https://github.com/danbev
danbevhttps://github.com/danbev
Nov 6, 2018 https://github.com/nodejs/node/pull/24115#pullrequestreview-171914361
View reviewed changes https://github.com/nodejs/node/pull/24115/files/8baeddcc1717e920ea051cb6481627d7e7d2eca3
Makefilehttps://github.com/nodejs/node/pull/24115/files/8baeddcc1717e920ea051cb6481627d7e7d2eca3#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
Please reload this pagehttps://github.com/nodejs/node/pull/24115
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 6, 2018 https://github.com/nodejs/node/pull/24115#pullrequestreview-171984822
View reviewed changes https://github.com/nodejs/node/pull/24115/files/8baeddcc1717e920ea051cb6481627d7e7d2eca3
Makefilehttps://github.com/nodejs/node/pull/24115/files/8baeddcc1717e920ea051cb6481627d7e7d2eca3#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
Please reload this pagehttps://github.com/nodejs/node/pull/24115
https://github.com/joyeecheung
fixup! build: only try to run node when it's needed by the targethttps://github.com/nodejs/node/pull/24115/commits/18c011eb5bc217dbd0dd1976c77e0cffded9e44c
18c011ehttps://github.com/nodejs/node/pull/24115/commits/18c011eb5bc217dbd0dd1976c77e0cffded9e44c
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 6, 2018https://github.com/nodejs/node/pull/24115#issuecomment-436229905
https://ci.nodejs.org/job/node-test-pull-request/18365/https://ci.nodejs.org/job/node-test-pull-request/18365/
Please reload this pagehttps://github.com/nodejs/node/pull/24115
https://github.com/danbev
danbevhttps://github.com/danbev
Nov 6, 2018 https://github.com/nodejs/node/pull/24115#pullrequestreview-172020604
View reviewed changes https://github.com/nodejs/node/pull/24115/files/18c011eb5bc217dbd0dd1976c77e0cffded9e44c
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 6, 2018https://github.com/nodejs/node/pull/24115#event-1948974610
Trotthttps://github.com/Trott
Nov 8, 2018 https://github.com/nodejs/node/pull/24115#ref-commit-dc3bc89
https://github.com/joyeecheung
https://github.com/Trott
build: only try to find node when it's needed by the targethttps://github.com/Trott/io.js/commit/dc3bc8928f9d7c22fe9b909fa3cc49e8c85ec860
dc3bc89https://github.com/Trott/io.js/commit/dc3bc8928f9d7c22fe9b909fa3cc49e8c85ec860
nodejs#24115https://github.com/nodejs/node/pull/24115
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 8, 2018https://github.com/nodejs/node/pull/24115#issuecomment-436872780
Please reload this pagehttps://github.com/nodejs/node/pull/24115
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 8, 2018https://github.com/nodejs/node/pull/24115#event-1953374496
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24115#ref-commit-a8008d1
https://github.com/joyeecheung
https://github.com/BridgeAR
build: only try to find node when it's needed by the targethttps://github.com/nodejs/node/commit/a8008d15177e44eaf25661c30fef58bfdff4c1ce
a8008d1https://github.com/nodejs/node/commit/a8008d15177e44eaf25661c30fef58bfdff4c1ce
#24115https://github.com/nodejs/node/pull/24115
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24115#ref-pullrequest-380492752
Release proposal: v11.2 #24350 https://github.com/nodejs/node/pull/24350
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24115#ref-commit-4e44b41
https://github.com/joyeecheung
https://github.com/kiyomizumia
build: only try to find node when it's needed by the targethttps://github.com/kiyomizumia/node/commit/4e44b41b1740ae257685d4d8a88b774c1ed68591
4e44b41https://github.com/kiyomizumia/node/commit/4e44b41b1740ae257685d4d8a88b774c1ed68591
nodejs#24115https://github.com/nodejs/node/pull/24115
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232 https://github.com/beevelop/docker-nodejs/issues/232
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249 https://github.com/beevelop/docker-android-nodejs/issues/249
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233 https://github.com/beevelop/docker-nodejs/issues/233
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234 https://github.com/beevelop/docker-nodejs/issues/234
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235 https://github.com/beevelop/docker-nodejs/issues/235
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236 https://github.com/beevelop/docker-nodejs/issues/236
codebyterehttps://github.com/codebytere
Dec 13, 2018 https://github.com/nodejs/node/pull/24115#ref-commit-2ff9143
https://github.com/joyeecheung
https://github.com/codebytere
build: only try to find node when it's needed by the targethttps://github.com/nodejs/node/commit/2ff91437c9fea49756408328f6bf426ffde079f8
2ff9143https://github.com/nodejs/node/commit/2ff91437c9fea49756408328f6bf426ffde079f8
#24115https://github.com/nodejs/node/pull/24115
https://github.com/codebytere
codebyterehttps://github.com/codebytere
backported-to-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x
Dec 13, 2018https://github.com/nodejs/node/pull/24115#event-2025341219
MylesBorinshttps://github.com/MylesBorins
Dec 26, 2018 https://github.com/nodejs/node/pull/24115#ref-commit-042749f
https://github.com/joyeecheung
https://github.com/MylesBorins
build: only try to find node when it's needed by the targethttps://github.com/nodejs/node/commit/042749fd231692e8cb0d6bf03a12afda111407ea
042749fhttps://github.com/nodejs/node/commit/042749fd231692e8cb0d6bf03a12afda111407ea
#24115https://github.com/nodejs/node/pull/24115
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jan 4, 2019 https://github.com/nodejs/node/pull/24115#ref-pullrequest-396037210
v10.15.1 proposal #25346 https://github.com/nodejs/node/pull/25346
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280 https://github.com/beevelop/docker-android-nodejs/issues/280
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258 https://github.com/beevelop/docker-nodejs/issues/258
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281 https://github.com/beevelop/docker-android-nodejs/issues/281
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259 https://github.com/beevelop/docker-nodejs/issues/259
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282 https://github.com/beevelop/docker-android-nodejs/issues/282
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260 https://github.com/beevelop/docker-nodejs/issues/260
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283 https://github.com/beevelop/docker-android-nodejs/issues/283
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261 https://github.com/beevelop/docker-nodejs/issues/261
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284 https://github.com/beevelop/docker-android-nodejs/issues/284
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262 https://github.com/beevelop/docker-nodejs/issues/262
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24115
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/24115/files/8baeddcc1717e920ea051cb6481627d7e7d2eca3
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/24115/files/18c011eb5bc217dbd0dd1976c77e0cffded9e44c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Please reload this pagehttps://github.com/nodejs/node/pull/24115
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/danbev
https://github.com/richardlau
https://github.com/codebytere
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.