| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:71d51cf1-1a8c-0ebe-62ac-83d05ba1e3d3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9AF4:381ACD:48835AB:65361BC:6A50DD07 |
| html-safe-nonce | 645d9b288e2ff0e5d4e0d413ae1e09982d461b913c0e12f2cf21980f8cab698f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUY0OjM4MUFDRDo0ODgzNUFCOjY1MzYxQkM6NkE1MEREMDciLCJ2aXNpdG9yX2lkIjoiODQ2MDE3MTU1NDMyMzQ4ODAwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f7eb9538ea34fa18b284e7ab9237f4ab13032e96c0888f628d3df89ac0bfccdc |
| hovercard-subject-tag | pull_request:42631611 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2410/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/207ce5921a669072535aa573801a0872b595d238a60dd1ef2f8133aa4d1fe092/nodejs/node/pull/2410 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/207ce5921a669072535aa573801a0872b595d238a60dd1ef2f8133aa4d1fe092/nodejs/node/pull/2410 |
| og:image:alt | String concatenation in the assert messages has drastic impact on test
runtime. Removal of these messages is unlikely to affect debugging if
any breaking changes are made.
Previous time to run:
$ t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | trevnorris |
| hostname | github.com |
| expected-hostname | github.com |
| None | 72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 17290b65caabb92b271e0949d1bf147b63deab41 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/2410#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2410 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2410 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/2410 |
| Reload | https://github.com/nodejs/node/pull/2410 |
| Reload | https://github.com/nodejs/node/pull/2410 |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
979
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| trevnorris | https://github.com/trevnorris |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| trevnorris:make-stringbytes-test-fast | https://github.com/trevnorris/node/tree/make-stringbytes-test-fast |
| Conversation | https://github.com/nodejs/node/pull/2410 |
| Commits1 (1) | https://github.com/nodejs/node/pull/2410/commits |
| Checks | https://github.com/nodejs/node/pull/2410/checks |
| Files changed | https://github.com/nodejs/node/pull/2410/files |
| test: remove excessively poor performance | https://github.com/nodejs/node/pull/2410#top |
| trevnorris | https://github.com/trevnorris |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| trevnorris:make-stringbytes-test-fast | https://github.com/trevnorris/node/tree/make-stringbytes-test-fast |
|
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Aug 17, 2015 | https://github.com/nodejs/node/pull/2410#issue-101505794 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
|
| https://github.com/trevnorris |
| test: remove excessively poor performance | https://github.com/nodejs/node/pull/2410/commits/53b9d98a0654553f3e089d21531e8240750946ee |
| 53b9d98 | https://github.com/nodejs/node/pull/2410/commits/53b9d98a0654553f3e089d21531e8240750946ee |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
|
Aug 17, 2015
| https://github.com/nodejs/node/pull/2410#ref-issue-100845297 |
|
test: parallel/test-stringbytes-external is too slow
#2370
| https://github.com/nodejs/node/issues/2370 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Aug 17, 2015 | https://github.com/nodejs/node/pull/2410#issuecomment-131959590 |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Aug 17, 2015 | https://github.com/nodejs/node/pull/2410#issuecomment-131960355 |
| https://jenkins-iojs.nodesource.com/job/node-test-pull-request/100/ | https://jenkins-iojs.nodesource.com/job/node-test-pull-request/100/ |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
| https://github.com/brendanashworth |
| brendanashworth | https://github.com/brendanashworth |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Aug 17, 2015 | https://github.com/nodejs/node/pull/2410#event-384706857 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Aug 17, 2015 | https://github.com/nodejs/node/pull/2410#issuecomment-131997782 |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
| https://github.com/Qard |
| Qard | https://github.com/Qard |
| Aug 18, 2015 | https://github.com/nodejs/node/pull/2410#issuecomment-131999360 |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Aug 18, 2015 | https://github.com/nodejs/node/pull/2410#issuecomment-132009498 |
| @Qard | https://github.com/Qard |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 18, 2015 | https://github.com/nodejs/node/pull/2410#issuecomment-132071571 |
| @rvagg | https://github.com/rvagg |
| #2393 | https://github.com/nodejs/node/pull/2393 |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 18, 2015
| https://github.com/nodejs/node/pull/2410#ref-issue-101689340 |
|
Refactor lib/* in ES6?
#2426
| https://github.com/nodejs/node/issues/2426 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Aug 28, 2015 | https://github.com/nodejs/node/pull/2410#issuecomment-135776604 |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Aug 28, 2015 | https://github.com/nodejs/node/pull/2410#issuecomment-135827613 |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Aug 28, 2015 | https://github.com/nodejs/node/pull/2410#event-395254449 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Aug 28, 2015 | https://github.com/nodejs/node/pull/2410#issuecomment-135833365 |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
| https://github.com/skomski |
| skomski | https://github.com/skomski |
|
Sep 1, 2015
| https://github.com/nodejs/node/pull/2410#ref-pullrequest-101269475 |
|
src: fix memory leak in ExternString
#2402
| https://github.com/nodejs/node/pull/2402 |
| trevnorris | https://github.com/trevnorris |
|
Sep 1, 2015
| https://github.com/nodejs/node/pull/2410#ref-commit-aa6cd0f |
|
| https://github.com/trevnorris |
| test: improve performance of stringbytes test | https://github.com/nodejs/node/commit/aa6cd0f24293d0ff2ea09328e37f3fb266f7309e |
| aa6cd0f | https://github.com/nodejs/node/commit/aa6cd0f24293d0ff2ea09328e37f3fb266f7309e |
| #2410 | https://github.com/nodejs/node/pull/2410 |
| trevnorris | https://github.com/trevnorris |
|
Sep 1, 2015
| https://github.com/nodejs/node/pull/2410#ref-commit-37ee43e |
|
| https://github.com/trevnorris |
|
| https://github.com/orangemocha |
| test: improve performance of stringbytes test | https://github.com/nodejs/node/commit/37ee43efd5927c401aa3b51a328c199bc253715f |
|
| https://github.com/nodejs/node/commit/37ee43efd5927c401aa3b51a328c199bc253715f#comments |
| 37ee43e | https://github.com/nodejs/node/commit/37ee43efd5927c401aa3b51a328c199bc253715f |
| #2544 | https://github.com/nodejs/node/pull/2544 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Sep 1, 2015 | https://github.com/nodejs/node/pull/2410#issuecomment-136848185 |
| 37ee43e | https://github.com/nodejs/node/commit/37ee43efd5927c401aa3b51a328c199bc253715f |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
|
Sep 2, 2015
| https://github.com/nodejs/node/pull/2410#ref-pullrequest-103074233 |
|
src: only memcmp if length > 0 in Buffer::Compare
#2544
| https://github.com/nodejs/node/pull/2544 |
| https://github.com/orangemocha |
| orangemocha | https://github.com/orangemocha |
| Sep 2, 2015 | https://github.com/nodejs/node/pull/2410#issuecomment-136980185 |
| #2544 (comment) | https://github.com/nodejs/node/pull/2544#issuecomment-136979840 |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Sep 3, 2015
| https://github.com/nodejs/node/pull/2410#ref-pullrequest-104159343 |
|
deps: update v8 to 4.5.103.30
#2632
| https://github.com/nodejs/node/pull/2632 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| October 7, 2015 21:25 | https://github.com/nodejs/node/pull/2410#event-429640150 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2410 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/2410 |
|
| https://github.com/trevnorris |
|
| https://github.com/bnoordhuis |
|
| https://github.com/rvagg |
|
| https://github.com/Qard |
|
| https://github.com/thefourtheye |
|
| https://github.com/Trott |
|
| https://github.com/Fishrock123 |
|
| https://github.com/jbergstroem |
|
| https://github.com/orangemocha |
|
| https://github.com/brendanashworth |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |