René's URL Explorer Experiment


Title: lib: move internalBinding whitelisting into loaders.js by joyeecheung · Pull Request #24088 · nodejs/node · GitHub

Open Graph Title: lib: move internalBinding whitelisting into loaders.js by joyeecheung · Pull Request #24088 · nodejs/node

X Title: lib: move internalBinding whitelisting into loaders.js by joyeecheung · Pull Request #24088 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Instead of setting the internalBinding white list in node.js and wrapping process.binding twice, put it directly in loaders.js where the user land process.binding is defined.

X Description: Instead of setting the internalBinding white list in node.js and wrapping process.binding twice, put it directly in loaders.js where the user land process.binding is defined.

Opengraph URL: https://github.com/nodejs/node/pull/24088

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:daef4c04-d22b-f68b-c023-357bc1723124
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEF2:197016:1241226:172472C:69917106
html-safe-nonce562dae5257cdeb4ea2c41258b7bedbff3ec8b923b24a05c5f3a2f6cdd0101fbf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUYyOjE5NzAxNjoxMjQxMjI2OjE3MjQ3MkM6Njk5MTcxMDYiLCJ2aXNpdG9yX2lkIjoiNjI2NTM4Njk2NzYyMzYyNzAxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0bf83a55b5c35e3f4ce5671936369aaea817f8c32bc5073eecad0b1666d23415
hovercard-subject-tagpull_request:228198032
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24088/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/31ea03db8ec7aafa51247b0ad664f8919540b6d8d74e6b85c55f9b46460d14c3/nodejs/node/pull/24088
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/31ea03db8ec7aafa51247b0ad664f8919540b6d8d74e6b85c55f9b46460d14c3/nodejs/node/pull/24088
og:image:altInstead of setting the internalBinding white list in node.js and wrapping process.binding twice, put it directly in loaders.js where the user land process.binding is defined.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24088#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24088
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24088
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24088
Reloadhttps://github.com/nodejs/node/pull/24088
Reloadhttps://github.com/nodejs/node/pull/24088
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24088
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:whitelisthttps://github.com/joyeecheung/node/tree/whitelist
Conversationhttps://github.com/nodejs/node/pull/24088
Commits1 (1)https://github.com/nodejs/node/pull/24088/commits
Checkshttps://github.com/nodejs/node/pull/24088/checks
Files changedhttps://github.com/nodejs/node/pull/24088/files
lib: move internalBinding whitelisting into loaders.jshttps://github.com/nodejs/node/pull/24088#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:whitelisthttps://github.com/joyeecheung/node/tree/whitelist
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 4, 2018https://github.com/nodejs/node/pull/24088#issue-377187076
Please reload this pagehttps://github.com/nodejs/node/pull/24088
https://github.com/joyeecheung
lib: move internalBinding whitelisting into loaders.jshttps://github.com/nodejs/node/pull/24088/commits/c5b6a2d5441fd5ec8fba5064f830187177f2c11c
c5b6a2dhttps://github.com/nodejs/node/pull/24088/commits/c5b6a2d5441fd5ec8fba5064f830187177f2c11c
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
addaleaxhttps://github.com/addaleax
November 4, 2018 19:44https://github.com/nodejs/node/pull/24088#event-1944980861
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 4, 2018https://github.com/nodejs/node/pull/24088#issuecomment-435699478
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1487/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1487/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24088
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 4, 2018https://github.com/nodejs/node/pull/24088#issuecomment-435699720
https://ci.nodejs.org/job/node-test-pull-request/18329/https://ci.nodejs.org/job/node-test-pull-request/18329/
Please reload this pagehttps://github.com/nodejs/node/pull/24088
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 4, 2018 https://github.com/nodejs/node/pull/24088#pullrequestreview-171379646
View reviewed changes https://github.com/nodejs/node/pull/24088/files/c5b6a2d5441fd5ec8fba5064f830187177f2c11c
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 4, 2018 https://github.com/nodejs/node/pull/24088#pullrequestreview-171380012
View reviewed changes https://github.com/nodejs/node/pull/24088/files/c5b6a2d5441fd5ec8fba5064f830187177f2c11c
lib/internal/bootstrap/loaders.jshttps://github.com/nodejs/node/pull/24088/files/c5b6a2d5441fd5ec8fba5064f830187177f2c11c#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9
devsnekhttps://github.com/devsnek
Nov 4, 2018https://github.com/nodejs/node/pull/24088#discussion_r230605911
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24088
refackhttps://github.com/refack
Nov 4, 2018https://github.com/nodejs/node/pull/24088#discussion_r230611368
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24088
devsnekhttps://github.com/devsnek
Nov 4, 2018https://github.com/nodejs/node/pull/24088#discussion_r230611469
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24088
https://github.com/refack
refackhttps://github.com/refack
Nov 4, 2018 https://github.com/nodejs/node/pull/24088#pullrequestreview-171386348
View reviewed changes https://github.com/nodejs/node/pull/24088/files/c5b6a2d5441fd5ec8fba5064f830187177f2c11c
lib/internal/bootstrap/loaders.jshttps://github.com/nodejs/node/pull/24088/files/c5b6a2d5441fd5ec8fba5064f830187177f2c11c#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9
refackhttps://github.com/refack
Nov 4, 2018https://github.com/nodejs/node/pull/24088#discussion_r230611368
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24088
https://github.com/refack
refackhttps://github.com/refack
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Nov 4, 2018https://github.com/nodejs/node/pull/24088#event-1945089847
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 5, 2018 https://github.com/nodejs/node/pull/24088#pullrequestreview-171563603
View reviewed changes https://github.com/nodejs/node/pull/24088/files/c5b6a2d5441fd5ec8fba5064f830187177f2c11c
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 6, 2018https://github.com/nodejs/node/pull/24088#event-1947977343
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 8, 2018https://github.com/nodejs/node/pull/24088#issuecomment-436869502
7bd8bbahttps://github.com/nodejs/node/commit/7bd8bbaabf4ed964476fca4bed267815b2b3967e
Please reload this pagehttps://github.com/nodejs/node/pull/24088
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 8, 2018https://github.com/nodejs/node/pull/24088#event-1953353508
Trotthttps://github.com/Trott
Nov 8, 2018 https://github.com/nodejs/node/pull/24088#ref-commit-7bd8bba
https://github.com/joyeecheung
https://github.com/Trott
lib: move internalBinding whitelisting into loaders.jshttps://github.com/Trott/io.js/commit/7bd8bbaabf4ed964476fca4bed267815b2b3967e
7bd8bbahttps://github.com/Trott/io.js/commit/7bd8bbaabf4ed964476fca4bed267815b2b3967e
nodejs#24088https://github.com/nodejs/node/pull/24088
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Nov 8, 2018https://github.com/nodejs/node/pull/24088#event-1953464849
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 8, 2018https://github.com/nodejs/node/pull/24088#issuecomment-436886244
#22269https://github.com/nodejs/node/pull/22269
Please reload this pagehttps://github.com/nodejs/node/pull/24088
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24088#ref-commit-6a6b036
https://github.com/joyeecheung
https://github.com/BridgeAR
lib: move internalBinding whitelisting into loaders.jshttps://github.com/nodejs/node/commit/6a6b03604272dc74faf3effdf88a20b1b343c0d2
6a6b036https://github.com/nodejs/node/commit/6a6b03604272dc74faf3effdf88a20b1b343c0d2
#24088https://github.com/nodejs/node/pull/24088
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24088#ref-pullrequest-380492752
Release proposal: v11.2 #24350 https://github.com/nodejs/node/pull/24350
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24088#ref-commit-d309cc5
https://github.com/joyeecheung
https://github.com/kiyomizumia
lib: move internalBinding whitelisting into loaders.jshttps://github.com/kiyomizumia/node/commit/d309cc5a9d036c0c6e358f57762c9a7a1db158e0
d309cc5https://github.com/kiyomizumia/node/commit/d309cc5a9d036c0c6e358f57762c9a7a1db158e0
nodejs#24088https://github.com/nodejs/node/pull/24088
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232 https://github.com/beevelop/docker-nodejs/issues/232
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249 https://github.com/beevelop/docker-android-nodejs/issues/249
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233 https://github.com/beevelop/docker-nodejs/issues/233
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234 https://github.com/beevelop/docker-nodejs/issues/234
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235 https://github.com/beevelop/docker-nodejs/issues/235
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236 https://github.com/beevelop/docker-nodejs/issues/236
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24088
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/24088/files/c5b6a2d5441fd5ec8fba5064f830187177f2c11c
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/24088/files/c5b6a2d5441fd5ec8fba5064f830187177f2c11c
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/24088/files/c5b6a2d5441fd5ec8fba5064f830187177f2c11c
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/24088/files/c5b6a2d5441fd5ec8fba5064f830187177f2c11c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
Please reload this pagehttps://github.com/nodejs/node/pull/24088
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/refack
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/devsnek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.