René's URL Explorer Experiment


Title: net: simplify Socket.prototype._final by addaleax · Pull Request #24075 · nodejs/node · GitHub

Open Graph Title: net: simplify Socket.prototype._final by addaleax · Pull Request #24075 · nodejs/node

X Title: net: simplify Socket.prototype._final by addaleax · Pull Request #24075 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Remove conditions that should be irrelevant since we started using _final, as well as an extra defaultTriggerAsyncIdScope() call which is unnecessary because there is an equivalent scope already pr...

X Description: Remove conditions that should be irrelevant since we started using _final, as well as an extra defaultTriggerAsyncIdScope() call which is unnecessary because there is an equivalent scope already pr...

Opengraph URL: https://github.com/nodejs/node/pull/24075

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8437c94f-8bce-3295-4a7b-4707e2d11ac8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC4F2:96DD6:479A4D:5CC7C5:69906D8A
html-safe-nonce9093737f62d7020e7bc4aebd7eb1ddcb9a35f0d1df981ac6e35395c8dcd0c49b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEYyOjk2REQ2OjQ3OUE0RDo1Q0M3QzU6Njk5MDZEOEEiLCJ2aXNpdG9yX2lkIjoiMjQ0NTEwMDE2NTg0NzA4NDQyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8b27141dc0f893b453ea767d3f7e850844e1e67234c608a8d72e0502cf6b03a2
hovercard-subject-tagpull_request:228171332
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24075/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9b5fcced559863ab3e250218219da5ac4f2c2ccb63ffe2d06627161e095de5ed/nodejs/node/pull/24075
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9b5fcced559863ab3e250218219da5ac4f2c2ccb63ffe2d06627161e095de5ed/nodejs/node/pull/24075
og:image:altRemove conditions that should be irrelevant since we started using _final, as well as an extra defaultTriggerAsyncIdScope() call which is unnecessary because there is an equivalent scope already pr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24075#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24075
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24075
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24075
Reloadhttps://github.com/nodejs/node/pull/24075
Reloadhttps://github.com/nodejs/node/pull/24075
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24075
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:net-simplify-finalhttps://github.com/addaleax/node/tree/net-simplify-final
Conversationhttps://github.com/nodejs/node/pull/24075
Commits2 (2)https://github.com/nodejs/node/pull/24075/commits
Checkshttps://github.com/nodejs/node/pull/24075/checks
Files changedhttps://github.com/nodejs/node/pull/24075/files
net: simplify Socket.prototype._finalhttps://github.com/nodejs/node/pull/24075#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:net-simplify-finalhttps://github.com/addaleax/node/tree/net-simplify-final
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 4, 2018https://github.com/nodejs/node/pull/24075#issue-377143879
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24075
https://github.com/addaleax
net: simplify Socket.prototype._finalhttps://github.com/nodejs/node/pull/24075/commits/ac1ec9300a4275ed88953ff5114d88bd4dad647f
ac1ec93https://github.com/nodejs/node/pull/24075/commits/ac1ec9300a4275ed88953ff5114d88bd4dad647f
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 4, 2018https://github.com/nodejs/node/pull/24075#issuecomment-435662107
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1484/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1484/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24075
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Nov 4, 2018https://github.com/nodejs/node/pull/24075#event-1944777971
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 4, 2018https://github.com/nodejs/node/pull/24075#issuecomment-435662245
https://ci.nodejs.org/job/node-test-pull-request/18327/https://ci.nodejs.org/job/node-test-pull-request/18327/
Please reload this pagehttps://github.com/nodejs/node/pull/24075
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 4, 2018 https://github.com/nodejs/node/pull/24075#pullrequestreview-171365478
View reviewed changes https://github.com/nodejs/node/pull/24075/files/ac1ec9300a4275ed88953ff5114d88bd4dad647f
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Nov 5, 2018https://github.com/nodejs/node/pull/24075#event-1945752963
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 5, 2018https://github.com/nodejs/node/pull/24075#issuecomment-435816610
Please reload this pagehttps://github.com/nodejs/node/pull/24075
https://github.com/addaleax
fixup! net: simplify Socket.prototype._finalhttps://github.com/nodejs/node/pull/24075/commits/e0171a33affa9961975f9008ac6862fc7de32012
e0171a3https://github.com/nodejs/node/pull/24075/commits/e0171a33affa9961975f9008ac6862fc7de32012
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 5, 2018https://github.com/nodejs/node/pull/24075#issuecomment-435850377
https://ci.nodejs.org/job/node-test-pull-request/18338/https://ci.nodejs.org/job/node-test-pull-request/18338/
Please reload this pagehttps://github.com/nodejs/node/pull/24075
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Nov 5, 2018https://github.com/nodejs/node/pull/24075#event-1946216627
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 7, 2018https://github.com/nodejs/node/pull/24075#issuecomment-436611081
Please reload this pagehttps://github.com/nodejs/node/pull/24075
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 10, 2018 https://github.com/nodejs/node/pull/24075#pullrequestreview-173670415
View reviewed changes https://github.com/nodejs/node/pull/24075/files/e0171a33affa9961975f9008ac6862fc7de32012
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 10, 2018https://github.com/nodejs/node/pull/24075#issuecomment-437607951
b7e6ccdhttps://github.com/nodejs/node/commit/b7e6ccd0cc60f20cc397e6ac0705bb3f38c7d225
Please reload this pagehttps://github.com/nodejs/node/pull/24075
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 10, 2018https://github.com/nodejs/node/pull/24075#event-1958527715
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
November 10, 2018 18:40https://github.com/nodejs/node/pull/24075#event-1958527797
addaleaxhttps://github.com/addaleax
Nov 10, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-b7e6ccd
https://github.com/addaleax
net: simplify Socket.prototype._finalhttps://github.com/nodejs/node/commit/b7e6ccd0cc60f20cc397e6ac0705bb3f38c7d225
b7e6ccdhttps://github.com/nodejs/node/commit/b7e6ccd0cc60f20cc397e6ac0705bb3f38c7d225
#24075https://github.com/nodejs/node/pull/24075
addaleaxhttps://github.com/addaleax
Nov 10, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-ac1f56c
https://github.com/addaleax
net: partially revert "simplify Socket.prototype._final"https://github.com/addaleax/node/commit/ac1f56c76a5d1a8ebcb2421d5c629e51df1ac48c
ac1f56chttps://github.com/addaleax/node/commit/ac1f56c76a5d1a8ebcb2421d5c629e51df1ac48c
b7e6ccdhttps://github.com/addaleax/node/commit/b7e6ccd0cc60f20cc397e6ac0705bb3f38c7d225
nodejs#24075https://github.com/nodejs/node/pull/24075
nodejs#23866https://github.com/nodejs/node/pull/23866
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 10, 2018 https://github.com/nodejs/node/pull/24075#ref-pullrequest-379456354
net: partially revert "simplify Socket.prototype._final" #24288 https://github.com/nodejs/node/pull/24288
addaleaxhttps://github.com/addaleax
Nov 10, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-fb6c669
https://github.com/addaleax
net: partially revert "simplify Socket.prototype._final"https://github.com/nodejs/node/commit/fb6c6692a8d2e7e4d86a742216151a6e5e15739b
fb6c669https://github.com/nodejs/node/commit/fb6c6692a8d2e7e4d86a742216151a6e5e15739b
b7e6ccdhttps://github.com/nodejs/node/commit/b7e6ccd0cc60f20cc397e6ac0705bb3f38c7d225
#24075https://github.com/nodejs/node/pull/24075
#23866https://github.com/nodejs/node/pull/23866
#24288https://github.com/nodejs/node/pull/24288
addaleaxhttps://github.com/addaleax
Nov 10, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-4cae5b8
https://github.com/addaleax
Revert "net: partially revert "simplify Socket.prototype._final""https://github.com/addaleax/node/commit/4cae5b8ec616f57e1618bc7160ff4fb41c116255
4cae5b8https://github.com/addaleax/node/commit/4cae5b8ec616f57e1618bc7160ff4fb41c116255
ac1f56chttps://github.com/addaleax/node/commit/ac1f56c76a5d1a8ebcb2421d5c629e51df1ac48c
nodejs#24288https://github.com/nodejs/node/pull/24288
nodejs#24075https://github.com/nodejs/node/pull/24075
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 10, 2018 https://github.com/nodejs/node/pull/24075#ref-pullrequest-379461359
tls,net: fix shutdown issue more cleanly #24290 https://github.com/nodejs/node/pull/24290
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-636e4e0
https://github.com/addaleax
https://github.com/BridgeAR
net: simplify Socket.prototype._finalhttps://github.com/nodejs/node/commit/636e4e02a5de3359613d83d4a98b9ecdda3ad450
636e4e0https://github.com/nodejs/node/commit/636e4e02a5de3359613d83d4a98b9ecdda3ad450
#24075https://github.com/nodejs/node/pull/24075
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-7445126
https://github.com/addaleax
https://github.com/BridgeAR
net: partially revert "simplify Socket.prototype._final"https://github.com/nodejs/node/commit/74451263a3cf38946060be81302afa8abc6f19be
7445126https://github.com/nodejs/node/commit/74451263a3cf38946060be81302afa8abc6f19be
b7e6ccdhttps://github.com/nodejs/node/commit/b7e6ccd0cc60f20cc397e6ac0705bb3f38c7d225
#24075https://github.com/nodejs/node/pull/24075
#23866https://github.com/nodejs/node/pull/23866
#24288https://github.com/nodejs/node/pull/24288
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24075#ref-pullrequest-380492752
Release proposal: v11.2 #24350 https://github.com/nodejs/node/pull/24350
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-a75b78d
https://github.com/addaleax
https://github.com/kiyomizumia
net: simplify Socket.prototype._finalhttps://github.com/kiyomizumia/node/commit/a75b78dba633bfc3354abce96d20a55e9116562d
a75b78dhttps://github.com/kiyomizumia/node/commit/a75b78dba633bfc3354abce96d20a55e9116562d
nodejs#24075https://github.com/nodejs/node/pull/24075
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-0108d92
https://github.com/addaleax
https://github.com/kiyomizumia
net: partially revert "simplify Socket.prototype._final"https://github.com/kiyomizumia/node/commit/0108d92cac28b3f5bf12cccbb28556f6ab3f769f
0108d92https://github.com/kiyomizumia/node/commit/0108d92cac28b3f5bf12cccbb28556f6ab3f769f
b7e6ccdhttps://github.com/kiyomizumia/node/commit/b7e6ccd0cc60f20cc397e6ac0705bb3f38c7d225
nodejs#24075https://github.com/nodejs/node/pull/24075
nodejs#23866https://github.com/nodejs/node/pull/23866
nodejs#24288https://github.com/nodejs/node/pull/24288
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232 https://github.com/beevelop/docker-nodejs/issues/232
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249 https://github.com/beevelop/docker-android-nodejs/issues/249
addaleaxhttps://github.com/addaleax
Nov 16, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-cbbf64e
https://github.com/addaleax
tls: do not rely on 'drain' handlers in StreamWraphttps://github.com/nodejs/node/commit/cbbf64e40e6a544f14f1d2888c41464e3a5acfab
cbbf64ehttps://github.com/nodejs/node/commit/cbbf64e40e6a544f14f1d2888c41464e3a5acfab
#24290https://github.com/nodejs/node/pull/24290
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
addaleaxhttps://github.com/addaleax
Nov 16, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-b92d55f
https://github.com/addaleax
tls: destroy TLS socket if StreamWrap is destroyedhttps://github.com/nodejs/node/commit/b92d55f71811528c38cfdb9ca552502603963360
b92d55fhttps://github.com/nodejs/node/commit/b92d55f71811528c38cfdb9ca552502603963360
#24290https://github.com/nodejs/node/pull/24290
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
addaleaxhttps://github.com/addaleax
Nov 16, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-8cdb92f
https://github.com/addaleax
Revert "net: partially revert "simplify Socket.prototype._final""https://github.com/nodejs/node/commit/8cdb92f11c79de45ed1e7686717bbfc6df304a05
8cdb92fhttps://github.com/nodejs/node/commit/8cdb92f11c79de45ed1e7686717bbfc6df304a05
ac1f56chttps://github.com/nodejs/node/commit/ac1f56c76a5d1a8ebcb2421d5c629e51df1ac48c
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
#24290https://github.com/nodejs/node/pull/24290
targoshttps://github.com/targos
Nov 18, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-b90f2f8
https://github.com/addaleax
https://github.com/targos
tls: do not rely on 'drain' handlers in StreamWraphttps://github.com/nodejs/node/commit/b90f2f8682d2b643a7289de6be6369104208375c
b90f2f8https://github.com/nodejs/node/commit/b90f2f8682d2b643a7289de6be6369104208375c
#24290https://github.com/nodejs/node/pull/24290
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
targoshttps://github.com/targos
Nov 18, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-7a54845
https://github.com/addaleax
https://github.com/targos
tls: destroy TLS socket if StreamWrap is destroyedhttps://github.com/nodejs/node/commit/7a548455ae95461be0a9d8e3e11dde9c51caef58
7a54845https://github.com/nodejs/node/commit/7a548455ae95461be0a9d8e3e11dde9c51caef58
#24290https://github.com/nodejs/node/pull/24290
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
targoshttps://github.com/targos
Nov 18, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-bf85369
https://github.com/addaleax
https://github.com/targos
Revert "net: partially revert "simplify Socket.prototype._final""https://github.com/nodejs/node/commit/bf85369acf347b1f84ad64c915465885a9014022
bf85369https://github.com/nodejs/node/commit/bf85369acf347b1f84ad64c915465885a9014022
ac1f56chttps://github.com/nodejs/node/commit/ac1f56c76a5d1a8ebcb2421d5c629e51df1ac48c
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
#24290https://github.com/nodejs/node/pull/24290
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-0c93b12
https://github.com/addaleax
https://github.com/rvagg
tls: do not rely on 'drain' handlers in StreamWraphttps://github.com/nodejs/node/commit/0c93b125e442e8f372590c11f03d8f33e2946648
0c93b12https://github.com/nodejs/node/commit/0c93b125e442e8f372590c11f03d8f33e2946648
#24290https://github.com/nodejs/node/pull/24290
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-71a9c98
https://github.com/addaleax
https://github.com/rvagg
tls: destroy TLS socket if StreamWrap is destroyedhttps://github.com/nodejs/node/commit/71a9c987b24c6808ef2ee4c22edfb98eb3e0bc38
71a9c98https://github.com/nodejs/node/commit/71a9c987b24c6808ef2ee4c22edfb98eb3e0bc38
#24290https://github.com/nodejs/node/pull/24290
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-e82f67d
https://github.com/addaleax
https://github.com/rvagg
Revert "net: partially revert "simplify Socket.prototype._final""https://github.com/nodejs/node/commit/e82f67d710c5e9b29eab9fd7563f51bd348904a2
e82f67dhttps://github.com/nodejs/node/commit/e82f67d710c5e9b29eab9fd7563f51bd348904a2
ac1f56chttps://github.com/nodejs/node/commit/ac1f56c76a5d1a8ebcb2421d5c629e51df1ac48c
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
#24290https://github.com/nodejs/node/pull/24290
codebyterehttps://github.com/codebytere
Dec 14, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-08c9e2b
https://github.com/addaleax
https://github.com/codebytere
net: simplify Socket.prototype._finalhttps://github.com/nodejs/node/commit/08c9e2bd97fc90e9295eac01ebcc4630e62c050c
08c9e2bhttps://github.com/nodejs/node/commit/08c9e2bd97fc90e9295eac01ebcc4630e62c050c
#24075https://github.com/nodejs/node/pull/24075
codebyterehttps://github.com/codebytere
Dec 14, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-db709c5
https://github.com/addaleax
https://github.com/codebytere
net: partially revert "simplify Socket.prototype._final"https://github.com/nodejs/node/commit/db709c58b82e36513aa0a253dd1d8d28aa6bad25
db709c5https://github.com/nodejs/node/commit/db709c58b82e36513aa0a253dd1d8d28aa6bad25
b7e6ccdhttps://github.com/nodejs/node/commit/b7e6ccd0cc60f20cc397e6ac0705bb3f38c7d225
#24075https://github.com/nodejs/node/pull/24075
#23866https://github.com/nodejs/node/pull/23866
#24288https://github.com/nodejs/node/pull/24288
MylesBorinshttps://github.com/MylesBorins
Dec 26, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-10a2727
https://github.com/addaleax
https://github.com/MylesBorins
net: simplify Socket.prototype._finalhttps://github.com/nodejs/node/commit/10a27277ad272c5a5cdfddd786251ffaa8e02295
10a2727https://github.com/nodejs/node/commit/10a27277ad272c5a5cdfddd786251ffaa8e02295
#24075https://github.com/nodejs/node/pull/24075
MylesBorinshttps://github.com/MylesBorins
Dec 26, 2018 https://github.com/nodejs/node/pull/24075#ref-commit-897114b
https://github.com/addaleax
https://github.com/MylesBorins
net: partially revert "simplify Socket.prototype._final"https://github.com/nodejs/node/commit/897114bf94cc80ef2e55daaa306f38f2fbb81020
897114bhttps://github.com/nodejs/node/commit/897114bf94cc80ef2e55daaa306f38f2fbb81020
b7e6ccdhttps://github.com/nodejs/node/commit/b7e6ccd0cc60f20cc397e6ac0705bb3f38c7d225
#24075https://github.com/nodejs/node/pull/24075
#23866https://github.com/nodejs/node/pull/23866
#24288https://github.com/nodejs/node/pull/24288
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jan 4, 2019 https://github.com/nodejs/node/pull/24075#ref-pullrequest-396037210
v10.15.1 proposal #25346 https://github.com/nodejs/node/pull/25346
codebyterehttps://github.com/codebytere
Jan 12, 2019 https://github.com/nodejs/node/pull/24075#ref-commit-5733849
https://github.com/addaleax
https://github.com/codebytere
tls: do not rely on 'drain' handlers in StreamWraphttps://github.com/nodejs/node/commit/5733849ed4995955969226175487d32093a4529f
5733849https://github.com/nodejs/node/commit/5733849ed4995955969226175487d32093a4529f
#24290https://github.com/nodejs/node/pull/24290
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
codebyterehttps://github.com/codebytere
Jan 12, 2019 https://github.com/nodejs/node/pull/24075#ref-commit-8b4502b
https://github.com/addaleax
https://github.com/codebytere
tls: destroy TLS socket if StreamWrap is destroyedhttps://github.com/nodejs/node/commit/8b4502b574d8ca899d9dae9809fa122044acc8da
8b4502bhttps://github.com/nodejs/node/commit/8b4502b574d8ca899d9dae9809fa122044acc8da
#24290https://github.com/nodejs/node/pull/24290
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
codebyterehttps://github.com/codebytere
Jan 12, 2019 https://github.com/nodejs/node/pull/24075#ref-commit-64fd3e2
https://github.com/addaleax
https://github.com/codebytere
Revert "net: partially revert "simplify Socket.prototype._final""https://github.com/nodejs/node/commit/64fd3e238588da3ad44e02ed34c58f846f7d3403
64fd3e2https://github.com/nodejs/node/commit/64fd3e238588da3ad44e02ed34c58f846f7d3403
ac1f56chttps://github.com/nodejs/node/commit/ac1f56c76a5d1a8ebcb2421d5c629e51df1ac48c
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
#24290https://github.com/nodejs/node/pull/24290
codebyterehttps://github.com/codebytere
Jan 29, 2019 https://github.com/nodejs/node/pull/24075#ref-commit-0c73221
https://github.com/addaleax
https://github.com/codebytere
tls: do not rely on 'drain' handlers in StreamWraphttps://github.com/nodejs/node/commit/0c73221699168268f4c3f5430693c0eb16e57e85
0c73221https://github.com/nodejs/node/commit/0c73221699168268f4c3f5430693c0eb16e57e85
#24290https://github.com/nodejs/node/pull/24290
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
codebyterehttps://github.com/codebytere
Jan 29, 2019 https://github.com/nodejs/node/pull/24075#ref-commit-0f6a952
https://github.com/addaleax
https://github.com/codebytere
tls: destroy TLS socket if StreamWrap is destroyedhttps://github.com/nodejs/node/commit/0f6a9524f82ca435ae5c53dfc580b7b37dbf9913
0f6a952https://github.com/nodejs/node/commit/0f6a9524f82ca435ae5c53dfc580b7b37dbf9913
#24290https://github.com/nodejs/node/pull/24290
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
codebyterehttps://github.com/codebytere
Jan 29, 2019 https://github.com/nodejs/node/pull/24075#ref-commit-c84b420
https://github.com/addaleax
https://github.com/codebytere
Revert "net: partially revert "simplify Socket.prototype._final""https://github.com/nodejs/node/commit/c84b4204571e8f87fae300e4ab331e688912fb10
c84b420https://github.com/nodejs/node/commit/c84b4204571e8f87fae300e4ab331e688912fb10
ac1f56chttps://github.com/nodejs/node/commit/ac1f56c76a5d1a8ebcb2421d5c629e51df1ac48c
#24288https://github.com/nodejs/node/pull/24288
#24075https://github.com/nodejs/node/pull/24075
#24290https://github.com/nodejs/node/pull/24290
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280 https://github.com/beevelop/docker-android-nodejs/issues/280
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258 https://github.com/beevelop/docker-nodejs/issues/258
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281 https://github.com/beevelop/docker-android-nodejs/issues/281
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259 https://github.com/beevelop/docker-nodejs/issues/259
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282 https://github.com/beevelop/docker-android-nodejs/issues/282
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260 https://github.com/beevelop/docker-nodejs/issues/260
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283 https://github.com/beevelop/docker-android-nodejs/issues/283
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261 https://github.com/beevelop/docker-nodejs/issues/261
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284 https://github.com/beevelop/docker-android-nodejs/issues/284
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262 https://github.com/beevelop/docker-nodejs/issues/262
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24075
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/24075/files/e0171a33affa9961975f9008ac6862fc7de32012
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/24075/files/ac1ec9300a4275ed88953ff5114d88bd4dad647f
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Please reload this pagehttps://github.com/nodejs/node/pull/24075
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.