| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9a657cb7-f33d-0a64-dfe1-e0b6d14d8370 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9C8A:2A9EAA:A249B7:DB44F6:6A4D420C |
| html-safe-nonce | 2e72ebbde3a92ed2b09ff1f0153ef403789bc82cd20ac8fbcf6501c15a3f87be |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzhBOjJBOUVBQTpBMjQ5Qjc6REI0NEY2OjZBNEQ0MjBDIiwidmlzaXRvcl9pZCI6IjkxNzk1MTA3NDA1NjA5NDIyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6d105a066cabf058c420608b6d2e2a5f6dddca83906063df965e3b76049476f8 |
| hovercard-subject-tag | pull_request:42552691 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2407/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/93c6833b1ca13bd5e3ab6056c6808f2868c8b4dc532d4fd55d78af65332d90fe/nodejs/node/pull/2407 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/93c6833b1ca13bd5e3ab6056c6808f2868c8b4dc532d4fd55d78af65332d90fe/nodejs/node/pull/2407 |
| og:image:alt | Addresses #2385.
Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if actual value is an error use
util.isError instead of instanceof. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | diversario |
| hostname | github.com |
| expected-hostname | github.com |
| None | 92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56fc8347865a14e2ec811533d68f929cf4e0ec19 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/2407#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2407 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2407 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/2407 |
| Reload | https://github.com/nodejs/node/pull/2407 |
| Reload | https://github.com/nodejs/node/pull/2407 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
958
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| diversario | https://github.com/diversario |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| diversario:fix/2385-inconsistency-in-assert-doesnotthrow | https://github.com/diversario/node/tree/fix/2385-inconsistency-in-assert-doesnotthrow |
| Conversation | https://github.com/nodejs/node/pull/2407 |
| Commits4 (4) | https://github.com/nodejs/node/pull/2407/commits |
| Checks | https://github.com/nodejs/node/pull/2407/checks |
| Files changed | https://github.com/nodejs/node/pull/2407/files |
| assert: respect assert.doesNotThrow message. | https://github.com/nodejs/node/pull/2407#top |
| diversario | https://github.com/diversario |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| diversario:fix/2385-inconsistency-in-assert-doesnotthrow | https://github.com/diversario/node/tree/fix/2385-inconsistency-in-assert-doesnotthrow |
|
| https://github.com/diversario |
| diversario | https://github.com/diversario |
| Aug 17, 2015 | https://github.com/nodejs/node/pull/2407#issue-101335406 |
| #2385 | https://github.com/nodejs/node/issues/2385 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/brendanashworth |
| brendanashworth | https://github.com/brendanashworth |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
| Aug 17, 2015 | https://github.com/nodejs/node/pull/2407#event-383975485 |
| https://github.com/brendanashworth |
| brendanashworth | https://github.com/brendanashworth |
| Aug 26, 2015 | https://github.com/nodejs/node/pull/2407#issuecomment-134875083 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/diversario |
| diversario | https://github.com/diversario |
| Aug 26, 2015 | https://github.com/nodejs/node/pull/2407#issuecomment-135016746 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| force-pushed | https://github.com/nodejs/node/compare/11c25c28e266dd89ce6744ed7a23f2576c1bb103..ba02bd02e91773be161e03a9ed67745fba8f22db |
| 11c25c2 | https://github.com/nodejs/node/commit/11c25c28e266dd89ce6744ed7a23f2576c1bb103 |
| ba02bd0 | https://github.com/nodejs/node/commit/ba02bd02e91773be161e03a9ed67745fba8f22db |
|
Compare
| https://github.com/nodejs/node/compare/11c25c28e266dd89ce6744ed7a23f2576c1bb103..ba02bd02e91773be161e03a9ed67745fba8f22db |
| September 6, 2015 11:55 | https://github.com/nodejs/node/pull/2407#event-402153250 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Nov 16, 2015 | https://github.com/nodejs/node/pull/2407#event-465701149 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 16, 2015 | https://github.com/nodejs/node/pull/2407#issuecomment-157110670 |
| @diversario | https://github.com/diversario |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/diversario |
| diversario | https://github.com/diversario |
| Nov 16, 2015 | https://github.com/nodejs/node/pull/2407#issuecomment-157111676 |
| here | https://github.com/nodejs/node/issues/2385#issuecomment-135619696 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 16, 2015 | https://github.com/nodejs/node/pull/2407#issuecomment-157111946 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Nov 16, 2015 | https://github.com/nodejs/node/pull/2407#issuecomment-157112654 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 16, 2015 | https://github.com/nodejs/node/pull/2407#issuecomment-157117873 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Nov 16, 2015 | https://github.com/nodejs/node/pull/2407#issuecomment-157118903 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Nov 16, 2015 | https://github.com/nodejs/node/pull/2407#issuecomment-157118968 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Nov 16, 2015 | https://github.com/nodejs/node/pull/2407#issuecomment-157119927 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| rvagg | https://github.com/rvagg |
|
Nov 17, 2015
| https://github.com/nodejs/node/pull/2407#discussion-diff-45044389 |
| View reviewed changes
| https://github.com/nodejs/node/pull/2407/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f |
| lib/assert.js | https://github.com/nodejs/node/pull/2407/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f |
| rvagg | https://github.com/rvagg |
| Nov 17, 2015 | https://github.com/nodejs/node/pull/2407#discussion_r45044389 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| diversario | https://github.com/diversario |
| Apr 2, 2016 | https://github.com/nodejs/node/pull/2407#discussion_r58294072 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Nov 17, 2015 | https://github.com/nodejs/node/pull/2407#issuecomment-157332696 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/1e896a69fae430b3221610cc50294a6563ad198d..082cc8d6d8f5c7c797e58cefeb475b783c730635 |
| 1e896a6 | https://github.com/nodejs/node/commit/1e896a69fae430b3221610cc50294a6563ad198d |
| 082cc8d | https://github.com/nodejs/node/commit/082cc8d6d8f5c7c797e58cefeb475b783c730635 |
|
Compare
| https://github.com/nodejs/node/compare/1e896a69fae430b3221610cc50294a6563ad198d..082cc8d6d8f5c7c797e58cefeb475b783c730635 |
| December 27, 2015 02:00 | https://github.com/nodejs/node/pull/2407#event-500828022 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 2, 2016 | https://github.com/nodejs/node/pull/2407#issuecomment-204646218 |
| @diversario | https://github.com/diversario |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/diversario |
| diversario | https://github.com/diversario |
| Apr 2, 2016 | https://github.com/nodejs/node/pull/2407#issuecomment-204726554 |
| @rvagg | https://github.com/rvagg |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 4, 2016 | https://github.com/nodejs/node/pull/2407#issuecomment-205518164 |
| @diversario | https://github.com/diversario |
| @rvagg | https://github.com/rvagg |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/diversario |
| diversario | https://github.com/diversario |
| Apr 10, 2016 | https://github.com/nodejs/node/pull/2407#issuecomment-208020946 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| jasnell | https://github.com/jasnell |
|
Apr 11, 2016
| https://github.com/nodejs/node/pull/2407#discussion-diff-59300421 |
| View reviewed changes
| https://github.com/nodejs/node/pull/2407/files#diff-d42dc4124a646e01c0f11caf6234089d08141ef163843dffcaf4f1b9c5670d6c |
| doc/api/assert.markdown | https://github.com/nodejs/node/pull/2407/files#diff-d42dc4124a646e01c0f11caf6234089d08141ef163843dffcaf4f1b9c5670d6c |
| jasnell | https://github.com/jasnell |
| Apr 11, 2016 | https://github.com/nodejs/node/pull/2407#discussion_r59300421 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 11, 2016 | https://github.com/nodejs/node/pull/2407#issuecomment-208623114 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/diversario |
| diversario | https://github.com/diversario |
| Apr 13, 2016 | https://github.com/nodejs/node/pull/2407#issuecomment-209691964 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 15, 2016 | https://github.com/nodejs/node/pull/2407#issuecomment-210312447 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| April 15, 2016 11:31 | https://github.com/nodejs/node/pull/2407#commits-pushed-83ec4b5 |
|
| https://github.com/diversario |
| assert: respect assert.doesNotThrow message. | https://github.com/nodejs/node/pull/2407/commits/83ec4b5cdc2004a88d608137a46d01897e2e7f6d |
| 83ec4b5 | https://github.com/nodejs/node/pull/2407/commits/83ec4b5cdc2004a88d608137a46d01897e2e7f6d |
| nodejs#2385 | https://github.com/nodejs/node/issues/2385 |
|
| https://github.com/diversario |
| assert: clean up conditional for _throws, fix docs. | https://github.com/nodejs/node/pull/2407/commits/d741140c1979ba82512e21072287d2e830430810 |
| d741140 | https://github.com/nodejs/node/pull/2407/commits/d741140c1979ba82512e21072287d2e830430810 |
| nodejs#2407 | https://github.com/nodejs/node/pull/2407 |
| jasnell | https://github.com/jasnell |
|
Apr 18, 2016
| https://github.com/nodejs/node/pull/2407#ref-commit-c1d82ac |
|
| https://github.com/jasnell |
| assert: respect assert.doesNotThrow message. | https://github.com/nodejs/node/commit/c1d82ac2ff15594840e2a1b9531b506ae067ed27 |
| c1d82ac | https://github.com/nodejs/node/commit/c1d82ac2ff15594840e2a1b9531b506ae067ed27 |
| #2385 | https://github.com/nodejs/node/issues/2385 |
| #2407 | https://github.com/nodejs/node/pull/2407 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Apr 18, 2016 | https://github.com/nodejs/node/pull/2407#event-632140465 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 18, 2016 | https://github.com/nodejs/node/pull/2407#issuecomment-211636911 |
| c1d82ac | https://github.com/nodejs/node/commit/c1d82ac2ff15594840e2a1b9531b506ae067ed27 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 18, 2016 | https://github.com/nodejs/node/pull/2407#event-632140551 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 19, 2016
| https://github.com/nodejs/node/pull/2407#ref-commit-a026b8a |
| assert: respect assert.doesNotThrow message. | https://github.com/nodejs/node/commit/a026b8a4d4de307b34c4d4e1cc279995c6b86417 |
| a026b8a | https://github.com/nodejs/node/commit/a026b8a4d4de307b34c4d4e1cc279995c6b86417 |
| #2385 | https://github.com/nodejs/node/issues/2385 |
| #2407 | https://github.com/nodejs/node/pull/2407 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 20, 2016
| https://github.com/nodejs/node/pull/2407#ref-commit-fde1348 |
| assert: respect assert.doesNotThrow message. | https://github.com/nodejs/node/commit/fde1348829fa05d853b972e83df0df50c56e728e |
| fde1348 | https://github.com/nodejs/node/commit/fde1348829fa05d853b972e83df0df50c56e728e |
| #2385 | https://github.com/nodejs/node/issues/2385 |
| #2407 | https://github.com/nodejs/node/pull/2407 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 20, 2016
| https://github.com/nodejs/node/pull/2407#ref-commit-690192c |
| assert: respect assert.doesNotThrow message. | https://github.com/nodejs/node/commit/690192c8c3908f7218fa6c58923d97995b9e0146 |
| 690192c | https://github.com/nodejs/node/commit/690192c8c3908f7218fa6c58923d97995b9e0146 |
| #2385 | https://github.com/nodejs/node/issues/2385 |
| #2407 | https://github.com/nodejs/node/pull/2407 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 20, 2016
| https://github.com/nodejs/node/pull/2407#ref-pullrequest-149848634 |
|
V5.10.2 proposal
#6311
| https://github.com/nodejs/node/pull/6311 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 20, 2016
| https://github.com/nodejs/node/pull/2407#ref-commit-14fcb1d |
| assert: respect assert.doesNotThrow message. | https://github.com/nodejs/node/commit/14fcb1dded8399934c6c84cb74d3eec6466de859 |
| 14fcb1d | https://github.com/nodejs/node/commit/14fcb1dded8399934c6c84cb74d3eec6466de859 |
| #2385 | https://github.com/nodejs/node/issues/2385 |
| #2407 | https://github.com/nodejs/node/pull/2407 |
|
V5.11.0 proposal
#6321
| https://github.com/nodejs/node/pull/6321 |
|
V5.11.0 proposal
#6322
| https://github.com/nodejs/node/pull/6322 |
|
Audit commits not found on v4.x
#5647
| https://github.com/nodejs/node/issues/5647 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Apr 21, 2016 | https://github.com/nodejs/node/pull/2407#issuecomment-212770449 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 21, 2016 | https://github.com/nodejs/node/pull/2407#issuecomment-212904194 |
| @jasnell | https://github.com/jasnell |
| https://github.com/jasnell | https://github.com/jasnell |
| #2407 (comment) | https://github.com/nodejs/node/pull/2407#issuecomment-212770449 |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 21, 2016
| https://github.com/nodejs/node/pull/2407#ref-commit-85cb9bb |
|
| https://github.com/MylesBorins |
| assert: respect assert.doesNotThrow message. | https://github.com/nodejs/node/commit/85cb9bb31dbe5103c257d2a559f2dc61ad97ea76 |
| 85cb9bb | https://github.com/nodejs/node/commit/85cb9bb31dbe5103c257d2a559f2dc61ad97ea76 |
| #2385 | https://github.com/nodejs/node/issues/2385 |
| #2407 | https://github.com/nodejs/node/pull/2407 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Apr 21, 2016 | https://github.com/nodejs/node/pull/2407#event-636417124 |
| joelostrowski | https://github.com/joelostrowski |
|
Apr 25, 2016
| https://github.com/nodejs/node/pull/2407#ref-commit-865bcfd |
|
| https://github.com/joelostrowski |
| assert: respect assert.doesNotThrow message. | https://github.com/joelostrowski/node/commit/865bcfdf1cba20980a7331b5c8721452c607c6fe |
| 865bcfd | https://github.com/joelostrowski/node/commit/865bcfdf1cba20980a7331b5c8721452c607c6fe |
| nodejs#2385 | https://github.com/nodejs/node/issues/2385 |
| nodejs#2407 | https://github.com/nodejs/node/pull/2407 |
| jasnell | https://github.com/jasnell |
|
Apr 26, 2016
| https://github.com/nodejs/node/pull/2407#ref-commit-8b8746f |
|
| https://github.com/jasnell |
| assert: respect assert.doesNotThrow message. | https://github.com/nodejs/node/commit/8b8746f43dbfe4766eac2876e4fc56918e4dd160 |
| 8b8746f | https://github.com/nodejs/node/commit/8b8746f43dbfe4766eac2876e4fc56918e4dd160 |
| #2385 | https://github.com/nodejs/node/issues/2385 |
| #2407 | https://github.com/nodejs/node/pull/2407 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
May 2, 2016
| https://github.com/nodejs/node/pull/2407#ref-issue-152637195 |
|
API stability level «Locked» is inaccurate
#6528
| https://github.com/nodejs/node/issues/6528 |
| MylesBorins | https://github.com/MylesBorins |
|
May 3, 2016
| https://github.com/nodejs/node/pull/2407#ref-commit-a0223c6 |
| assert: respect assert.doesNotThrow message. | https://github.com/nodejs/node/commit/a0223c61cd5eb9550421bb7c19cd0fd88fd0ec64 |
| a0223c6 | https://github.com/nodejs/node/commit/a0223c61cd5eb9550421bb7c19cd0fd88fd0ec64 |
| #2385 | https://github.com/nodejs/node/issues/2385 |
| #2407 | https://github.com/nodejs/node/pull/2407 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| May 3, 2016 | https://github.com/nodejs/node/pull/2407#event-649180276 |
| MylesBorins | https://github.com/MylesBorins |
|
May 6, 2016
| https://github.com/nodejs/node/pull/2407#ref-commit-c2eff54 |
| assert: respect assert.doesNotThrow message. | https://github.com/nodejs/node/commit/c2eff5434206e55edd8c0630e8cb1e4e9544b102 |
| c2eff54 | https://github.com/nodejs/node/commit/c2eff5434206e55edd8c0630e8cb1e4e9544b102 |
| #2385 | https://github.com/nodejs/node/issues/2385 |
| #2407 | https://github.com/nodejs/node/pull/2407 |
| MylesBorins | https://github.com/MylesBorins |
|
May 18, 2016
| https://github.com/nodejs/node/pull/2407#ref-commit-59a977d |
| assert: respect assert.doesNotThrow message. | https://github.com/nodejs/node/commit/59a977dd22996e8380b7085eed6a0772156a9769 |
| 59a977d | https://github.com/nodejs/node/commit/59a977dd22996e8380b7085eed6a0772156a9769 |
| #2385 | https://github.com/nodejs/node/issues/2385 |
| #2407 | https://github.com/nodejs/node/pull/2407 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
May 18, 2016
| https://github.com/nodejs/node/pull/2407#ref-pullrequest-155393333 |
|
v4.4.5 proposal
#6824
| https://github.com/nodejs/node/pull/6824 |
| https://github.com/LinusU |
| LinusU | https://github.com/LinusU |
|
Sep 27, 2016
| https://github.com/nodejs/node/pull/2407#pullrequestreview-1830754 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/2407/files/610a38ea7f71223b940273aaebc30cfee340dfc8 |
| lib/assert.js | https://github.com/nodejs/node/pull/2407/files/610a38ea7f71223b940273aaebc30cfee340dfc8#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f |
| LinusU | https://github.com/LinusU |
| Sep 27, 2016 | https://github.com/nodejs/node/pull/2407#discussion_r80800918 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @diversario | https://github.com/diversario |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| BridgeAR | https://github.com/BridgeAR |
| Aug 23, 2017 | https://github.com/nodejs/node/pull/2407#discussion_r134883225 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2407 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/2407/files/610a38ea7f71223b940273aaebc30cfee340dfc8 |
|
| https://github.com/LinusU |
|
LinusU
| https://github.com/LinusU |
|
| https://github.com/nodejs/node/pull/2407/files/610a38ea7f71223b940273aaebc30cfee340dfc8 |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
| Please reload this page | https://github.com/nodejs/node/pull/2407 |
|
| https://github.com/diversario |
|
| https://github.com/brendanashworth |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/mscdex |
|
| https://github.com/rvagg |
|
| https://github.com/MylesBorins |
|
| https://github.com/LinusU |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |