René's URL Explorer Experiment


Title: stream: make `.destroy()` interact better with write queue by addaleax · Pull Request #24062 · nodejs/node · GitHub

Open Graph Title: stream: make `.destroy()` interact better with write queue by addaleax · Pull Request #24062 · nodejs/node

X Title: stream: make `.destroy()` interact better with write queue by addaleax · Pull Request #24062 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: @nodejs/streams @mcollina @mafintosh I’m mostly looking for feedback on the idea here rather than the implementation, i.e., does this make sense, is this the right behaviour, etc.? Also, does the t...

X Description: @nodejs/streams @mcollina @mafintosh I’m mostly looking for feedback on the idea here rather than the implementation, i.e., does this make sense, is this the right behaviour, etc.? Also, does the t...

Opengraph URL: https://github.com/nodejs/node/pull/24062

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f7fec207-b7fc-5de2-8cc3-96de009b84a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE14E:139E28:381CEA:4649DC:69906DFD
html-safe-nonce5f8ce812ee2c0f0081e74fd10bc9d10b7ae046c2498fdbee1f701c9d13afa5aa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTRFOjEzOUUyODozODFDRUE6NDY0OURDOjY5OTA2REZEIiwidmlzaXRvcl9pZCI6IjExMTgwNzc0ODg5NzI0NTk1MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccbeddaa844154fdbd550ca05a048367bf34c7a85cb2b418083459375f4331254
hovercard-subject-tagpull_request:228129550
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24062/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/47321cc13c52d26c7cd3524864a60a31e886c9438c768082fa87f363ad8c40aa/nodejs/node/pull/24062
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/47321cc13c52d26c7cd3524864a60a31e886c9438c768082fa87f363ad8c40aa/nodejs/node/pull/24062
og:image:alt@nodejs/streams @mcollina @mafintosh I’m mostly looking for feedback on the idea here rather than the implementation, i.e., does this make sense, is this the right behaviour, etc.? Also, does the t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24062#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24062
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24062
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24062
Reloadhttps://github.com/nodejs/node/pull/24062
Reloadhttps://github.com/nodejs/node/pull/24062
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24062
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:stream-write-destroyhttps://github.com/addaleax/node/tree/stream-write-destroy
Conversationhttps://github.com/nodejs/node/pull/24062
Commits2 (2)https://github.com/nodejs/node/pull/24062/commits
Checkshttps://github.com/nodejs/node/pull/24062/checks
Files changedhttps://github.com/nodejs/node/pull/24062/files
stream: make .destroy() interact better with write queuehttps://github.com/nodejs/node/pull/24062#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:stream-write-destroyhttps://github.com/addaleax/node/tree/stream-write-destroy
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 3, 2018https://github.com/nodejs/node/pull/24062#issue-377073925
Please reload this pagehttps://github.com/nodejs/node/pull/24062
@mcollinahttps://github.com/mcollina
@mafintoshhttps://github.com/mafintosh
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24062
https://github.com/addaleax
stream: make .destroy() interact better with write queuehttps://github.com/nodejs/node/pull/24062/commits/af56ec26f9f5eece026ebe2bbffbf4ede0193d59
af56ec2https://github.com/nodejs/node/pull/24062/commits/af56ec26f9f5eece026ebe2bbffbf4ede0193d59
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 3, 2018https://github.com/nodejs/node/pull/24062#issuecomment-435604524
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1472/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1472/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24062
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Nov 3, 2018https://github.com/nodejs/node/pull/24062#event-1944466236
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 3, 2018https://github.com/nodejs/node/pull/24062#issuecomment-435604566
https://ci.nodejs.org/job/node-test-pull-request/18316/https://ci.nodejs.org/job/node-test-pull-request/18316/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1609/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1609/
Please reload this pagehttps://github.com/nodejs/node/pull/24062
https://github.com/addaleax
fixup! stream: make .destroy() interact better with write queuehttps://github.com/nodejs/node/pull/24062/commits/589f159d3c3b3de8943ae0100b0e72d179af53d2
589f159https://github.com/nodejs/node/pull/24062/commits/589f159d3c3b3de8943ae0100b0e72d179af53d2
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 3, 2018https://github.com/nodejs/node/pull/24062#issuecomment-435608443
Please reload this pagehttps://github.com/nodejs/node/pull/24062
https://ci.nodejs.org/job/node-test-pull-request/18319/https://ci.nodejs.org/job/node-test-pull-request/18319/
Please reload this pagehttps://github.com/nodejs/node/pull/24062
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 3, 2018https://github.com/nodejs/node/pull/24062#issuecomment-435612412
CITGMhttps://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1609/
Please reload this pagehttps://github.com/nodejs/node/pull/24062
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 5, 2018 https://github.com/nodejs/node/pull/24062#pullrequestreview-171470200
View reviewed changes https://github.com/nodejs/node/pull/24062/files/589f159d3c3b3de8943ae0100b0e72d179af53d2
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/24062#pullrequestreview-171470200
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24062
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 5, 2018https://github.com/nodejs/node/pull/24062#issuecomment-435817319
Please reload this pagehttps://github.com/nodejs/node/pull/24062
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1610/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1610/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1612/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1612/
Please reload this pagehttps://github.com/nodejs/node/pull/24062
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 7, 2018https://github.com/nodejs/node/pull/24062#issuecomment-436611179
Please reload this pagehttps://github.com/nodejs/node/pull/24062
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 10, 2018 https://github.com/nodejs/node/pull/24062#pullrequestreview-173670390
View reviewed changes https://github.com/nodejs/node/pull/24062/files/589f159d3c3b3de8943ae0100b0e72d179af53d2
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 10, 2018https://github.com/nodejs/node/pull/24062#issuecomment-437620931
d3f02d0https://github.com/nodejs/node/commit/d3f02d0da3d574b91a15d3ace10e76014b7574fc
Please reload this pagehttps://github.com/nodejs/node/pull/24062
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 10, 2018https://github.com/nodejs/node/pull/24062#event-1958593985
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
November 10, 2018 21:00https://github.com/nodejs/node/pull/24062#event-1958594045
addaleaxhttps://github.com/addaleax
Nov 10, 2018 https://github.com/nodejs/node/pull/24062#ref-commit-d3f02d0
https://github.com/addaleax
stream: make .destroy() interact better with write queuehttps://github.com/addaleax/node/commit/d3f02d0da3d574b91a15d3ace10e76014b7574fc
d3f02d0https://github.com/addaleax/node/commit/d3f02d0da3d574b91a15d3ace10e76014b7574fc
nodejs#24062https://github.com/nodejs/node/pull/24062
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24062#ref-commit-13dee43
https://github.com/addaleax
https://github.com/BridgeAR
stream: make .destroy() interact better with write queuehttps://github.com/nodejs/node/commit/13dee430cd7728fa1d403f71505803a11f3b62fa
13dee43https://github.com/nodejs/node/commit/13dee430cd7728fa1d403f71505803a11f3b62fa
#24062https://github.com/nodejs/node/pull/24062
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24062#ref-pullrequest-380492752
Release proposal: v11.2 #24350 https://github.com/nodejs/node/pull/24350
kiyomizumiahttps://github.com/kiyomizumia
Nov 15, 2018 https://github.com/nodejs/node/pull/24062#ref-commit-0091af5
https://github.com/addaleax
https://github.com/kiyomizumia
stream: make .destroy() interact better with write queuehttps://github.com/kiyomizumia/node/commit/0091af564caee26cead64adf582797392dbe006b
0091af5https://github.com/kiyomizumia/node/commit/0091af564caee26cead64adf582797392dbe006b
nodejs#24062https://github.com/nodejs/node/pull/24062
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232 https://github.com/beevelop/docker-nodejs/issues/232
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249 https://github.com/beevelop/docker-android-nodejs/issues/249
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233 https://github.com/beevelop/docker-nodejs/issues/233
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234 https://github.com/beevelop/docker-nodejs/issues/234
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235 https://github.com/beevelop/docker-nodejs/issues/235
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236 https://github.com/beevelop/docker-nodejs/issues/236
codebyterehttps://github.com/codebytere
Dec 14, 2018 https://github.com/nodejs/node/pull/24062#ref-commit-f41eddc
https://github.com/addaleax
https://github.com/codebytere
stream: make .destroy() interact better with write queuehttps://github.com/nodejs/node/commit/f41eddc2c626db025274a4a42231332c1e2ab708
f41eddchttps://github.com/nodejs/node/commit/f41eddc2c626db025274a4a42231332c1e2ab708
#24062https://github.com/nodejs/node/pull/24062
MylesBorinshttps://github.com/MylesBorins
Dec 26, 2018 https://github.com/nodejs/node/pull/24062#ref-commit-6ce4ef3
https://github.com/addaleax
https://github.com/MylesBorins
stream: make .destroy() interact better with write queuehttps://github.com/nodejs/node/commit/6ce4ef3387faa42a884fbd31ffd13e8ae49b4972
6ce4ef3https://github.com/nodejs/node/commit/6ce4ef3387faa42a884fbd31ffd13e8ae49b4972
#24062https://github.com/nodejs/node/pull/24062
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jan 4, 2019 https://github.com/nodejs/node/pull/24062#ref-pullrequest-396037210
v10.15.1 proposal #25346 https://github.com/nodejs/node/pull/25346
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280 https://github.com/beevelop/docker-android-nodejs/issues/280
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258 https://github.com/beevelop/docker-nodejs/issues/258
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281 https://github.com/beevelop/docker-android-nodejs/issues/281
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259 https://github.com/beevelop/docker-nodejs/issues/259
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282 https://github.com/beevelop/docker-android-nodejs/issues/282
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260 https://github.com/beevelop/docker-nodejs/issues/260
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283 https://github.com/beevelop/docker-android-nodejs/issues/283
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261 https://github.com/beevelop/docker-nodejs/issues/261
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284 https://github.com/beevelop/docker-android-nodejs/issues/284
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262 https://github.com/beevelop/docker-nodejs/issues/262
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 7, 2019 https://github.com/nodejs/node/pull/24062#ref-pullrequest-407485394
doc: clarify effect of stream.destroy() on write() #25973 https://github.com/nodejs/node/pull/25973
https://github.com/rscherich
rscherichhttps://github.com/rscherich
Nov 16, 2021 https://github.com/nodejs/node/pull/24062#ref-issue-920504256
Writable does not check if stream has been destroyed during _final and _write #39030 https://github.com/nodejs/node/issues/39030
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24062
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/24062/files/589f159d3c3b3de8943ae0100b0e72d179af53d2
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/24062/files/589f159d3c3b3de8943ae0100b0e72d179af53d2
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/24062
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.