René's URL Explorer Experiment


Title: fs: handle result of access binding directly in fs.existsSync by joyeecheung · Pull Request #24015 · nodejs/node · GitHub

Open Graph Title: fs: handle result of access binding directly in fs.existsSync by joyeecheung · Pull Request #24015 · nodejs/node

X Title: fs: handle result of access binding directly in fs.existsSync by joyeecheung · Pull Request #24015 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Instead of throwing errors in fs.accessSync and then catching it, handle the result from the binding directly in fs.existsSync. Note that the argument validation errors still needs to be caught unt...

X Description: Instead of throwing errors in fs.accessSync and then catching it, handle the result from the binding directly in fs.existsSync. Note that the argument validation errors still needs to be caught unt...

Opengraph URL: https://github.com/nodejs/node/pull/24015

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4a3a4c66-aebf-2bb6-792a-8c91e89dbc5f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE4B4:92C15:7050D:90A2C:69905052
html-safe-nonce67157a89581eaf4ba36d960dc962a464639b97cc81172bb25e8e1cc060760181
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEI0OjkyQzE1OjcwNTBEOjkwQTJDOjY5OTA1MDUyIiwidmlzaXRvcl9pZCI6IjU1ODAxMzMzODgwNDIzOTE2MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacacc1caacc356bfd90b9d9a08b6122dd0d8fa6c88dc4fe8f39efe76ea662fb56b
hovercard-subject-tagpull_request:227569720
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24015/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/00ed352c4d958443f0bece256897a08996e8346864f2d2475531101e62e6ab47/nodejs/node/pull/24015
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/00ed352c4d958443f0bece256897a08996e8346864f2d2475531101e62e6ab47/nodejs/node/pull/24015
og:image:altInstead of throwing errors in fs.accessSync and then catching it, handle the result from the binding directly in fs.existsSync. Note that the argument validation errors still needs to be caught unt...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24015#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24015
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24015
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24015
Reloadhttps://github.com/nodejs/node/pull/24015
Reloadhttps://github.com/nodejs/node/pull/24015
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24015
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 707 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:exists-sync-no-errorhttps://github.com/joyeecheung/node/tree/exists-sync-no-error
Conversationhttps://github.com/nodejs/node/pull/24015
Commits1 (1)https://github.com/nodejs/node/pull/24015/commits
Checkshttps://github.com/nodejs/node/pull/24015/checks
Files changedhttps://github.com/nodejs/node/pull/24015/files
fs: handle result of access binding directly in fs.existsSynchttps://github.com/nodejs/node/pull/24015#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:exists-sync-no-errorhttps://github.com/joyeecheung/node/tree/exists-sync-no-error
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 1, 2018https://github.com/nodejs/node/pull/24015#issue-376329422
Please reload this pagehttps://github.com/nodejs/node/pull/24015
#24008https://github.com/nodejs/node/issues/24008
Please reload this pagehttps://github.com/nodejs/node/pull/24015
https://github.com/joyeecheung
fs: handle result of access binding directly in fs.existsSynchttps://github.com/nodejs/node/pull/24015/commits/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7
b87682ahttps://github.com/nodejs/node/pull/24015/commits/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 1, 2018https://github.com/nodejs/node/pull/24015#issuecomment-434994079
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1449/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1449/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24015
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Nov 1, 2018https://github.com/nodejs/node/pull/24015#event-1940125733
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 1, 2018https://github.com/nodejs/node/pull/24015#issuecomment-434994160
https://ci.nodejs.org/job/node-test-pull-request/18275/https://ci.nodejs.org/job/node-test-pull-request/18275/
Please reload this pagehttps://github.com/nodejs/node/pull/24015
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 1, 2018 https://github.com/nodejs/node/pull/24015#pullrequestreview-170707169
View reviewed changes https://github.com/nodejs/node/pull/24015/files/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 1, 2018 https://github.com/nodejs/node/pull/24015#pullrequestreview-170865421
View reviewed changes https://github.com/nodejs/node/pull/24015/files/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 2, 2018https://github.com/nodejs/node/pull/24015#issuecomment-435324306
https://ci.nodejs.org/job/node-test-pull-request/18297/https://ci.nodejs.org/job/node-test-pull-request/18297/
Please reload this pagehttps://github.com/nodejs/node/pull/24015
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 2, 2018https://github.com/nodejs/node/pull/24015#event-1942528543
https://github.com/jdalton
jdaltonhttps://github.com/jdalton
Nov 2, 2018 https://github.com/nodejs/node/pull/24015#pullrequestreview-171300338
View reviewed changes https://github.com/nodejs/node/pull/24015/files/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7
lib/fs.jshttps://github.com/nodejs/node/pull/24015/files/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
jdaltonhttps://github.com/jdalton
Nov 2, 2018https://github.com/nodejs/node/pull/24015#discussion_r230531759
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24015
https://github.com/refack
refackhttps://github.com/refack
Nov 3, 2018 https://github.com/nodejs/node/pull/24015#pullrequestreview-171338492
View reviewed changes https://github.com/nodejs/node/pull/24015/files/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7
lib/fs.jshttps://github.com/nodejs/node/pull/24015/files/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
Please reload this pagehttps://github.com/nodejs/node/pull/24015
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Nov 3, 2018 https://github.com/nodejs/node/pull/24015#ref-pullrequest-377089126
fs: makes existsSync stop using errors #24068 https://github.com/nodejs/node/pull/24068
https://github.com/arcanis
arcanishttps://github.com/arcanis
Nov 3, 2018 https://github.com/nodejs/node/pull/24015#ref-issue-376209596
existsSync is expensive #24008 https://github.com/nodejs/node/issues/24008
https://github.com/refack
refackhttps://github.com/refack
Nov 3, 2018 https://github.com/nodejs/node/pull/24015#pullrequestreview-171344668
View reviewed changes https://github.com/nodejs/node/pull/24015/files/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7
Trotthttps://github.com/Trott
Nov 4, 2018 https://github.com/nodejs/node/pull/24015#ref-commit-bcc7b7a
https://github.com/joyeecheung
https://github.com/Trott
fs: handle result of access binding directly in fs.existsSynchttps://github.com/Trott/io.js/commit/bcc7b7a58c13b92f6427184f3fe4583a7728f57c
bcc7b7ahttps://github.com/Trott/io.js/commit/bcc7b7a58c13b92f6427184f3fe4583a7728f57c
nodejs#24015https://github.com/nodejs/node/pull/24015
nodejs#24008https://github.com/nodejs/node/issues/24008
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 4, 2018https://github.com/nodejs/node/pull/24015#issuecomment-435634879
bcc7b7ahttps://github.com/nodejs/node/commit/bcc7b7a58c13b92f6427184f3fe4583a7728f57c
@jdaltonhttps://github.com/jdalton
Please reload this pagehttps://github.com/nodejs/node/pull/24015
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 4, 2018https://github.com/nodejs/node/pull/24015#event-1944629914
targoshttps://github.com/targos
Nov 5, 2018 https://github.com/nodejs/node/pull/24015#ref-commit-424be28
https://github.com/joyeecheung
https://github.com/targos
fs: handle result of access binding directly in fs.existsSynchttps://github.com/nodejs/node/commit/424be28840c7ceb10a5f1f552114053087e734f2
424be28https://github.com/nodejs/node/commit/424be28840c7ceb10a5f1f552114053087e734f2
#24015https://github.com/nodejs/node/pull/24015
#24008https://github.com/nodejs/node/issues/24008
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/24015#ref-pullrequest-380492752
Release proposal: v11.2 #24350 https://github.com/nodejs/node/pull/24350
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232 https://github.com/beevelop/docker-nodejs/issues/232
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249 https://github.com/beevelop/docker-android-nodejs/issues/249
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233 https://github.com/beevelop/docker-nodejs/issues/233
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234 https://github.com/beevelop/docker-nodejs/issues/234
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235 https://github.com/beevelop/docker-nodejs/issues/235
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236 https://github.com/beevelop/docker-nodejs/issues/236
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/24015#ref-commit-8b3b688
https://github.com/joyeecheung
https://github.com/codebytere
fs: handle result of access binding directly in fs.existsSynchttps://github.com/nodejs/node/commit/8b3b68804f9e019f8f55e6b8cee00610f4159074
8b3b688https://github.com/nodejs/node/commit/8b3b68804f9e019f8f55e6b8cee00610f4159074
#24015https://github.com/nodejs/node/pull/24015
#24008https://github.com/nodejs/node/issues/24008
https://github.com/codebytere
codebyterehttps://github.com/codebytere
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Nov 29, 2018https://github.com/nodejs/node/pull/24015#event-1994038049
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/24015#ref-commit-00badcb
https://github.com/joyeecheung
https://github.com/MylesBorins
fs: handle result of access binding directly in fs.existsSynchttps://github.com/nodejs/node/commit/00badcbf2bc405643f4fce80fa21f1208f4803cf
00badcbhttps://github.com/nodejs/node/commit/00badcbf2bc405643f4fce80fa21f1208f4803cf
#24015https://github.com/nodejs/node/pull/24015
#24008https://github.com/nodejs/node/issues/24008
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/24015#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
MylesBorinshttps://github.com/MylesBorins
Dec 3, 2018 https://github.com/nodejs/node/pull/24015#ref-commit-765a3a9
https://github.com/joyeecheung
https://github.com/MylesBorins
fs: handle result of access binding directly in fs.existsSynchttps://github.com/nodejs/node/commit/765a3a946600236b4cf60e6bd8c9b32a23cdb591
765a3a9https://github.com/nodejs/node/commit/765a3a946600236b4cf60e6bd8c9b32a23cdb591
#24015https://github.com/nodejs/node/pull/24015
#24008https://github.com/nodejs/node/issues/24008
https://github.com/mheggeseth
mheggesethhttps://github.com/mheggeseth
Dec 21, 2018 https://github.com/nodejs/node/pull/24015#ref-issue-381770096
existsSync throws an error instead of returning false in Node 11 tschaub/mock-fs#256 https://github.com/tschaub/mock-fs/issues/256
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24015
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/24015/files/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/24015/files/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7
https://github.com/jdalton
jdalton https://github.com/jdalton
https://github.com/nodejs/node/pull/24015/files/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/24015/files/b87682a54fb9d7b21d8b418dcafda0b2b21d73e7
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/24015
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jdalton
https://github.com/refack
https://github.com/jasnell
https://github.com/lpinca
https://github.com/codebytere
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.