René's URL Explorer Experiment


Title: tools: fix c++ code coverage on macOS by evanlucas · Pull Request #24004 · nodejs/node · GitHub

Open Graph Title: tools: fix c++ code coverage on macOS by evanlucas · Pull Request #24004 · nodejs/node

X Title: tools: fix c++ code coverage on macOS by evanlucas · Pull Request #24004 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Recent libtool on macOS does not support the --coverage flag that was being passed through in the final linking stage. This change patches gyp-mac-tool to not pass the --coverage flag through to li...

X Description: Recent libtool on macOS does not support the --coverage flag that was being passed through in the final linking stage. This change patches gyp-mac-tool to not pass the --coverage flag through to li...

Opengraph URL: https://github.com/nodejs/node/pull/24004

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8b8affba-a78b-137c-7f1a-91b2ba67397a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA6C2:221381:119433E:16A0CB4:6990CDF4
html-safe-nonce8aaebbfd48d2432e870c5469e690d72c4810cf4f8f98cf579b643efa4118641a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkMyOjIyMTM4MToxMTk0MzNFOjE2QTBDQjQ6Njk5MENERjQiLCJ2aXNpdG9yX2lkIjoiNjc4NzEwNTU2MTQyMDgxMTc2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac71fa988895460f3f0b6644ce5248d83ae5e69c7dd791c05862880d15b9bca4bf
hovercard-subject-tagpull_request:227409783
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24004/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c0b7261313193f566b9a030f2860cca325ba952477d4cd2cb26c8af627c7f03d/nodejs/node/pull/24004
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c0b7261313193f566b9a030f2860cca325ba952477d4cd2cb26c8af627c7f03d/nodejs/node/pull/24004
og:image:altRecent libtool on macOS does not support the --coverage flag that was being passed through in the final linking stage. This change patches gyp-mac-tool to not pass the --coverage flag through to li...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameevanlucas
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/24004#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24004
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24004
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/24004
Reloadhttps://github.com/nodejs/node/pull/24004
Reloadhttps://github.com/nodejs/node/pull/24004
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/24004
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
evanlucashttps://github.com/evanlucas
nodejs:masterhttps://github.com/nodejs/node/tree/master
evanlucas:fixmaccppcoveragehttps://github.com/evanlucas/node/tree/fixmaccppcoverage
Conversationhttps://github.com/nodejs/node/pull/24004
Commits1 (1)https://github.com/nodejs/node/pull/24004/commits
Checkshttps://github.com/nodejs/node/pull/24004/checks
Files changedhttps://github.com/nodejs/node/pull/24004/files
tools: fix c++ code coverage on macOShttps://github.com/nodejs/node/pull/24004#top
evanlucashttps://github.com/evanlucas
nodejs:masterhttps://github.com/nodejs/node/tree/master
evanlucas:fixmaccppcoveragehttps://github.com/evanlucas/node/tree/fixmaccppcoverage
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 31, 2018https://github.com/nodejs/node/pull/24004#issue-376119837
#19057https://github.com/nodejs/node/issues/19057
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/evanlucas
tools: fix c++ code coverage on macOShttps://github.com/nodejs/node/pull/24004/commits/bd692c4b1a8df76a4ffe18857b893ced26ca1000
bd692c4https://github.com/nodejs/node/pull/24004/commits/bd692c4b1a8df76a4ffe18857b893ced26ca1000
nodejs#19057https://github.com/nodejs/node/issues/19057
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 31, 2018https://github.com/nodejs/node/pull/24004#issuecomment-434812139
@evanlucashttps://github.com/evanlucas
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1444/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1444/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Oct 31, 2018https://github.com/nodejs/node/pull/24004#event-1938832072
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 31, 2018 https://github.com/nodejs/node/pull/24004#pullrequestreview-170431659
View reviewed changes https://github.com/nodejs/node/pull/24004/files/bd692c4b1a8df76a4ffe18857b893ced26ca1000
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 31, 2018https://github.com/nodejs/node/pull/24004#issuecomment-434819973
node/node.gypihttps://github.com/nodejs/node/blob/c515e5c604492b2e7171e8d859c77cba33063d40/node.gypi#L272-L291
c515e5chttps://github.com/nodejs/node/commit/c515e5c604492b2e7171e8d859c77cba33063d40
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 31, 2018https://github.com/nodejs/node/pull/24004#issuecomment-434823252
@richardlauhttps://github.com/richardlau
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2018 https://github.com/nodejs/node/pull/24004#pullrequestreview-170444149
View reviewed changes https://github.com/nodejs/node/pull/24004/files/bd692c4b1a8df76a4ffe18857b893ced26ca1000
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/24004#pullrequestreview-170444149
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2018 https://github.com/nodejs/node/pull/24004#pullrequestreview-170469922
View reviewed changes https://github.com/nodejs/node/pull/24004/files/bd692c4b1a8df76a4ffe18857b893ced26ca1000
tools/gyp/pylib/gyp/xcode_emulation.pyhttps://github.com/nodejs/node/pull/24004/files/bd692c4b1a8df76a4ffe18857b893ced26ca1000#diff-442988ab0350a1a08f5229ccd5d3f8cb99c924774b3897dafadba1e25d052d29
refackhttps://github.com/refack
Oct 31, 2018https://github.com/nodejs/node/pull/24004#discussion_r229865845
Please reload this pagehttps://github.com/nodejs/node/pull/24004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24004
refackhttps://github.com/refack
Oct 31, 2018https://github.com/nodejs/node/pull/24004#discussion_r229880107
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2018 https://github.com/nodejs/node/pull/24004#pullrequestreview-170470405
View reviewed changes https://github.com/nodejs/node/pull/24004/files/bd692c4b1a8df76a4ffe18857b893ced26ca1000
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/24004#pullrequestreview-170470405
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2018https://github.com/nodejs/node/pull/24004#issuecomment-434846141
@evanlucashttps://github.com/evanlucas
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Oct 31, 2018 https://github.com/nodejs/node/pull/24004#pullrequestreview-170476957
View reviewed changes https://github.com/nodejs/node/pull/24004/files/bd692c4b1a8df76a4ffe18857b893ced26ca1000
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2018 https://github.com/nodejs/node/pull/24004#pullrequestreview-170487542
View reviewed changes https://github.com/nodejs/node/pull/24004/files/bd692c4b1a8df76a4ffe18857b893ced26ca1000
tools/gyp/pylib/gyp/xcode_emulation.pyhttps://github.com/nodejs/node/pull/24004/files/bd692c4b1a8df76a4ffe18857b893ced26ca1000#diff-442988ab0350a1a08f5229ccd5d3f8cb99c924774b3897dafadba1e25d052d29
refackhttps://github.com/refack
Oct 31, 2018https://github.com/nodejs/node/pull/24004#discussion_r229880107
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2018https://github.com/nodejs/node/pull/24004#issuecomment-434860627
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/refack
refackhttps://github.com/refack
python https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython
Oct 31, 2018https://github.com/nodejs/node/pull/24004#event-1939169322
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2018https://github.com/nodejs/node/pull/24004#issuecomment-434884621
node/node.gypihttps://github.com/nodejs/node/blob/c515e5c604492b2e7171e8d859c77cba33063d40/node.gypi#L272-L291
c515e5chttps://github.com/nodejs/node/commit/c515e5c604492b2e7171e8d859c77cba33063d40
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Nov 3, 2018https://github.com/nodejs/node/pull/24004#issuecomment-435564722
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 4, 2018https://github.com/nodejs/node/pull/24004#issuecomment-435636969
@antsmartianhttps://github.com/antsmartian
@refackhttps://github.com/refack
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Nov 4, 2018https://github.com/nodejs/node/pull/24004#issuecomment-435637743
Please reload this pagehttps://github.com/nodejs/node/pull/24004
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/Trott
Trotthttps://github.com/Trott
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Nov 4, 2018https://github.com/nodejs/node/pull/24004#event-1944654062
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 4, 2018https://github.com/nodejs/node/pull/24004#issuecomment-435674780
@cjihrighttps://github.com/cjihrig
@evanlucashttps://github.com/evanlucas
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Nov 4, 2018https://github.com/nodejs/node/pull/24004#issuecomment-435697949
@antsmartianhttps://github.com/antsmartian
#23690https://github.com/nodejs/node/issues/23690
#23769https://github.com/nodejs/node/pull/23769
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 18, 2018https://github.com/nodejs/node/pull/24004#issuecomment-439667819
@evanlucashttps://github.com/evanlucas
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/refack
refackhttps://github.com/refack
Nov 20, 2018 https://github.com/nodejs/node/pull/24004#ref-pullrequest-382745095
build: fix c++ code coverage on macOS #24520 https://github.com/nodejs/node/pull/24520
https://github.com/refack
refackhttps://github.com/refack
Nov 20, 2018https://github.com/nodejs/node/pull/24004#issuecomment-440336857
#24520https://github.com/nodejs/node/pull/24520
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 1, 2018https://github.com/nodejs/node/pull/24004#issuecomment-443434077
#24520https://github.com/nodejs/node/pull/24520
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 1, 2018https://github.com/nodejs/node/pull/24004#event-1999550704
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24004
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/24004/files/bd692c4b1a8df76a4ffe18857b893ced26ca1000
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/24004/files/bd692c4b1a8df76a4ffe18857b893ced26ca1000
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/24004/files/bd692c4b1a8df76a4ffe18857b893ced26ca1000
https://github.com/ryzokuken
ryzokuken https://github.com/ryzokuken
https://github.com/nodejs/node/pull/24004/files/bd692c4b1a8df76a4ffe18857b893ced26ca1000
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
python https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/24004
https://github.com/evanlucas
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/refack
https://github.com/antsmartian
https://github.com/Trott
https://github.com/cjihrig
https://github.com/addaleax
https://github.com/mhdawson
https://github.com/ryzokuken
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.