René's URL Explorer Experiment


Title: deps,v8: cherry-pick dc704497 by refack · Pull Request #23985 · nodejs/node · GitHub

Open Graph Title: deps,v8: cherry-pick dc704497 by refack · Pull Request #23985 · nodejs/node

X Title: deps,v8: cherry-pick dc704497 by refack · Pull Request #23985 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refs: #19630 Refs: v8/v8@dc70449 Original commit message: undef min,max macros on windows This blocks building with official clang-cl and Windows SDK Refs: https://github.com/nodejs/node/is...

X Description: Refs: #19630 Refs: v8/v8@dc70449 Original commit message: undef min,max macros on windows This blocks building with official clang-cl and Windows SDK Refs: https://github.com/nodejs/node/is...

Opengraph URL: https://github.com/nodejs/node/pull/23985

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e036f7f3-593d-2a4d-cb63-e14b95658712
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDA6:C17B1:50999F:689C78:699048C6
html-safe-nonce6ff26a3d8d57d11716fb48518635166ad7a15d6f9be30f8c890f09441c978701
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREE2OkMxN0IxOjUwOTk5Rjo2ODlDNzg6Njk5MDQ4QzYiLCJ2aXNpdG9yX2lkIjoiMjM5MDc3MTEwMDM1MDA3Njg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac69d04933647ff0a5ffee05eed86a0dcb9a99f68e04d3e80a21b8897a8368be40
hovercard-subject-tagpull_request:227114505
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23985/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/321a05bc1fddc793bc33e01fb534484ce210a38eb300d2a22607ffafefe2b9cf/nodejs/node/pull/23985
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/321a05bc1fddc793bc33e01fb534484ce210a38eb300d2a22607ffafefe2b9cf/nodejs/node/pull/23985
og:image:altRefs: #19630 Refs: v8/v8@dc70449 Original commit message: undef min,max macros on windows This blocks building with official clang-cl and Windows SDK Refs: https://github.com/nodejs/node/is...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerefack
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23985#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23985
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23985
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23985
Reloadhttps://github.com/nodejs/node/pull/23985
Reloadhttps://github.com/nodejs/node/pull/23985
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23985
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 708 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:cherry-pick-v8-dc704497https://github.com/refack/node/tree/cherry-pick-v8-dc704497
Conversationhttps://github.com/nodejs/node/pull/23985
Commits1 (1)https://github.com/nodejs/node/pull/23985/commits
Checkshttps://github.com/nodejs/node/pull/23985/checks
Files changedhttps://github.com/nodejs/node/pull/23985/files
deps,v8: cherry-pick dc704497https://github.com/nodejs/node/pull/23985#top
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:cherry-pick-v8-dc704497https://github.com/refack/node/tree/cherry-pick-v8-dc704497
https://github.com/refack
refackhttps://github.com/refack
Oct 30, 2018https://github.com/nodejs/node/pull/23985#issue-375737733
Please reload this pagehttps://github.com/nodejs/node/pull/23985
#19630https://github.com/nodejs/node/issues/19630
v8/v8@dc70449https://github.com/v8/v8/commit/dc704497ee84245931533c3575dd250d4b498300
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23985
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 30, 2018https://github.com/nodejs/node/pull/23985#issuecomment-434508523
@refackhttps://github.com/refack
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1430/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1430/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23985
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Oct 30, 2018https://github.com/nodejs/node/pull/23985#event-1936566279
https://github.com/refack
refackhttps://github.com/refack
targoshttps://github.com/targos
October 30, 2018 23:31https://github.com/nodejs/node/pull/23985#event-1936566565
https://github.com/refack
refackhttps://github.com/refack
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Oct 30, 2018https://github.com/nodejs/node/pull/23985#event-1936566910
https://github.com/refack
refackhttps://github.com/refack
bzozhttps://github.com/bzoz
joaocgreishttps://github.com/joaocgreis
joyeecheunghttps://github.com/joyeecheung
seishunhttps://github.com/seishun
October 30, 2018 23:32https://github.com/nodejs/node/pull/23985#event-1936567441
https://github.com/refack
refackhttps://github.com/refack
Oct 30, 2018https://github.com/nodejs/node/pull/23985#event-1936567512
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 31, 2018https://github.com/nodejs/node/pull/23985#issuecomment-434517378
node/common.gypihttps://github.com/nodejs/node/blob/6f4721b7335f7f849c04af8c1158067eaf4ddae3/common.gypi#L36
6f4721bhttps://github.com/nodejs/node/commit/6f4721b7335f7f849c04af8c1158067eaf4ddae3
node/node.gypihttps://github.com/nodejs/node/blob/bf7ed80475cfa7ae1ab6086c325f57557b75dffe/node.gypi#L61
bf7ed80https://github.com/nodejs/node/commit/bf7ed80475cfa7ae1ab6086c325f57557b75dffe
Please reload this pagehttps://github.com/nodejs/node/pull/23985
https://github.com/refack
refackhttps://github.com/refack
force-pushedhttps://github.com/nodejs/node/compare/a52211212bfb29bc5c4bdf736bba004296087970..46ddcf1cf0deae6046075ba870942e05ae2034a2
a522112https://github.com/nodejs/node/commit/a52211212bfb29bc5c4bdf736bba004296087970
46ddcf1https://github.com/nodejs/node/commit/46ddcf1cf0deae6046075ba870942e05ae2034a2
Compare https://github.com/nodejs/node/compare/a52211212bfb29bc5c4bdf736bba004296087970..46ddcf1cf0deae6046075ba870942e05ae2034a2
October 31, 2018 00:59https://github.com/nodejs/node/pull/23985#event-1936668240
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2018https://github.com/nodejs/node/pull/23985#issuecomment-434524191
node/node.gypihttps://github.com/nodejs/node/blob/bf7ed80475cfa7ae1ab6086c325f57557b75dffe/node.gypi#L61
bf7ed80https://github.com/nodejs/node/commit/bf7ed80475cfa7ae1ab6086c325f57557b75dffe
https://github.com/nodejs/node/blob/46ddcf1cf0deae6046075ba870942e05ae2034a2/common.gypi#L36https://github.com/nodejs/node/blob/46ddcf1cf0deae6046075ba870942e05ae2034a2/common.gypi#L36
Please reload this pagehttps://github.com/nodejs/node/pull/23985
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 31, 2018 https://github.com/nodejs/node/pull/23985#pullrequestreview-170060043
View reviewed changes https://github.com/nodejs/node/pull/23985/files
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 31, 2018https://github.com/nodejs/node/pull/23985#issuecomment-434583018
Please reload this pagehttps://github.com/nodejs/node/pull/23985
Please reload this pagehttps://github.com/nodejs/node/pull/23985
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 31, 2018 https://github.com/nodejs/node/pull/23985#pullrequestreview-170178433
View reviewed changes https://github.com/nodejs/node/pull/23985/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 31, 2018 https://github.com/nodejs/node/pull/23985#pullrequestreview-170204960
View reviewed changes https://github.com/nodejs/node/pull/23985/files
https://github.com/refack
refackhttps://github.com/refack
Nov 2, 2018https://github.com/nodejs/node/pull/23985#issuecomment-435490312
Please reload this pagehttps://github.com/nodejs/node/pull/23985
https://ci.nodejs.org/job/node-test-pull-request/18307/https://ci.nodejs.org/job/node-test-pull-request/18307/
https://ci.nodejs.org/job/node-test-commit-v8-linux/1809/https://ci.nodejs.org/job/node-test-commit-v8-linux/1809/
Please reload this pagehttps://github.com/nodejs/node/pull/23985
https://github.com/refack
deps,v8: cherry-pick dc704497https://github.com/nodejs/node/pull/23985/commits/d24756bf790c4d00fffe2366defa910b5ef760c3
d24756bhttps://github.com/nodejs/node/pull/23985/commits/d24756bf790c4d00fffe2366defa910b5ef760c3
nodejs#19630https://github.com/nodejs/node/issues/19630
https://chromium-review.googlesource.com/c/1297479https://chromium-review.googlesource.com/c/1297479
nodejs#57053https://github.com/nodejs/node/pull/57053
nodejs#23985https://github.com/nodejs/node/pull/23985
v8/v8@dc70449https://github.com/v8/v8/commit/dc704497ee84245931533c3575dd250d4b498300
https://github.com/refack
refackhttps://github.com/refack
force-pushedhttps://github.com/nodejs/node/compare/46ddcf1cf0deae6046075ba870942e05ae2034a2..d24756bf790c4d00fffe2366defa910b5ef760c3
46ddcf1https://github.com/nodejs/node/commit/46ddcf1cf0deae6046075ba870942e05ae2034a2
d24756bhttps://github.com/nodejs/node/commit/d24756bf790c4d00fffe2366defa910b5ef760c3
Compare https://github.com/nodejs/node/compare/46ddcf1cf0deae6046075ba870942e05ae2034a2..d24756bf790c4d00fffe2366defa910b5ef760c3
November 3, 2018 00:31https://github.com/nodejs/node/pull/23985#event-1944152558
https://github.com/refack
refackhttps://github.com/refack
d24756bhttps://github.com/nodejs/node/commit/d24756bf790c4d00fffe2366defa910b5ef760c3
Nov 3, 2018https://github.com/nodejs/node/pull/23985#event-1944153603
targoshttps://github.com/targos
Nov 3, 2018 https://github.com/nodejs/node/pull/23985#ref-commit-6e4f238
https://github.com/refack
https://github.com/targos
deps,v8: cherry-pick dc704497https://github.com/nodejs/node/commit/6e4f23834400b42c0579bf840800003f61f54d19
6e4f238https://github.com/nodejs/node/commit/6e4f23834400b42c0579bf840800003f61f54d19
#19630https://github.com/nodejs/node/issues/19630
https://chromium-review.googlesource.com/c/1297479https://chromium-review.googlesource.com/c/1297479
#57053https://github.com/nodejs/node/pull/57053
#23985https://github.com/nodejs/node/pull/23985
v8/v8@dc70449https://github.com/v8/v8/commit/dc704497ee84245931533c3575dd250d4b498300
https://github.com/refack
refackhttps://github.com/refack
November 3, 2018 17:30https://github.com/nodejs/node/pull/23985#event-1944474207
https://github.com/refack
refackhttps://github.com/refack
Nov 6, 2018https://github.com/nodejs/node/pull/23985#event-1950356030
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/23985#ref-pullrequest-380492752
Release proposal: v11.2 #24350 https://github.com/nodejs/node/pull/24350
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232 https://github.com/beevelop/docker-nodejs/issues/232
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249 https://github.com/beevelop/docker-android-nodejs/issues/249
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233 https://github.com/beevelop/docker-nodejs/issues/233
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234 https://github.com/beevelop/docker-nodejs/issues/234
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235 https://github.com/beevelop/docker-nodejs/issues/235
https://github.com/beevelop
beevelophttps://github.com/beevelop
Nov 16, 2018 https://github.com/nodejs/node/pull/23985#ref-issue-381456370
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236 https://github.com/beevelop/docker-nodejs/issues/236
https://github.com/codebytere
codebyterehttps://github.com/codebytere
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Nov 29, 2018https://github.com/nodejs/node/pull/23985#event-1994021352
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23985
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/23985/files/46ddcf1cf0deae6046075ba870942e05ae2034a2
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23985/files/46ddcf1cf0deae6046075ba870942e05ae2034a2
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/23985/files/46ddcf1cf0deae6046075ba870942e05ae2034a2
https://github.com/targos
targos https://github.com/targos
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/bzoz
bzoz https://github.com/bzoz
https://github.com/joaocgreis
joaocgreis https://github.com/joaocgreis
https://github.com/seishun
seishun https://github.com/seishun
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Please reload this pagehttps://github.com/nodejs/node/pull/23985
https://github.com/refack
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/bnoordhuis
https://github.com/cjihrig
https://github.com/codebytere
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.