René's URL Explorer Experiment


Title: repl: use promise#finally by starkwang · Pull Request #23971 · nodejs/node · GitHub

Open Graph Title: repl: use promise#finally by starkwang · Pull Request #23971 · nodejs/node

X Title: repl: use promise#finally by starkwang · Pull Request #23971 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/23971

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:aacb5cfb-a4b8-c737-fbbf-767f660ad108
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D56:1BECDB:3EF18:4F9C9:6990A3E7
html-safe-nonce4dfb26a4a91841ec6d3f0788d59bb899ae13e3e1216b5a70af5009e19d522ea0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDU2OjFCRUNEQjozRUYxODo0RjlDOTo2OTkwQTNFNyIsInZpc2l0b3JfaWQiOiI0ODQ1MjQ4MjIyOTUwNjMwMzc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac74353e6db3603961b073d63853be7f8e0b8a848af45db4b266fdd688ff5fa1ce
hovercard-subject-tagpull_request:226831802
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23971/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b4aeef813e4b00d17ca06af4fb7c7293c3bffc061db7f5b367370305018a5264/nodejs/node/pull/23971
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b4aeef813e4b00d17ca06af4fb7c7293c3bffc061db7f5b367370305018a5264/nodejs/node/pull/23971
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamestarkwang
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23971#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23971
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23971
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23971
Reloadhttps://github.com/nodejs/node/pull/23971
Reloadhttps://github.com/nodejs/node/pull/23971
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23971
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
starkwanghttps://github.com/starkwang
nodejs:masterhttps://github.com/nodejs/node/tree/master
starkwang:repl-promise-finallyhttps://github.com/starkwang/node/tree/repl-promise-finally
Conversationhttps://github.com/nodejs/node/pull/23971
Commits1 (1)https://github.com/nodejs/node/pull/23971/commits
Checkshttps://github.com/nodejs/node/pull/23971/checks
Files changedhttps://github.com/nodejs/node/pull/23971/files
repl: use promise#finallyhttps://github.com/nodejs/node/pull/23971#top
starkwanghttps://github.com/starkwang
nodejs:masterhttps://github.com/nodejs/node/tree/master
starkwang:repl-promise-finallyhttps://github.com/starkwang/node/tree/repl-promise-finally
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Oct 30, 2018https://github.com/nodejs/node/pull/23971#issue-375373524
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23971
https://github.com/starkwang
repl: use promise#finallyhttps://github.com/nodejs/node/pull/23971/commits/2a27af6b77cb72c20bd3490fd31a7a8e2092729e
2a27af6https://github.com/nodejs/node/pull/23971/commits/2a27af6b77cb72c20bd3490fd31a7a8e2092729e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 30, 2018https://github.com/nodejs/node/pull/23971#issuecomment-434213992
@starkwanghttps://github.com/starkwang
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1418/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1418/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23971
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
Oct 30, 2018https://github.com/nodejs/node/pull/23971#event-1934358276
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Oct 30, 2018https://github.com/nodejs/node/pull/23971#issuecomment-434231270
https://ci.nodejs.org/job/node-test-pull-request/18226/https://ci.nodejs.org/job/node-test-pull-request/18226/
Please reload this pagehttps://github.com/nodejs/node/pull/23971
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2018 https://github.com/nodejs/node/pull/23971#pullrequestreview-169789122
View reviewed changes https://github.com/nodejs/node/pull/23971/files/2a27af6b77cb72c20bd3490fd31a7a8e2092729e
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 30, 2018 https://github.com/nodejs/node/pull/23971#pullrequestreview-169997800
View reviewed changes https://github.com/nodejs/node/pull/23971/files/2a27af6b77cb72c20bd3490fd31a7a8e2092729e
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 31, 2018 https://github.com/nodejs/node/pull/23971#pullrequestreview-170130232
View reviewed changes https://github.com/nodejs/node/pull/23971/files/2a27af6b77cb72c20bd3490fd31a7a8e2092729e
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 4, 2018https://github.com/nodejs/node/pull/23971#issuecomment-435637289
c1e6703https://github.com/nodejs/node/commit/c1e670338ba105faaf6df3e8ab7086bede04ad6f
Please reload this pagehttps://github.com/nodejs/node/pull/23971
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 4, 2018https://github.com/nodejs/node/pull/23971#event-1944644362
Trotthttps://github.com/Trott
Nov 4, 2018 https://github.com/nodejs/node/pull/23971#ref-commit-c1e6703
https://github.com/starkwang
https://github.com/Trott
repl: use promise#finallyhttps://github.com/Trott/io.js/commit/c1e670338ba105faaf6df3e8ab7086bede04ad6f
c1e6703https://github.com/Trott/io.js/commit/c1e670338ba105faaf6df3e8ab7086bede04ad6f
nodejs#23971https://github.com/nodejs/node/pull/23971
targoshttps://github.com/targos
Nov 5, 2018 https://github.com/nodejs/node/pull/23971#ref-commit-e27f432
https://github.com/starkwang
https://github.com/targos
repl: use promise#finallyhttps://github.com/nodejs/node/commit/e27f43201c02dc73074bb6c1c5cf7e9ef57e8374
e27f432https://github.com/nodejs/node/commit/e27f43201c02dc73074bb6c1c5cf7e9ef57e8374
#23971https://github.com/nodejs/node/pull/23971
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/23971#ref-pullrequest-380492752
Release proposal: v11.2 #24350 https://github.com/nodejs/node/pull/24350
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232 https://github.com/beevelop/docker-nodejs/issues/232
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249 https://github.com/beevelop/docker-android-nodejs/issues/249
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233 https://github.com/beevelop/docker-nodejs/issues/233
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234 https://github.com/beevelop/docker-nodejs/issues/234
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235 https://github.com/beevelop/docker-nodejs/issues/235
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236 https://github.com/beevelop/docker-nodejs/issues/236
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23971#ref-commit-cdf4112
https://github.com/starkwang
https://github.com/codebytere
repl: use promise#finallyhttps://github.com/nodejs/node/commit/cdf41120486e04e5d0ce1546dd1b90e4e962c089
cdf4112https://github.com/nodejs/node/commit/cdf41120486e04e5d0ce1546dd1b90e4e962c089
#23971https://github.com/nodejs/node/pull/23971
https://github.com/codebytere
codebyterehttps://github.com/codebytere
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Nov 29, 2018https://github.com/nodejs/node/pull/23971#event-1994152220
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23971#ref-commit-e5177e9
https://github.com/starkwang
https://github.com/MylesBorins
repl: use promise#finallyhttps://github.com/nodejs/node/commit/e5177e9f3209eb0f2e35afed818dc1d9930aedbb
e5177e9https://github.com/nodejs/node/commit/e5177e9f3209eb0f2e35afed818dc1d9930aedbb
#23971https://github.com/nodejs/node/pull/23971
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23971#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
MylesBorinshttps://github.com/MylesBorins
Dec 3, 2018 https://github.com/nodejs/node/pull/23971#ref-commit-f866a0b
https://github.com/starkwang
https://github.com/MylesBorins
repl: use promise#finallyhttps://github.com/nodejs/node/commit/f866a0bcb9a7a8530a1249055afb195d72b196e3
f866a0bhttps://github.com/nodejs/node/commit/f866a0bcb9a7a8530a1249055afb195d72b196e3
#23971https://github.com/nodejs/node/pull/23971
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23971
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23971/files/2a27af6b77cb72c20bd3490fd31a7a8e2092729e
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/23971/files/2a27af6b77cb72c20bd3490fd31a7a8e2092729e
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/23971/files/2a27af6b77cb72c20bd3490fd31a7a8e2092729e
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
Please reload this pagehttps://github.com/nodejs/node/pull/23971
https://github.com/starkwang
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/lpinca
https://github.com/trivikr
https://github.com/codebytere
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.