| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:86932f00-7c2b-adbf-0a29-ff628a003a29 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B2FA:EB011:739821:940287:69907920 |
| html-safe-nonce | e899a1bc14d711e5ec07128b1463d322de8f2766d3551d4087bf5558a8e2b203 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkZBOkVCMDExOjczOTgyMTo5NDAyODc6Njk5MDc5MjAiLCJ2aXNpdG9yX2lkIjoiNzU5ODYzNTAxMDYxNTE3OTU1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 602bc7cd2635d9467913542902da9a3833cb643250d57d123869384c869698e2 |
| hovercard-subject-tag | pull_request:226618192 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23958/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/77c1936b58c976a0599b9b02710e37c7957a4f3edab28a79e0d78a1ec4442f1c/nodejs/node/pull/23958 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/77c1936b58c976a0599b9b02710e37c7957a4f3edab28a79e0d78a1ec4442f1c/nodejs/node/pull/23958 |
| og:image:alt | Back-port v8 changes for ppc64, Aix platform
Changes included:
ppc64, aix: Pass CallFrequency object by const reference to avoid value copy error.
Bug: v8:8193
GCC bug: https://gcc.gnu.org/bugzilla... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | V-for-Vasili |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23958#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23958 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23958 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23958 |
| Reload | https://github.com/nodejs/node/pull/23958 |
| Reload | https://github.com/nodejs/node/pull/23958 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
706
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| V-for-Vasili | https://github.com/V-for-Vasili |
| nodejs:v8.x-staging | https://github.com/nodejs/node/tree/v8.x-staging |
| V-for-Vasili:Node-8-backport-cherry-pick-final | https://github.com/V-for-Vasili/node/tree/Node-8-backport-cherry-pick-final |
| Conversation | https://github.com/nodejs/node/pull/23958 |
| Commits3 (3) | https://github.com/nodejs/node/pull/23958/commits |
| Checks | https://github.com/nodejs/node/pull/23958/checks |
| Files changed | https://github.com/nodejs/node/pull/23958/files |
| Back-port deps/v8 changes for ppc64, Aix platform (Node 8 backport) | https://github.com/nodejs/node/pull/23958#top |
| V-for-Vasili | https://github.com/V-for-Vasili |
| nodejs:v8.x-staging | https://github.com/nodejs/node/tree/v8.x-staging |
| V-for-Vasili:Node-8-backport-cherry-pick-final | https://github.com/V-for-Vasili/node/tree/Node-8-backport-cherry-pick-final |
|
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/23958#issue-375090747 |
| v8:8193 | https://bugs.chromium.org/p/v8/issues/detail?id=8193 |
| https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 | https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 |
| https://chromium-review.googlesource.com/c/v8/v8/+/1228633 | https://chromium-review.googlesource.com/c/v8/v8/+/1228633 |
| https://chromium-review.googlesource.com/c/v8/v8/+/927484 | https://chromium-review.googlesource.com/c/v8/v8/+/927484 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
|
v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/23958#event-1932685698 |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-433968574 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| @mhdawson | https://github.com/mhdawson |
| @refack | https://github.com/refack |
| #23718 | https://github.com/nodejs/node/pull/23718 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
|
Oct 29, 2018
| https://github.com/nodejs/node/pull/23958#ref-pullrequest-371211862 |
|
Back-port v8 changes for ppc64, Aix platform (Node 8 backport)
#23718
| https://github.com/nodejs/node/pull/23718 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-433995486 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| force-pushed | https://github.com/nodejs/node/compare/ae200cca48fe9fb237d30c9c6a46d758d3902dd2..615d0aed700c513e8a6725550299cf1ad9ac9227 |
| ae200cc | https://github.com/nodejs/node/commit/ae200cca48fe9fb237d30c9c6a46d758d3902dd2 |
| 615d0ae | https://github.com/nodejs/node/commit/615d0aed700c513e8a6725550299cf1ad9ac9227 |
|
Compare
| https://github.com/nodejs/node/compare/ae200cca48fe9fb237d30c9c6a46d758d3902dd2..615d0aed700c513e8a6725550299cf1ad9ac9227 |
| October 29, 2018 17:31 | https://github.com/nodejs/node/pull/23958#event-1932937942 |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434004739 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434007344 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| @V-for-Vasili | https://github.com/V-for-Vasili |
| the guide | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Oct 29, 2018
| https://github.com/nodejs/node/pull/23958#pullrequestreview-169431972 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23958/files |
| refack | https://github.com/refack |
| https://github.com/nodejs/node/pull/23958#pullrequestreview-169431972 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| force-pushed | https://github.com/nodejs/node/compare/615d0aed700c513e8a6725550299cf1ad9ac9227..e402a7545792a024eb868e0321e9a01a791f32d9 |
| 615d0ae | https://github.com/nodejs/node/commit/615d0aed700c513e8a6725550299cf1ad9ac9227 |
| e402a75 | https://github.com/nodejs/node/commit/e402a7545792a024eb868e0321e9a01a791f32d9 |
|
Compare
| https://github.com/nodejs/node/compare/615d0aed700c513e8a6725550299cf1ad9ac9227..e402a7545792a024eb868e0321e9a01a791f32d9 |
| October 29, 2018 18:06 | https://github.com/nodejs/node/pull/23958#event-1933032205 |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434018473 |
| @refack | https://github.com/refack |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434248549 |
| @V-for-Vasili | https://github.com/V-for-Vasili |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434350780 |
| @V-for-Vasili | https://github.com/V-for-Vasili |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434445117 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| force-pushed | https://github.com/nodejs/node/compare/e402a7545792a024eb868e0321e9a01a791f32d9..51304c2ab8f8aae7b994b275f5a9b2ddf0133d3c |
| e402a75 | https://github.com/nodejs/node/commit/e402a7545792a024eb868e0321e9a01a791f32d9 |
| 51304c2 | https://github.com/nodejs/node/commit/51304c2ab8f8aae7b994b275f5a9b2ddf0133d3c |
|
Compare
| https://github.com/nodejs/node/compare/e402a7545792a024eb868e0321e9a01a791f32d9..51304c2ab8f8aae7b994b275f5a9b2ddf0133d3c |
| October 30, 2018 21:01 | https://github.com/nodejs/node/pull/23958#event-1936291292 |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434469413 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/06b8e7d984546eb7e7afbb49c2cee0a54201a4a5..9260e0e616de0eaa47f044950deaffe1667cb82e |
| 06b8e7d | https://github.com/nodejs/node/commit/06b8e7d984546eb7e7afbb49c2cee0a54201a4a5 |
| 9260e0e | https://github.com/nodejs/node/commit/9260e0e616de0eaa47f044950deaffe1667cb82e |
|
Compare
| https://github.com/nodejs/node/compare/06b8e7d984546eb7e7afbb49c2cee0a54201a4a5..9260e0e616de0eaa47f044950deaffe1667cb82e |
| October 30, 2018 21:55 | https://github.com/nodejs/node/pull/23958#event-1936405637 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434484830 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| @V-for-Vasili | https://github.com/V-for-Vasili |
| https://ci.nodejs.org/job/node-test-pull-request/18242/ | https://ci.nodejs.org/job/node-test-pull-request/18242/ |
| https://ci.nodejs.org/job/node-test-pull-request/18244/ | https://ci.nodejs.org/job/node-test-pull-request/18244/ |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434485377 |
| https://help.github.com/articles/setting-your-commit-email-address-on-github/ | https://help.github.com/articles/setting-your-commit-email-address-on-github/ |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 31, 2018 | https://github.com/nodejs/node/pull/23958#event-1936741618 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x |
| Oct 31, 2018 | https://github.com/nodejs/node/pull/23958#event-1936741731 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 31, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434536281 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x |
| Oct 31, 2018 | https://github.com/nodejs/node/pull/23958#event-1936742516 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 31, 2018 | https://github.com/nodejs/node/pull/23958#event-1936743033 |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| Oct 31, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434693043 |
| @refack | https://github.com/refack |
| #23695 | https://github.com/nodejs/node/pull/23695 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 31, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434720718 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Oct 31, 2018
| https://github.com/nodejs/node/pull/23958#pullrequestreview-170430623 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23958/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/23958#pullrequestreview-170430623 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Oct 31, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434816115 |
| @BethGriggs | https://github.com/BethGriggs |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Oct 31, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434821660 |
| @MylesBorins | https://github.com/MylesBorins |
| #23958 (comment) | https://github.com/nodejs/node/pull/23958#issuecomment-434350780 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 31, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-434831106 |
| @mhdawson | https://github.com/mhdawson |
| @hashseed | https://github.com/hashseed |
| @fhinkel | https://github.com/fhinkel |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Nov 12, 2018
| https://github.com/nodejs/node/pull/23958#ref-pullrequest-375564151 |
|
v8.13.0 proposal
#23974
| https://github.com/nodejs/node/pull/23974 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Nov 15, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-439111177 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=ppcle-ubuntu1404,v8test=v8test/1846/console | https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=ppcle-ubuntu1404,v8test=v8test/1846/console |
| #23974 (comment) | https://github.com/nodejs/node/pull/23974#issuecomment-439093639 |
| https://ci.nodejs.org/job/node-test-pull-request/18651 | https://ci.nodejs.org/job/node-test-pull-request/18651 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Nov 15, 2018 | https://github.com/nodejs/node/pull/23958#event-1969202255 |
| https://github.com/gdams |
| gdams | https://github.com/gdams |
|
Nov 15, 2018
| https://github.com/nodejs/node/pull/23958#pullrequestreview-175479470 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23958/files |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| force-pushed | https://github.com/nodejs/node/compare/d95ed59b35d52aede66acb656acd2b160f7f4666..393346598ca9dcd240220548631549cb7f27f5b6 |
| d95ed59 | https://github.com/nodejs/node/commit/d95ed59b35d52aede66acb656acd2b160f7f4666 |
| 3933465 | https://github.com/nodejs/node/commit/393346598ca9dcd240220548631549cb7f27f5b6 |
|
Compare
| https://github.com/nodejs/node/compare/d95ed59b35d52aede66acb656acd2b160f7f4666..393346598ca9dcd240220548631549cb7f27f5b6 |
| November 19, 2018 21:40 | https://github.com/nodejs/node/pull/23958#event-1975819329 |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-440052515 |
| @BethGriggs | https://github.com/BethGriggs |
| @MylesBorins | https://github.com/MylesBorins |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-440054431 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1886/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1886/ |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/V-for-Vasili |
| V-for-Vasili | https://github.com/V-for-Vasili |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-440375213 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-440382405 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 20, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-440416221 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| @V-for-Vasili | https://github.com/V-for-Vasili |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 21, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-440727635 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://ci.nodejs.org/job/node-test-pull-request/18849/ | https://ci.nodejs.org/job/node-test-pull-request/18849/ |
| https://ci.nodejs.org/job/node-test-pull-request/18850/ | https://ci.nodejs.org/job/node-test-pull-request/18850/ |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| November 21, 2018 11:31 | https://github.com/nodejs/node/pull/23958#commits-pushed-1d958e0 |
|
| https://github.com/MylesBorins |
| deps: cherry-pick | https://github.com/nodejs/node/pull/23958/commits/1d958e08a524af80f86a25424a7076a782ef9af9 |
| 6bc4bfe | https://github.com/V-for-Vasili/node/commit/6bc4bfeb07e894ea39449c1ad447f283a251b4b8 |
| from V8 upstream (Only changes to src/base/… | https://github.com/nodejs/node/pull/23958/commits/1d958e08a524af80f86a25424a7076a782ef9af9 |
| 1d958e0 | https://github.com/nodejs/node/pull/23958/commits/1d958e08a524af80f86a25424a7076a782ef9af9 |
| https://chromium-review.googlesource.com/927484 | https://chromium-review.googlesource.com/927484 |
| nodejs#52071 | https://github.com/nodejs/node/pull/52071 |
|
| https://github.com/MylesBorins |
| deps: cherry-pick d2e0166 from V8 upstream | https://github.com/nodejs/node/pull/23958/commits/b2d6e7658f506fcc146084cb812df92b6bb6f707 |
| b2d6e76 | https://github.com/nodejs/node/pull/23958/commits/b2d6e7658f506fcc146084cb812df92b6bb6f707 |
| https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 | https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 |
| https://chromium-review.googlesource.com/1228633 | https://chromium-review.googlesource.com/1228633 |
| nodejs#56275 | https://github.com/nodejs/node/pull/56275 |
|
| https://github.com/MylesBorins |
| deps,v8: fix gyp build on Aix platform | https://github.com/nodejs/node/pull/23958/commits/96dbfb0932405948bf4e49a86ee02fa5b113fd87 |
| 96dbfb0 | https://github.com/nodejs/node/pull/23958/commits/96dbfb0932405948bf4e49a86ee02fa5b113fd87 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/393346598ca9dcd240220548631549cb7f27f5b6..96dbfb0932405948bf4e49a86ee02fa5b113fd87 |
| 3933465 | https://github.com/nodejs/node/commit/393346598ca9dcd240220548631549cb7f27f5b6 |
| 96dbfb0 | https://github.com/nodejs/node/commit/96dbfb0932405948bf4e49a86ee02fa5b113fd87 |
|
Compare
| https://github.com/nodejs/node/compare/393346598ca9dcd240220548631549cb7f27f5b6..96dbfb0932405948bf4e49a86ee02fa5b113fd87 |
| November 21, 2018 16:33 | https://github.com/nodejs/node/pull/23958#event-1980547722 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 21, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-440769170 |
| https://ci.nodejs.org/job/node-test-pull-request/18850/ | https://ci.nodejs.org/job/node-test-pull-request/18850/ |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2018
| https://github.com/nodejs/node/pull/23958#ref-commit-b3084f0 |
|
| https://github.com/MylesBorins |
| deps: cherry-pick | https://github.com/nodejs/node/commit/b3084f067600e558ef739b619fd440d7b99c1cd2 |
| 6bc4bfe | https://github.com/nodejs/node/commit/6bc4bfeb07e894ea39449c1ad447f283a251b4b8 |
| from V8 upstream | https://github.com/nodejs/node/commit/b3084f067600e558ef739b619fd440d7b99c1cd2 |
| b3084f0 | https://github.com/nodejs/node/commit/b3084f067600e558ef739b619fd440d7b99c1cd2 |
| https://chromium-review.googlesource.com/927484 | https://chromium-review.googlesource.com/927484 |
| #52071 | https://github.com/nodejs/node/pull/52071 |
| #23958 | https://github.com/nodejs/node/pull/23958 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2018
| https://github.com/nodejs/node/pull/23958#ref-commit-d21aff1 |
|
| https://github.com/MylesBorins |
| deps: cherry-pick d2e0166 from V8 upstream | https://github.com/nodejs/node/commit/d21aff1dd4409c80ed0b5b7d351e4bc3f5703832 |
| d21aff1 | https://github.com/nodejs/node/commit/d21aff1dd4409c80ed0b5b7d351e4bc3f5703832 |
| v8:8193 | https://bugs.chromium.org/p/v8/issues/detail?id=8193 |
| https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 | https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 |
| https://chromium-review.googlesource.com/1228633 | https://chromium-review.googlesource.com/1228633 |
| #56275 | https://github.com/nodejs/node/pull/56275 |
| #23958 | https://github.com/nodejs/node/pull/23958 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2018
| https://github.com/nodejs/node/pull/23958#ref-commit-4d00e1c |
|
| https://github.com/MylesBorins |
| deps,v8: fix gyp build on Aix platform | https://github.com/nodejs/node/commit/4d00e1c9536c40ab1b9b369647c7ee2383fd9c21 |
| 4d00e1c | https://github.com/nodejs/node/commit/4d00e1c9536c40ab1b9b369647c7ee2383fd9c21 |
| #23958 | https://github.com/nodejs/node/pull/23958 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/23958#issuecomment-440911249 |
| ebe617e...4d00e1c | https://github.com/nodejs/node/compare/ebe617e239c0f6dd51c8130b2612ce862d80ce8f...4d00e1c9536c40ab1b9b369647c7ee2383fd9c21 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 22, 2018 | https://github.com/nodejs/node/pull/23958#event-1981598283 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23958#ref-commit-9bedae5 |
|
| https://github.com/rvagg |
| deps: cherry-pick | https://github.com/nodejs/node/commit/9bedae52667d91e59a2d63d27a4211bf25890e29 |
| 6bc4bfe | https://github.com/nodejs/node/commit/6bc4bfeb07e894ea39449c1ad447f283a251b4b8 |
| from V8 upstream | https://github.com/nodejs/node/commit/9bedae52667d91e59a2d63d27a4211bf25890e29 |
| 9bedae5 | https://github.com/nodejs/node/commit/9bedae52667d91e59a2d63d27a4211bf25890e29 |
| https://chromium-review.googlesource.com/927484 | https://chromium-review.googlesource.com/927484 |
| #52071 | https://github.com/nodejs/node/pull/52071 |
| #23958 | https://github.com/nodejs/node/pull/23958 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23958#ref-commit-5034729 |
|
| https://github.com/rvagg |
| deps: cherry-pick d2e0166 from V8 upstream | https://github.com/nodejs/node/commit/50347297a106cd592c9638448eba611e09bb39e5 |
| 5034729 | https://github.com/nodejs/node/commit/50347297a106cd592c9638448eba611e09bb39e5 |
| v8:8193 | https://bugs.chromium.org/p/v8/issues/detail?id=8193 |
| https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 | https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 |
| https://chromium-review.googlesource.com/1228633 | https://chromium-review.googlesource.com/1228633 |
| #56275 | https://github.com/nodejs/node/pull/56275 |
| #23958 | https://github.com/nodejs/node/pull/23958 |
| rvagg | https://github.com/rvagg |
|
Nov 28, 2018
| https://github.com/nodejs/node/pull/23958#ref-commit-4f3c9e6 |
|
| https://github.com/rvagg |
| deps,v8: fix gyp build on Aix platform | https://github.com/nodejs/node/commit/4f3c9e6aab54ace23bda9266ffb6999f05ae2009 |
| 4f3c9e6 | https://github.com/nodejs/node/commit/4f3c9e6aab54ace23bda9266ffb6999f05ae2009 |
| #23958 | https://github.com/nodejs/node/pull/23958 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 4, 2018
| https://github.com/nodejs/node/pull/23958#ref-pullrequest-387422551 |
|
v8.14.1 proposal
#24832
| https://github.com/nodejs/node/pull/24832 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#267
| https://github.com/beevelop/docker-android-nodejs/issues/267 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#268
| https://github.com/beevelop/docker-android-nodejs/issues/268 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#269
| https://github.com/beevelop/docker-android-nodejs/issues/269 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#270
| https://github.com/beevelop/docker-android-nodejs/issues/270 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#271
| https://github.com/beevelop/docker-android-nodejs/issues/271 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23958 |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/23958/files/d95ed59b35d52aede66acb656acd2b160f7f4666 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/23958/files/9260e0e616de0eaa47f044950deaffe1667cb82e |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/23958/files/615d0aed700c513e8a6725550299cf1ad9ac9227 |
|
| https://github.com/gdams |
|
gdams
| https://github.com/gdams |
|
| https://github.com/nodejs/node/pull/23958/files/d95ed59b35d52aede66acb656acd2b160f7f4666 |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/23958 |
|
| https://github.com/V-for-Vasili |
|
| https://github.com/bnoordhuis |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
|
| https://github.com/mhdawson |
|
| https://github.com/BethGriggs |
|
| https://github.com/Trott |
|
| https://github.com/gdams |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |