René's URL Explorer Experiment


Title: buffer: throw exception when creating from non-Node.js Context by addaleax · Pull Request #23938 · nodejs/node · GitHub

Open Graph Title: buffer: throw exception when creating from non-Node.js Context by addaleax · Pull Request #23938 · nodejs/node

X Title: buffer: throw exception when creating from non-Node.js Context by addaleax · Pull Request #23938 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Throw an exception instead of crashing when attempting to create Buffer objects from a Context that is not associated with a Node.js Environment. Possible alternatives for the future might be just ...

X Description: Throw an exception instead of crashing when attempting to create Buffer objects from a Context that is not associated with a Node.js Environment. Possible alternatives for the future might be just ...

Opengraph URL: https://github.com/nodejs/node/pull/23938

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5f96351c-ede8-b06a-4435-be23d4363eb1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8912:1D0835:02EA:03E1:699028E0
html-safe-nonceeb4d084d281275e1ad478d802a9a9718b63a1c3440d4d028a2e16a3840ae10cd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTEyOjFEMDgzNTowMkVBOjAzRTE6Njk5MDI4RTAiLCJ2aXNpdG9yX2lkIjoiNTc2Mjk5ODkwNDkzNDExNTU1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0be918cb6be737cdd2cbc5cb58de3fe1c5860233c1c52b183284297b1fe11dab
hovercard-subject-tagpull_request:226373704
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23938/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/363954a2a7c7bb21c6d6cc6fa760cfb490ae514a58ca8bb2a7451ef7d0a03d35/nodejs/node/pull/23938
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/363954a2a7c7bb21c6d6cc6fa760cfb490ae514a58ca8bb2a7451ef7d0a03d35/nodejs/node/pull/23938
og:image:altThrow an exception instead of crashing when attempting to create Buffer objects from a Context that is not associated with a Node.js Environment. Possible alternatives for the future might be just ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23938#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23938
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23938
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23938
Reloadhttps://github.com/nodejs/node/pull/23938
Reloadhttps://github.com/nodejs/node/pull/23938
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23938
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:buffer-context-exceptionhttps://github.com/addaleax/node/tree/buffer-context-exception
Conversationhttps://github.com/nodejs/node/pull/23938
Commits1 (1)https://github.com/nodejs/node/pull/23938/commits
Checkshttps://github.com/nodejs/node/pull/23938/checks
Files changedhttps://github.com/nodejs/node/pull/23938/files
buffer: throw exception when creating from non-Node.js Contexthttps://github.com/nodejs/node/pull/23938#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:buffer-context-exceptionhttps://github.com/addaleax/node/tree/buffer-context-exception
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 28, 2018https://github.com/nodejs/node/pull/23938#issue-374763722
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23938
https://github.com/addaleax
buffer: throw exception when creating from non-Node.js Contexthttps://github.com/nodejs/node/pull/23938/commits/b7dd1c5574c368daf211902acd43879e0ca54b92
b7dd1c5https://github.com/nodejs/node/pull/23938/commits/b7dd1c5574c368daf211902acd43879e0ca54b92
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 28, 2018https://github.com/nodejs/node/pull/23938#issuecomment-433713969
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1398/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1398/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23938
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Oct 28, 2018https://github.com/nodejs/node/pull/23938#event-1930815405
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 28, 2018 https://github.com/nodejs/node/pull/23938#pullrequestreview-169106810
View reviewed changes https://github.com/nodejs/node/pull/23938/files/b7dd1c5574c368daf211902acd43879e0ca54b92
doc/api/errors.mdhttps://github.com/nodejs/node/pull/23938/files/b7dd1c5574c368daf211902acd43879e0ca54b92#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
Please reload this pagehttps://github.com/nodejs/node/pull/23938
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
Oct 28, 2018https://github.com/nodejs/node/pull/23938#event-1930938882
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 29, 2018 https://github.com/nodejs/node/pull/23938#pullrequestreview-169340565
View reviewed changes https://github.com/nodejs/node/pull/23938/files/b7dd1c5574c368daf211902acd43879e0ca54b92
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 31, 2018 https://github.com/nodejs/node/pull/23938#pullrequestreview-170088733
View reviewed changes https://github.com/nodejs/node/pull/23938/files/b7dd1c5574c368daf211902acd43879e0ca54b92
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 31, 2018https://github.com/nodejs/node/pull/23938#issuecomment-434556697
https://ci.nodejs.org/job/node-test-pull-request/18253/https://ci.nodejs.org/job/node-test-pull-request/18253/
Please reload this pagehttps://github.com/nodejs/node/pull/23938
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 4, 2018https://github.com/nodejs/node/pull/23938#event-1944693044
Trotthttps://github.com/Trott
Nov 4, 2018 https://github.com/nodejs/node/pull/23938#ref-commit-9c7d191
https://github.com/addaleax
https://github.com/Trott
buffer: throw exception when creating from non-Node.js Contexthttps://github.com/Trott/io.js/commit/9c7d19104d1f03f70658a6834a7d0baac7d38724
9c7d191https://github.com/Trott/io.js/commit/9c7d19104d1f03f70658a6834a7d0baac7d38724
nodejs#23938https://github.com/nodejs/node/pull/23938
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 4, 2018https://github.com/nodejs/node/pull/23938#issuecomment-435645926
9c7d191https://github.com/nodejs/node/commit/9c7d19104d1f03f70658a6834a7d0baac7d38724
@vsemozhetbythttps://github.com/vsemozhetbyt
Please reload this pagehttps://github.com/nodejs/node/pull/23938
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 4, 2018https://github.com/nodejs/node/pull/23938#event-1944693812
targoshttps://github.com/targos
Nov 5, 2018 https://github.com/nodejs/node/pull/23938#ref-commit-e4cd255
https://github.com/addaleax
https://github.com/targos
buffer: throw exception when creating from non-Node.js Contexthttps://github.com/nodejs/node/commit/e4cd255a8583fe1b4044673708e7ea0c88e82b4c
e4cd255https://github.com/nodejs/node/commit/e4cd255a8583fe1b4044673708e7ea0c88e82b4c
#23938https://github.com/nodejs/node/pull/23938
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 14, 2018 https://github.com/nodejs/node/pull/23938#ref-pullrequest-380492752
Release proposal: v11.2 #24350 https://github.com/nodejs/node/pull/24350
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232 https://github.com/beevelop/docker-nodejs/issues/232
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249 https://github.com/beevelop/docker-android-nodejs/issues/249
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233 https://github.com/beevelop/docker-nodejs/issues/233
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234 https://github.com/beevelop/docker-nodejs/issues/234
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235 https://github.com/beevelop/docker-nodejs/issues/235
2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236 https://github.com/beevelop/docker-nodejs/issues/236
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018https://github.com/nodejs/node/pull/23938#issuecomment-442699358
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/23938
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
November 29, 2018 16:50https://github.com/nodejs/node/pull/23938#event-1995803723
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 29, 2018https://github.com/nodejs/node/pull/23938#issuecomment-442908249
@codebyterehttps://github.com/codebytere
Please reload this pagehttps://github.com/nodejs/node/pull/23938
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018https://github.com/nodejs/node/pull/23938#issuecomment-442928300
Please reload this pagehttps://github.com/nodejs/node/pull/23938
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/23938
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 29, 2018https://github.com/nodejs/node/pull/23938#issuecomment-442928907
@codebyterehttps://github.com/codebytere
#23879https://github.com/nodejs/node/pull/23879
Please reload this pagehttps://github.com/nodejs/node/pull/23938
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018https://github.com/nodejs/node/pull/23938#issuecomment-442939296
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/23938
https://github.com/codebytere
codebyterehttps://github.com/codebytere
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jan 12, 2019https://github.com/nodejs/node/pull/23938#event-2069955945
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 17, 2019 https://github.com/nodejs/node/pull/23938#pullrequestreview-204577437
View reviewed changes https://github.com/nodejs/node/pull/23938/files/b7dd1c5574c368daf211902acd43879e0ca54b92
src/node_buffer.cchttps://github.com/nodejs/node/pull/23938/files/b7dd1c5574c368daf211902acd43879e0ca54b92#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
bnoordhuishttps://github.com/bnoordhuis
Feb 17, 2019https://github.com/nodejs/node/pull/23938#discussion_r257520504
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23938
addaleaxhttps://github.com/addaleax
Feb 17, 2019https://github.com/nodejs/node/pull/23938#discussion_r257520778
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/23938
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Feb 17, 2019https://github.com/nodejs/node/pull/23938#event-2144871733
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Feb 17, 2019https://github.com/nodejs/node/pull/23938#event-2144871734
deepak1556https://github.com/deepak1556
Jul 10, 2019 https://github.com/nodejs/node/pull/23938#ref-commit-7b35642
https://github.com/addaleax
https://github.com/deepak1556
buffer: throw exception when creating from non-Node.js Contexthttps://github.com/electron/node/commit/7b3564269c2fab1ced6bf8fdb01f35ea78897c8d
7b35642https://github.com/electron/node/commit/7b3564269c2fab1ced6bf8fdb01f35ea78897c8d
nodejs/node#23938https://github.com/nodejs/node/pull/23938
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23938
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/23938/files/b7dd1c5574c368daf211902acd43879e0ca54b92
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23938/files/b7dd1c5574c368daf211902acd43879e0ca54b92
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/23938/files/b7dd1c5574c368daf211902acd43879e0ca54b92
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/23938/files/b7dd1c5574c368daf211902acd43879e0ca54b92
https://github.com/Trott
Trott https://github.com/Trott
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
Please reload this pagehttps://github.com/nodejs/node/pull/23938
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/Trott
https://github.com/codebytere
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/vsemozhetbyt
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.