| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:290a21b0-92da-4364-a7c4-2143dea393f2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 89B4:68859:1E83462:2713C95:69900461 |
| html-safe-nonce | 6a7598b98ec94d88b5658459c5a59623a078c95993d24a3022aa66e7a1f476fb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUI0OjY4ODU5OjFFODM0NjI6MjcxM0M5NTo2OTkwMDQ2MSIsInZpc2l0b3JfaWQiOiIxODQ1MjczODY4MDM1NDI1Mzc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b4fa46aace68c5321d096116186e270009ff49daa45afd4dd8cc4b6765302020 |
| hovercard-subject-tag | pull_request:226350964 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23934/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ed6339f98f41816e8798af9dbe3c3ef279c3b5a570c06b2608c626a72e32e765/nodejs/node/pull/23934 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ed6339f98f41816e8798af9dbe3c3ef279c3b5a570c06b2608c626a72e32e765/nodejs/node/pull/23934 |
| og:image:alt | Promote v8 name spaces with using for consistent in util related codebase.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ZYSzys |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23934#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23934 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23934 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23934 |
| Reload | https://github.com/nodejs/node/pull/23934 |
| Reload | https://github.com/nodejs/node/pull/23934 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23934 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
709
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ZYSzys | https://github.com/ZYSzys |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/23934 |
| Commits1 (1) | https://github.com/nodejs/node/pull/23934/commits |
| Checks | https://github.com/nodejs/node/pull/23934/checks |
| Files changed | https://github.com/nodejs/node/pull/23934/files |
| src: promote v8 name spaces with using | https://github.com/nodejs/node/pull/23934#top |
| ZYSzys | https://github.com/ZYSzys |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
| Oct 28, 2018 | https://github.com/nodejs/node/pull/23934#issue-374729828 |
| Please reload this page | https://github.com/nodejs/node/pull/23934 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23934 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Oct 28, 2018 | https://github.com/nodejs/node/pull/23934#event-1930667728 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 28, 2018
| https://github.com/nodejs/node/pull/23934#pullrequestreview-169082695 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23934/files |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 28, 2018
| https://github.com/nodejs/node/pull/23934#pullrequestreview-169082721 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23934/files |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 28, 2018
| https://github.com/nodejs/node/pull/23934#pullrequestreview-169097833 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23934/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 28, 2018
| https://github.com/nodejs/node/pull/23934#pullrequestreview-169110341 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23934/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 29, 2018
| https://github.com/nodejs/node/pull/23934#pullrequestreview-169340100 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23934/files |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23934#pullrequestreview-169678745 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23934/files |
| fhinkel | https://github.com/fhinkel |
| https://github.com/nodejs/node/pull/23934#pullrequestreview-169678745 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23934 |
|
| https://github.com/ZYSzys |
| src: use v8:: for consistency in util | https://github.com/nodejs/node/pull/23934/commits/b1595d46f688e362776041a0213023eab3ecbdf5 |
| b1595d4 | https://github.com/nodejs/node/pull/23934/commits/b1595d46f688e362776041a0213023eab3ecbdf5 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23934#issuecomment-434261576 |
| @fhinkel | https://github.com/fhinkel |
| Please reload this page | https://github.com/nodejs/node/pull/23934 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23934#pullrequestreview-169747715 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23934/files/b1595d46f688e362776041a0213023eab3ecbdf5 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Oct 31, 2018 | https://github.com/nodejs/node/pull/23934#issuecomment-434557450 |
| https://ci.nodejs.org/job/node-test-pull-request/18254/ | https://ci.nodejs.org/job/node-test-pull-request/18254/ |
| Please reload this page | https://github.com/nodejs/node/pull/23934 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23934#issuecomment-435330766 |
| 9e31a72 | https://github.com/nodejs/node/commit/9e31a7286107cdfa24277cb781b893eb24ebfa9c |
| Please reload this page | https://github.com/nodejs/node/pull/23934 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23934#event-1942580581 |
| danbev | https://github.com/danbev |
|
Nov 2, 2018
| https://github.com/nodejs/node/pull/23934#ref-commit-9e31a72 |
|
| https://github.com/ZYSzys |
|
| https://github.com/danbev |
| src: use v8:: for consistency in util | https://github.com/nodejs/node/commit/9e31a7286107cdfa24277cb781b893eb24ebfa9c |
| 9e31a72 | https://github.com/nodejs/node/commit/9e31a7286107cdfa24277cb781b893eb24ebfa9c |
| #23934 | https://github.com/nodejs/node/pull/23934 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
| November 2, 2018 10:25 | https://github.com/nodejs/node/pull/23934#event-1942617404 |
| targos | https://github.com/targos |
|
Nov 2, 2018
| https://github.com/nodejs/node/pull/23934#ref-commit-38b0525 |
|
| https://github.com/ZYSzys |
|
| https://github.com/targos |
| src: use v8:: for consistency in util | https://github.com/nodejs/node/commit/38b0525bc33362a86ca221e6c36335b1f6467374 |
| 38b0525 | https://github.com/nodejs/node/commit/38b0525bc33362a86ca221e6c36335b1f6467374 |
| #23934 | https://github.com/nodejs/node/pull/23934 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Nov 5, 2018
| https://github.com/nodejs/node/pull/23934#ref-issue-376657327 |
|
Bangalore, November 17th
nodejs/code-and-learn#88
| https://github.com/nodejs/code-and-learn/issues/88 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 14, 2018
| https://github.com/nodejs/node/pull/23934#ref-pullrequest-380492752 |
|
Release proposal: v11.2
#24350
| https://github.com/nodejs/node/pull/24350 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#232
| https://github.com/beevelop/docker-nodejs/issues/232 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#249
| https://github.com/beevelop/docker-android-nodejs/issues/249 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#233
| https://github.com/beevelop/docker-nodejs/issues/233 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#234
| https://github.com/beevelop/docker-nodejs/issues/234 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#235
| https://github.com/beevelop/docker-nodejs/issues/235 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#236
| https://github.com/beevelop/docker-nodejs/issues/236 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x |
| Nov 27, 2018 | https://github.com/nodejs/node/pull/23934#event-1988760990 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 27, 2018 | https://github.com/nodejs/node/pull/23934#issuecomment-441955581 |
| Please reload this page | https://github.com/nodejs/node/pull/23934 |
| the guide | https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md |
| Please reload this page | https://github.com/nodejs/node/pull/23934 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Nov 27, 2018
| https://github.com/nodejs/node/pull/23934#ref-pullrequest-384798739 |
|
[v10.x backport] src: use v8:: for consistency in util
#24671
| https://github.com/nodejs/node/pull/24671 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Dec 13, 2018
| https://github.com/nodejs/node/pull/23934#ref-pullrequest-390503235 |
|
[v10.x backport] src: promote v8 name spaces with using
#25005
| https://github.com/nodejs/node/pull/25005 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 4, 2019
| https://github.com/nodejs/node/pull/23934#ref-commit-450bcde |
|
| https://github.com/ZYSzys |
|
| https://github.com/BethGriggs |
| src: use v8:: for consistency in util | https://github.com/nodejs/node/commit/450bcde46253f3bab335ca99c41d67b6bfa65f91 |
| 450bcde | https://github.com/nodejs/node/commit/450bcde46253f3bab335ca99c41d67b6bfa65f91 |
| #25005 | https://github.com/nodejs/node/pull/25005 |
| #23934 | https://github.com/nodejs/node/pull/23934 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
backported-to-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x |
|
backport-requested-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x |
| Feb 4, 2019 | https://github.com/nodejs/node/pull/23934#event-2116522293 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/23934#ref-pullrequest-409543286 |
|
v10.15.3 proposal
#26063
| https://github.com/nodejs/node/pull/26063 |
| rvagg | https://github.com/rvagg |
|
Feb 28, 2019
| https://github.com/nodejs/node/pull/23934#ref-commit-f9fc1ea |
|
| https://github.com/ZYSzys |
|
| https://github.com/rvagg |
| src: use v8:: for consistency in util | https://github.com/nodejs/node/commit/f9fc1ea0ab200e2d61fd343b7fce6e208d8367a0 |
| f9fc1ea | https://github.com/nodejs/node/commit/f9fc1ea0ab200e2d61fd343b7fce6e208d8367a0 |
| #25005 | https://github.com/nodejs/node/pull/25005 |
| #23934 | https://github.com/nodejs/node/pull/23934 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23934 |
|
| https://github.com/fhinkel |
|
fhinkel
| https://github.com/fhinkel |
|
| https://github.com/nodejs/node/pull/23934/files/b1595d46f688e362776041a0213023eab3ecbdf5 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23934/files/934bc388afda3459f0a752b524315249f3e7e6c0 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/23934/files/934bc388afda3459f0a752b524315249f3e7e6c0 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/23934/files/934bc388afda3459f0a752b524315249f3e7e6c0 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/23934/files/934bc388afda3459f0a752b524315249f3e7e6c0 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/23934/files/934bc388afda3459f0a752b524315249f3e7e6c0 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Please reload this page | https://github.com/nodejs/node/pull/23934 |
|
| https://github.com/ZYSzys |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
|
| https://github.com/fhinkel |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
|
| https://github.com/cjihrig |
|
| https://github.com/BethGriggs |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |