René's URL Explorer Experiment


Title: readline: inform line event about separator used by Sayanc93 · Pull Request #23929 · nodejs/node · GitHub

Open Graph Title: readline: inform line event about separator used by Sayanc93 · Pull Request #23929 · nodejs/node

X Title: readline: inform line event about separator used by Sayanc93 · Pull Request #23929 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is an attempt to address #7952 and is a work in progress PR (as of now). Would love some suggestions and guidance on the changes. Tests and documentation updates are pending on this. Any help ...

X Description: This is an attempt to address #7952 and is a work in progress PR (as of now). Would love some suggestions and guidance on the changes. Tests and documentation updates are pending on this. Any help ...

Opengraph URL: https://github.com/nodejs/node/pull/23929

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0e6f7d74-8b29-9294-8f5f-9643a665111d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DE6:78E00:C8EE0:1026BF:6990921D
html-safe-nonceaa549c8f2e07e24efedd578c4ff68daf9519ce9723cf60de3cc91f20a2e64c6a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REU2Ojc4RTAwOkM4RUUwOjEwMjZCRjo2OTkwOTIxRCIsInZpc2l0b3JfaWQiOiI1MjM5MTMxMDUzNjY3NDIyNzUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1b4243ed3845c47078bd7972b8210411ae2dbd7ba5613c646ac4fcc616bd6ac7
hovercard-subject-tagpull_request:226331907
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23929/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/48cf020c1b222a690d15d719adc436e948dde068a4c340f6815c7e27e24b58cb/nodejs/node/pull/23929
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/48cf020c1b222a690d15d719adc436e948dde068a4c340f6815c7e27e24b58cb/nodejs/node/pull/23929
og:image:altThis is an attempt to address #7952 and is a work in progress PR (as of now). Would love some suggestions and guidance on the changes. Tests and documentation updates are pending on this. Any help ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameSayanc93
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23929#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23929
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23929
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23929
Reloadhttps://github.com/nodejs/node/pull/23929
Reloadhttps://github.com/nodejs/node/pull/23929
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23929
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sayanc93https://github.com/Sayanc93
nodejs:masterhttps://github.com/nodejs/node/tree/master
Sayanc93:inform-line-event-on-readline-about-endline-inputhttps://github.com/Sayanc93/node/tree/inform-line-event-on-readline-about-endline-input
Conversationhttps://github.com/nodejs/node/pull/23929
Commits1 (1)https://github.com/nodejs/node/pull/23929/commits
Checkshttps://github.com/nodejs/node/pull/23929/checks
Files changedhttps://github.com/nodejs/node/pull/23929/files
readline: inform line event about separator usedhttps://github.com/nodejs/node/pull/23929#top
Sayanc93https://github.com/Sayanc93
nodejs:masterhttps://github.com/nodejs/node/tree/master
Sayanc93:inform-line-event-on-readline-about-endline-inputhttps://github.com/Sayanc93/node/tree/inform-line-event-on-readline-about-endline-input
https://github.com/Sayanc93
Sayanc93https://github.com/Sayanc93
Oct 27, 2018https://github.com/nodejs/node/pull/23929#issue-374700074
Please reload this pagehttps://github.com/nodejs/node/pull/23929
#7952https://github.com/nodejs/node/issues/7952
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23929
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
Oct 27, 2018https://github.com/nodejs/node/pull/23929#event-1930543298
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 27, 2018https://github.com/nodejs/node/pull/23929#issuecomment-433664279
Please reload this pagehttps://github.com/nodejs/node/pull/23929
https://github.com/Sayanc93
readline: inform line event about separator usedhttps://github.com/nodejs/node/pull/23929/commits/687cdf5dc9c5bfd2d3a87540064c496feb81ca38
687cdf5https://github.com/nodejs/node/pull/23929/commits/687cdf5dc9c5bfd2d3a87540064c496feb81ca38
nodejs#7952 (comment)https://github.com/nodejs/node/issues/7952#event-743092674
https://github.com/Sayanc93
Sayanc93https://github.com/Sayanc93
force-pushedhttps://github.com/nodejs/node/compare/9887ce2928e9f37405839658f299220afbffaccb..687cdf5dc9c5bfd2d3a87540064c496feb81ca38
9887ce2https://github.com/nodejs/node/commit/9887ce2928e9f37405839658f299220afbffaccb
687cdf5https://github.com/nodejs/node/commit/687cdf5dc9c5bfd2d3a87540064c496feb81ca38
Compare https://github.com/nodejs/node/compare/9887ce2928e9f37405839658f299220afbffaccb..687cdf5dc9c5bfd2d3a87540064c496feb81ca38
October 27, 2018 23:53https://github.com/nodejs/node/pull/23929#event-1930549290
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 28, 2018 https://github.com/nodejs/node/pull/23929#ref-pullrequest-374593003
readline: add support for async iteration #23916 https://github.com/nodejs/node/pull/23916
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 4, 2018https://github.com/nodejs/node/pull/23929#issuecomment-435646086
Please reload this pagehttps://github.com/nodejs/node/pull/23929
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 4, 2018 https://github.com/nodejs/node/pull/23929#pullrequestreview-171375699
View reviewed changes https://github.com/nodejs/node/pull/23929/files/687cdf5dc9c5bfd2d3a87540064c496feb81ca38
lib/readline.jshttps://github.com/nodejs/node/pull/23929/files/687cdf5dc9c5bfd2d3a87540064c496feb81ca38#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
BridgeARhttps://github.com/BridgeAR
Nov 4, 2018https://github.com/nodejs/node/pull/23929#discussion_r230601786
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23929
Sayanc93https://github.com/Sayanc93
Nov 6, 2018https://github.com/nodejs/node/pull/23929#discussion_r230980183
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/23929
lib/readline.jshttps://github.com/nodejs/node/pull/23929/files/687cdf5dc9c5bfd2d3a87540064c496feb81ca38#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
BridgeARhttps://github.com/BridgeAR
Nov 4, 2018https://github.com/nodejs/node/pull/23929#discussion_r230601935
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23929
Sayanc93https://github.com/Sayanc93
Nov 6, 2018https://github.com/nodejs/node/pull/23929#discussion_r230980220
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23929
lib/readline.jshttps://github.com/nodejs/node/pull/23929/files/687cdf5dc9c5bfd2d3a87540064c496feb81ca38#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
BridgeARhttps://github.com/BridgeAR
Nov 4, 2018https://github.com/nodejs/node/pull/23929#discussion_r230602103
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23929
Sayanc93https://github.com/Sayanc93
Nov 6, 2018https://github.com/nodejs/node/pull/23929#discussion_r230980537
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23929
lib/readline.jshttps://github.com/nodejs/node/pull/23929/files/687cdf5dc9c5bfd2d3a87540064c496feb81ca38#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
BridgeARhttps://github.com/BridgeAR
Nov 4, 2018https://github.com/nodejs/node/pull/23929#discussion_r230602291
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23929
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 4, 2018https://github.com/nodejs/node/pull/23929#issuecomment-435699756
Please reload this pagehttps://github.com/nodejs/node/pull/23929
https://github.com/Sayanc93
Sayanc93https://github.com/Sayanc93
Nov 6, 2018https://github.com/nodejs/node/pull/23929#issuecomment-436106738
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/23929
https://github.com/Trott
Trotthttps://github.com/Trott
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Nov 6, 2018https://github.com/nodejs/node/pull/23929#event-1947927874
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 21, 2018https://github.com/nodejs/node/pull/23929#issuecomment-440675797
Please reload this pagehttps://github.com/nodejs/node/pull/23929
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Jan 26, 2019https://github.com/nodejs/node/pull/23929#issuecomment-457819990
@Sayanc93https://github.com/Sayanc93
Please reload this pagehttps://github.com/nodejs/node/pull/23929
https://github.com/zero1five
zero1fivehttps://github.com/zero1five
May 25, 2019https://github.com/nodejs/node/pull/23929#issuecomment-495828987
@Sayanc93https://github.com/Sayanc93
Please reload this pagehttps://github.com/nodejs/node/pull/23929
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7
1ecc406https://github.com/nodejs/node/commit/1ecc406b77ba7573ed0b982a7e6654514c71a7a2
49cf67ehttps://github.com/nodejs/node/commit/49cf67efd66a94a93f4c91be6c39125e7f896ee7
Compare https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7
September 17, 2019 16:52https://github.com/nodejs/node/pull/23929#event-2640607568
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 14, 2019https://github.com/nodejs/node/pull/23929#issuecomment-565715816
Please reload this pagehttps://github.com/nodejs/node/pull/23929
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 14, 2019https://github.com/nodejs/node/pull/23929#event-2883372315
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23929
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/23929/files/687cdf5dc9c5bfd2d3a87540064c496feb81ca38
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/23929
https://github.com/Sayanc93
https://github.com/devsnek
https://github.com/Trott
https://github.com/BridgeAR
https://github.com/antsmartian
https://github.com/zero1five
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.