René's URL Explorer Experiment


Title: readline: add support for async iteration by TimothyGu · Pull Request #23916 · nodejs/node · GitHub

Open Graph Title: readline: add support for async iteration by TimothyGu · Pull Request #23916 · nodejs/node

X Title: readline: add support for async iteration by TimothyGu · Pull Request #23916 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Rewritten version of #18904, using more existing streams mechanisms. Depends on #23901 for some of the edge case tests (relevant commits included within this PR). Co-authored-by: Ivan Filenko ivan....

X Description: Rewritten version of #18904, using more existing streams mechanisms. Depends on #23901 for some of the edge case tests (relevant commits included within this PR). Co-authored-by: Ivan Filenko ivan....

Mail addresses
ivan.filenko@protonmail.com

Opengraph URL: https://github.com/nodejs/node/pull/23916

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b3d39363-3ead-645e-7f1c-cce5fdea0255
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE29C:D63F2:1430F9:1A1E4F:69904547
html-safe-nonceb74a8fb34fe63ffc0db9f2bfed89bb34fe144fa3274e6bf69bb0ef100a5ef4fa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjlDOkQ2M0YyOjE0MzBGOToxQTFFNEY6Njk5MDQ1NDciLCJ2aXNpdG9yX2lkIjoiMzY4NTIwODE4MzcxMjc5MzkyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9f0324e4e5dddbe543b4b34fe27b7f0194e2ce7fcf79671463cdf95e759ebad6
hovercard-subject-tagpull_request:226260747
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23916/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b89f98bba4b621b623c2a0a0b028545b36bd7f3a4fc6f76b18cc56dcd262bf07/nodejs/node/pull/23916
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b89f98bba4b621b623c2a0a0b028545b36bd7f3a4fc6f76b18cc56dcd262bf07/nodejs/node/pull/23916
og:image:altRewritten version of #18904, using more existing streams mechanisms. Depends on #23901 for some of the edge case tests (relevant commits included within this PR). Co-authored-by: Ivan Filenko ivan....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTimothyGu
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23916#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23916
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23916
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23916
Reloadhttps://github.com/nodejs/node/pull/23916
Reloadhttps://github.com/nodejs/node/pull/23916
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23916
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 708 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
TimothyGuhttps://github.com/TimothyGu
nodejs:masterhttps://github.com/nodejs/node/tree/master
TimothyGu:readline-async-iterationhttps://github.com/TimothyGu/node/tree/readline-async-iteration
Conversationhttps://github.com/nodejs/node/pull/23916
Commits2 (2)https://github.com/nodejs/node/pull/23916/commits
Checkshttps://github.com/nodejs/node/pull/23916/checks
Files changedhttps://github.com/nodejs/node/pull/23916/files
readline: add support for async iterationhttps://github.com/nodejs/node/pull/23916#top
TimothyGuhttps://github.com/TimothyGu
nodejs:masterhttps://github.com/nodejs/node/tree/master
TimothyGu:readline-async-iterationhttps://github.com/TimothyGu/node/tree/readline-async-iteration
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Oct 27, 2018https://github.com/nodejs/node/pull/23916#issue-374593003
#18904https://github.com/nodejs/node/pull/18904
#23901https://github.com/nodejs/node/pull/23901
#18603https://github.com/nodejs/node/issues/18603
#18904https://github.com/nodejs/node/pull/18904
@mcollinahttps://github.com/mcollina
@devsnekhttps://github.com/devsnek
@prog1devhttps://github.com/prog1dev
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
devsnekhttps://github.com/devsnek
mcollinahttps://github.com/mcollina
October 27, 2018 01:35https://github.com/nodejs/node/pull/23916#event-1930091684
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 27, 2018https://github.com/nodejs/node/pull/23916#issuecomment-433580673
@TimothyGuhttps://github.com/TimothyGu
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1386/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1386/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Oct 27, 2018https://github.com/nodejs/node/pull/23916#event-1930091699
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
force-pushedhttps://github.com/nodejs/node/compare/550bb04f54860381460a1bc4176bdc4fd408d720..b631b4cdab60ad4726d598ba34808fa338a8b4d4
550bb04https://github.com/nodejs/node/commit/550bb04f54860381460a1bc4176bdc4fd408d720
b631b4chttps://github.com/nodejs/node/commit/b631b4cdab60ad4726d598ba34808fa338a8b4d4
Compare https://github.com/nodejs/node/compare/550bb04f54860381460a1bc4176bdc4fd408d720..b631b4cdab60ad4726d598ba34808fa338a8b4d4
October 27, 2018 01:37https://github.com/nodejs/node/pull/23916#event-1930092526
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Oct 27, 2018https://github.com/nodejs/node/pull/23916#issuecomment-433580905
https://ci.nodejs.org/job/node-test-pull-request/18180/https://ci.nodejs.org/job/node-test-pull-request/18180/
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Oct 27, 2018 https://github.com/nodejs/node/pull/23916#ref-pullrequest-299041239
readline: add support for async iteration #18904 https://github.com/nodejs/node/pull/18904
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 27, 2018 https://github.com/nodejs/node/pull/23916#ref-issue-362894606
Readline: emit data events along with current line events #23032 https://github.com/nodejs/node/issues/23032
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 27, 2018 https://github.com/nodejs/node/pull/23916#pullrequestreview-169041408
View reviewed changes https://github.com/nodejs/node/pull/23916/files
doc/api/readline.mdhttps://github.com/nodejs/node/pull/23916/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 27, 2018https://github.com/nodejs/node/pull/23916#issuecomment-433586767
#23032 (comment)https://github.com/nodejs/node/issues/23032#issuecomment-423779309
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
Oct 27, 2018https://github.com/nodejs/node/pull/23916#event-1930126972
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 27, 2018 https://github.com/nodejs/node/pull/23916#pullrequestreview-169046382
View reviewed changes https://github.com/nodejs/node/pull/23916/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/23916#pullrequestreview-169046382
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23916
lib/readline.jshttps://github.com/nodejs/node/pull/23916/files#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
mcollinahttps://github.com/mcollina
Oct 27, 2018https://github.com/nodejs/node/pull/23916#discussion_r228703815
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23916
TimothyGuhttps://github.com/TimothyGu
Nov 20, 2018https://github.com/nodejs/node/pull/23916#discussion_r234834289
Please reload this pagehttps://github.com/nodejs/node/pull/23916
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#23916 (comment)https://github.com/nodejs/node/pull/23916#issuecomment-434233762
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 28, 2018https://github.com/nodejs/node/pull/23916#issuecomment-433685507
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 28, 2018https://github.com/nodejs/node/pull/23916#issuecomment-433697737
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 28, 2018https://github.com/nodejs/node/pull/23916#issuecomment-433707541
Please reload this pagehttps://github.com/nodejs/node/pull/23916
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 28, 2018https://github.com/nodejs/node/pull/23916#issuecomment-433710183
Please reload this pagehttps://github.com/nodejs/node/pull/23916
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 28, 2018https://github.com/nodejs/node/pull/23916#issuecomment-433710439
Please reload this pagehttps://github.com/nodejs/node/pull/23916
#23901https://github.com/nodejs/node/pull/23901
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Oct 28, 2018https://github.com/nodejs/node/pull/23916#issuecomment-433710509
#23929https://github.com/nodejs/node/pull/23929
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 30, 2018https://github.com/nodejs/node/pull/23916#issuecomment-434233762
@vsemozhetbythttps://github.com/vsemozhetbyt
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 30, 2018 https://github.com/nodejs/node/pull/23916#ref-issue-375396755
WHATWG Streams discussion nodejs/open-standards#12 https://github.com/nodejs/open-standards/issues/12
TimothyGuhttps://github.com/TimothyGu
November 19, 2018 16:38https://github.com/nodejs/node/pull/23916#commits-pushed-179dd7b
https://github.com/TimothyGu
https://github.com/prog1dev
readline: add support for async iterationhttps://github.com/nodejs/node/pull/23916/commits/179dd7b48f204be01a65c9a8f719b6c9a793ba2e
179dd7bhttps://github.com/nodejs/node/pull/23916/commits/179dd7b48f204be01a65c9a8f719b6c9a793ba2e
nodejs#18603https://github.com/nodejs/node/issues/18603
nodejs#18904https://github.com/nodejs/node/pull/18904
https://github.com/TimothyGu
fixup! readline: add support for async iterationhttps://github.com/nodejs/node/pull/23916/commits/f8ff7c7823644a29af022aaa54decbfa1659aa57
f8ff7c7https://github.com/nodejs/node/pull/23916/commits/f8ff7c7823644a29af022aaa54decbfa1659aa57
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
force-pushedhttps://github.com/nodejs/node/compare/b631b4cdab60ad4726d598ba34808fa338a8b4d4..f8ff7c7823644a29af022aaa54decbfa1659aa57
b631b4chttps://github.com/nodejs/node/commit/b631b4cdab60ad4726d598ba34808fa338a8b4d4
f8ff7c7https://github.com/nodejs/node/commit/f8ff7c7823644a29af022aaa54decbfa1659aa57
Compare https://github.com/nodejs/node/compare/b631b4cdab60ad4726d598ba34808fa338a8b4d4..f8ff7c7823644a29af022aaa54decbfa1659aa57
November 20, 2018 00:46https://github.com/nodejs/node/pull/23916#event-1976110238
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Nov 20, 2018https://github.com/nodejs/node/pull/23916#issuecomment-440095046
@vsemozhetbythttps://github.com/vsemozhetbyt
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 20, 2018 https://github.com/nodejs/node/pull/23916#pullrequestreview-176643094
View reviewed changes https://github.com/nodejs/node/pull/23916/files/f8ff7c7823644a29af022aaa54decbfa1659aa57
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/23916#pullrequestreview-176643094
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Nov 20, 2018https://github.com/nodejs/node/pull/23916#issuecomment-440302132
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Nov 20, 2018https://github.com/nodejs/node/pull/23916#issuecomment-440303062
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 20, 2018https://github.com/nodejs/node/pull/23916#issuecomment-440306428
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/23916
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262 https://github.com/beevelop/docker-android-nodejs/issues/262
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263 https://github.com/beevelop/docker-android-nodejs/issues/263
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264 https://github.com/beevelop/docker-android-nodejs/issues/264
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265 https://github.com/beevelop/docker-android-nodejs/issues/265
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/23916#ref-commit-e86e768
https://github.com/TimothyGu
https://github.com/prog1dev
https://github.com/refack
readline: add support for async iterationhttps://github.com/refack/node/commit/e86e7689e38b72e25e0de5676215a06a69210bd4
e86e768https://github.com/refack/node/commit/e86e7689e38b72e25e0de5676215a06a69210bd4
nodejs#18603https://github.com/nodejs/node/issues/18603
nodejs#18904https://github.com/nodejs/node/pull/18904
nodejs#23916https://github.com/nodejs/node/pull/23916
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/23916#ref-commit-5912f6d
https://github.com/BridgeAR
https://github.com/refack
2018-12-07, Version 11.4.0 (Current)https://github.com/refack/node/commit/5912f6d859f18535af44c15d8b16035403fa1b62
5912f6dhttps://github.com/refack/node/commit/5912f6d859f18535af44c15d8b16035403fa1b62
nodejs#23708https://github.com/nodejs/node/pull/23708
nodejs#24326https://github.com/nodejs/node/pull/24326
nodejs#23798https://github.com/nodejs/node/pull/23798
nodejs#24739https://github.com/nodejs/node/pull/24739
nodejs#23916https://github.com/nodejs/node/pull/23916
nodejs#24804https://github.com/nodejs/node/pull/24804
nodejs#24405https://github.com/nodejs/node/pull/24405
nodejs#24358https://github.com/nodejs/node/pull/24358
nodejs#23720https://github.com/nodejs/node/pull/23720
nodejs#24677https://github.com/nodejs/node/pull/24677
nodejs#24233https://github.com/nodejs/node/pull/24233
https://github.com/antsmartianhttps://github.com/antsmartian
nodejs#24655https://github.com/nodejs/node/pull/24655
nodejs#24854https://github.com/nodejs/node/pull/24854
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Mar 6, 2019 https://github.com/nodejs/node/pull/23916#ref-pullrequest-417851982
doc: add caveat and tradeoff example to readline #26472 https://github.com/nodejs/node/pull/26472
vsemozhetbythttps://github.com/vsemozhetbyt
Mar 8, 2019 https://github.com/nodejs/node/pull/23916#ref-commit-15e741a
https://github.com/vsemozhetbyt
doc: add caveat and tradeoff example to readlinehttps://github.com/nodejs/node/commit/15e741a1320638a1fcf108d65b3338142769eecb
15e741ahttps://github.com/nodejs/node/commit/15e741a1320638a1fcf108d65b3338142769eecb
#26472https://github.com/nodejs/node/pull/26472
#23916https://github.com/nodejs/node/pull/23916
BridgeARhttps://github.com/BridgeAR
Mar 13, 2019 https://github.com/nodejs/node/pull/23916#ref-commit-bab6c63
https://github.com/vsemozhetbyt
https://github.com/BridgeAR
doc: add caveat and tradeoff example to readlinehttps://github.com/BridgeAR/node/commit/bab6c63f63f5f628e916c222e596701515a3e28d
bab6c63https://github.com/BridgeAR/node/commit/bab6c63f63f5f628e916c222e596701515a3e28d
nodejs#26472https://github.com/nodejs/node/pull/26472
nodejs#23916https://github.com/nodejs/node/pull/23916
BridgeARhttps://github.com/BridgeAR
Mar 14, 2019 https://github.com/nodejs/node/pull/23916#ref-commit-2ee9a96
https://github.com/vsemozhetbyt
https://github.com/BridgeAR
doc: add caveat and tradeoff example to readlinehttps://github.com/nodejs/node/commit/2ee9a962d7179a4ec352636868b8091c65850c45
2ee9a96https://github.com/nodejs/node/commit/2ee9a962d7179a4ec352636868b8091c65850c45
#26472https://github.com/nodejs/node/pull/26472
#23916https://github.com/nodejs/node/pull/23916
BethGriggshttps://github.com/BethGriggs
Apr 16, 2019 https://github.com/nodejs/node/pull/23916#ref-commit-4065785
https://github.com/vsemozhetbyt
https://github.com/BethGriggs
doc: add caveat and tradeoff example to readlinehttps://github.com/nodejs/node/commit/40657859ca52874abd9ca15e0d0e5569fd63e565
4065785https://github.com/nodejs/node/commit/40657859ca52874abd9ca15e0d0e5569fd63e565
#26472https://github.com/nodejs/node/pull/26472
#23916https://github.com/nodejs/node/pull/23916
BethGriggshttps://github.com/BethGriggs
Apr 17, 2019 https://github.com/nodejs/node/pull/23916#ref-commit-b364fa3
https://github.com/TimothyGu
https://github.com/prog1dev
https://github.com/BethGriggs
readline: add support for async iterationhttps://github.com/nodejs/node/commit/b364fa341db5e69edc73b1a784cbee9d355dbada
b364fa3https://github.com/nodejs/node/commit/b364fa341db5e69edc73b1a784cbee9d355dbada
#18603https://github.com/nodejs/node/issues/18603
#18904https://github.com/nodejs/node/pull/18904
#23916https://github.com/nodejs/node/pull/23916
BethGriggshttps://github.com/BethGriggs
Apr 28, 2019 https://github.com/nodejs/node/pull/23916#ref-commit-a0a3095
https://github.com/TimothyGu
https://github.com/prog1dev
https://github.com/BethGriggs
readline: add support for async iterationhttps://github.com/nodejs/node/commit/a0a3095aab402884f4e893112982b386989f15df
a0a3095https://github.com/nodejs/node/commit/a0a3095aab402884f4e893112982b386989f15df
#18603https://github.com/nodejs/node/issues/18603
#18904https://github.com/nodejs/node/pull/18904
#23916https://github.com/nodejs/node/pull/23916
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
May 1, 2019 https://github.com/nodejs/node/pull/23916#ref-pullrequest-439147711
v10.16.0 proposal #27514 https://github.com/nodejs/node/pull/27514
MylesBorinshttps://github.com/MylesBorins
May 16, 2019 https://github.com/nodejs/node/pull/23916#ref-commit-d3f15b0
https://github.com/TimothyGu
https://github.com/prog1dev
https://github.com/MylesBorins
readline: add support for async iterationhttps://github.com/nodejs/node/commit/d3f15b0ffb48f1ef8c38cba3c20aedecd8cd57b7
d3f15b0https://github.com/nodejs/node/commit/d3f15b0ffb48f1ef8c38cba3c20aedecd8cd57b7
#18603https://github.com/nodejs/node/issues/18603
#18904https://github.com/nodejs/node/pull/18904
#23916https://github.com/nodejs/node/pull/23916
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#315 https://github.com/beevelop/docker-android-nodejs/issues/315
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#316 https://github.com/beevelop/docker-android-nodejs/issues/316
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#317 https://github.com/beevelop/docker-android-nodejs/issues/317
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#318 https://github.com/beevelop/docker-android-nodejs/issues/318
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#319 https://github.com/beevelop/docker-android-nodejs/issues/319
[Snyk] Fix for 2 vulnerabilities kissofire/node#17 https://github.com/kissofire/node/pull/17
[Snyk] Fix for 2 vulnerabilities ron-a20/node#14 https://github.com/ron-a20/node/pull/14
[Snyk] Fix for 2 vulnerabilities sitedata/node#6 https://github.com/sitedata/node/pull/6
[Snyk] Fix for 2 vulnerabilities meghasfdc/node#17 https://github.com/meghasfdc/node/pull/17
[Snyk] Fix for 2 vulnerabilities 137717unity/node#7 https://github.com/137717unity/node/pull/7
[Snyk] Fix for 2 vulnerabilities Rednickle/node-1#2 https://github.com/Rednickle/node-1/pull/2
[Snyk] Fix for 3 vulnerabilities turkdevops/node#2 https://github.com/turkdevops/node/pull/2
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Oct 29, 2020 https://github.com/nodejs/node/pull/23916#ref-pullrequest-732099539
[Snyk] Security upgrade gatsby from 2.18.18 to 2.23.20 Rednickle/node-1#4 https://github.com/Rednickle/node-1/pull/4
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jan 27, 2022 https://github.com/nodejs/node/pull/23916#pullrequestreview-864574542
View reviewed changes https://github.com/nodejs/node/pull/23916/files/f8ff7c7823644a29af022aaa54decbfa1659aa57
test/parallel/test-readline-async-iterators-backpressure.jshttps://github.com/nodejs/node/pull/23916/files/f8ff7c7823644a29af022aaa54decbfa1659aa57#diff-da096145c44dc24dcb4996d99ba8e532146466fd24b14c321bd4dd5bab2d7e36
benjamingrhttps://github.com/benjamingr
Jan 27, 2022https://github.com/nodejs/node/pull/23916#discussion_r793399865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23916
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/23916/files/f8ff7c7823644a29af022aaa54decbfa1659aa57
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/23916/files/f8ff7c7823644a29af022aaa54decbfa1659aa57
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/23916/files/b631b4cdab60ad4726d598ba34808fa338a8b4d4
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/23916/files/f8ff7c7823644a29af022aaa54decbfa1659aa57
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/23916
https://github.com/TimothyGu
https://github.com/nodejs-github-bot
https://github.com/vsemozhetbyt
https://github.com/mcollina
https://github.com/devsnek
https://github.com/Trott
https://github.com/rauschma
https://github.com/benjamingr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.