| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:839ee8eb-ab04-6122-9e44-8f40afad72a5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C188:2780A3:6E6538:994519:696A71B4 |
| html-safe-nonce | 1b1b8729ee00ee99e49df0f5a7f7f864b1e5d42b227a14db79d94e72aea58d0a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTg4OjI3ODBBMzo2RTY1Mzg6OTk0NTE5OjY5NkE3MUI0IiwidmlzaXRvcl9pZCI6IjgyNDMzMTYzMDYxODYyMzYzNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 04e17eb331d2c819ad4d232f7f198fa975397d14c0db73b9d6ef19e4480bf93a |
| hovercard-subject-tag | pull_request:226244980 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23915/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/84d8dc9d7e30a46110303e21d042c964daf0e13f959d31c4b6e2444926a93119/nodejs/node/pull/23915 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/84d8dc9d7e30a46110303e21d042c964daf0e13f959d31c4b6e2444926a93119/nodejs/node/pull/23915 |
| og:image:alt | Updated take on #10846
Fixes: #10555
/cc @sam-github
Checklist
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23915#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23915 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23915 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23915 |
| Reload | https://github.com/nodejs/node/pull/23915 |
| Reload | https://github.com/nodejs/node/pull/23915 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/23915#issue-comment-box |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:tls-socket-take2 | https://github.com/jasnell/node/tree/tls-socket-take2 |
|
tls: deprecate undocumented tlsSocket.ssl property, add docs
| https://github.com/nodejs/node/pull/23915#top |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:tls-socket-take2 | https://github.com/jasnell/node/tree/tls-socket-take2 |
|
Conversation
28
| https://github.com/nodejs/node/pull/23915 |
|
Commits
3
| https://github.com/nodejs/node/pull/23915/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/23915/checks |
|
Files changed
| https://github.com/nodejs/node/pull/23915/files |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 26, 2018 | https://github.com/nodejs/node/pull/23915#issue-374571896 |
| #10846 | https://github.com/nodejs/node/pull/10846 |
| #10555 | https://github.com/nodejs/node/issues/10555 |
| @sam-github | https://github.com/sam-github |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 26, 2018 | https://github.com/nodejs/node/pull/23915#issuecomment-433562989 |
| @jasnell | https://github.com/jasnell |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1385/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1385/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Oct 26, 2018 | https://github.com/nodejs/node/pull/23915#event-1929979212 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 26, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169023251 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 26, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169023280 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Oct 27, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169055069 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Oct 27, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169055175 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Oct 27, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169055337 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 27, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169055412 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Oct 27, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169055617 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Oct 27, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169055792 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 29, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169347924 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 29, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169348419 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 29, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169349568 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Oct 29, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169371764 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/02e937ed6a9bd05ba8da67b845a3112e60104f09..66849e720d3013d1e9689b3504d057cf0428f696 |
| 02e937e | https://github.com/nodejs/node/commit/02e937ed6a9bd05ba8da67b845a3112e60104f09 |
| 66849e7 | https://github.com/nodejs/node/commit/66849e720d3013d1e9689b3504d057cf0428f696 |
|
Compare
| https://github.com/nodejs/node/compare/02e937ed6a9bd05ba8da67b845a3112e60104f09..66849e720d3013d1e9689b3504d057cf0428f696 |
| October 30, 2018 15:44 | https://github.com/nodejs/node/pull/23915#event-1935465799 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23915#event-1935468515 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
deprecations
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23915#event-1935469059 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23915#issuecomment-434354586 |
| @addaleax | https://github.com/addaleax |
| @sam-github | https://github.com/sam-github |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23915#issuecomment-434357828 |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 30, 2018 | https://github.com/nodejs/node/pull/23915#issuecomment-434361985 |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169858299 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/deprecations.md | https://github.com/nodejs/node/pull/23915/files#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87 |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-169871003 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 1, 2018 | https://github.com/nodejs/node/pull/23915#issuecomment-435059768 |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| addaleax | https://github.com/addaleax |
| November 1, 2018 14:35 | https://github.com/nodejs/node/pull/23915#event-1940650008 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 1, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-170723240 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files |
| lib/_tls_wrap.js | https://github.com/nodejs/node/pull/23915/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8 |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| jasnell | https://github.com/jasnell |
| November 1, 2018 08:37 | https://github.com/nodejs/node/pull/23915#commits-pushed-4ca0e4c |
|
| https://github.com/jasnell |
| tls: deprecate undocumented .ssl property, add docs | https://github.com/nodejs/node/pull/23915/commits/4ca0e4c949307d7e93e797b1a2cb4c54e6af0dc5 |
| 4ca0e4c | https://github.com/nodejs/node/pull/23915/commits/4ca0e4c949307d7e93e797b1a2cb4c54e6af0dc5 |
| nodejs#10846 | https://github.com/nodejs/node/pull/10846 |
| nodejs#10555 | https://github.com/nodejs/node/issues/10555 |
|
| https://github.com/jasnell |
| [Squash] use kHandle | https://github.com/nodejs/node/pull/23915/commits/c82010d5e48bd559d214bd0831e08fac9c0e2408 |
| c82010d | https://github.com/nodejs/node/pull/23915/commits/c82010d5e48bd559d214bd0831e08fac9c0e2408 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/0a479a4e78d85335f72d39f02f89a450ec6cd1c1..c82010d5e48bd559d214bd0831e08fac9c0e2408 |
| 0a479a4 | https://github.com/nodejs/node/commit/0a479a4e78d85335f72d39f02f89a450ec6cd1c1 |
| c82010d | https://github.com/nodejs/node/commit/c82010d5e48bd559d214bd0831e08fac9c0e2408 |
|
Compare
| https://github.com/nodejs/node/compare/0a479a4e78d85335f72d39f02f89a450ec6cd1c1..c82010d5e48bd559d214bd0831e08fac9c0e2408 |
| November 1, 2018 19:19 | https://github.com/nodejs/node/pull/23915#event-1941356708 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 2, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-170993793 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files/c82010d5e48bd559d214bd0831e08fac9c0e2408 |
| doc/api/deprecations.md | https://github.com/nodejs/node/pull/23915/files/c82010d5e48bd559d214bd0831e08fac9c0e2408#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87 |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 2, 2018
| https://github.com/nodejs/node/pull/23915#pullrequestreview-170995449 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23915/files/c82010d5e48bd559d214bd0831e08fac9c0e2408 |
| doc/api/tls.md | https://github.com/nodejs/node/pull/23915/files/c82010d5e48bd559d214bd0831e08fac9c0e2408#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Trott | https://github.com/Trott |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23915#discussion_r230290746 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| jasnell | https://github.com/jasnell |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/23915#discussion_r234637892 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
| [Squash] suggestion | https://github.com/nodejs/node/pull/23915/commits/5116f589e7dadef16679f3817f6d38a6825cea37 |
| 5116f58 | https://github.com/nodejs/node/pull/23915/commits/5116f589e7dadef16679f3817f6d38a6825cea37 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/23915#issuecomment-439792364 |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Nov 19, 2018 | https://github.com/nodejs/node/pull/23915#issuecomment-439864223 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 28, 2019 | https://github.com/nodejs/node/pull/23915#event-2101965768 |
| https://github.com/armanbilge |
| armanbilge | https://github.com/armanbilge |
|
Jul 26, 2022
| https://github.com/nodejs/node/pull/23915#ref-issue-1317672883 |
|
How to use new tls.TLSSocket(...) to establish a secure connection?
#43994
| https://github.com/nodejs/node/issues/43994 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23915 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/23915/files/0b4aaf5a4901bd90596e15dd8b89871be80a2acc |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/23915/files/c82010d5e48bd559d214bd0831e08fac9c0e2408 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/23915/files/0a479a4e78d85335f72d39f02f89a450ec6cd1c1 |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/23915/files/4e06ef373a0f0e034a05cc872c145e4902a4a80b |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/23915/files/59e1763e7eac7d6fbeb94b886d0bed483d0cd173 |
|
deprecations
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Please reload this page | https://github.com/nodejs/node/pull/23915 |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/sam-github |
|
| https://github.com/rvagg |
|
| https://github.com/bnoordhuis |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |