René's URL Explorer Experiment


Title: os: fix memory leak in `userInfo()` by addaleax · Pull Request #23893 · nodejs/node · GitHub

Open Graph Title: os: fix memory leak in `userInfo()` by addaleax · Pull Request #23893 · nodejs/node

X Title: os: fix memory leak in `userInfo()` by addaleax · Pull Request #23893 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This previously leaked memory in the ‘success’ case. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: This previously leaked memory in the ‘success’ case. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/23893

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8fe336c6-8c91-3dcf-c69f-2254310388dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB10:C5B4E:21F23E:2B2193:69903094
html-safe-nonceb20ff31caee399d94dd36b4b1f50775c0d2853f42e0fb7d498c7cda3c74f8012
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjEwOkM1QjRFOjIxRjIzRToyQjIxOTM6Njk5MDMwOTQiLCJ2aXNpdG9yX2lkIjoiODkwMzYyMTA3Nzg3NzQwMzc5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0b4f5c8354a3520917ba2e022c6d8fbe9d961e9d3f2366b57ea1791c3e967f0d
hovercard-subject-tagpull_request:225997969
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23893/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e8ac777264ae2442ac2887db31eb844580036fa16511575690599ab0a2ffe35c/nodejs/node/pull/23893
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e8ac777264ae2442ac2887db31eb844580036fa16511575690599ab0a2ffe35c/nodejs/node/pull/23893
og:image:altThis previously leaked memory in the ‘success’ case. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23893#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23893
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23893
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23893
Reloadhttps://github.com/nodejs/node/pull/23893
Reloadhttps://github.com/nodejs/node/pull/23893
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23893
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 709 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:os-mem-leakhttps://github.com/addaleax/node/tree/os-mem-leak
Conversationhttps://github.com/nodejs/node/pull/23893
Commits2 (2)https://github.com/nodejs/node/pull/23893/commits
Checkshttps://github.com/nodejs/node/pull/23893/checks
Files changedhttps://github.com/nodejs/node/pull/23893/files
os: fix memory leak in userInfo()https://github.com/nodejs/node/pull/23893#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:os-mem-leakhttps://github.com/addaleax/node/tree/os-mem-leak
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 26, 2018https://github.com/nodejs/node/pull/23893#issue-374255705
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/23893
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 26, 2018https://github.com/nodejs/node/pull/23893#issuecomment-433310517
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1375/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1375/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23893
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
os https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aos
Oct 26, 2018https://github.com/nodejs/node/pull/23893#event-1928076058
https://github.com/addaleax
os: fix memory leak in userInfo()https://github.com/nodejs/node/pull/23893/commits/1d0c4f82e5130e3d125b20ebd5a9dc7d3789f6f1
1d0c4f8https://github.com/nodejs/node/pull/23893/commits/1d0c4f82e5130e3d125b20ebd5a9dc7d3789f6f1
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/0ef7ffefc84ae7b0c86ae89a009afeedd50d799e..1d0c4f82e5130e3d125b20ebd5a9dc7d3789f6f1
0ef7ffehttps://github.com/nodejs/node/commit/0ef7ffefc84ae7b0c86ae89a009afeedd50d799e
1d0c4f8https://github.com/nodejs/node/commit/1d0c4f82e5130e3d125b20ebd5a9dc7d3789f6f1
Compare https://github.com/nodejs/node/compare/0ef7ffefc84ae7b0c86ae89a009afeedd50d799e..1d0c4f82e5130e3d125b20ebd5a9dc7d3789f6f1
October 26, 2018 07:14https://github.com/nodejs/node/pull/23893#event-1928076977
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 26, 2018https://github.com/nodejs/node/pull/23893#issuecomment-433310805
https://ci.nodejs.org/job/node-test-pull-request/18167/https://ci.nodejs.org/job/node-test-pull-request/18167/
Please reload this pagehttps://github.com/nodejs/node/pull/23893
https://github.com/targos
targoshttps://github.com/targos
Oct 26, 2018 https://github.com/nodejs/node/pull/23893#pullrequestreview-168701997
View reviewed changes https://github.com/nodejs/node/pull/23893/files/1d0c4f82e5130e3d125b20ebd5a9dc7d3789f6f1
src/node_os.cchttps://github.com/nodejs/node/pull/23893/files/1d0c4f82e5130e3d125b20ebd5a9dc7d3789f6f1#diff-d7e4bd6c075665cd9b102228c64daf3fb862630a5d3120d535a2e27cc647422a
targoshttps://github.com/targos
Oct 26, 2018https://github.com/nodejs/node/pull/23893#discussion_r228430782
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23893
addaleaxhttps://github.com/addaleax
Oct 26, 2018https://github.com/nodejs/node/pull/23893#discussion_r228431751
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23893
https://github.com/addaleax
fixup! os: fix memory leak in userInfo()https://github.com/nodejs/node/pull/23893/commits/21e0e8657d68e9ee38a9c1826f97ffc918504ea5
21e0e86https://github.com/nodejs/node/pull/23893/commits/21e0e8657d68e9ee38a9c1826f97ffc918504ea5
https://github.com/targos
targoshttps://github.com/targos
Oct 26, 2018 https://github.com/nodejs/node/pull/23893#pullrequestreview-168713559
View reviewed changes https://github.com/nodejs/node/pull/23893/files/21e0e8657d68e9ee38a9c1826f97ffc918504ea5
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 26, 2018 https://github.com/nodejs/node/pull/23893#pullrequestreview-168797582
View reviewed changes https://github.com/nodejs/node/pull/23893/files/21e0e8657d68e9ee38a9c1826f97ffc918504ea5
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 26, 2018 https://github.com/nodejs/node/pull/23893#pullrequestreview-168875734
View reviewed changes https://github.com/nodejs/node/pull/23893/files/21e0e8657d68e9ee38a9c1826f97ffc918504ea5
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 26, 2018 https://github.com/nodejs/node/pull/23893#pullrequestreview-168928385
View reviewed changes https://github.com/nodejs/node/pull/23893/files/21e0e8657d68e9ee38a9c1826f97ffc918504ea5
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 31, 2018https://github.com/nodejs/node/pull/23893#issuecomment-434565091
d690a87https://github.com/nodejs/node/commit/d690a87b8c71208a021cbcc21b09d27007c0f9dd
Please reload this pagehttps://github.com/nodejs/node/pull/23893
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 31, 2018https://github.com/nodejs/node/pull/23893#event-1936931628
danbevhttps://github.com/danbev
Oct 31, 2018 https://github.com/nodejs/node/pull/23893#ref-commit-d690a87
https://github.com/addaleax
https://github.com/danbev
os: fix memory leak in userInfo()https://github.com/nodejs/node/commit/d690a87b8c71208a021cbcc21b09d27007c0f9dd
d690a87https://github.com/nodejs/node/commit/d690a87b8c71208a021cbcc21b09d27007c0f9dd
#23893https://github.com/nodejs/node/pull/23893
targoshttps://github.com/targos
Nov 1, 2018 https://github.com/nodejs/node/pull/23893#ref-commit-3e512f1
https://github.com/addaleax
https://github.com/targos
os: fix memory leak in userInfo()https://github.com/nodejs/node/commit/3e512f1897f90a93d31dc1b2181495f9970973fb
3e512f1https://github.com/nodejs/node/commit/3e512f1897f90a93d31dc1b2181495f9970973fb
#23893https://github.com/nodejs/node/pull/23893
https://github.com/targos
targoshttps://github.com/targos
Nov 1, 2018 https://github.com/nodejs/node/pull/23893#ref-pullrequest-374624819
Release proposal: v11.1.0 #23922 https://github.com/nodejs/node/pull/23922
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245 https://github.com/beevelop/docker-android-nodejs/issues/245
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246 https://github.com/beevelop/docker-android-nodejs/issues/246
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247 https://github.com/beevelop/docker-android-nodejs/issues/247
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248 https://github.com/beevelop/docker-android-nodejs/issues/248
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 27, 2018https://github.com/nodejs/node/pull/23893#issuecomment-441857020
Please reload this pagehttps://github.com/nodejs/node/pull/23893
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Nov 27, 2018https://github.com/nodejs/node/pull/23893#event-1988285760
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
November 27, 2018 00:57https://github.com/nodejs/node/pull/23893#event-1988286793
MylesBorinshttps://github.com/MylesBorins
Nov 27, 2018 https://github.com/nodejs/node/pull/23893#ref-commit-ac73050
https://github.com/addaleax
https://github.com/MylesBorins
os: fix memory leak in userInfo()https://github.com/nodejs/node/commit/ac73050fc84ac3e729f7da6d2871279c9e56ee29
ac73050https://github.com/nodejs/node/commit/ac73050fc84ac3e729f7da6d2871279c9e56ee29
#23893https://github.com/nodejs/node/pull/23893
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 27, 2018 https://github.com/nodejs/node/pull/23893#ref-pullrequest-384882602
v10.13.1 proposal #24675 https://github.com/nodejs/node/pull/24675
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/23893#ref-commit-771caa4
https://github.com/addaleax
https://github.com/rvagg
os: fix memory leak in userInfo()https://github.com/nodejs/node/commit/771caa48237a542616640bb2142ce6a7dd45ffe0
771caa4https://github.com/nodejs/node/commit/771caa48237a542616640bb2142ce6a7dd45ffe0
#23893https://github.com/nodejs/node/pull/23893
MylesBorinshttps://github.com/MylesBorins
Nov 29, 2018 https://github.com/nodejs/node/pull/23893#ref-commit-4a79bef
https://github.com/addaleax
https://github.com/MylesBorins
os: fix memory leak in userInfo()https://github.com/nodejs/node/commit/4a79bef6c659c354741de1f39de54fee4dbfb33d
4a79befhttps://github.com/nodejs/node/commit/4a79bef6c659c354741de1f39de54fee4dbfb33d
#23893https://github.com/nodejs/node/pull/23893
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 29, 2018 https://github.com/nodejs/node/pull/23893#ref-pullrequest-385836001
v10.14.2 proposal #24727 https://github.com/nodejs/node/pull/24727
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23893
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23893/files/21e0e8657d68e9ee38a9c1826f97ffc918504ea5
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/23893/files/21e0e8657d68e9ee38a9c1826f97ffc918504ea5
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/23893/files/21e0e8657d68e9ee38a9c1826f97ffc918504ea5
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/23893/files/21e0e8657d68e9ee38a9c1826f97ffc918504ea5
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
os https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aos
Please reload this pagehttps://github.com/nodejs/node/pull/23893
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/MylesBorins
https://github.com/jasnell
https://github.com/targos
https://github.com/cjihrig
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.