| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f5a16f51-f47b-1e25-8900-b59b3199b067 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 92AC:231D79:28A057C:3568AD9:696B28EF |
| html-safe-nonce | 32b0e5d30623edbeefb22ef02f5bd9467d8fb282c02818e2bbb0cb4393870957 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkFDOjIzMUQ3OToyOEEwNTdDOjM1NjhBRDk6Njk2QjI4RUYiLCJ2aXNpdG9yX2lkIjoiNjk1MzE0OTQ2MDkzODE3MjY1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e0c9fa9571e1c9d26a78c413b15e0e5ace724a9edea7aaf997cf2a320d397aa1 |
| hovercard-subject-tag | pull_request:225785893 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23876/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7c8b6bc08ce194908f863f08ce364ad85e1ae81b349858be01e7dd588d8b2868/nodejs/node/pull/23876 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7c8b6bc08ce194908f863f08ce364ad85e1ae81b349858be01e7dd588d8b2868/nodejs/node/pull/23876 |
| og:image:alt | Fixed test-bootstrap-modules to pass CI when run with --experimental-worker.
(Example of current fail)
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | refack |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/23876#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23876 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23876 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/23876 |
| Reload | https://github.com/nodejs/node/pull/23876 |
| Reload | https://github.com/nodejs/node/pull/23876 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/23876#issue-comment-box |
| refack | https://github.com/refack |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| refack:fix-bootstrap-test | https://github.com/refack/node/tree/fix-bootstrap-test |
|
test: fix test-bootstrap-modules to account for workers module
| https://github.com/nodejs/node/pull/23876#top |
| refack | https://github.com/refack |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| refack:fix-bootstrap-test | https://github.com/refack/node/tree/fix-bootstrap-test |
|
Conversation
16
| https://github.com/nodejs/node/pull/23876 |
|
Commits
221
| https://github.com/nodejs/node/pull/23876/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/23876/checks |
|
Files changed
| https://github.com/nodejs/node/pull/23876/files |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/23876#issue-373981225 |
| Example of current fail | https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/1900/testReport/junit/(root)/test/parallel_test_bootstrap_modules/ |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| styfle | https://github.com/styfle |
| October 10, 2018 23:56 | https://github.com/nodejs/node/pull/23876#commits-pushed-4153114 |
|
| https://github.com/styfle |
|
| https://github.com/targos |
| doc: add WebAssembly to globals | https://github.com/nodejs/node/pull/23876/commits/4153114797bd91c0b92fffe5ff8aacf667449ed7 |
| 4153114 | https://github.com/nodejs/node/pull/23876/commits/4153114797bd91c0b92fffe5ff8aacf667449ed7 |
| nodejs#23339 | https://github.com/nodejs/node/pull/23339 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| doc: remove style instruction that is not followed | https://github.com/nodejs/node/pull/23876/commits/dd161cab62758946b82072eb0786e33bc837f3ca |
| dd161ca | https://github.com/nodejs/node/pull/23876/commits/dd161cab62758946b82072eb0786e33bc837f3ca |
| nodejs#23346 | https://github.com/nodejs/node/pull/23346 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| doc: remove personal pronoun from domain.md | https://github.com/nodejs/node/pull/23876/commits/d61cb657ceb9f0f1ef68edd40c9f6ad10d7f691a |
| d61cb65 | https://github.com/nodejs/node/pull/23876/commits/d61cb657ceb9f0f1ef68edd40c9f6ad10d7f691a |
| nodejs#23347 | https://github.com/nodejs/node/pull/23347 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| doc: remove personal pronoun from worker_threads | https://github.com/nodejs/node/pull/23876/commits/080b0150d4953dcf66f8a09a63f3889a277d7e59 |
| 080b015 | https://github.com/nodejs/node/pull/23876/commits/080b0150d4953dcf66f8a09a63f3889a277d7e59 |
| nodejs#23347 | https://github.com/nodejs/node/pull/23347 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| doc: edit for minor fixes to prcoess.md | https://github.com/nodejs/node/pull/23876/commits/2f17cdbb7c98cf69f17e4bfb8ce6288692318a95 |
| 2f17cdb | https://github.com/nodejs/node/pull/23876/commits/2f17cdbb7c98cf69f17e4bfb8ce6288692318a95 |
| nodejs#23347 | https://github.com/nodejs/node/pull/23347 |
|
| https://github.com/danbev |
|
| https://github.com/targos |
| test: fix compiler warning in doc/api/addons.md | https://github.com/nodejs/node/pull/23876/commits/ebf04c1741dfebc8b39a93acfb2628500a665dcb |
| ebf04c1 | https://github.com/nodejs/node/pull/23876/commits/ebf04c1741dfebc8b39a93acfb2628500a665dcb |
| nodejs#23323 | https://github.com/nodejs/node/pull/23323 |
|
| https://github.com/danbev |
|
| https://github.com/targos |
| http2: make Http2Settings constructors delegate | https://github.com/nodejs/node/pull/23876/commits/907ebd21301d0937dd085e6f5dc1c4d9b4d70301 |
| 907ebd2 | https://github.com/nodejs/node/pull/23876/commits/907ebd21301d0937dd085e6f5dc1c4d9b4d70301 |
| nodejs#23326 | https://github.com/nodejs/node/pull/23326 |
|
| https://github.com/conectado |
|
| https://github.com/targos |
| test: add test for a vm indexed property | https://github.com/nodejs/node/pull/23876/commits/e34761f8fdec20b49158ac8d5a4952de0bc41332 |
| e34761f | https://github.com/nodejs/node/pull/23876/commits/e34761f8fdec20b49158ac8d5a4952de0bc41332 |
| nodejs#23318 | https://github.com/nodejs/node/pull/23318 |
|
| https://github.com/targos |
| src: fix usage of deprecated v8::Date::New | https://github.com/nodejs/node/pull/23876/commits/8c04c371dfe7a070c6c488bef40184940eec9905 |
| 8c04c37 | https://github.com/nodejs/node/pull/23876/commits/8c04c371dfe7a070c6c488bef40184940eec9905 |
| nodejs#23288 | https://github.com/nodejs/node/pull/23288 |
|
| https://github.com/targos |
| vm: pass parsing_context to ScriptCompiler::CompileFunctionInContext | https://github.com/nodejs/node/pull/23876/commits/8624cbad4d47b6ee026a066ae72246834900cf19 |
| 8624cba | https://github.com/nodejs/node/pull/23876/commits/8624cbad4d47b6ee026a066ae72246834900cf19 |
| nodejs#23194 | https://github.com/nodejs/node/issues/23194 |
| nodejs#23206 | https://github.com/nodejs/node/pull/23206 |
| nodejs#23194 | https://github.com/nodejs/node/issues/23194 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: add logging to test-worker-memory | https://github.com/nodejs/node/pull/23876/commits/b279b966a773ec8d0e3fb1d52cd536e4f4bf2d4a |
| b279b96 | https://github.com/nodejs/node/pull/23876/commits/b279b966a773ec8d0e3fb1d52cd536e4f4bf2d4a |
| nodejs#23277 (comment) | https://github.com/nodejs/node/issues/23277#issuecomment-428819187 |
| nodejs#23418 | https://github.com/nodejs/node/pull/23418 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| doc: rewrite consensus seeking in guide | https://github.com/nodejs/node/pull/23876/commits/650e92463b2a3e560d85ff0da81bd4e5129a0eee |
| 650e924 | https://github.com/nodejs/node/pull/23876/commits/650e92463b2a3e560d85ff0da81bd4e5129a0eee |
| nodejs#23349 | https://github.com/nodejs/node/pull/23349 |
|
| https://github.com/refack |
|
| https://github.com/targos |
| src: replace NO_RETURN with [[noreturn]] | https://github.com/nodejs/node/pull/23876/commits/772709cbb136f8fb77f1b0785ca1b9eaa022c838 |
| 772709c | https://github.com/nodejs/node/pull/23876/commits/772709cbb136f8fb77f1b0785ca1b9eaa022c838 |
| nodejs#23337 | https://github.com/nodejs/node/pull/23337 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| tools: update node-lint-md-cli-rollup | https://github.com/nodejs/node/pull/23876/commits/5c9ef5ea741f01ec54ec5608053658c2d05a76ff |
| 5c9ef5e | https://github.com/nodejs/node/pull/23876/commits/5c9ef5ea741f01ec54ec5608053658c2d05a76ff |
| nodejs#23358 | https://github.com/nodejs/node/pull/23358 |
|
| https://github.com/refack |
|
| https://github.com/targos |
| tools,icu: read full ICU version info from file | https://github.com/nodejs/node/pull/23876/commits/9cc73d384efda3d479a13d8895716cf8f537a601 |
| 9cc73d3 | https://github.com/nodejs/node/pull/23876/commits/9cc73d384efda3d479a13d8895716cf8f537a601 |
| nodejs#23269 | https://github.com/nodejs/node/pull/23269 |
| nodejs#23245 | https://github.com/nodejs/node/issues/23245 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: rename WPT console test | https://github.com/nodejs/node/pull/23876/commits/cdba84e11a3569a7198994e54425af26e34d9bee |
| cdba84e | https://github.com/nodejs/node/pull/23876/commits/cdba84e11a3569a7198994e54425af26e34d9bee |
| nodejs#23340 | https://github.com/nodejs/node/pull/23340 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: add WPT console-label-conversion test | https://github.com/nodejs/node/pull/23876/commits/9efe84ede476c0b92e71f3b6fc93ee23356e30f7 |
| 9efe84e | https://github.com/nodejs/node/pull/23876/commits/9efe84ede476c0b92e71f3b6fc93ee23356e30f7 |
| nodejs#23340 | https://github.com/nodejs/node/pull/23340 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: separate WPT console test from other test | https://github.com/nodejs/node/pull/23876/commits/3a5887f7a1963ae51b9ddbb765cfac832245904d |
| 3a5887f | https://github.com/nodejs/node/pull/23876/commits/3a5887f7a1963ae51b9ddbb765cfac832245904d |
| nodejs#23340 | https://github.com/nodejs/node/pull/23340 |
|
| https://github.com/danbev |
|
| https://github.com/addaleax |
| src: remove unused limits header from util-inl.h | https://github.com/nodejs/node/pull/23876/commits/cea396a57021130dd361093c2a5bc83d7fbe9462 |
| cea396a | https://github.com/nodejs/node/pull/23876/commits/cea396a57021130dd361093c2a5bc83d7fbe9462 |
| e812be4 | https://github.com/refack/node/commit/e812be4a55915575fc1afce739848026a48b781e |
| nodejs#23353 | https://github.com/nodejs/node/pull/23353 |
|
| https://github.com/oyyd |
|
| https://github.com/targos |
| tls: make StreamWrap work correctly in "drain" callback | https://github.com/nodejs/node/pull/23876/commits/3721f1414e57b5a667e698a3aa20efc1bfa0c0bc |
| 3721f14 | https://github.com/nodejs/node/pull/23876/commits/3721f1414e57b5a667e698a3aa20efc1bfa0c0bc |
| nodejs#23294 | https://github.com/nodejs/node/pull/23294 |
|
| https://github.com/dyatlov |
|
| https://github.com/targos |
| src: revert removal of SecureContext _external getter | https://github.com/nodejs/node/pull/23876/commits/f681691b451a35ab8573c850522d388e48a43324 |
| f681691 | https://github.com/nodejs/node/pull/23876/commits/f681691b451a35ab8573c850522d388e48a43324 |
| nodejs#21711 | https://github.com/nodejs/node/pull/21711 |
|
| https://github.com/sagitsofan |
|
| https://github.com/targos |
| lib: http server, friendly error messages | https://github.com/nodejs/node/pull/23876/commits/efe4f5e217a1a5a3f3852544100b5446b6fb3006 |
| efe4f5e | https://github.com/nodejs/node/pull/23876/commits/efe4f5e217a1a5a3f3852544100b5446b6fb3006 |
| nodejs#22936 | https://github.com/nodejs/node/issues/22936 |
| nodejs#22995 | https://github.com/nodejs/node/pull/22995 |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/targos |
| src: improve SSL version extraction logic | https://github.com/nodejs/node/pull/23876/commits/05108eb0f5265d90bf5748b4af4fa177934b0dae |
| 05108eb | https://github.com/nodejs/node/pull/23876/commits/05108eb0f5265d90bf5748b4af4fa177934b0dae |
| nodejs#23050 | https://github.com/nodejs/node/pull/23050 |
|
| https://github.com/tniessen |
|
| https://github.com/targos |
| src: fix bug in MallocedBuffer constructor | https://github.com/nodejs/node/pull/23876/commits/678019ced27c6e238ee70b056e50dfdbf6ab2cb3 |
| 678019c | https://github.com/nodejs/node/pull/23876/commits/678019ced27c6e238ee70b056e50dfdbf6ab2cb3 |
| nodejs#23434 | https://github.com/nodejs/node/pull/23434 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| doc: revise security-reporting text in README | https://github.com/nodejs/node/pull/23876/commits/dd3dd5f08af3b8fa6e24cb3c11a7efa6ec4f435e |
| dd3dd5f | https://github.com/nodejs/node/pull/23876/commits/dd3dd5f08af3b8fa6e24cb3c11a7efa6ec4f435e |
| nodejs#23407 | https://github.com/nodejs/node/pull/23407 |
|
| https://github.com/joesepi |
|
| https://github.com/targos |
| test: fixing assertion value order | https://github.com/nodejs/node/pull/23876/commits/d0254208ba453bd5b0e6efbdce12e298bba80a1f |
| d025420 | https://github.com/nodejs/node/pull/23876/commits/d0254208ba453bd5b0e6efbdce12e298bba80a1f |
| nodejs#23574 | https://github.com/nodejs/node/pull/23574 |
|
| https://github.com/et4891 |
|
| https://github.com/targos |
| test: fix assert.strictEqual argument order | https://github.com/nodejs/node/pull/23876/commits/243c227df4f77d3afc09bae5de6b2bc974382556 |
| 243c227 | https://github.com/nodejs/node/pull/23876/commits/243c227df4f77d3afc09bae5de6b2bc974382556 |
| nodejs#23518 | https://github.com/nodejs/node/pull/23518 |
|
| https://github.com/lundibundi |
|
| https://github.com/targos |
| test: improve test-gc-http-client-connaborted | https://github.com/nodejs/node/pull/23876/commits/9197a72547fe07517307ddb7da03a23d0df853da |
| 9197a72 | https://github.com/nodejs/node/pull/23876/commits/9197a72547fe07517307ddb7da03a23d0df853da |
| nodejs#23193 | https://github.com/nodejs/node/pull/23193 |
|
| https://github.com/lundibundi |
|
| https://github.com/targos |
| test: improve test-gc-http-client-onerror | https://github.com/nodejs/node/pull/23876/commits/e402b22bd5d9d33ba93790a974d7caa01890d8c4 |
| e402b22 | https://github.com/nodejs/node/pull/23876/commits/e402b22bd5d9d33ba93790a974d7caa01890d8c4 |
| nodejs#23196 | https://github.com/nodejs/node/pull/23196 |
|
| https://github.com/targos |
| test: move some gc tests back to parallel/, unmark flaky | https://github.com/nodejs/node/pull/23876/commits/dc52a51f7548288ca88bf7877bd33b34d78d8ab8 |
| dc52a51 | https://github.com/nodejs/node/pull/23876/commits/dc52a51f7548288ca88bf7877bd33b34d78d8ab8 |
| nodejs#23336 | https://github.com/nodejs/node/pull/23336 |
| nodejs#23356 | https://github.com/nodejs/node/pull/23356 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-433109851 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 25, 2018
| https://github.com/nodejs/node/pull/23876#ref-pullrequest-372279322 |
|
[v10.x] buffer: fix crash for invalid index types
#23795
| https://github.com/nodejs/node/pull/23795 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 25, 2018
| https://github.com/nodejs/node/pull/23876#pullrequestreview-168465577 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23876/files/e343e4c7bcbe9b8e749d51fd083258af6b2800ed |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/23876#pullrequestreview-168465577 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Oct 25, 2018
| https://github.com/nodejs/node/pull/23876#ref-pullrequest-373700258 |
|
[v10.x backport] src: initial large page (2M) support
#23861
| https://github.com/nodejs/node/pull/23861 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 25, 2018
| https://github.com/nodejs/node/pull/23876#pullrequestreview-168468738 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/23876/files/e343e4c7bcbe9b8e749d51fd083258af6b2800ed |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-433118836 |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-433123564 |
| node/test/parallel/test-bootstrap-modules.js | https://github.com/nodejs/node/blob/1523111250788e0e1651d30c1fd506e9ef4ac7f0/test/parallel/test-bootstrap-modules.js#L14 |
| 1523111 | https://github.com/nodejs/node/commit/1523111250788e0e1651d30c1fd506e9ef4ac7f0 |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-433124534 |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-433125807 |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-433126603 |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-433135416 |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-433172040 |
| @BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/23081/files/56c2099197e08f46d4bb4e021b40955dd8663d95#diff-b35754f7aa079e299b8ac8c51ea88959 | https://github.com/nodejs/node/pull/23081/files/56c2099197e08f46d4bb4e021b40955dd8663d95#diff-b35754f7aa079e299b8ac8c51ea88959 |
| #23050 (comment) | https://github.com/nodejs/node/pull/23050#issuecomment-425215332 |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-433175390 |
| @refack | https://github.com/refack |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-433178502 |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| @devsnek | https://github.com/devsnek |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Oct 25, 2018
| https://github.com/nodejs/node/pull/23876#ref-issue-374102379 |
|
test: make parallel/test-bootstrap-modules easier to reason about
#23884
| https://github.com/nodejs/node/issues/23884 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 25, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-433180837 |
| #23884 | https://github.com/nodejs/node/issues/23884 |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 25, 2018
| https://github.com/nodejs/node/pull/23876#ref-pullrequest-374094903 |
|
[v10.x backport] test: enable trace-events tests for workers
#23882
| https://github.com/nodejs/node/pull/23882 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/8b431ad84ce2be095d904b17ae48c04e483e3211..3f63297fe8e10e54122f211c6ae573112a9f74cc |
| 8b431ad | https://github.com/nodejs/node/commit/8b431ad84ce2be095d904b17ae48c04e483e3211 |
| 3f63297 | https://github.com/nodejs/node/commit/3f63297fe8e10e54122f211c6ae573112a9f74cc |
|
Compare
| https://github.com/nodejs/node/compare/8b431ad84ce2be095d904b17ae48c04e483e3211..3f63297fe8e10e54122f211c6ae573112a9f74cc |
| October 27, 2018 08:14 | https://github.com/nodejs/node/pull/23876#event-1930208612 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 29, 2018 | https://github.com/nodejs/node/pull/23876#event-1933245480 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/3f63297fe8e10e54122f211c6ae573112a9f74cc..8e7a12f4500c702731313591d64726031ab8c4d2 |
| 3f63297 | https://github.com/nodejs/node/commit/3f63297fe8e10e54122f211c6ae573112a9f74cc |
| 8e7a12f | https://github.com/nodejs/node/commit/8e7a12f4500c702731313591d64726031ab8c4d2 |
|
Compare
| https://github.com/nodejs/node/compare/3f63297fe8e10e54122f211c6ae573112a9f74cc..8e7a12f4500c702731313591d64726031ab8c4d2 |
| October 30, 2018 08:43 | https://github.com/nodejs/node/pull/23876#event-1934378243 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-435250361 |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23876#issuecomment-435254684 |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23876#event-1942034077 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
abandoned
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aabandoned |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Nov 2, 2018 | https://github.com/nodejs/node/pull/23876#event-1942036264 |
| https://github.com/refack |
| refack | https://github.com/refack |
| November 2, 2018 02:52 | https://github.com/nodejs/node/pull/23876#event-1942036681 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Nov 4, 2018 | https://github.com/nodejs/node/pull/23876#event-1944914680 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 14, 2018
| https://github.com/nodejs/node/pull/23876#ref-pullrequest-390961334 |
|
[10.x] deps: V8: cherry-pick 52a9e67
#25027
| https://github.com/nodejs/node/pull/25027 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23876 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/23876/files/e343e4c7bcbe9b8e749d51fd083258af6b2800ed |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/23876/files/e343e4c7bcbe9b8e749d51fd083258af6b2800ed |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/23876/files/e343e4c7bcbe9b8e749d51fd083258af6b2800ed |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/23876 |
|
| https://github.com/refack |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/richardlau |
|
| https://github.com/devsnek |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/styfle |
|
| https://github.com/danbev |
|
| https://github.com/conectado |
|
| https://github.com/targos |
|
| https://github.com/oyyd |
|
| https://github.com/dyatlov |
|
| https://github.com/sagitsofan |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/tniessen |
|
| https://github.com/joesepi |
|
| https://github.com/et4891 |
|
| https://github.com/lundibundi |
|
| https://github.com/sam-github |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |