René's URL Explorer Experiment


Title: lib: modify NativeModule to use compileFunction by ryzokuken · Pull Request #23837 · nodejs/node · GitHub

Open Graph Title: lib: modify NativeModule to use compileFunction by ryzokuken · Pull Request #23837 · nodejs/node

X Title: lib: modify NativeModule to use compileFunction by ryzokuken · Pull Request #23837 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Modify the NativeModule class to use compileFunction instead of manually wrapping the string source code and then compiling it. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes ...

X Description: Modify the NativeModule class to use compileFunction instead of manually wrapping the string source code and then compiling it. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes ...

Opengraph URL: https://github.com/nodejs/node/pull/23837

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4aa70f09-c368-b49b-db0f-c95105e6f3d6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8688:C17B1:817FFA:A7B0F7:6990546D
html-safe-nonce9d5355571cba4e50568e2a41239d46b4db306bb3656b61fd544bd506e9f5c679
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Njg4OkMxN0IxOjgxN0ZGQTpBN0IwRjc6Njk5MDU0NkQiLCJ2aXNpdG9yX2lkIjoiMzQ5NzUxNDUzNTE2OTg0MDIzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb5e984f71f2b6166fc2a69c0478b5a043adf4f2e07d3c469d30270c1c48767d8
hovercard-subject-tagpull_request:225146361
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23837/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2f503f1219ac489911cdc2ef5535836d0f35906e43ca30f22e0f5b44f9425c32/nodejs/node/pull/23837
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2f503f1219ac489911cdc2ef5535836d0f35906e43ca30f22e0f5b44f9425c32/nodejs/node/pull/23837
og:image:altModify the NativeModule class to use compileFunction instead of manually wrapping the string source code and then compiling it. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameryzokuken
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/23837#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23837
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23837
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/23837
Reloadhttps://github.com/nodejs/node/pull/23837
Reloadhttps://github.com/nodejs/node/pull/23837
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/23837
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 706 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ryzokukenhttps://github.com/ryzokuken
nodejs:mainhttps://github.com/nodejs/node/tree/main
ryzokuken:compilefunction-nativemoduleshttps://github.com/ryzokuken/node/tree/compilefunction-nativemodules
Conversationhttps://github.com/nodejs/node/pull/23837
Commits9 (9)https://github.com/nodejs/node/pull/23837/commits
Checkshttps://github.com/nodejs/node/pull/23837/checks
Files changedhttps://github.com/nodejs/node/pull/23837/files
lib: modify NativeModule to use compileFunctionhttps://github.com/nodejs/node/pull/23837#top
ryzokukenhttps://github.com/ryzokuken
nodejs:mainhttps://github.com/nodejs/node/tree/main
ryzokuken:compilefunction-nativemoduleshttps://github.com/ryzokuken/node/tree/compilefunction-nativemodules
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Oct 23, 2018https://github.com/nodejs/node/pull/23837#issue-373146530
Please reload this pagehttps://github.com/nodejs/node/pull/23837
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
@devsnekhttps://github.com/devsnek
@bcoehttps://github.com/bcoe
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/ryzokuken
lib: modify NativeModule to use compileFunctionhttps://github.com/nodejs/node/pull/23837/commits/dc9f7e1a37d38ca52abc5cfe3c71715d2ce33c1a
dc9f7e1https://github.com/nodejs/node/pull/23837/commits/dc9f7e1a37d38ca52abc5cfe3c71715d2ce33c1a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 23, 2018https://github.com/nodejs/node/pull/23837#issuecomment-432371527
@ryzokukenhttps://github.com/ryzokuken
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1347/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1347/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 23, 2018https://github.com/nodejs/node/pull/23837#issuecomment-432378052
@ryzokukenhttps://github.com/ryzokuken
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 23, 2018 https://github.com/nodejs/node/pull/23837#pullrequestreview-167618571
View reviewed changes https://github.com/nodejs/node/pull/23837/files/dc9f7e1a37d38ca52abc5cfe3c71715d2ce33c1a
lib/internal/bootstrap/loaders.jshttps://github.com/nodejs/node/pull/23837/files/dc9f7e1a37d38ca52abc5cfe3c71715d2ce33c1a#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9
devsnekhttps://github.com/devsnek
Oct 23, 2018https://github.com/nodejs/node/pull/23837#discussion_r227549632
Please reload this pagehttps://github.com/nodejs/node/pull/23837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23837
ryzokukenhttps://github.com/ryzokuken
Oct 23, 2018https://github.com/nodejs/node/pull/23837#discussion_r227565302
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23837
devsnekhttps://github.com/devsnek
Oct 23, 2018https://github.com/nodejs/node/pull/23837#discussion_r227567968
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23837
ryzokukenhttps://github.com/ryzokuken
Oct 23, 2018https://github.com/nodejs/node/pull/23837#discussion_r227568840
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Oct 23, 2018 https://github.com/nodejs/node/pull/23837#pullrequestreview-167619139
View reviewed changes https://github.com/nodejs/node/pull/23837/files/dc9f7e1a37d38ca52abc5cfe3c71715d2ce33c1a
lib/internal/bootstrap/loaders.jshttps://github.com/nodejs/node/pull/23837/files/dc9f7e1a37d38ca52abc5cfe3c71715d2ce33c1a#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/devsnek
devsnekhttps://github.com/devsnek
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Oct 23, 2018https://github.com/nodejs/node/pull/23837#event-1921773614
https://github.com/ryzokuken
fixup! lib: modify NativeModule to use compileFunctionhttps://github.com/nodejs/node/pull/23837/commits/efc0892947077e82a40584609a69399537f997c4
efc0892https://github.com/nodejs/node/pull/23837/commits/efc0892947077e82a40584609a69399537f997c4
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 24, 2018 https://github.com/nodejs/node/pull/23837#pullrequestreview-167690331
View reviewed changes https://github.com/nodejs/node/pull/23837/files/efc0892947077e82a40584609a69399537f997c4
bcoehttps://github.com/bcoe
https://github.com/nodejs/node/pull/23837#pullrequestreview-167690331
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
confirmed herehttps://github.com/bcoe/node-coverage-debug
#22919 (comment)https://github.com/nodejs/node/issues/22919#issuecomment-432468192
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/jdalton
jdaltonhttps://github.com/jdalton
Oct 24, 2018 https://github.com/nodejs/node/pull/23837#pullrequestreview-167718933
View reviewed changes https://github.com/nodejs/node/pull/23837/files/efc0892947077e82a40584609a69399537f997c4
lib/internal/bootstrap/loaders.jshttps://github.com/nodejs/node/pull/23837/files/efc0892947077e82a40584609a69399537f997c4#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9
jdaltonhttps://github.com/jdalton
Oct 24, 2018https://github.com/nodejs/node/pull/23837#discussion_r227633221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23837
ryzokukenhttps://github.com/ryzokuken
Oct 24, 2018https://github.com/nodejs/node/pull/23837#discussion_r227649935
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jdaltonhttps://github.com/jdalton
Please reload this pagehttps://github.com/nodejs/node/pull/23837
jdaltonhttps://github.com/jdalton
Oct 24, 2018https://github.com/nodejs/node/pull/23837#discussion_r227807259
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23837
ryzokukenhttps://github.com/ryzokuken
October 24, 2018 17:52https://github.com/nodejs/node/pull/23837#commits-pushed-19262a0
https://github.com/ryzokuken
vm: report cache rejection in vm.compileFunctionhttps://github.com/nodejs/node/pull/23837/commits/19262a0d4ac39dacc96af990b4642c69a49c39a9
19262a0https://github.com/nodejs/node/pull/23837/commits/19262a0d4ac39dacc96af990b4642c69a49c39a9
https://github.com/ryzokuken
fixup! lib: modify NativeModule to use compileFunctionhttps://github.com/nodejs/node/pull/23837/commits/9ec01a2f54291b3e9b092aca72bfff99493215c8
9ec01a2https://github.com/nodejs/node/pull/23837/commits/9ec01a2f54291b3e9b092aca72bfff99493215c8
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Oct 24, 2018https://github.com/nodejs/node/pull/23837#issuecomment-432634230
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 24, 2018 https://github.com/nodejs/node/pull/23837#pullrequestreview-167883680
View reviewed changes https://github.com/nodejs/node/pull/23837/files/9ec01a2f54291b3e9b092aca72bfff99493215c8
lib/internal/bootstrap/loaders.jshttps://github.com/nodejs/node/pull/23837/files/9ec01a2f54291b3e9b092aca72bfff99493215c8#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9
Please reload this pagehttps://github.com/nodejs/node/pull/23837
lib/internal/bootstrap/loaders.jshttps://github.com/nodejs/node/pull/23837/files/9ec01a2f54291b3e9b092aca72bfff99493215c8#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/ryzokuken
fixup! lib: modify NativeModule to use compileFunctionhttps://github.com/nodejs/node/pull/23837/commits/382e3e800246b7183fcc4f2b6e1f2aa7d04c46b7
382e3e8https://github.com/nodejs/node/pull/23837/commits/382e3e800246b7183fcc4f2b6e1f2aa7d04c46b7
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Oct 25, 2018https://github.com/nodejs/node/pull/23837#issuecomment-432871451
@joyeecheunghttps://github.com/joyeecheung
@jdaltonhttps://github.com/jdalton
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/jdalton
jdaltonhttps://github.com/jdalton
Oct 25, 2018 https://github.com/nodejs/node/pull/23837#pullrequestreview-168176322
View reviewed changes https://github.com/nodejs/node/pull/23837/files/382e3e800246b7183fcc4f2b6e1f2aa7d04c46b7
src/node_contextify.cchttps://github.com/nodejs/node/pull/23837/files/382e3e800246b7183fcc4f2b6e1f2aa7d04c46b7#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 25, 2018 https://github.com/nodejs/node/pull/23837#pullrequestreview-168211275
View reviewed changes https://github.com/nodejs/node/pull/23837/files/382e3e800246b7183fcc4f2b6e1f2aa7d04c46b7
lib/internal/bootstrap/loaders.jshttps://github.com/nodejs/node/pull/23837/files/382e3e800246b7183fcc4f2b6e1f2aa7d04c46b7#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/ryzokuken
fixup! lib: modify NativeModule to use compileFunctionhttps://github.com/nodejs/node/pull/23837/commits/72d542b55cee9e2b85634eb68bb77a42a9a19f95
72d542bhttps://github.com/nodejs/node/pull/23837/commits/72d542b55cee9e2b85634eb68bb77a42a9a19f95
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 25, 2018 https://github.com/nodejs/node/pull/23837#pullrequestreview-168456720
View reviewed changes https://github.com/nodejs/node/pull/23837/files/72d542b55cee9e2b85634eb68bb77a42a9a19f95
joyeecheunghttps://github.com/joyeecheung
https://github.com/nodejs/node/pull/23837#pullrequestreview-168456720
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23837
lib/internal/bootstrap/loaders.jshttps://github.com/nodejs/node/pull/23837/files/72d542b55cee9e2b85634eb68bb77a42a9a19f95#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9
Please reload this pagehttps://github.com/nodejs/node/pull/23837
lib/internal/bootstrap/loaders.jshttps://github.com/nodejs/node/pull/23837/files/72d542b55cee9e2b85634eb68bb77a42a9a19f95#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9
Please reload this pagehttps://github.com/nodejs/node/pull/23837
lib/internal/bootstrap/loaders.jshttps://github.com/nodejs/node/pull/23837/files/72d542b55cee9e2b85634eb68bb77a42a9a19f95#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/ryzokuken
fixup! lib: modify NativeModule to use compileFunctionhttps://github.com/nodejs/node/pull/23837/commits/690fe8b72b8135c01c06cce42fe3f6bb0624d351
690fe8bhttps://github.com/nodejs/node/pull/23837/commits/690fe8b72b8135c01c06cce42fe3f6bb0624d351
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Oct 27, 2018 https://github.com/nodejs/node/pull/23837#ref-issue-374627353
vm.compileFunction should return an object #23923 https://github.com/nodejs/node/issues/23923
https://github.com/ryzokuken
fixup! lib: modify NativeModule to use compileFunctionhttps://github.com/nodejs/node/pull/23837/commits/ab4d9ad0a8cf7540427cb45d314138aec51d4f9a
ab4d9adhttps://github.com/nodejs/node/pull/23837/commits/ab4d9ad0a8cf7540427cb45d314138aec51d4f9a
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Oct 27, 2018https://github.com/nodejs/node/pull/23837#issuecomment-433626923
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 28, 2018 https://github.com/nodejs/node/pull/23837#ref-issue-361092909
coverage: NODE_V8_COVERAGE for Node's test suite, remaining blockers #22919 https://github.com/nodejs/node/issues/22919
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 29, 2018 https://github.com/nodejs/node/pull/23837#pullrequestreview-169171738
View reviewed changes https://github.com/nodejs/node/pull/23837/files/ab4d9ad0a8cf7540427cb45d314138aec51d4f9a
lib/internal/bootstrap/loaders.jshttps://github.com/nodejs/node/pull/23837/files/ab4d9ad0a8cf7540427cb45d314138aec51d4f9a#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/ryzokuken
fixup! lib: modify NativeModule to use compileFunctionhttps://github.com/nodejs/node/pull/23837/commits/d2dcd54dea3b200d577ff28c2e490b002ace5003
d2dcd54https://github.com/nodejs/node/pull/23837/commits/d2dcd54dea3b200d577ff28c2e490b002ace5003
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2018 https://github.com/nodejs/node/pull/23837#pullrequestreview-169567895
View reviewed changes https://github.com/nodejs/node/pull/23837/files/d2dcd54dea3b200d577ff28c2e490b002ace5003
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 30, 2018https://github.com/nodejs/node/pull/23837#event-1934493586
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Oct 30, 2018https://github.com/nodejs/node/pull/23837#issuecomment-434231694
https://ci.nodejs.org/job/node-test-pull-request/18227/https://ci.nodejs.org/job/node-test-pull-request/18227/
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 30, 2018 https://github.com/nodejs/node/pull/23837#pullrequestreview-169803093
View reviewed changes https://github.com/nodejs/node/pull/23837/files/d2dcd54dea3b200d577ff28c2e490b002ace5003
src/node_contextify.cchttps://github.com/nodejs/node/pull/23837/files/d2dcd54dea3b200d577ff28c2e490b002ace5003#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
joyeecheunghttps://github.com/joyeecheung
Oct 30, 2018https://github.com/nodejs/node/pull/23837#discussion_r229329326
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23837
joyeecheunghttps://github.com/joyeecheung
Oct 30, 2018https://github.com/nodejs/node/pull/23837#discussion_r229335960
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23837
joyeecheunghttps://github.com/joyeecheung
Oct 30, 2018https://github.com/nodejs/node/pull/23837#discussion_r229355356
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 2, 2018https://github.com/nodejs/node/pull/23837#event-1942006215
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 6, 2018https://github.com/nodejs/node/pull/23837#issuecomment-436133990
@ryzokukenhttps://github.com/ryzokuken
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Nov 6, 2018https://github.com/nodejs/node/pull/23837#issuecomment-436142802
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 6, 2018https://github.com/nodejs/node/pull/23837#issuecomment-436144806
#24069https://github.com/nodejs/node/pull/24069
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/Trott
Trotthttps://github.com/Trott
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Nov 6, 2018https://github.com/nodejs/node/pull/23837#event-1948114772
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 7, 2018 https://github.com/nodejs/node/pull/23837#ref-pullrequest-378238583
src: compile native modules and their code cache in C++ #24221 https://github.com/nodejs/node/pull/24221
https://github.com/bcoe
bcoehttps://github.com/bcoe
Dec 2, 2018 https://github.com/nodejs/node/pull/23837#ref-pullrequest-336494782
module: use compileFunction over Module.wrap #21573 https://github.com/nodejs/node/pull/21573
https://github.com/bcoe
bcoehttps://github.com/bcoe
Dec 15, 2018 https://github.com/nodejs/node/pull/23837#ref-issue-389907633
Coverage reporting is broken #24966 https://github.com/nodejs/node/issues/24966
https://github.com/bcoe
bcoehttps://github.com/bcoe
Jan 19, 2019https://github.com/nodejs/node/pull/23837#issuecomment-455732488
@joyeecheunghttps://github.com/joyeecheung
@ryzokukenhttps://github.com/ryzokuken
#21573https://github.com/nodejs/node/pull/21573
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Jan 19, 2019https://github.com/nodejs/node/pull/23837#issuecomment-455784234
@bcoehttps://github.com/bcoe
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7
1ecc406https://github.com/nodejs/node/commit/1ecc406b77ba7573ed0b982a7e6654514c71a7a2
49cf67ehttps://github.com/nodejs/node/commit/49cf67efd66a94a93f4c91be6c39125e7f896ee7
Compare https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7
September 17, 2019 16:52https://github.com/nodejs/node/pull/23837#event-2640607627
https://github.com/devnexen
devnexenhttps://github.com/devnexen
force-pushedhttps://github.com/nodejs/node/compare/e8a45686c7512211f96c0fe8153b5253cf5923a6..5289f80eadafcc508b24d5817f0ec416eccf8404
e8a4568https://github.com/nodejs/node/commit/e8a45686c7512211f96c0fe8153b5253cf5923a6
5289f80https://github.com/nodejs/node/commit/5289f80eadafcc508b24d5817f0ec416eccf8404
Compare https://github.com/nodejs/node/compare/e8a45686c7512211f96c0fe8153b5253cf5923a6..5289f80eadafcc508b24d5817f0ec416eccf8404
December 26, 2019 19:46https://github.com/nodejs/node/pull/23837#event-2909598640
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5
8ae28ffhttps://github.com/nodejs/node/commit/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda
2935f72https://github.com/nodejs/node/commit/2935f72ae1b991c64118031dec12e7d7db7714a5
Compare https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5
May 31, 2020 12:20https://github.com/nodejs/node/pull/23837#event-3390559882
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 23, 2020https://github.com/nodejs/node/pull/23837#issuecomment-648463993
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Jun 28, 2020https://github.com/nodejs/node/pull/23837#issuecomment-650716112
@Trotthttps://github.com/Trott
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 1, 2020https://github.com/nodejs/node/pull/23837#issuecomment-736427784
@ryzokukenhttps://github.com/ryzokuken
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Dec 1, 2020https://github.com/nodejs/node/pull/23837#issuecomment-736448459
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04..8e46568b1e12fe00581b1292bd6c2b01373f17bd
dc5a5dahttps://github.com/nodejs/node/commit/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04
8e46568https://github.com/nodejs/node/commit/8e46568b1e12fe00581b1292bd6c2b01373f17bd
Compare https://github.com/nodejs/node/compare/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04..8e46568b1e12fe00581b1292bd6c2b01373f17bd
March 29, 2021 21:33https://github.com/nodejs/node/pull/23837#event-4523996018
https://github.com/bnb
bnbhttps://github.com/bnb
Jan 7, 2022https://github.com/nodejs/node/pull/23837#issuecomment-1007815960
@ryzokukenhttps://github.com/ryzokuken
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/ryzokuken
ryzokukenhttps://github.com/ryzokuken
Jan 12, 2022https://github.com/nodejs/node/pull/23837#issuecomment-1010919513
@bnbhttps://github.com/bnb
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
2d76238https://github.com/nodejs/node/commit/2d76238f9184c9009bfa395848a120ac3e5b98e5
ca3ed36https://github.com/nodejs/node/commit/ca3ed363ffefa4819c1414aff7ffca34b53a7b95
Compare https://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
November 12, 2022 01:49https://github.com/nodejs/node/pull/23837#event-7795751709
https://github.com/aduh95
aduh95https://github.com/aduh95
May 11, 2024https://github.com/nodejs/node/pull/23837#issuecomment-2105954103
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/aduh95
aduh95https://github.com/aduh95
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Nov 8, 2025https://github.com/nodejs/node/pull/23837#event-20807981279
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 8, 2025https://github.com/nodejs/node/pull/23837#issuecomment-3506580472
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/aduh95
aduh95https://github.com/aduh95
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Nov 8, 2025https://github.com/nodejs/node/pull/23837#event-20808086945
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Nov 9, 2025https://github.com/nodejs/node/pull/23837#event-20814025327
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23837
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/23837/files/d2dcd54dea3b200d577ff28c2e490b002ace5003
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/23837/files/d2dcd54dea3b200d577ff28c2e490b002ace5003
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/23837/files/d2dcd54dea3b200d577ff28c2e490b002ace5003
https://github.com/jdalton
jdalton https://github.com/jdalton
https://github.com/nodejs/node/pull/23837/files/690fe8b72b8135c01c06cce42fe3f6bb0624d351
https://github.com/bcoe
bcoe https://github.com/bcoe
https://github.com/nodejs/node/pull/23837/files/382e3e800246b7183fcc4f2b6e1f2aa7d04c46b7
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/23837/files/ab4d9ad0a8cf7540427cb45d314138aec51d4f9a
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Please reload this pagehttps://github.com/nodejs/node/pull/23837
https://github.com/ryzokuken
https://github.com/nodejs-github-bot
https://github.com/bcoe
https://github.com/Trott
https://github.com/joyeecheung
https://github.com/gireeshpunathil
https://github.com/bnb
https://github.com/aduh95
https://github.com/jdalton
https://github.com/jasnell
https://github.com/targos
https://github.com/devsnek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.